active_storage-send_zip 0.3.5 → 0.5.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: f4a1c89a7b8a630d378b77f1e0cadd4ddb7eaadaa96f4040875ed4cc41944775
-  data.tar.gz: b366d585f90a600c4210053c52a1c69e13d7cd226574ad3f6b3400c6d37729f0
+  metadata.gz: 3cb438270e8304e1c4feea19d3c14c254cdf819978eeb82cb58a74b9bbcdf05e
+  data.tar.gz: e8ca7ec1429aa7b3d770c7ca671150ea039da739095ccea4994d161a6e583130
 SHA512:
-  metadata.gz: b9f936395e0bbb982b150b79a513d91f8703238ec3b70d7f95a0c7c00d417696dc45a32366294e42f2b26de6c5bc67628dd67ac7e42fd9cb0d96b1382459144a
-  data.tar.gz: 4a9087b99c8bb4116af9b2ea553a58091827a4c4fbc1a305f378e573f89d64b2d0180a1d7eed664ea193f19cd0ec41c3ffb610878e9d9b2a017a96a5658372c7
+  metadata.gz: b14c230be0bf9b23b26b94b3d5efc3cdac7917eb1538bbdfb85ff024d2bde09ee7213e42a82f594dff16daecfa2a75dae479f6ecbacd213b9f476a03121e6602
+  data.tar.gz: b8966756b2582528fc4e4c5378e8944b9b276c706160f23dcaa8e9912eb6ba9d70e1f07dc2270ba97dd3ca8ccbe4e1355fd400b88910c7a9414e534540733256

data/.github/workflows/ci.yml

@@ -0,0 +1,24 @@
+name: CI
+
+on:
+  push:
+    branches: [master]
+  pull_request:
+    branches: [master]
+
+jobs:
+  test:
+    runs-on: ubuntu-latest
+
+    steps:
+      - uses: actions/checkout@v3
+
+      - name: Set up Ruby
+        uses: ruby/setup-ruby@v1
+        with:
+          ruby-version: 3.2.7
+          bundler-cache: true
+
+      - name: Run tests
+        run: bundle exec rake test
+

data/AGENTS.md

@@ -0,0 +1,56 @@
+# AGENTS.md
+
+## Build/Lint/Test Commands
+
+### Setup
+```bash
+bin/setup          # Install dependencies
+```
+
+### Testing
+```bash
+rake test          # Run all tests
+```
+
+### Development
+```bash
+bin/console        # Interactive Ruby console
+bundle exec rake install    # Install gem locally
+```
+
+## Code Style Guidelines
+
+### Imports
+- Group standard library requires first, then third-party, then local files
+- Use double quotes for require paths
+- Place all requires at the top of the file
+
+### Formatting
+- Use 2 space indentation (no tabs)
+- Max line length 80-100 characters
+- Add empty line at end of file
+- Use frozen_string_literal: true magic comment
+- Add newline after class/module definition
+
+### Naming Conventions
+- Use snake_case for methods and variables
+- Use PascalCase for classes and modules
+- Use SCREAMING_SNAKE_CASE for constants
+- Method names should be descriptive verbs
+
+### Types
+- Use explicit return types in comments for public methods
+- Document parameter types with YARD-style comments
+- Use appropriate Ruby types (String, Array, Hash, etc.)
+
+### Error Handling
+- Raise specific exception types (ArgumentError, StandardError, etc.)
+- Use guard clauses for early returns
+- Handle edge cases explicitly
+- Provide meaningful error messages
+
+### Documentation
+- Add YARD-style comments for all public methods
+- Include @param and @return tags
+- Document complex logic with inline comments
+- Keep comments up-to-date with code changes

data/CHANGELOG.yml

@@ -1,3 +1,6 @@
+0.4.1:
+  - fix issue with `has_many_attached` associations not working properly with folder names
+  - properly handle `ActiveStorage::Attached::Many` objects by iterating through their attachments
 0.3.4:
   - add resize before download capability
 0.3.2:

data/Gemfile.lock

@@ -1,9 +1,9 @@
 PATH
   remote: .
   specs:
-    active_storage-send_zip (0.3.5)
+    active_storage-send_zip (0.5.0)
       rails (> 5.2)
-      rubyzip (< 3.0)
+      rubyzip (>= 2.1.0, < 4.0)
 
 GEM
   remote: https://rubygems.org/

data/README.md

@@ -59,13 +59,13 @@ class HolidaysController < ApplicationController
   include ActiveStorage::SendZip
 
   def zip
-    send_zip {
+    send_zip({
       'Holidays in Lyon <3' => Holidays.where(place: 'lyon').first.pictures,
       'Holidays in Paris' => [
         'Eiffle Tower' => Holidays.where(place: 'eiffle_tower').first.pictures,
         Holidays.where(place: 'paris').first.pictures
       ]
-    }
+    })
   end
 end
 ~~~
@@ -87,6 +87,8 @@ Will produce a `.zip` archive like this:
     └── c.gif
 ~~~
 
+> Note: `has_many_attached` associations (like `Holidays.where(place: 'lyon').first.pictures`) are now properly supported and will automatically extract the individual attachments.
+
 
 ### Resize images before downloading
 

data/active_storage-send_zip.gemspec

@@ -41,5 +41,5 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency 'minitest', '~> 5.0'
   spec.add_development_dependency 'rake'
   spec.add_dependency 'rails', '> 5.2'
-  spec.add_dependency 'rubyzip', '< 3.0'
+  spec.add_dependency 'rubyzip', ['>= 2.1.0', '< 4.0']
 end

data/lib/active_storage/send_zip/version.rb

@@ -3,6 +3,6 @@
 module ActiveStorage
   module SendZip
     # The version of this gem
-    VERSION = '0.3.5'
+    VERSION = '0.5.0'
   end
 end

data/lib/active_storage/send_zip_helper.rb

@@ -20,9 +20,16 @@ module ActiveStorage
       temp_folder = Dir.mktmpdir 'active_storage-send_zip'
 
       if files.is_a? Hash
-        filepaths = construct_with_hash(files, temp_folder)
+        construct_with_hash(files, temp_folder)
       elsif files.respond_to? :each
-        files.each { |file| save_file_on_server(file, temp_folder, resize_to_limit: resize_to_limit) }
+        # Handle ActiveStorage::Attached::Many objects by iterating through their attachments
+        if defined?(ActiveStorage::Attached::Many) && files.is_a?(ActiveStorage::Attached::Many)
+          files.attachments.each do |attachment|
+            save_file_on_server(attachment, temp_folder, resize_to_limit: resize_to_limit)
+          end
+        else
+          files.each { |file| save_file_on_server(file, temp_folder, resize_to_limit: resize_to_limit) }
+        end
       else
         raise ArgumentError, '`files` must be an hash or an iterable object'
       end
@@ -38,6 +45,11 @@ module ActiveStorage
       filepaths = []
 
       files.each do |subfolder, filesHash|
+        # Handle ActiveStorage::Attached::Many objects by converting them to attachments array
+        if defined?(ActiveStorage::Attached::Many) && filesHash.is_a?(ActiveStorage::Attached::Many)
+          filesHash = filesHash.attachments
+        end
+
         filesHash = [filesHash] unless filesHash.is_a? Array
 
         filesHash.each do |f|
@@ -84,9 +96,7 @@ module ActiveStorage
       end
 
       # resize images if needed
-      unless resize_to_limit.nil?
-        file = file.variant(resize_to_limit: resize_to_limit).processed
-      end
+      file = file.variant(resize_to_limit: resize_to_limit).processed unless resize_to_limit.nil?
 
       # write the file on disk
       File.open(filepath, 'wb') { |f| f.write(file.service.download(file.key)) }
@@ -109,7 +119,7 @@ module ActiveStorage
         Zip::OutputStream.open(temp_file) { |zos| }
 
         # open the zip
-        Zip::File.open(temp_file.path, Zip::File::CREATE) do |zip|
+        Zip::File.open(temp_file.path, create: true) do |zip|
           files.each do |filepath|
             filepath_zip = filepath.sub(folderpath, '').sub(File::SEPARATOR, '')
             zip.add filepath_zip, filepath
@@ -117,7 +127,7 @@ module ActiveStorage
         end
 
         File.read(temp_file.path)
-      ensure
+
         # close all ressources & remove temporary files
         # temp_file.close
         # temp_file.unlink

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: active_storage-send_zip
 version: !ruby/object:Gem::Version
-  version: 0.3.5
+  version: 0.5.0
 platform: ruby
 authors:
 - Alexandre Rousseau
@@ -9,7 +9,7 @@ authors:
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2024-02-27 00:00:00.000000000 Z
+date: 2025-10-28 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -71,16 +71,22 @@ dependencies:
   name: rubyzip
   requirement: !ruby/object:Gem::Requirement
     requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 2.1.0
     - - "<"
       - !ruby/object:Gem::Version
-        version: '3.0'
+        version: '4.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 2.1.0
     - - "<"
       - !ruby/object:Gem::Version
-        version: '3.0'
+        version: '4.0'
 description: Add a `send_zip` method in your Rails controller to send a `.zip` file
   containing one (or many) ActiveStorage object(s)
 email:
@@ -89,8 +95,10 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
+- ".github/workflows/ci.yml"
 - ".gitignore"
 - ".travis.yml"
+- AGENTS.md
 - CHANGELOG.yml
 - CODE_OF_CONDUCT.md
 - Gemfile
@@ -126,7 +134,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.4.20
+rubygems_version: 3.4.19
 signing_key:
 specification_version: 4
 summary: Create a zip from one or more Active Storage objects