active_spy 1.3.8 → 1.3.9

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 175b2633f946d4be05ff26032bb63ce4a9a6a251
-  data.tar.gz: 541b822cf2559a57dee0624d27b6110b3c951dbe
+  metadata.gz: 958e1adca6d2520d73bdbb3f5fd9533f9ac207a0
+  data.tar.gz: 5af7b7c09aaf6cdf2a741bcf6b07eb4953bf39a8
 SHA512:
-  metadata.gz: 1c853ef9af0b3f95caf6da74223fab48d906dd17ad6869da34046961d1ec7ebaba3b987e2a4cd3edb0c8c78bb50a0f0c615137f19d8290c34309611cbf9062fc
-  data.tar.gz: 1125f1630060496f43fb6ca53afd1d9a9aaba281c88a1d9aee92b88ca1a4b68467a04310d407f033cb5f980199c334b84166bcecaf7a1bd2bbaf6e1cf568a518
+  metadata.gz: 638d8b4b04fb4988cdfd4746a1858ad58c2c2a1956a244d3f5f8c9eae167c46d935edf3b11ed206a87c93314595d3526d1b0767d6ca377fcc396228459472c71
+  data.tar.gz: 47bc762bb0b25b0c1d295cc4d3f722a3f7ac2df3ae88a0c574d16efdb06e23563a14e8ed7d4a5ad3e32a8a21f293680223fecf13a31c4b089ddd470ef80b61b4

data/VERSION

@@ -1 +1 @@
-1.3.8
+1.3.9

data/active_spy.gemspec

@@ -2,16 +2,16 @@
 # DO NOT EDIT THIS FILE DIRECTLY
 # Instead, edit Jeweler::Tasks in Rakefile, and run 'rake gemspec'
 # -*- encoding: utf-8 -*-
-# stub: active_spy 1.3.8 ruby lib
+# stub: active_spy 1.3.9 ruby lib
 
 Gem::Specification.new do |s|
   s.name = "active_spy"
-  s.version = "1.3.8"
+  s.version = "1.3.9"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.require_paths = ["lib"]
   s.authors = ["Douglas Camata"]
-  s.date = "2014-09-30"
+  s.date = "2014-10-20"
   s.description = "    Watch for a method call in any class and run before/after callbacks.\n    You can even watch your Rails models for events (like create, update,\n    destroy), send these events to a event-runner instance and it redirect these\n    events to other apps that are subscrived for them. This gem also provides\n    classes that you can use to process the received events too.\n"
   s.email = "d.camata@gmail.com"
   s.extra_rdoc_files = [

data/app/controllers/active_spy/notifications_controller.rb

@@ -35,7 +35,7 @@ module ActiveSpy
     def handle_model_result(hook, result, params)
       if result.errors.present?
         ::Rails.logger.warn("[EVENT][#{hook['post_class']}] Error receiving event #{params}")
-        ::Rails.logger.warn("[EVENT][#{hook['post_class']}] Result errors: #{result.errors}")
+        ::Rails.logger.warn("[EVENT][#{hook['post_class']}] Result errors: #{result.errors.full_messages}")
         render json: result.errors, status: :unprocessable_entity
       else
         render nothing: true
@@ -47,7 +47,7 @@ module ActiveSpy
       if model_with_errors.any?
         ::Rails.logger.warn("[EVENT][#{hook['post_class']}] Error receiving event #{params}")
         model_with_errors.each do |model|
-          ::Rails.logger.warn("[EVENT][#{hook['post_class']}] #{model} errors: #{model.errors}")
+          ::Rails.logger.warn("[EVENT][#{hook['post_class']}] #{model} errors: #{model.errors.full_messages}")
         end
         render nothing: true, status: :internal_server_error
       else

data/lib/active_spy/rails/base.rb

@@ -37,30 +37,47 @@ module ActiveSpy
         end
       end
 
-      # Overriding to always send the object to the server, even though the
-      # after callback is not explicitly defined.
+      # Handles the generic +save+. Determines which rail action was done,
+      # +create+ or +update+ and call the right callback.
       #
-      def method_missing(method, *_args, &_block)
-        request_params = get_request_params(method)
-        @event_json = { event: request_params }.to_json
-        ActiveSpy::Rails::Validation::Event.new(@event_json).validate! unless ActiveSpy::Configuration.skip_validations
-        after_callback = "after_#{request_params[:action]}"
-        send(after_callback) if respond_to? after_callback
-        remove_is_new_method(@object)
+      def after_save
+        action = get_action('save')
+        send("after_#{action}")
       end
 
+      # Handles a +create+ callback, prepare and send the request to the event-runner.
+      #
       def after_create
+        request_params = get_request_params('create')
+        prepare_request(request_params)
         send_event_request unless ActiveSpy::Configuration.development_mode
       end
 
+      # Handles an +update+ callback, prepare and send the request to the event-runner.
+      #
       def after_update
+        request_params = get_request_params('update')
+        prepare_request(request_params)
         send_event_request unless ActiveSpy::Configuration.development_mode
       end
 
+      # Handles an +destroy+ callback, prepare and send the request to the event-runner.
+      #
       def after_destroy
+        request_params = get_request_params('destroy')
+        prepare_request(request_params)
         send_event_request unless ActiveSpy::Configuration.development_mode
       end
 
+      # Prepare a request with +request_params+, validates the request and
+      # remove the injected +is_mew_method+, because it's not needed anymore.
+      #
+      def prepare_request(request_params)
+        @event_json = { event: request_params }.to_json
+        ActiveSpy::Rails::Validation::Event.new(@event_json).validate! unless ActiveSpy::Configuration.skip_validations
+        remove_is_new_method(@object)
+      end
+
       # Sends the event request to the configured event-runner instance.
       #
       def send_event_request
@@ -81,9 +98,9 @@ module ActiveSpy
 
       # Get the event request params for a given +method+.
       #
-      def get_request_params(method)
-        real_method = method.to_s.split('_').last
-        action = get_action(real_method)
+      def get_request_params(action)
+        # real_method = method.to_s.split('_').last
+        # action = get_action(real_method)
         {
           type:     @object.class.name,
           actor:    @object.instance_variable_get('@actor'),

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: active_spy
 version: !ruby/object:Gem::Version
-  version: 1.3.8
+  version: 1.3.9
 platform: ruby
 authors:
 - Douglas Camata
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-09-30 00:00:00.000000000 Z
+date: 2014-10-20 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport