active_shrine 0.7.0 → 0.7.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: b0330c7363b9c8b14e0f718886933c33dff3998618da11b47e5d14e813def269
-  data.tar.gz: eda5c702640dd7c6b884ffd6aea3bf9246dffb729100d8d762bb109a6e35e79e
+  metadata.gz: 3f065c42ed2f757f8bbd3ed001d303bcd81a1b492f661e9a37226579009a2561
+  data.tar.gz: b4ff34b56c8a3deb7daa4f29e83ba38f715072c1544a6c8aeddbc5b81a4694bd
 SHA512:
-  metadata.gz: 31e7f98809b76810e2056389ef8512c1f990864d6ec05324bee267b00f9381aace0182fb1a4fb1043d54617d42ab45ccae12199af112df55beeff016115ce307
-  data.tar.gz: 9010a2da61a53f475fc24b258892a179848dcd93e36fe38f7e3a257d451b0ad43977497d5a63e4f68c95b30f47f63a9f6764324a5780de56c8e40315b416677d
+  metadata.gz: 69ea2bf8b0e93d7686d867096726440cce536c764d486ea88663f0054833ea5c985bcb6b1619205f9689bcb132679045779075a5acb1e9f21e0fc6205bf3ab00
+  data.tar.gz: e17ac504880cde68f96a2f3b5d0ec66362bd3813c2da9e593050367bd9414900c6f755fdd1ba2541a7b65c61906c6a111cdf8d20955bc0edbae410e18ce09bac

data/CHANGELOG.md

@@ -1,5 +1,13 @@
 ## [Unreleased]
 
+## [0.7.2] - 2026-08-16
+
+- Store the record pointer in attachment metadata under string keys, so it is no longer duplicated as both symbols and strings
+
+## [0.7.1] - 2026-04-16
+
+- Bridge attacher errors to `record.errors` on `has_many_attached`
+
 ## [0.7.0] - 2026-04-15
 
 - Support `variant:` and `strict:` options in `Attachment#url`

data/lib/active_shrine/attached/changes/create_many.rb

@@ -20,9 +20,16 @@ module ActiveShrine
         end
 
         def save
+          raise ActiveRecord::RecordInvalid.new(record) unless valid?
+
           assign_associated_attachments
         end
 
+        def valid?
+          # .map then .all? — don't short-circuit; collect errors from every subchange
+          subchanges.map(&:valid?).all?
+        end
+
         private
 
         def subchanges

data/lib/active_shrine/attached/changes/create_one.rb

@@ -23,15 +23,19 @@ module ActiveShrine
         end
 
         def save
-          unless attachment.valid?
-            attachment.errors.each do |error|
-              record.errors.add(name, error.message)
-            end
+          raise ActiveRecord::RecordInvalid.new(record) unless valid?
 
-            raise ActiveRecord::RecordInvalid.new(record)
+          record.public_send(:"#{name}_attachment=", attachment)
+        end
+
+        def valid?
+          return true if attachment.valid?
+
+          attachment.errors.each do |error|
+            record.errors.add(name, error.message)
           end
 
-          record.public_send(:"#{name}_attachment=", attachment)
+          false
         end
 
         private

data/lib/active_shrine/attachment.rb

@@ -116,7 +116,13 @@ module ActiveShrine
       def maybe_store_record
         return unless record.present?
 
-        metadata.merge! record_type:, record_id:
+        # String keys, because metadata comes back from its JSON column with
+        # string keys and this runs on every save. Merging symbols in left the
+        # pointer under both spellings, which the json gem warns about now and
+        # refuses from 3.0. Shrine persists again from its own after_save, so
+        # an attachment that receives a file after its row exists saves twice
+        # and hits this on the second pass.
+        metadata.merge!("record_type" => record_type, "record_id" => record_id)
       end
     end
   end

data/lib/active_shrine/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module ActiveShrine
-  VERSION = "0.7.0"
+  VERSION = "0.7.2"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: active_shrine
 version: !ruby/object:Gem::Version
-  version: 0.7.0
+  version: 0.7.2
 platform: ruby
 authors:
 - Radioactive Labs
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2026-04-15 00:00:00.000000000 Z
+date: 2026-08-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: railties