active_shipping 1.14.2 → 2.0.0

data/test/unit/response_test.rb

@@ -1,19 +1,38 @@
 require 'test_helper'
 
-class ResponseTest < Minitest::Test
-  def test_initialize_success
-    response = RateResponse.new(true, "success!", {:rate => 'Free!'}, :rates => [stub(:service_name => 'Free!', :total_price => 0)], :xml => "<rate>Free!</rate>")
-    assert response.success?
+class ResponseTest < ActiveSupport::TestCase
+  test "#initialize for a successful response" do
+    response = RateResponse.new(
+      true,
+      "success!",
+      { rate: 'Free!' },
+      rates: [ stub(service_name: 'Free!', total_price: 0) ],
+      xml: "<rate>Free!</rate>"
+    )
+    assert_predicate response, :success?
   end
 
-  def test_initialize_failure
+  test "#initialize for a failed response raises ResponseError" do
     assert_raises(ActiveShipping::ResponseError) do
-      RateResponse.new(false, "fail!", {:rate => 'Free!'}, :rates => [stub(:service_name => 'Free!', :total_price => 0)], :xml => "<rate>Free!</rate>")
+      RateResponse.new(
+        false,
+        "fail!",
+        { rate: 'Free!' },
+        rates: [ stub(service_name: 'Free!', total_price: 0) ],
+        xml: "<rate>Free!</rate>"
+      )
     end
   end
 
-  def test_initialize_failure_no_raise
-    response = RateResponse.new(false, "fail!", {:rate => 'Free!'}, :rates => [stub(:service_name => 'Free!', :total_price => 0)], :xml => "<rate>Free!</rate>", :allow_failure => true)
-    refute response.success?
+  test "#initialize doesn't raise when you pass in allow_failure" do
+    response = RateResponse.new(
+      false,
+      "fail!",
+      { rate: 'Free!' },
+      rates: [ stub(service_name: 'Free!', total_price: 0) ],
+      xml: "<rate>Free!</rate>",
+      allow_failure: true,
+    )
+    refute_predicate response, :success?
   end
 end

data/test/unit/shipment_event_test.rb

@@ -1,6 +1,6 @@
 require 'test_helper'
 
-class ShipmentEventTest < Minitest::Test
+class ShipmentEventTest < ActiveSupport::TestCase
   def test_equality
     options1 = [
       'ARRIVED AT UNIT',

data/test/unit/shipment_packer_test.rb

@@ -1,42 +1,42 @@
 require 'test_helper'
 
-class ShipmentPackerTest < Minitest::Test
+class ShipmentPackerTest < ActiveSupport::TestCase
   def setup
     @dimensions = [5.1, 15.2, 30.5]
   end
 
-  def test_pack_divide_order_into_a_single_package
+  test "pack divide order into a single package" do
     items = [{ grams: 1, quantity: 1, price: 1.0 }]
 
     packages = ShipmentPacker.pack(items, @dimensions, 1, 'USD')
     assert_equal 1, packages.size
 
     package = packages.first
-    assert_equal 1, package.weight
+    assert_equal Measured::Weight(1, :g), package.weight
   end
 
-  def test_divide_order_with_multiple_lines_into_a_single_package
+  test "divide order with multiple lines into a single package" do
     items = [{ grams: 1, quantity: 2, price: 1.0 }]
 
     packages = ShipmentPacker.pack(items, @dimensions, 2, 'USD')
     assert_equal 1, packages.size
 
     package = packages.first
-    assert_equal 2, package.weight
+    assert_equal Measured::Weight(2, :g), package.weight
   end
 
-  def test_divide_order_with_single_line_into_two_packages
+  test "divide order with single line into two packages" do
     items = [{ grams: 1, quantity: 2, price: 1.0 }]
 
     packages = ShipmentPacker.pack(items, @dimensions, 1, 'USD')
     assert_equal 2, packages.size
 
     packages.each do |package|
-      assert_equal 1, package.weight
+      assert_equal Measured::Weight(1, :g), package.weight
     end
   end
 
-  def test_divide_order_with_single_line_into_two_packages_max_weight_as_float
+  test "divide order with single line into two packages max weight as float" do
     max_weight = 68038.8555
 
     items = [{ grams: 45359, quantity: 2, price: 1.0 }]
@@ -45,11 +45,11 @@ class ShipmentPackerTest < Minitest::Test
     assert_equal 2, packages.size
 
     packages.each do |package|
-      assert_equal 45359, package.weight
+      assert_equal Measured::Weight(45359, :g), package.weight
     end
   end
 
-  def test_divide_order_with_multiple_lines_into_two_packages
+  test "divide order with multiple lines into two packages" do
     items = [
       { grams: 1, quantity: 1, price: 1.0 },
       { grams: 1, quantity: 1, price: 1.0 }
@@ -59,11 +59,11 @@ class ShipmentPackerTest < Minitest::Test
     assert_equal 2, packages.size
 
     packages.each do |package|
-      assert_equal 1, package.weight
+      assert_equal Measured::Weight(1, :g), package.weight
     end
   end
 
-  def test_divide_order_into_two_packages_mixing_line_items
+  test "divide order into two packages mixing line items" do
     items = [
       { grams: 1, quantity: 1, price: 1.0 },
       { grams: 1, quantity: 1, price: 1.0 },
@@ -73,29 +73,29 @@ class ShipmentPackerTest < Minitest::Test
     packages = ShipmentPacker.pack(items, @dimensions, 2, 'USD')
     assert_equal 2, packages.size
 
-    assert_equal 2, packages[0].weight
-    assert_equal 1, packages[1].weight
+    assert_equal Measured::Weight(2, :g), packages[0].weight
+    assert_equal Measured::Weight(1, :g), packages[1].weight
   end
 
-  def test_raise_overweight_exception_when_a_single_item_exceeds_the_maximum_weight_of_a_package
+  test "raise overweight exception when a single item exceeds the maximum weight of a package" do
     assert_raises(ShipmentPacker::OverweightItem) do
       items = [{ grams: 2, quantity: 1, price: 1.0 }]
       ShipmentPacker.pack(items, @dimensions, 1, 'USD')
     end
   end
 
-  def test_raise_over_weight_exceptions_before_over_package_limit_exceptions
+  test "raise over weight exceptions before over package limit exceptions" do
     assert_raises(ShipmentPacker::OverweightItem) do
       items = [{ grams: 5, quantity: ShipmentPacker::EXCESS_PACKAGE_QUANTITY_THRESHOLD + 1, price: 1.0 }]
       ShipmentPacker.pack(items, @dimensions, 4, 'USD')
     end
   end
 
-  def test_returns_an_empty_list_when_no_items_provided
+  test "returns an empty list when no items provided" do
     assert_equal [], ShipmentPacker.pack([], @dimensions, 1, 'USD')
   end
 
-  def test_add_summarized_prices_for_all_items_and_currency_to_package
+  test "add summarized prices for all items and currency to package" do
     items = [
       { grams: 1, quantity: 3, price: 1.0 },
       { grams: 2, quantity: 1, price: 2.0 }
@@ -106,7 +106,7 @@ class ShipmentPackerTest < Minitest::Test
     assert_equal 'USD', packages.first.currency
   end
 
-  def test_divide_items_and_prices_accordingly_when_splitting_into_two_packages
+  test "divide items and prices accordingly when splitting into two packages" do
     items = [
       { grams: 1, quantity: 1, price: 1.0 },
       { grams: 1, quantity: 1, price: 1.0 },
@@ -122,7 +122,7 @@ class ShipmentPackerTest < Minitest::Test
     assert_equal 'USD', packages[1].currency
   end
 
-  def test_symbolize_item_keys
+  test "symbolize item keys" do
     string_key_items          = [{ 'grams' => 1, 'quantity' => 1, 'price' => 1.0 }]
     indifferent_access_items  = [{ 'grams' => 1, 'quantity' => 1, 'price' => 1.0 }.with_indifferent_access]
 
@@ -131,22 +131,22 @@ class ShipmentPackerTest < Minitest::Test
       assert_equal 1, packages.size
 
       package = packages.first
-      assert_equal 1, package.weight
+      assert_equal Measured::Weight(1, :g), package.weight
       assert_equal 100, package.value
     end
   end
 
-  def test_cast_quantity_and_grams_to_int
+  test "cast quantity and grams to int" do
     items = [{ grams: '1', quantity: '1', price: '1.0' }]
 
     packages = ShipmentPacker.pack(items, @dimensions, 1, 'USD')
 
     package = packages.first
-    assert_equal 1, package.weight
+    assert_equal Measured::Weight(1, :g), package.weight
     assert_equal 100, package.value
   end
 
-  def test_excess_packages_raised_over_threshold_before_packing_begins
+  test "excess packages raised over threshold before packing begins" do
     ActiveShipping::Package.expects(:new).never
     items = [{ grams: 1, quantity: ShipmentPacker::EXCESS_PACKAGE_QUANTITY_THRESHOLD + 1, price: 1.0 }]
 
@@ -155,21 +155,21 @@ class ShipmentPackerTest < Minitest::Test
     end
   end
 
-  def test_excess_packages_not_raised_at_threshold
+  test "excess packages not raised at threshold" do
     items = [{ grams: 1, quantity: ShipmentPacker::EXCESS_PACKAGE_QUANTITY_THRESHOLD, price: 1.0 }]
     packages = ShipmentPacker.pack(items, @dimensions, 1, 'USD')
 
     assert_predicate packages, :present?
   end
 
-  def test_excess_packages_not_raised_below_threshold
+  test "excess packages not raised below threshold" do
     items = [{ grams: 1, quantity: ShipmentPacker::EXCESS_PACKAGE_QUANTITY_THRESHOLD - 1, price: 1.0 }]
     packages = ShipmentPacker.pack(items, @dimensions, 1, 'USD')
 
     assert_predicate packages, :present?
   end
 
-  def test_excess_packages_with_slightly_larger_max_weight_than_item_weight
+  test "excess packages with slightly larger max weight than item weight" do
     max_weight = 750
     items = [{ grams: 500, quantity: ShipmentPacker::EXCESS_PACKAGE_QUANTITY_THRESHOLD + 1, price: 1.0 }]
 
@@ -178,7 +178,7 @@ class ShipmentPackerTest < Minitest::Test
     end
   end
 
-  def test_lots_of_zero_weight_items
+  test "lots of zero weight items" do
     items = [{ grams: 0, quantity: 1_000_000, price: 1.0 }]
     packages = ShipmentPacker.pack(items, @dimensions, 1, 'USD')
 
@@ -187,7 +187,7 @@ class ShipmentPackerTest < Minitest::Test
     assert_equal 100_000_000, packages[0].value
   end
 
-  def test_dont_destroy_input_items
+  test "dont destroy input items" do
     items = [{ grams: 1, quantity: 5, price: 1.0 }]
 
     packages = ShipmentPacker.pack(items, @dimensions, 10, 'USD')
@@ -196,14 +196,14 @@ class ShipmentPackerTest < Minitest::Test
     assert_equal 1, packages.size
   end
 
-  def test_dont_modify_input_item_quantities
+  test "dont modify input item quantities" do
     items = [{ grams: 1, quantity: 5, price: 1.0 }]
 
     ShipmentPacker.pack(items, @dimensions, 10, 'USD')
     assert_equal 5, items.first[:quantity]
   end
 
-  def test_items_with_negative_weight
+  test "items with negative weight" do
     items = [{ grams: -1, quantity: 5, price: 1.0 }]
 
     ShipmentPacker.pack(items, @dimensions, 10, 'USD')

data/test/unit/tracking_response_test.rb

@@ -1,6 +1,6 @@
 require 'test_helper'
 
-class TrackingResponseTest < Minitest::Test
+class TrackingResponseTest < ActiveSupport::TestCase
   def test_equality
     options1 = {
       carrier: 'usps',

metadata

@@ -1,36 +1,36 @@
 --- !ruby/object:Gem::Specification
 name: active_shipping
 version: !ruby/object:Gem::Version
-  version: 1.14.2
+  version: 2.0.0
 platform: ruby
 authors:
 - Shopify
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-05-17 00:00:00.000000000 Z
+date: 2017-05-30 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
-  name: quantified
+  name: measured
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 1.0.1
+        version: '2.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 1.0.1
+        version: '2.0'
 - !ruby/object:Gem::Dependency
   name: activesupport
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '3.2'
+        version: '4.2'
     - - "<"
       - !ruby/object:Gem::Version
         version: 5.2.0
@@ -40,7 +40,7 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '3.2'
+        version: '4.2'
     - - "<"
       - !ruby/object:Gem::Version
         version: 5.2.0
@@ -64,14 +64,14 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 1.6.8
+        version: '1.6'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 1.6.8
+        version: '1.6'
 - !ruby/object:Gem::Dependency
   name: minitest
   requirement: !ruby/object:Gem::Requirement
@@ -86,6 +86,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: minitest-reporters
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
@@ -156,6 +170,48 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: pry-byebug
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: vcr
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: webmock
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 description: Get rates and tracking info from various shipping carriers. Extracted
   from Shopify.
 email:
@@ -175,14 +231,7 @@ files:
 - Rakefile
 - active_shipping.gemspec
 - dev.yml
-- gemfiles/activesupport32.gemfile
-- gemfiles/activesupport32_nokogiri_17.gemfile
-- gemfiles/activesupport40.gemfile
-- gemfiles/activesupport40_nokogiri_17.gemfile
-- gemfiles/activesupport41.gemfile
-- gemfiles/activesupport41_nokogiri_17.gemfile
 - gemfiles/activesupport42.gemfile
-- gemfiles/activesupport42_nokogiri_17.gemfile
 - gemfiles/activesupport50.gemfile
 - gemfiles/activesupport_master.gemfile
 - lib/active_shipping.rb
@@ -256,7 +305,6 @@ files:
 - test/fixtures/xml/canadapost_pws/dnc_tracking_details_en.xml
 - test/fixtures/xml/canadapost_pws/merchant_details_error.xml
 - test/fixtures/xml/canadapost_pws/merchant_details_response.xml
-- test/fixtures/xml/canadapost_pws/merchant_details_response_no_contract_number.xml
 - test/fixtures/xml/canadapost_pws/option_response.xml
 - test/fixtures/xml/canadapost_pws/option_response_no_conflicts.xml
 - test/fixtures/xml/canadapost_pws/rates_info.xml
@@ -266,7 +314,6 @@ files:
 - test/fixtures/xml/canadapost_pws/register_token_error.xml
 - test/fixtures/xml/canadapost_pws/register_token_response.xml
 - test/fixtures/xml/canadapost_pws/service_options_response.xml
-- test/fixtures/xml/canadapost_pws/service_options_response_priority_worldwide.xml
 - test/fixtures/xml/canadapost_pws/services_error.xml
 - test/fixtures/xml/canadapost_pws/services_response.xml
 - test/fixtures/xml/canadapost_pws/shipment_domestic.xml
@@ -393,6 +440,7 @@ files:
 - test/fixtures/xml/usps/world_rate_request_without_value.xml
 - test/fixtures/xml/usps_returns/external_return_label_response.xml
 - test/fixtures/xml/usps_returns/external_return_label_response_failure.xml
+- test/helpers/holiday_helpers.rb
 - test/remote/australia_post_test.rb
 - test/remote/canada_post_pws_platform_test.rb
 - test/remote/canada_post_pws_test.rb
@@ -440,7 +488,8 @@ homepage: http://github.com/shopify/active_shipping
 licenses:
 - MIT
 metadata: {}
-post_install_message: 
+post_install_message: 'Thanks for installing ActiveShipping! If upgrading to v2.0,
+  please see the changelog for breaking changes: https://github.com/Shopify/active_shipping/blob/master/CHANGELOG.md.'
 rdoc_options: []
 require_paths:
 - lib
@@ -494,7 +543,6 @@ test_files:
 - test/fixtures/xml/canadapost_pws/dnc_tracking_details_en.xml
 - test/fixtures/xml/canadapost_pws/merchant_details_error.xml
 - test/fixtures/xml/canadapost_pws/merchant_details_response.xml
-- test/fixtures/xml/canadapost_pws/merchant_details_response_no_contract_number.xml
 - test/fixtures/xml/canadapost_pws/option_response.xml
 - test/fixtures/xml/canadapost_pws/option_response_no_conflicts.xml
 - test/fixtures/xml/canadapost_pws/rates_info.xml
@@ -504,7 +552,6 @@ test_files:
 - test/fixtures/xml/canadapost_pws/register_token_error.xml
 - test/fixtures/xml/canadapost_pws/register_token_response.xml
 - test/fixtures/xml/canadapost_pws/service_options_response.xml
-- test/fixtures/xml/canadapost_pws/service_options_response_priority_worldwide.xml
 - test/fixtures/xml/canadapost_pws/services_error.xml
 - test/fixtures/xml/canadapost_pws/services_response.xml
 - test/fixtures/xml/canadapost_pws/shipment_domestic.xml
@@ -631,6 +678,7 @@ test_files:
 - test/fixtures/xml/usps/world_rate_request_without_value.xml
 - test/fixtures/xml/usps_returns/external_return_label_response.xml
 - test/fixtures/xml/usps_returns/external_return_label_response_failure.xml
+- test/helpers/holiday_helpers.rb
 - test/remote/australia_post_test.rb
 - test/remote/canada_post_pws_platform_test.rb
 - test/remote/canada_post_pws_test.rb