active_scheduler 0.3.0 → 0.4.0

Sign up to get free protection for your applications and to get access to all the features.
checksums.yaml CHANGED
@@ -1,7 +1,7 @@
1
1
  ---
2
2
  SHA1:
3
- metadata.gz: 5947ed39877bdeb1e41be0dc069f91cbd42a3d0b
4
- data.tar.gz: 738b6e3d63ed6ecb05359ca01491fd0b0785c9e9
3
+ metadata.gz: aacb194aabc4d58844c53d39ea5a6ea6e6874e78
4
+ data.tar.gz: fa71108f500b8f327ed795bd9d1ff745585a3963
5
5
  SHA512:
6
- metadata.gz: 78e7c5564036a7b8517a801bcf693bb843dbc2304836e2065d20cd8b3a6b992d0b9cac1a665d18a235eee1cd615884726b54d7d7ba103e2c27951213a1c39aae
7
- data.tar.gz: b7016a965d05c43aab4f044a23b9ca6369618f45385dde78f8ac83785fd7c64e9e1a90ce822a354b5fc3e3a0dab72eef2988cdf2473bd1d6400d48069705503f
6
+ metadata.gz: 79cf50db7912a468042094b3892175a32e34b237d7febf2954c8cccd4008ef4e8aac8853c58448d0d1b52f15bf6611ee8705bc7eb1fb2f6003852a058127cf8f
7
+ data.tar.gz: a26920e8ee37167a7ad2e0a986cba4525afe9b5f57047a12fa11a1a689c1587ba9818aa9a07cb2df3f8ed17c71e585d6f64747a8ec69dd1b2a9481f89df22b0b
data/CHANGELOG.markdown CHANGED
@@ -1,6 +1,9 @@
1
+ # 0.4.0
2
+ - Use job's queue instead of hardcoded `default` [#9](https://github.com/JustinAiken/active_scheduler/pull/9) (Thanks @r3trofitted)
3
+
1
4
  # 0.3.0
2
5
 
3
- - :boom: active_support dependency
6
+ - Remove explicit active_support dependency (it's pulled in by activejob)
4
7
  - Updated testing matrix for more rubies 💎💎💎
5
8
  - Support named args [#6](https://github.com/JustinAiken/active_scheduler/pull/6) (Thanks @jdguzman)
6
9
 
data/README.markdown CHANGED
@@ -83,6 +83,7 @@ simple_job:
83
83
  - @jeremycrosbie
84
84
  - @ximus
85
85
  - @jdguzman
86
+ - @r3trofitted
86
87
 
87
88
  ## License
88
89
 
@@ -24,9 +24,11 @@ module ActiveScheduler
24
24
  schedule.each do |job, opts|
25
25
  class_name = opts[:class] || job
26
26
  next if class_name =~ /ActiveScheduler::ResqueWrapper/
27
- next unless class_name.constantize <= ActiveJob::Base
27
+
28
+ klass = class_name.constantize
29
+ next unless klass <= ActiveJob::Base
28
30
 
29
- queue = opts[:queue] || 'default'
31
+ queue = opts[:queue] || klass.queue_name
30
32
  args = opts[:args]
31
33
  named_args = opts[:named_args] || false
32
34
 
@@ -1,3 +1,3 @@
1
1
  module ActiveScheduler
2
- VERSION = "0.3.0"
2
+ VERSION = "0.4.0"
3
3
  end
@@ -79,9 +79,14 @@ describe ActiveScheduler::ResqueWrapper do
79
79
  context "when the queue is blank" do
80
80
  let(:schedule) { YAML.load_file 'spec/fixtures/no_queue.yaml' }
81
81
 
82
- it "uses 'default'" do
83
- stub_jobs("SimpleJob")
84
- expect(wrapped['no_queue_job']['queue']).to eq 'default'
82
+ it "uses the job's queue" do
83
+ simple_job = Class.new(ActiveJob::Base) do
84
+ queue_as :myscheduledjobqueue
85
+ end
86
+
87
+ stub_const("SimpleJob", simple_job)
88
+
89
+ expect(wrapped['no_queue_job']['queue']).to eq 'myscheduledjobqueue'
85
90
  end
86
91
  end
87
92
 
metadata CHANGED
@@ -1,14 +1,14 @@
1
1
  --- !ruby/object:Gem::Specification
2
2
  name: active_scheduler
3
3
  version: !ruby/object:Gem::Version
4
- version: 0.3.0
4
+ version: 0.4.0
5
5
  platform: ruby
6
6
  authors:
7
7
  - Justin Aiken
8
8
  autorequire:
9
9
  bindir: bin
10
10
  cert_chain: []
11
- date: 2016-08-02 00:00:00.000000000 Z
11
+ date: 2016-12-15 00:00:00.000000000 Z
12
12
  dependencies:
13
13
  - !ruby/object:Gem::Dependency
14
14
  name: rake