active_scaffold_batch 3.5.2 → 3.6.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 57996a4d8d4924a4d1dd7bea60e270cc86906312e3b98a806425e4b0742f248e
-  data.tar.gz: acb26347253ee5fa7f8babd740de40897ce9d8673f6c004aa36c8536459f85ef
+  metadata.gz: e95a8d9d4e5992e891a21ce962d70afafe38fec0ec4657c7a83d2fe7cbb92029
+  data.tar.gz: be53b9d4c5c36a261ecec93d28408bed9f13d9772d1029121ad9d43ea9431073
 SHA512:
-  metadata.gz: b70ebd0b00056a6ad2a6432d179efa852deb037dd271c492bee28fc982743779d0a2df0d5e3cf5bded88aa7e6d5a5412a227a4829e5909052e99d90a3105db5a
-  data.tar.gz: ae11b116e3bd9195797bb0e00d57911c51433b329c7b7af3d58e902fc05955c2bda96d288fef118f722204ca13a9d4e041bf7b2dd759f13b6b86ae87317a6fea
+  metadata.gz: da80d681008c619906e14e6442e156fd9ddc3109ad0c58f08a9d92dcb2521be1c6e51dd449a777ce837c6043b6af667b7f206d7cf4954b7d6f7884caf9098971
+  data.tar.gz: ba40cf458703959ec5d4a8a12a192372754be3bb772ae017efe252ddceb075c11b710344ec0849d0f2934f385a3173378365e6d474c913a4b2994e4caeff4ce0

data/app/assets/javascripts/{jquery/active_scaffold_batch.js → active_scaffold_batch.js}

@@ -10,4 +10,10 @@ jQuery(document).ready(function() {
     record.prev('.form_record-errors').remove();
     record.remove();
   });
+  jQuery(document).on('change', 'select.as_update_date_operator, select.as_batch_update_operator', function(event) {
+    ActiveScaffold[jQuery(this).val() === 'REPLACE' ? 'show' : 'hide'](jQuery(this).next());
+  });
+  jQuery(document).on('change', 'select.as_update_date_operator', function(event) {
+    ActiveScaffold[['REPLACE', 'NO_UPDATE', 'NULL'].indexOf(jQuery(this).val()) !== -1 ? 'hide' : 'show'](jQuery(this).next().next());
+  });
 });

data/lib/active_scaffold/actions/batch_update.rb

@@ -217,7 +217,8 @@ module ActiveScaffold::Actions
     alias_method :batch_update_value_for_float, :batch_update_value_for_numeric
 
     def batch_update_all_value_for_numeric(column, calculation_info)
-      if ActiveScaffold::Actions::BatchUpdate::GenericOperators.include?(calculation_info[:operator]) || ActiveScaffold::Actions::BatchUpdate::NumericOperators.include?(calculation_info[:operator])
+      operator = calculation_info[:operator]
+      if operator == 'NULL' || ActiveScaffold::Actions::BatchUpdate::GenericOperators.include?(operator) || ActiveScaffold::Actions::BatchUpdate::NumericOperators.include?(operator)
         operand = active_scaffold_config.model.quote_value(self.class.condition_value_for_numeric(column, calculation_info[:value]))
         if calculation_info[:opt] == 'PERCENT'
           operand = "#{active_scaffold_config.model.connection.quote_column_name(column.name)} / 100.0 * #{operand}"
@@ -242,18 +243,18 @@ module ActiveScaffold::Actions
 
     def batch_update_value_for_date_picker(column, record, calculation_info)
       current_value = record.send(column.name)
-      {"number"=>"", "unit"=>"DAYS", "value"=>"November 16, 2010", "operator"=>"REPLACE"}
-      if ActiveScaffold::Actions::BatchUpdate::GenericOperators.include?(calculation_info[:operator]) || ActiveScaffold::Actions::BatchUpdate::DateOperators.include?(calculation_info[:operator])
+      operator = calculation_info[:operator]
+      if operator == 'NULL' || ActiveScaffold::Actions::BatchUpdate::GenericOperators.include?(operator) || ActiveScaffold::Actions::BatchUpdate::DateOperators.include?(operator)
         operand = self.class.condition_value_for_datetime(column, calculation_info[:value], column.column.type == :date ? :to_date : :to_time)
         case calculation_info[:operator]
         when 'REPLACE' then operand
         when 'NULL' then nil
         when 'PLUS' then
           trend_number = [calculation_info['number'].to_i,  1].max
-          current_value.in((trend_number).send(calculation_info['unit'].downcase.singularize.to_sym))
+          current_value&.in((trend_number).send(calculation_info['unit'].downcase.singularize.to_sym))
         when 'MINUS' then
           trend_number = [calculation_info['number'].to_i,  1].max
-          current_value.ago((trend_number).send(calculation_info['unit'].downcase.singularize.to_sym))
+          current_value&.ago((trend_number).send(calculation_info['unit'].downcase.singularize.to_sym))
         else
           current_value
         end
@@ -261,7 +262,6 @@ module ActiveScaffold::Actions
         current_value
       end
     end
-    alias_method :batch_update_value_for_calendar_date_select, :batch_update_value_for_date_picker
 
     def override_batch_update_value(form_ui)
       method = "batch_update_value_for_#{form_ui}"

data/lib/active_scaffold/helpers/datepicker_update_column_helpers.rb

@@ -3,26 +3,25 @@ module ActiveScaffold
     module DatepickerUpdateColumnHelpers
       def active_scaffold_update_date_picker(column, options)
         current_params = {:value => nil, :number => nil, :unit => nil, :operator => 'NO_UPDATE'}
-        current_params.merge!(batch_update_values[column.name][:value].symbolize_keys) if batch_update_values[column.name] && batch_update_values[column.name][:value]
+        current_params.merge!(batch_update_values[column.name][:value].symbolize_keys) if batch_update_values.dig(column.name, :value)
         operator_options = active_scaffold_update_generic_operators(column)
         operator_options.concat(ActiveScaffold::Actions::BatchUpdate::DateOperators.collect {|comp| [as_(comp.downcase.to_sym), comp]}) if active_scaffold_config.batch_update.process_mode == :update
         options = options.merge(:show => ['PLUS', 'MINUS'].exclude?(current_params[:operator]))
         tags = []
-        tags << select_tag("[record][#{column.name}][operator]",
+        tags << select_tag("#{options[:name]}[operator]",
                 options_for_select(operator_options, current_params[:operator]),
                   :id => "#{options[:id]}_operator",
                   :class => "text-input as_update_date_operator")
-        tags << active_scaffold_search_date_bridge_calendar_control(column, options, current_params[:value], 'value')
+        tags << active_scaffold_search_date_picker_field(column, options.merge(show: current_params[:operator] == 'REPLACE'), current_params[:value], 'value')
         tags << active_scaffold_update_date_bridge_trend_tag(column, current_params, options)
         tags.join("&nbsp;").html_safe
       end
 
       def active_scaffold_update_date_bridge_trend_tag(column, current_params, options)
-        active_scaffold_date_bridge_trend_tag(column, options,
-                                             {:name_prefix => '[record]',
-                                              :number_value => current_params[:number],
-                                              :unit_value => current_params[:unit],
-                                              :show => ['PLUS','MINUS'].include?(current_params[:operator])})
+        active_scaffold_search_datetime_trend_tag(column, options,
+                                             {'number' => current_params[:number],
+                                              'unit' => current_params[:unit],
+                                              show: ['PLUS','MINUS'].include?(current_params[:operator])})
       end
     end
   end

data/lib/active_scaffold/helpers/update_column_helpers.rb

@@ -17,7 +17,9 @@ module ActiveScaffold
        elsif column.column and column.form_ui.nil? and (method = override_update(column.column.type))
           send(method, column, options)
         else
-          active_scaffold_update_generic_operators_select(column, options)<< ' ' << active_scaffold_render_input(column, options.merge(:name => "record[#{column.name}][value]"))
+          show_field = batch_update_values.dig(column.name, :value, :operator) == 'REPLACE'
+          active_scaffold_update_generic_operators_select(column, options) << ' ' <<
+            active_scaffold_render_input(column, options.merge(name: "record[#{column.name}][value]", style: ('display: none;' unless show_field)))
         end
       end
 
@@ -31,8 +33,8 @@ module ActiveScaffold
 
       def active_scaffold_update_generic_operators_select(column, options)
         current = {:operator => 'NO_UPDATE'}
-        current.merge!(batch_update_values[column.name][:value].symbolize_keys) if batch_update_values[column.name] && batch_update_values[column.name][:value]
-        select_tag("[record][#{column.name}][operator]",
+        current.merge!(batch_update_values[column.name][:value].symbolize_keys) if batch_update_values.dig(column.name, :value)
+        select_tag("record[#{column.name}][operator]",
               options_for_select(active_scaffold_update_generic_operators(column), current[:operator]),
               :id => "#{options[:id]}_operator",
               :class => "as_batch_update_operator text_input")
@@ -43,12 +45,12 @@ module ActiveScaffold
         current.merge!(batch_update_values[column.name][:value].symbolize_keys) if batch_update_values[column.name] && batch_update_values[column.name][:value]
         operator_options = active_scaffold_update_generic_operators(column) + ActiveScaffold::Actions::BatchUpdate::NumericOperators.collect {|comp| [as_(comp.downcase.to_sym), comp]}
         select_options = ActiveScaffold::Actions::BatchUpdate::NumericOptions.collect {|comp| [as_(comp.downcase.to_sym), comp]}
-        html = select_tag("[record][#{column.name}][operator]",
+        html = select_tag("record[#{column.name}][operator]",
               options_for_select(operator_options, current[:operator]),
               :id => "#{options[:id]}_operator",
               :class => "as_update_numeric_option")
-        html << ' ' << text_field_tag("[record][#{column.name}][value]", current[:value], active_scaffold_input_text_options)
-        html << ' ' << select_tag("[record][#{column.name}][opt]",
+        html << ' ' << text_field_tag("record[#{column.name}][value]", current[:value], active_scaffold_input_text_options)
+        html << ' ' << select_tag("record[#{column.name}][opt]",
               options_for_select(select_options, current[:opt]),
               :id => "#{options[:id]}_opt",
               :class => "as_update_numeric_option")

data/lib/active_scaffold_batch/engine.rb

@@ -19,11 +19,7 @@ module ActiveScaffoldBatch
       ActiveSupport.on_load(:action_view) do
         begin
           include ActiveScaffold::Helpers::UpdateColumnHelpers
-          if ActiveScaffold.js_framework == :jquery
-            include ActiveScaffold::Helpers::DatepickerUpdateColumnHelpers
-          elsif ActiveScaffold.js_framework == :prototype
-            include ActiveScaffold::Helpers::CalendarDateSelectUpdateColumnHelpers if defined? CalendarDateSelect
-          end
+          include ActiveScaffold::Helpers::DatepickerUpdateColumnHelpers
           include ActiveScaffold::Helpers::BatchCreateColumnHelpers
         rescue
           raise $! unless Rails.env == 'production'

data/lib/active_scaffold_batch/version.rb

@@ -1,8 +1,8 @@
 module ActiveScaffoldBatch
   module Version
     MAJOR = 3
-    MINOR = 5
-    PATCH = 2
+    MINOR = 6
+    PATCH = 1
 
     STRING = [MAJOR, MINOR, PATCH].compact.join('.')
   end

data/lib/active_scaffold_batch.rb

@@ -22,4 +22,4 @@ module ActiveScaffold
 end
 
 ActiveScaffold.stylesheets << 'active_scaffold_batch'
-ActiveScaffold.javascripts << "#{ActiveScaffold.js_framework}/active_scaffold_batch"
+ActiveScaffold.javascripts << 'active_scaffold_batch'

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: active_scaffold_batch
 version: !ruby/object:Gem::Version
-  version: 3.5.2
+  version: 3.6.1
 platform: ruby
 authors:
 - Sergio Cambra
@@ -9,7 +9,7 @@ authors:
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2024-08-23 00:00:00.000000000 Z
+date: 2025-04-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: active_scaffold
@@ -17,14 +17,14 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 3.7.1
+        version: 4.0.4
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 3.7.1
+        version: 4.0.4
 description: You want to destroy/update many records at once with activescaffold?
 email: activescaffold@googlegroups.com
 executables: []
@@ -34,8 +34,7 @@ extra_rdoc_files:
 files:
 - LICENSE.txt
 - README
-- app/assets/javascripts/jquery/active_scaffold_batch.js
-- app/assets/javascripts/prototype/active_scaffold_batch.js
+- app/assets/javascripts/active_scaffold_batch.js
 - app/assets/stylesshets/active_scaffold_batch.scss
 - app/views/active_scaffold_overrides/_batch_create_form.html.erb
 - app/views/active_scaffold_overrides/_batch_create_form_attribute.html.erb
@@ -69,7 +68,6 @@ files:
 - lib/active_scaffold/config/batch_destroy.rb
 - lib/active_scaffold/config/batch_update.rb
 - lib/active_scaffold/helpers/batch_create_column_helpers.rb
-- lib/active_scaffold/helpers/calendar_date_select_update_column_helpers.rb
 - lib/active_scaffold/helpers/datepicker_update_column_helpers.rb
 - lib/active_scaffold/helpers/update_column_helpers.rb
 - lib/active_scaffold_batch.rb
@@ -94,7 +92,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.2.3
+rubygems_version: 3.5.11
 signing_key:
 specification_version: 4
 summary: Batch Processing for ActiveScaffold

data/app/assets/javascripts/prototype/active_scaffold_batch.js

@@ -1,13 +0,0 @@
-document.observe("dom:loaded", function() {
-  document.on('ajax:create', '.batch-create-rows a', function(event, response) {
-    var num_records = $(this).up('.batch-create-rows').down('input[name=num_records]').value();
-    if (num_records) response.request.url += (response.request.url.include('?') ? '&' : '?') + 'num_records=' + num_records;
-    return true;
-  });
-  document.on('click', '.multiple .form_record > a.remove', function(event) {
-    event.stop();
-    var record = $(this).up('.form_record'), errors = record.previous('.form_record-errors');
-    if (errors) errors.remove();
-    record.remove();
-  });
-});

data/lib/active_scaffold/helpers/calendar_date_select_update_column_helpers.rb

@@ -1,33 +0,0 @@
-module ActiveScaffold
-  module Helpers
-    module CalendarDateSelectUpdateColumnHelpers
-      def active_scaffold_update_calendar_date_select(column, options)
-        current_params = {:value => nil, :number => nil, :unit => nil, :operator => 'NO_UPDATE'}
-        current_params.merge!(batch_update_values[column.name][:value].symbolize_keys) if batch_update_values[column.name] && batch_update_values[column.name][:value]
-        Rails.logger.info("update_date column: #{column.name}: #{current_params[:value].inspect}, class: #{current_params[:value].class}")
-        Rails.logger.info("update_date column: #{column.name}: options #{options.inspect}")
-        current_params[:value] = nil if current_params[:value].is_a?(String)
-        Rails.logger.info("update_date2 column: #{column.name}: #{current_params[:value].inspect}, class: #{current_params[:value].class}")
-        operator_options = active_scaffold_update_generic_operators(column)
-        operator_options.concat(ActiveScaffold::Actions::BatchUpdate::DateOperators.collect {|comp| [as_(comp.downcase.to_sym), comp]}) if active_scaffold_config.batch_update.process_mode == :update
-        options = options.merge(:show => ['PLUS', 'MINUS'].exclude?(current_params[:operator]))
-        tags = []
-        tags << select_tag("[record][#{column.name}][operator]",
-                options_for_select(operator_options, current_params[:operator]),
-                  :id => "#{options[:id]}_operator",
-                  :class => "text-input as_update_date_operator")
-        tags << active_scaffold_search_date_bridge_calendar_control(column, options, current_params[:value], 'value')
-        tags << active_scaffold_update_date_bridge_trend_tag(column, current_params, options)
-        tags.join("&nbsp;").html_safe
-      end
-
-      def active_scaffold_update_date_bridge_trend_tag(column, current_params, options)
-        active_scaffold_date_bridge_trend_tag(column, options,
-                                             {:name_prefix => '[record]',
-                                              :number_value => current_params[:number],
-                                              :unit_value => current_params[:unit],
-                                              :show => ['PLUS','MINUS'].include?(current_params[:operator])})
-      end
-    end
-  end
-end