active_scaffold 4.2.1 → 4.2.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 0ce255799e0bff6d3854d55afdf9278d3a283f68f6d0b1a639acf5bd229b359a
-  data.tar.gz: 62761ad0b3530526880f7d8ac464f1f61623f76a6cbdd55512ab6e6102b6f963
+  metadata.gz: d279597d030fea168fba4fbcc8cd44c99d02f44b4596c774ec4476db04d53cd1
+  data.tar.gz: 48fd530b7990ec28454a1b3adebd5da80ca1d833727b22563a85cef1e140747f
 SHA512:
-  metadata.gz: ad75a5aef07ab0ed9a6997847249ebfd30b749ffe6502472a74066e86ff08fd196b85579bdec112108a71d149f7918af79cfeec64cdee23d095440594a33dba0
-  data.tar.gz: 6bcb9392ee5554b46ebb708d957b061c890b23fc613298c8296370276480b27bae10c4dc7fbb683aeed615aec9bbb1c83de7ac11ada6e1714fcf1d5b6958813b
+  metadata.gz: 1317103cf2e2344d0340f76f020a7df076f7aedff8f07b1c0a19499338d2d7941e762c51b33757cbcf3cd039d0d9f8bc8b57653282098f23fadfc069fd631bf0
+  data.tar.gz: 1300926c2397ea724f788a2b9899397e6c1e0ec6ca5a55a77677edf93dc98e5ed70e1b742c9a6ee8618067e4c378e58899d18e0fba9514e41cbde943c5589c01

data/CHANGELOG.rdoc

@@ -1,3 +1,13 @@
+= 4.2.3
+- Make simplified searches on LogicalQueryParser bridge working with upstream gem, no need for my fork
+- Styles for radio form_ui
+- Fix style for checkbox list in subform
+- Fix constraints (broken on 4.2.2 on some cases)
+
+= 4.2.2
+- Support setting form_ui_options with nil, for subforms
+- Support saving when embedded on through singular association, as it's supported for nested too
+
 = 4.2.1
 - Fix replacing tinymce fields with update_columns
 - Support refresh_link in radio form UI

data/app/assets/stylesheets/active_scaffold_layout.scss

@@ -750,6 +750,12 @@ float: left;
 .active-scaffold li.form-element dd input[type="checkbox"] {
 margin-top: 6px;
 }
+.active-scaffold form input[type=radio] {
+  margin-right: 5px;
+}
+.active-scaffold form label:has(input[type=radio]) {
+  margin-right: 10px;
+}
 
 .active-scaffold li.form-element dd .select-field:not(.draggable-lists-container) {
   display: inline-block;
@@ -1039,7 +1045,7 @@ padding: 0 2px 2px 2px;
 border: solid 1px;
 }
 
-.active-scaffold .sub-form .checkbox-list label {
+.active-scaffold .sub-form .checkbox-list li {
 display: block;
 }
 

data/lib/active_scaffold/actions/core.rb

@@ -146,6 +146,16 @@ module ActiveScaffold::Actions
       "#{params[:parent_controller].camelize}Controller"
     end
 
+    def create_on_through_singular(record, association, parent_record)
+      through = parent_record.send(association.through_reflection.name) ||
+                parent_record.send(:"build_#{association.through_reflection.name}")
+      if association.source_reflection.reverse_association.collection?
+        record.send(association.source_reflection.reverse) << through
+      else
+        record.send(:"#{association.source_reflection.reverse}=", through)
+      end
+    end
+
     def setup_parent
       cfg = main_form_controller.active_scaffold_config
       parent = cfg.model.new

data/lib/active_scaffold/actions/nested.rb

@@ -107,13 +107,7 @@ module ActiveScaffold::Actions
       if nested.child_association&.singular?
         record.send(:"#{nested.child_association.name}=", nested_parent_record)
       elsif nested.create_through_singular?
-        through = nested_parent_record.send(nested.association.through_reflection.name) ||
-                  nested_parent_record.send(:"build_#{nested.association.through_reflection.name}")
-        if nested.source_reflection.reverse_association.collection?
-          record.send(nested.source_reflection.reverse) << through
-        else
-          record.send(:"#{nested.source_reflection.reverse}=", through)
-        end
+        create_on_through_singular(record, nested.association, nested_parent_record)
       else
         record.send(nested.child_association.name) << nested_parent_record
       end

data/lib/active_scaffold/bridges/logical_query_parser/keyword_query_parser.rb

@@ -0,0 +1,23 @@
+# frozen_string_literal: true
+
+require 'method_source'
+
+class ActiveScaffold::Bridges::LogicalQueryParser
+  class KeywordQueryParser
+    LogicalQueryParser.singleton_methods.each do |method_name|
+      method = LogicalQueryParser.method(method_name)
+      define_method(method_name, &method)
+    end
+
+    # Copy search method from LogicalQueryParser
+    class_eval(LogicalQueryParser.method(:search).source, __FILE__, __LINE__)
+
+    def initialize(operator)
+      @operator = operator
+    end
+
+    def new
+      ActiveScaffold::Bridges::LogicalQueryParser::TokensGrammar::Parser.new(@operator)
+    end
+  end
+end

data/lib/active_scaffold/bridges/logical_query_parser.rb

@@ -1,9 +1,10 @@
 # frozen_string_literal: true
 
 class ActiveScaffold::Bridges::LogicalQueryParser < ActiveScaffold::DataStructures::Bridge
+  autoload :TokensGrammar, 'active_scaffold/bridges/logical_query_parser/tokens_grammar'
+  autoload :KeywordQueryParser, 'active_scaffold/bridges/logical_query_parser/keyword_query_parser'
+
   def self.install
-    require File.join(File.dirname(__FILE__), 'logical_query_parser/tokens_grammar')
-    ActiveScaffold::Finder.send(:remove_const, :LOGICAL_COMPARATORS)
     ActiveScaffold::Finder.const_set :LOGICAL_COMPARATORS, %w[all_tokens any_token logical].freeze
   end
 end

data/lib/active_scaffold/constraints.rb

@@ -155,6 +155,41 @@ module ActiveScaffold
       "Malformed constraint `#{klass}##{column_name}'. If it's a legitimate column, and you are using a nested scaffold, please specify or double-check the reverse association name."
     end
 
+    def apply_constraint_on_association(record, association, value, allow_autosave: false)
+      if association.through_singular? && association.source_reflection.reverse
+        create_on_through_singular(record, association, association.klass.find(value))
+      elsif association.collection?
+        record.send(k.to_s).send(:<<, association.klass.find(value)) unless association.nested?
+      elsif association.polymorphic?
+        apply_constraint_on_polymorphic_association(record, association, value)
+      elsif !association.source_reflection&.through? && # regular singular association, or one-level through association
+            !value.is_a?(Array)
+        record.send(:"#{association.name}=", association.klass.find(value))
+
+        # setting the belongs_to side of a has_one isn't safe. if the has_one was already
+        # specified, rails won't automatically clear out the previous associated record.
+        #
+        # note that we can't take the extra step to correct this unless we're permitted to
+        # run operations where activerecord auto-saves the object.
+        reverse = association.reverse_association
+        if reverse&.singular? && !reverse.belongs_to? && allow_autosave
+          record.send(association.name).send(:"#{reverse.name}=", record)
+        end
+      end
+    end
+
+    def apply_constraint_on_polymorphic_association(record, association, value)
+      unless value.is_a?(Array) && value.size >= 2
+        raise ActiveScaffold::MalformedConstraint, polymorphic_constraint_error(association), caller
+      end
+
+      if value.size == 2
+        record.send(:"#{association.name}=", value[0].constantize.find(value[1]))
+      else
+        record.send(:"#{association.foreign_type}=", value[0])
+      end
+    end
+
     # Applies constraints to the given record.
     #
     # Searches through the known columns for association columns. If the given constraint is an association,
@@ -163,40 +198,12 @@ module ActiveScaffold
     #
     # For some operations ActiveRecord will automatically update the database. That's not always ok.
     # If it *is* ok (e.g. you're in a transaction), then set :allow_autosave to true.
-    def apply_constraints_to_record(record, options = {})
-      options[:allow_autosave] = false if options[:allow_autosave].nil?
-      constraints = options[:constraints] || active_scaffold_constraints
-
+    def apply_constraints_to_record(record, allow_autosave: false, constraints: active_scaffold_constraints)
       config = record.is_a?(active_scaffold_config.model) ? active_scaffold_config : active_scaffold_config_for(record.class)
       constraints.each do |k, v|
         column = config.columns[k]
         if column&.association
-          if column.association.collection?
-            record.send(k.to_s).send(:<<, column.association.klass.find(v)) unless column.association.nested?
-          elsif column.association.polymorphic?
-            unless v.is_a?(Array) && v.size >= 2
-              raise ActiveScaffold::MalformedConstraint, polymorphic_constraint_error(column.association), caller
-            end
-
-            if v.size == 2
-              record.send(:"#{k}=", v[0].constantize.find(v[1]))
-            else
-              record.send(:"#{column.association.foreign_type}=", v[0])
-            end
-          elsif !column.association.source_reflection&.options&.include?(:through) && # regular singular association, or one-level through association
-                !v.is_a?(Array)
-            record.send(:"#{k}=", column.association.klass.find(v))
-
-            # setting the belongs_to side of a has_one isn't safe. if the has_one was already
-            # specified, rails won't automatically clear out the previous associated record.
-            #
-            # note that we can't take the extra step to correct this unless we're permitted to
-            # run operations where activerecord auto-saves the object.
-            reverse = column.association.reverse_association
-            if reverse&.singular? && !reverse.belongs_to? && options[:allow_autosave]
-              record.send(k).send(:"#{reverse.name}=", record)
-            end
-          end
+          apply_constraint_on_association(record, column.association, v, allow_autosave: allow_autosave)
         else
           record.send(:"#{k}=", v)
         end

data/lib/active_scaffold/data_structures/association/active_record.rb

@@ -6,7 +6,7 @@ module ActiveScaffold::DataStructures::Association
       klass.reflect_on_all_associations
     end
 
-    delegate :collection?, :polymorphic?, :association_primary_key, :foreign_type, :table_name, :nested?, :scope, to: :@association
+    delegate :collection?, :polymorphic?, :association_primary_key, :foreign_type, :table_name, :nested?, :scope, :class_name, to: :@association
 
     def through?
       @association.options[:through].present?
@@ -17,11 +17,11 @@ module ActiveScaffold::DataStructures::Association
     end
 
     def through_reflection
-      @association.through_reflection if through?
+      @through_reflection ||= self.class.new(@association.through_reflection) if through?
     end
 
     def source_reflection
-      @association.source_reflection if through?
+      @source_reflection ||= self.class.new(@association.source_reflection) if through?
     end
 
     def inverse_klass

data/lib/active_scaffold/data_structures/column.rb

@@ -346,7 +346,7 @@ module ActiveScaffold::DataStructures
       end
 
       def searchable?
-        search_sql.present? || (logical_search.present? && ActiveScaffold::Finder::LOGICAL_COMPARATORS.present?)
+        search_sql.present? || (logical_search.present? && ActiveScaffold::Finder.logical_comparators.present?)
       end
 
       def link
@@ -746,10 +746,14 @@ module ActiveScaffold::DataStructures
 
     def valid_action_ui_params?(value)
       if value.is_a?(Array)
-        value.size <= 2 && value[0].is_a?(Symbol) && (value[1].nil? || value[1].is_a?(Hash))
+        value.size <= 2 && valid_form_ui?(value[0]) && (value[1].nil? || value[1].is_a?(Hash))
       else
-        value.nil? || value.is_a?(Symbol)
+        valid_form_ui?(value)
       end
     end
+
+    def valid_form_ui?(value)
+      value.nil? || value.is_a?(Symbol)
+    end
   end
 end

data/lib/active_scaffold/data_structures/nested_info.rb

@@ -104,8 +104,8 @@ module ActiveScaffold::DataStructures
     #    RatesController has employee in create action columns (reverse is vendor, and through association employee is in create form).
     def readonly_through_association?(columns)
       return false unless through_association?
-      return true if association.through_reflection.options[:through] # create not possible, too many levels
-      return true if association.source_reflection.options[:through] # create not possible, too many levels
+      return true if association.through_reflection.through? # create not possible, too many levels
+      return true if association.source_reflection.through? # create not possible, too many levels
       return false if create_through_singular? # create allowed, AS has code for this
       return false unless association.source_reflection.collection? # create allowed if source is singular, rails creates joint model
 
@@ -114,7 +114,7 @@ module ActiveScaffold::DataStructures
     end
 
     def create_through_singular?
-      association.through_singular? && source_reflection.reverse
+      association.through_singular? && association.source_reflection.reverse
     end
 
     def create_with_parent?
@@ -125,10 +125,6 @@ module ActiveScaffold::DataStructures
       end
     end
 
-    def source_reflection
-      @source_reflection ||= ActiveScaffold::DataStructures::Association::ActiveRecord.new(association.source_reflection)
-    end
-
     def through_association?
       association.through?
     end

data/lib/active_scaffold/finder.rb

@@ -6,6 +6,10 @@ module ActiveScaffold
       @@like_operator ||= ::ActiveRecord::Base.connection.adapter_name.in?(%w[PostgreSQL PostGIS]) ? 'ILIKE' : 'LIKE'
     end
 
+    def self.logical_comparators
+      ActiveScaffold::Finder::LOGICAL_COMPARATORS if ActiveScaffold::Finder.const_defined? :LOGICAL_COMPARATORS
+    end
+
     module ClassMethods
       def self.extended(klass)
         return unless klass.active_scaffold_config
@@ -231,21 +235,21 @@ module ActiveScaffold
           ['(%<search_sql>s BETWEEN ? AND ?)', value[:from], value[:to]]
         elsif ActiveScaffold::Finder::NUMERIC_COMPARATORS.include?(value[:opt])
           ["%<search_sql>s #{value[:opt]} ?", value[:from]]
-        elsif ActiveScaffold::Finder::LOGICAL_COMPARATORS.include?(value[:opt])
+        elsif ActiveScaffold::Finder.logical_comparators&.include?(value[:opt])
           operator =
             case value[:opt]
             when 'all_tokens' then 'AND'
             when 'any_token'  then 'OR'
             end
-          parser = ActiveScaffold::Bridges::LogicalQueryParser::TokensGrammar::Parser.new(operator) if operator
-          [logical_search_condition(column, value[:from], parser)]
+          parser = ActiveScaffold::Bridges::LogicalQueryParser::KeywordQueryParser.new(operator) if operator
+          [logical_search_condition(column, value[:from], parser || ::LogicalQueryParser)]
         end
       end
 
-      def logical_search_condition(column, search, parser = nil)
+      def logical_search_condition(column, search, parser)
         model = column.active_record_class
         subquery = alias_query_for_same_table_exists(model.all) if column.logical_search.any?(Hash)
-        query = ::LogicalQueryParser.search(search, subquery || model, columns: column.logical_search, parser: parser)
+        query = parser.search(search, subquery || model, column.logical_search)
         if subquery
           model.where(same_table_exists_subquery(query))
         else
@@ -526,7 +530,6 @@ module ActiveScaffold
       doesnt_begin_with: 'not_?%',
       doesnt_end_with:   'not_%?'
     }.freeze
-    LOGICAL_COMPARATORS = [].freeze
     NULL_COMPARATORS = %w[null not_null].freeze
     DATE_COMPARATORS = %w[PAST FUTURE RANGE].freeze
     DATE_UNITS = %w[DAYS WEEKS MONTHS YEARS].freeze

data/lib/active_scaffold/helpers/controller_helpers.rb

@@ -167,15 +167,13 @@ module ActiveScaffold
       def build_associated(association, parent_record)
         if association.through? && association.through_reflection.collection?
           # build full chain, only check create_associated on initial parent_record
-          parent_record = build_associated(association.class.new(association.through_reflection), parent_record)
-          source_assoc = association.class.new(association.source_reflection)
-          build_associated(source_assoc, parent_record).tap do |record|
-            save_record_to_association(record, source_assoc.reverse_association, parent_record) # set inverse
+          parent_record = build_associated(association.through_reflection, parent_record)
+          build_associated(association.source_reflection, parent_record).tap do |record|
+            save_record_to_association(record, association.source_reflection.reverse_association, parent_record) # set inverse
           end
         elsif association.through? # through belongs_to/has_one
           parent_record = parent_record.send(association.through_reflection.name)
-          source_assoc = association.class.new(association.source_reflection)
-          build_associated(source_assoc, parent_record)
+          build_associated(association.source_reflection, parent_record)
         elsif association.collection?
           parent_record.send(association.name).build
         elsif association.belongs_to? || parent_record.new_record? || parent_record.send(association.name).nil?

data/lib/active_scaffold/helpers/search_column_helpers.rb

@@ -213,8 +213,8 @@ module ActiveScaffold
           if column.search_sql.present?
             select_options.concat(ActiveScaffold::Finder::STRING_COMPARATORS.collect { |title, comp| [as_(title), comp] })
           end
-          if ActiveScaffold::Finder::LOGICAL_COMPARATORS.present? && column.logical_search.present?
-            select_options.concat(ActiveScaffold::Finder::LOGICAL_COMPARATORS.collect { |comp| [as_(comp.downcase.to_sym), comp] })
+          if ActiveScaffold::Finder.logical_comparators.present? && column.logical_search.present?
+            select_options.concat(ActiveScaffold::Finder.logical_comparators.collect { |comp| [as_(comp.downcase.to_sym), comp] })
           end
         end
         if column.search_sql.present?

data/lib/active_scaffold/version.rb

@@ -4,7 +4,7 @@ module ActiveScaffold
   module Version
     MAJOR = 4
     MINOR = 2
-    PATCH = 1
+    PATCH = 3
     FIX = nil
 
     STRING = [MAJOR, MINOR, PATCH, FIX].compact.join('.')

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: active_scaffold
 version: !ruby/object:Gem::Version
-  version: 4.2.1
+  version: 4.2.3
 platform: ruby
 authors:
 - Many, see README
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2026-02-09 00:00:00.000000000 Z
+date: 2026-02-26 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: dartsass-sprockets
@@ -38,6 +38,20 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '0.11'
+- !ruby/object:Gem::Dependency
+  name: method_source
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.1'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.1'
 - !ruby/object:Gem::Dependency
   name: rails
   requirement: !ruby/object:Gem::Requirement
@@ -242,6 +256,7 @@ files:
 - lib/active_scaffold/bridges/file_column/test/functional/file_column_keep_test.rb
 - lib/active_scaffold/bridges/file_column/test/mock_model.rb
 - lib/active_scaffold/bridges/logical_query_parser.rb
+- lib/active_scaffold/bridges/logical_query_parser/keyword_query_parser.rb
 - lib/active_scaffold/bridges/logical_query_parser/tokens_grammar.rb
 - lib/active_scaffold/bridges/logical_query_parser/tokens_grammar.treetop
 - lib/active_scaffold/bridges/paper_trail.rb