active_scaffold 3.6.9 → 3.6.11.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: e1e1f178ccfe11c704e5064d0ee50bfa6a27d6aee4f478f478e6e0529a7e0683
-  data.tar.gz: de3fb5ad387969bc8c796ca9db23de2f311e8b16f6002316456b475953d66ae1
+  metadata.gz: 10795ad02dbbf1ea2033af6b1b36857f0105acf45daa21f44bf576737b838331
+  data.tar.gz: e5fb0e9f651127a06d8057a5eeab6934ba62211c9bb9d3f0b8ac6df5e7e5bb58
 SHA512:
-  metadata.gz: 175f49bcb07a4fd3fd313f5437b3d2b438a20d9a697e2cc481fcc7086a4a0add3e08fa342ed90f984fed13eff68bad632b8bd772bbbf6869319d1024ace9082d
-  data.tar.gz: 8db9c02a65266fc858910ecf180800c4adabe0913eb02cb3464db665f51ad3ab3230a5bc1e6d38a581d93a874d390e6e8fa7ae7f72ec5c09d54cbecfcb070a71
+  metadata.gz: e738f18a2fe367d7796057fe2f098c6bc5f7291615e4315a78a33f0283df30b7c6c12b26af51b03489112ecd2c2310ac30a5bfac7d29e1c6be26a9700982dc41
+  data.tar.gz: 4ccb202176df05c3f9d4882ccd4abf6f025204ffa993b9daa6c3b3b4bcabc06eb22e4f98630253a85c1ef9ce68160b11d6beeb6c6a64ae8f7a885b26e12278ed

data/CHANGELOG.rdoc

@@ -1,3 +1,18 @@
+= 3.6.11.1
+- Fix required attribute broken on previous version when no validation was found
+
+= 3.6.11
+- Fix inplace edit cloning with jquery >= 1.9, when more than one child is cloned
+- Support inplace edit cloning for :radio form_ui
+- Add records parameter to cache_columns_count and related methods (count_query_for_column, mongoid_count_for_column)
+- Fix required attribute when validator uses :on option, so on: :update only set required on update form, and :create only set required on create form
+
+= 3.6.10
+- Don't add numerical constraints based on conditional validation
+- Fix typo in cache key for numerical constraints
+- Fix duplicated params in search form, e.g. embedded constraints
+
+= 3.6.9
 - Support depend on .rb or .json locale files for date picker bridge
 - Fix search with dates entered with timezone in datepicker
 

data/app/assets/javascripts/jquery/jquery.editinplace.js

@@ -317,7 +317,6 @@ $.extend(InlineEditor.prototype, {
 		if (editorNode.data('id')) editorNode.attr('id', editorNode.data('id') + this.settings.clone_id_suffix);
 		editorNode.attr('name', 'inplace_value');
 		editorNode.addClass('editor_field');
-		this.setValue(editorNode, this.originalValue);
 		clonedNodes = editorNode;
 
 		if (patternNodes.additionalNodes) {
@@ -326,9 +325,10 @@ $.extend(InlineEditor.prototype, {
 				if (patternNode.data('id')) {
 					patternNode.attr('id', patternNode.data('id') + this.settings.clone_id_suffix);
 				}
-				clonedNodes = clonedNodes.after(patternNode);
+				clonedNodes.push(patternNode[0]);
 			});
 		}
+		this.setValue(clonedNodes, this.originalValue);
 		return clonedNodes;
 	},
 
@@ -349,23 +349,37 @@ $.extend(InlineEditor.prototype, {
 		return nodes;
 	},
 	
-	setValue: function(editField, textValue) {
-		var function_name = 'setValueFor' + editField.get(0).nodeName.toLowerCase();
+	setValue: function(editFields, textValue) {
+		var editField = editFields.find(':input').addBack(':input'),
+			type = editField.get(0).nodeName.toLowerCase();
+		if (type === 'input') type = editField.attr('type').toLowerCase();
+		var function_name = 'setValueFor' + type;
 		if (typeof(this[function_name]) == 'function') {
-			this[function_name](editField, textValue);
+			this[function_name](editFields, textValue);
 		} else {
 			editField.val(textValue);
 		}
 	},
 
-	setValueForselect: function(editField, textValue) {
-		var option_value = editField.children("option:contains('" + textValue + "')").val();
+	setValueForselect: function(editFields, textValue) {
+		var editField = editFields.find('select').addBack('select').first(),
+			option_value = editField.children("option:contains('" + textValue + "')").val();
 
 		if (typeof(option_value) !== 'undefined') {
 			editField.val(option_value);
 		}
 	},
 
+	setValueForradio: function(editFields, textValue) {
+		var editField = editFields.find('input[type=radio]').addBack('input[type=radio]').filter(function() {
+			var contains = ':contains("' + textValue + '")';
+			return editFields.find('label[for="' + $(this).attr('id') + '"]' + contains).length ||
+				$(this).closest('label' + contains).length;
+		}).first();
+
+		if (editField.length) editField.prop('checked', true);
+	},
+
 	inputNameAndClass: function() {
 		return ' name="inplace_value" class="inplace_field" ';
 	},

data/app/views/active_scaffold_overrides/_form.html.erb

@@ -24,7 +24,7 @@
     <%= render_column(column, @record, renders_as, scope) %>
   <% end %>
   <% else -%>
-  <li class="form-element <%= 'required' if column.required? %> <%= column.form_ui %> <%= column_css_class %>">
+  <li class="form-element <%= 'required' if column.required?(action_for_validation?(@record)) %> <%= column.form_ui %> <%= column_css_class %>">
     <%= render_column(column, @record, renders_as, scope, !authorized) %>
   </li>
   <% end -%>

data/app/views/active_scaffold_overrides/_form_association.html.erb

@@ -4,7 +4,7 @@ if column.show_blank_record?(associated)
   show_blank_record = build_associated(column.association, parent_record)
 end
 disable_required_for_new = @disable_required_for_new
-@disable_required_for_new = !!show_blank_record unless (column.association.singular? && column.required?)
+@disable_required_for_new = !!show_blank_record unless (column.association.singular? && column.required?(action_for_validation?(parent_record)))
 subform_div_id = "#{sub_form_id(:association => column.name, :id => parent_record.id || generated_id(parent_record) || 99999999999)}-div"
 
 # render footer before rendering associated records, fixes create new on self-associations

data/app/views/active_scaffold_overrides/_form_association_record.html.erb

@@ -58,7 +58,7 @@
     end
 
     col_class = default_col_class.clone
-    col_class << 'required' if column.required?
+    col_class << 'required' if column.required?(action_for_validation?(record))
     col_class << column.css_class unless column.css_class.nil? || column.css_class.is_a?(Proc)
     col_class << 'hidden' if column_renders_as(column) == :hidden
   -%>
@@ -88,7 +88,7 @@
       <% columns_group.each_column(for: record.class, crud_type: :read, flatten: true) do |col| %>
         <%
           col_class = default_col_class.clone
-          col_class << 'required' if col.required?
+          col_class << 'required' if col.required?(action_for_validation?(record))
           col_class << col.css_class unless col.css_class.nil? || col.css_class.is_a?(Proc)
           col_class << 'hidden' if column_renders_as(col) == :hidden
         %>

data/app/views/active_scaffold_overrides/_search.html.erb

@@ -14,7 +14,7 @@
   hidden_params = url_options.except(:controller, :action, :id, :search).to_query.split(Rack::Utils::DEFAULT_SEP)
 -%>
 
-<%= form_tag url_options, options do %>
+<%= form_tag url_options.slice(:controller, :action, :id, :search), options do %>
   <% hidden_params.each do |pair| -%>
     <% key, value = pair.split('=', 2).map { |str| Rack::Utils.unescape(str) } -%>
     <%= hidden_field_tag(key, value) %>

data/lib/active_scaffold/actions/list.rb

@@ -125,7 +125,7 @@ module ActiveScaffold::Actions
       @remove_id_from_list_links = params[:id].blank?
       @page = current_page
       @records = @page.items
-      cache_column_counts
+      cache_column_counts @records
     end
 
     def columns_to_cache_counts
@@ -136,12 +136,12 @@ module ActiveScaffold::Actions
       end
     end
 
-    def cache_column_counts
+    def cache_column_counts(records)
       @counts = columns_to_cache_counts.each_with_object({}) do |column, counts|
         if ActiveScaffold::OrmChecks.active_record?(column.association.klass)
-          counts[column.name] = count_query_for_column(column).count
+          counts[column.name] = count_query_for_column(column, records).count
         elsif ActiveScaffold::OrmChecks.mongoid?(column.association.klass)
-          counts[column.name] = mongoid_count_for_column(column)
+          counts[column.name] = mongoid_count_for_column(column, records)
         end
       end
     end
@@ -151,17 +151,17 @@ module ActiveScaffold::Actions
         (!column.association.as || column.association.reverse_association)
     end
 
-    def count_query_for_column(column)
+    def count_query_for_column(column, records)
       if count_on_association_class?(column)
-        count_query_on_association_class(column)
+        count_query_on_association_class(column, records)
       else
-        count_query_with_join(column)
+        count_query_with_join(column, records)
       end
     end
 
-    def count_query_on_association_class(column)
+    def count_query_on_association_class(column, records)
       key = column.association.primary_key || :id
-      query = column.association.klass.where(column.association.foreign_key => @records.map(&key.to_sym))
+      query = column.association.klass.where(column.association.foreign_key => records.map(&key.to_sym))
       if column.association.as
         query.where!(column.association.reverse_association.foreign_type => active_scaffold_config.model.name)
       end
@@ -171,17 +171,17 @@ module ActiveScaffold::Actions
       query.group(column.association.foreign_key)
     end
 
-    def count_query_with_join(column)
+    def count_query_with_join(column, records)
       klass = column.association.klass
-      query = active_scaffold_config.model.where(active_scaffold_config.primary_key => @records.map(&:id))
+      query = active_scaffold_config.model.where(active_scaffold_config.primary_key => records.map(&:id))
                                     .joins(column.name).group(active_scaffold_config.primary_key)
                                     .select("#{klass.quoted_table_name}.#{klass.quoted_primary_key}")
       query = query.uniq if column.association.scope && klass.instance_exec(&column.association.scope).values[:distinct]
       query
     end
 
-    def mongoid_count_for_column(column)
-      matches = {column.association.foreign_key => {'$in': @records.map(&:id)}}
+    def mongoid_count_for_column(column, records)
+      matches = {column.association.foreign_key => {'$in': records.map(&:id)}}
       if column.association.as
         matches[column.association.reverse_association.foreign_type] = {'$eq': active_scaffold_config.model.name}
       end

data/lib/active_scaffold/actions/update.rb

@@ -69,7 +69,7 @@ module ActiveScaffold::Actions
       @updated_record = @record
       # get_row so associations are cached like in list action
       # if record doesn't fullfil current conditions remove it from list
-      @record = get_row
+      get_row
     rescue ActiveRecord::RecordNotFound
       nil
     end

data/lib/active_scaffold/data_structures/column.rb

@@ -66,8 +66,12 @@ module ActiveScaffold::DataStructures
     # whether the field is required or not. used on the form for visually indicating the fact to the user.
     # TODO: move into predicate
     attr_writer :required
-    def required?
-      @required
+    def required?(action = nil)
+      if action && @required
+        @required == true || @required.include?(action)
+      else
+        @required
+      end
     end
 
     attr_reader :update_columns
@@ -353,9 +357,11 @@ module ActiveScaffold::DataStructures
 
       # default all the configurable variables
       self.css_class = ''
-      self.required = active_record_class.validators_on(name).any? do |val|
-        validator_force_required?(val)
-      end
+      validators_force_require_on = active_record_class.validators_on(name)
+                                                       .map { |val| validator_force_required?(val) }
+                                                       .select(&:present?)
+      self.required = validators_force_require_on.any? { |opt| opt == true } ||
+                      validators_force_require_on.reject { |opt| opt == true }.flatten.presence
       self.sort = true
       self.search_sql = true
 
@@ -436,13 +442,18 @@ module ActiveScaffold::DataStructures
       return false if val.options[:if] || val.options[:unless]
       case val
       when ActiveModel::Validations::PresenceValidator
-        true
+        validator_required_on(val)
       when ActiveModel::Validations::InclusionValidator
-        !val.options[:allow_nil] && !val.options[:allow_blank] &&
-          !inclusion_validator_for_checkbox?(val)
+        if !val.options[:allow_nil] && !val.options[:allow_blank] && !inclusion_validator_for_checkbox?(val)
+          validator_required_on(val)
+        end
       end
     end
 
+    def validator_required_on(val)
+      val.options[:on] ? Array(val.options[:on]) : true
+    end
+
     def inclusion_validator_for_checkbox?(val)
       @form_ui == :checkbox &&
         [[true, false], [false, true]].include?(val.options[:with] || val.options[:within] || val.options[:in])

data/lib/active_scaffold/helpers/form_column_helpers.rb

@@ -55,7 +55,7 @@ module ActiveScaffold
       def active_scaffold_render_subform_column(column, scope, crud_type, readonly, add_class = false, record = nil) # rubocop:disable Metrics/ParameterLists
         if add_class
           col_class = []
-          col_class << 'required' if column.required?
+          col_class << 'required' if column.required?(action_for_validation?(record))
           col_class << column.css_class unless column.css_class.nil? || column.css_class.is_a?(Proc)
           col_class << 'hidden' if column_renders_as(column) == :hidden
           col_class << 'checkbox' if column.form_ui == :checkbox
@@ -85,13 +85,17 @@ module ActiveScaffold
         options
       end
 
+      def action_for_validation?(record)
+        record&.persisted? ? :update : :create
+      end
+
       # the standard active scaffold options used for class, name and scope
       def active_scaffold_input_options(column, scope = nil, options = {})
         name = scope ? "record#{scope}[#{column.name}]" : "record[#{column.name}]"
         record = options[:object]
 
         # Add some HTML5 attributes for in-browser validation and better user experience
-        if column.required? && (!@disable_required_for_new || scope.nil? || record&.persisted?)
+        if column.required?(action_for_validation?(record)) && (!@disable_required_for_new || scope.nil? || record&.persisted?)
           options[:required] = true
         end
         options[:placeholder] = column.placeholder if column.placeholder.present?
@@ -720,7 +724,9 @@ module ActiveScaffold
       # Try to get numerical constraints from model's validators
       def column_numerical_constraints(column, options)
         validators = column.active_record_class.validators.select do |v|
-          v.is_a?(ActiveModel::Validations::NumericalityValidator) && v.attributes.include?(column.name)
+          v.is_a?(ActiveModel::Validations::NumericalityValidator) &&
+            v.attributes.include?(column.name) &&
+            !v.options[:if] && !v.options[:unless]
         end
 
         equal_validator = validators.find { |v| v.options[:equal_to] }
@@ -770,7 +776,7 @@ module ActiveScaffold
       end
 
       def numerical_constraints_for_column(column, options)
-        constraints = Rails.cache.fetch("#{column.cache_key}#numerical_constarints") do
+        constraints = Rails.cache.fetch("#{column.cache_key}#numerical_constraints") do
           column_numerical_constraints(column, options)
         end
         constraints.merge(options)

data/lib/active_scaffold/version.rb

@@ -2,7 +2,7 @@ module ActiveScaffold
   module Version
     MAJOR = 3
     MINOR = 6
-    PATCH = 9
+    PATCH = '11.1'.freeze
 
     STRING = [MAJOR, MINOR, PATCH].compact.join('.')
   end

data/test/data_structures/validation_reflection_test.rb

@@ -9,6 +9,16 @@ class ValidationReflectionTest < MiniTest::Test
     assert column.required?
   end
 
+  def test_set_required_for_validates_presence_of_with_on
+    column = ActiveScaffold::DataStructures::Column.new(:name, Company)
+    refute column.required?
+    Company.expects(:validators_on).with(:name).returns([ActiveModel::Validations::PresenceValidator.new(:attributes => :name, :on => [:create])])
+    column = ActiveScaffold::DataStructures::Column.new(:name, Company)
+    assert column.required?
+    assert column.required?(:create)
+    refute column.required?(:update)
+  end
+
   def test_set_required_for_validates_inclusion_of
     column = ActiveScaffold::DataStructures::Column.new(:name, Company)
     refute column.required?

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: active_scaffold
 version: !ruby/object:Gem::Version
-  version: 3.6.9
+  version: 3.6.11.1
 platform: ruby
 authors:
 - Many, see README
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2022-05-03 00:00:00.000000000 Z
+date: 2022-07-04 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -477,7 +477,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.3.7
+rubygems_version: 3.0.9
 signing_key:
 specification_version: 4
 summary: Rails 4.x and 5.x versions of ActiveScaffold supporting prototype and jquery