active_scaffold 3.5.3 → 3.6.0.rc2

data/lib/active_scaffold/version.rb

@@ -1,8 +1,8 @@
 module ActiveScaffold
   module Version
     MAJOR = 3
-    MINOR = 5
-    PATCH = 3
+    MINOR = 6
+    PATCH = '0.rc2'.freeze
 
     STRING = [MAJOR, MINOR, PATCH].compact.join('.')
   end

data/lib/generators/active_scaffold/controller_generator.rb

@@ -2,10 +2,10 @@
 
 module ActiveScaffold
   module Generators
-    class ControllerGenerator < Rails::Generators::NamedBase # metagenerator
+    class ControllerGenerator < Rails::Generators::NamedBase
       include Rails::Generators::ResourceHelpers
 
-      source_root File.expand_path('../../templates', __FILE__)
+      source_root File.expand_path('../templates', __dir__)
 
       check_class_collision :suffix => 'Controller'
 

data/lib/generators/active_scaffold/install_generator.rb

@@ -3,7 +3,7 @@ require 'rails/generators/base'
 
 module ActiveScaffold
   module Generators
-    class InstallGenerator < Rails::Generators::Base # metagenerator
+    class InstallGenerator < Rails::Generators::Base
       desc 'Add concerns to routes and require lines to assets manifest files'
 
       def add_concern_routes

data/lib/generators/active_scaffold/resource_generator.rb

@@ -3,7 +3,7 @@ require 'rails/generators/rails/resource/resource_generator'
 
 module ActiveScaffold
   module Generators
-    class ResourceGenerator < Rails::Generators::ResourceGenerator # metagenerator
+    class ResourceGenerator < Rails::Generators::ResourceGenerator
       remove_hook_for :resource_controller
       remove_hook_for :resource_route
       remove_class_option :actions
@@ -46,7 +46,7 @@ module ActiveScaffold
         routing_code << ' end' * class_path.size
         log :route, routing_code
         in_root do
-          inject_into_file 'config/routes.rb', "  #{routing_code}\n", {after: /^[ ]*concern :active_scaffold,.*\n/, verbose: false, force: true}
+          inject_into_file 'config/routes.rb', "  #{routing_code}\n", after: /^[ ]*concern :active_scaffold,.*\n/, verbose: false, force: true
         end
       end
 

data/shoulda_macros/macros.rb

@@ -127,7 +127,9 @@ class ActiveSupport::TestCase
       script = script.gsub('\n', '\\\\\\n')
                      .gsub(/['"]/, '\\\\\\\\\&')
                      .gsub('</script>', '</scr"+"ipt>')
-      assert_select 'script[type=text/javascript]', Regexp.new('.*' + Regexp.quote("with(window.parent) { setTimeout(function() { window.eval('") + script + Regexp.quote("'); if (typeof(loc) !== 'undefined') loc.replace('about:blank'); }, 1) };") + '.*')
+      pre_regex = Regexp.quote("with(window.parent) { setTimeout(function() { window.eval('")
+      post_regex = Regexp.quote("'); if (typeof(loc) !== 'undefined') loc.replace('about:blank'); }, 1) };")
+      assert_select 'script[type=text/javascript]', Regexp.new('.*' + pre_regex + script + post_regex + '.*')
     end
   end
 

data/test/bridges/date_picker_test.rb

@@ -1,7 +1,6 @@
 require 'test_helper'
 require 'active_scaffold_config_mock'
-require File.join(File.dirname(__FILE__), '../../lib/active_scaffold/bridges/date_picker/ext')
-# require File.join(File.dirname(__FILE__), '../../lib/active_scaffold/bridges/date_picker/helper')
+require File.expand_path('../../lib/active_scaffold/bridges/date_picker/ext', __dir__)
 
 class DatePickerTest < ActionView::TestCase
   include ActiveScaffold::Helpers::ViewHelpers

data/test/bridges/paperclip_test.rb

@@ -1,8 +1,8 @@
 require 'test_helper'
-require File.expand_path('../../../lib/active_scaffold/bridges/paperclip/paperclip_bridge', __FILE__)
-require File.expand_path('../../../lib/active_scaffold/bridges/paperclip/paperclip_bridge_helpers', __FILE__)
-require File.expand_path('../../../lib/active_scaffold/bridges/paperclip/form_ui', __FILE__)
-require File.expand_path('../../../lib/active_scaffold/bridges/paperclip/list_ui', __FILE__)
+require File.expand_path('../../lib/active_scaffold/bridges/paperclip/paperclip_bridge', __dir__)
+require File.expand_path('../../lib/active_scaffold/bridges/paperclip/paperclip_bridge_helpers', __dir__)
+require File.expand_path('../../lib/active_scaffold/bridges/paperclip/form_ui', __dir__)
+require File.expand_path('../../lib/active_scaffold/bridges/paperclip/list_ui', __dir__)
 
 class PaperclipCore < ActiveScaffold::Config::Core
   include ActiveScaffold::Bridges::Paperclip::PaperclipBridge
@@ -16,7 +16,7 @@ class PaperclipTest < ActionView::TestCase
     config = PaperclipCore.new(:company)
     refute config.create.multipart?
     refute config.update.multipart?
-    refute config.columns.any? { |column| column.form_ui == :paperclip }
+    refute(config.columns.any? { |column| column.form_ui == :paperclip })
   end
 
   def test_initialization
@@ -51,7 +51,7 @@ class PaperclipTest < ActionView::TestCase
     assert_dom_equal '<a href="/system/file" target="_blank">file</a>', active_scaffold_column_paperclip(company, config.columns[:logo])
 
     company.stubs(:logo).returns(stub(:file? => true, :original_filename => 'file', :url => '/system/file', :styles => {:thumbnail => '40x40'}))
-    assert_dom_equal '<a href="/system/file" target="_blank"><img src="/system/file" border="0" alt="File"/></a>', active_scaffold_column_paperclip(company, config.columns[:logo])
+    assert_dom_equal '<a href="/system/file" target="_blank"><img src="/system/file" border="0"/></a>', active_scaffold_column_paperclip(company, config.columns[:logo])
   end
 
   def test_form_ui

data/test/class_with_finder.rb

@@ -18,8 +18,8 @@ class ClassWithFinder
     {}
   end
 
-  def params_hash(v)
-    v
+  def params_hash(value)
+    value
   end
 
   def joins_for_collection; end

data/test/company.rb

@@ -37,8 +37,8 @@ class Company < ActiveRecord::Base
   end
 
   # not the real signature of the method, but forgive me
-  def self.before_destroy(s = nil)
-    @@before = s
+  def self.before_destroy(string = nil)
+    @@before = string
   end
 
   if respond_to?(:create_reflection)
@@ -53,11 +53,11 @@ class Company < ActiveRecord::Base
     end
   end
 
-  def self.has_many(association_id, options = {})
+  def self.has_many(association_id, options = {}) # rubocop:disable Naming/PredicateName
     create_reflection(:has_many, association_id, nil, options, self)
   end
 
-  def self.has_one(association_id, options = {})
+  def self.has_one(association_id, options = {}) # rubocop:disable Naming/PredicateName
     create_reflection(:has_one, association_id, nil, options, self)
   end
 

data/test/config/create_test.rb

@@ -2,6 +2,8 @@ require 'test_helper'
 
 module Config
   class CreateTest < MiniTest::Test
+    include ActiveScaffold::Helpers::ControllerHelpers
+
     def setup
       @config = ActiveScaffold::Config::Core.new :model_stub
       @default_link = @config.create.link
@@ -12,7 +14,7 @@ module Config
     end
 
     def test_default_columns
-      assert_equal %i[a d other_model other_models], @config.create.columns.names
+      assert_equal %i[a d other_model other_models], @config.create.columns.visible_columns_names
     end
 
     def test_default_options
@@ -52,7 +54,7 @@ module Config
       label = 'create new monkeys'
       @config.create.label = label
       assert_equal label, @config.create.label
-      I18n.backend.store_translations :en, :active_scaffold => {:create_new_model => 'Create new %{model}'}
+      I18n.backend.store_translations :en, :active_scaffold => {:create_new_model => 'Create new %<model>s'}
       @config.create.label = :create_new_model
       assert_equal 'Create new Model stub', @config.create.label
     end

data/test/config/nested_test.rb

@@ -20,7 +20,7 @@ module Config
       label = 'nested monkeys'
       @config.nested.label = label
       assert_equal label, @config.nested.label
-      I18n.backend.store_translations :en, :active_scaffold => {:test_create_model => 'Add new %{model}'}
+      I18n.backend.store_translations :en, :active_scaffold => {:test_create_model => 'Add new %<model>s'}
       @config.nested.label = :test_create_model
       assert_equal 'Add new Model stub', @config.nested.label
     end

data/test/config/show_test.rb

@@ -36,7 +36,7 @@ module Config
       label = 'show monkeys'
       @config.show.label = label
       assert_equal label, @config.show.label
-      I18n.backend.store_translations :en, :active_scaffold => {:view_model => 'View %{model}'}
+      I18n.backend.store_translations :en, :active_scaffold => {:view_model => 'View %<model>s'}
       @config.show.label = :view_model
       assert_equal 'View Model stub', @config.show.label
       assert_equal 'View record', @config.show.label('record')

data/test/config/update_test.rb

@@ -2,20 +2,20 @@ require 'test_helper'
 
 module Config
   class UpdateTest < MiniTest::Test
+    include ActiveScaffold::Helpers::ControllerHelpers
+
     def setup
       @config = ActiveScaffold::Config::Core.new :model_stub
     end
 
     def test_copy_columns_from_create
       @config.create.columns = %i[a c d]
-      assert_equal %i[a d], @config.create.columns.names
+      assert_equal %i[a d], @config.create.columns.visible_columns_names
       @config.update.columns = @config.create.columns
-      @config._load_action_columns
-      assert_equal %i[a c d], @config.update.columns.names
+      assert_equal %i[a c d], @config.update.columns.visible_columns_names
     end
 
     def test__params_for_columns__returns_all_params
-      @config._load_action_columns
       @config.columns[:a].params.add :keep_a, :a_temp
       assert @config.columns[:a].params.include?(:keep_a)
       assert @config.columns[:a].params.include?(:a_temp)
@@ -33,7 +33,8 @@ module Config
     end
 
     def test_nested_links
-      old, @config.update.nested_links = @config.update.nested_links, true
+      old = @config.update.nested_links
+      @config.update.nested_links = true
       assert @config.update.nested_links
       @config.update.nested_links = old
     end
@@ -42,7 +43,7 @@ module Config
       label = 'update new monkeys'
       @config.update.label = label
       assert_equal label, @config.update.label
-      I18n.backend.store_translations :en, :active_scaffold => {:change_model => 'Change %{model}'}
+      I18n.backend.store_translations :en, :active_scaffold => {:change_model => 'Change %<model>s'}
       @config.update.label = :change_model
       assert_equal 'Change Model stub', @config.update.label
       assert_equal 'Change record', @config.update.label('record')

data/test/data_structures/action_columns_test.rb

@@ -71,12 +71,12 @@ class ActionColumnsTest < MiniTest::Test
     # first, use @columns.add directly
     @c2 = ActiveScaffold::DataStructures::ActionColumns.new
     @columns.add @c2
-    assert @columns.any? { |c| c == @c2 }
+    assert(@columns.any? { |c| c == @c2 })
 
     # then use the shortcut
     @columns.add_subgroup 'foo' do
     end
-    assert @columns.any? { |c| c.respond_to?(:label) && c.label == 'foo' }
+    assert(@columns.any? { |c| c.respond_to?(:label) && c.label == 'foo' })
   end
 
   def test_block_config

data/test/data_structures/action_links_test.rb

@@ -70,7 +70,7 @@ class ActionLinksTest < MiniTest::Test
     begin
       @links.delete :foo
       @links.delete 'foo'
-    rescue
+    rescue StandardError
       assert false, "deleting from action links when item doesn't exist should not throw an error"
     end
     refute @links['bar'].nil?

data/test/data_structures/column_test.rb

@@ -16,9 +16,6 @@ class ColumnTest < MiniTest::Test
   def test_basic_properties
     # test that it was set during initialization
     assert_equal @column.name, :a
-    # test that we can change it
-    @column.name = :b
-    assert_equal @column.name, :b
 
     # label
     @column.label = 'foo'
@@ -74,7 +71,7 @@ class ColumnTest < MiniTest::Test
     # comparison with different object of same type
     column2 = ActiveScaffold::DataStructures::Column.new(:fake, ModelStub)
     refute_equal @column, column2
-    column2.name = 'a'
+    column2 = ActiveScaffold::DataStructures::Column.new(:a, ModelStub)
     assert_equal @column, column2
 
     # special comparisons
@@ -152,12 +149,12 @@ class ColumnTest < MiniTest::Test
   def test_config_block
     @column.configure do |config|
       # we can use the config object
-      config.name = 'foo'
+      config.form_ui = :select
       # or not
       self.label = 'hello'
     end
 
-    assert_equal 'foo', @column.name
+    assert_equal :select, @column.form_ui
     assert_equal 'hello', @column.label
   end
 

data/test/data_structures/columns_test.rb

@@ -41,8 +41,8 @@ class ColumnsTest < MiniTest::Test
 
     # test the collection finders
     found = @columns.find_by_names(:a, :b)
-    assert found.any? { |c| c.name == :a }
-    assert found.any? { |c| c.name == :b }
+    assert(found.any? { |c| c.name == :a })
+    assert(found.any? { |c| c.name == :b })
   end
 
   def test_each

data/test/data_structures/sorting_test.rb

@@ -64,6 +64,13 @@ class SortingTest < MiniTest::Test
     assert @sorting.sorts_on?(:b)
     assert_equal 'ASC', @sorting.direction_of(:b)
 
+    @sorting.set({a: 'DESC'}, {b: 'ASC'})
+    assert @sorting.instance_variable_get('@clauses').size == 2
+    assert @sorting.sorts_on?(:a)
+    assert_equal 'DESC', @sorting.direction_of(:a)
+    assert @sorting.sorts_on?(:b)
+    assert_equal 'ASC', @sorting.direction_of(:b)
+
     @sorting.set [:a, 'DESC'], [:b, 'ASC']
     assert @sorting.instance_variable_get('@clauses').size == 2
     assert @sorting.sorts_on?(:a)

data/test/extensions/active_record_test.rb

@@ -14,7 +14,7 @@ class ActiveRecordTest < MiniTest::Test
         'to_s'
       end
     end
-
+    RequestStore.clear!
     assert_equal 'to_s', @record.to_label
 
     class << @record
@@ -22,7 +22,7 @@ class ActiveRecordTest < MiniTest::Test
         'title'
       end
     end
-
+    RequestStore.clear!
     assert_equal 'title', @record.to_label
 
     class << @record
@@ -30,7 +30,7 @@ class ActiveRecordTest < MiniTest::Test
         'label'
       end
     end
-
+    RequestStore.clear!
     assert_equal 'label', @record.to_label
 
     class << @record
@@ -38,7 +38,7 @@ class ActiveRecordTest < MiniTest::Test
         'name'
       end
     end
-
+    RequestStore.clear!
     assert_equal 'name', @record.to_label
   end
 end

data/test/extensions/routing_mapper_test.rb

@@ -54,8 +54,8 @@ class RoutingMapperTest < ActionController::TestCase
     assert_routing 'cars/1/edit', controller: 'cars', action: 'edit', id: '1'
     assert_routing({method: :patch, path: 'cars/1'}, {controller: 'cars', action: 'update', id: '1'})
 
-    assert_raises(ActionController::RoutingError) { @routes.recognize_path '/cars' }
-    assert_raises(ActionController::RoutingError) { @routes.recognize_path '/cars/1/list' }
+    assert_raises(ActionController::RoutingError) { @routes.recognize_path '/cars', method: :post }
+    assert_raises(ActionController::RoutingError) { @routes.recognize_path '/cars/1' }
     assert_raises(ActionController::RoutingError) { @routes.recognize_path '/cars/1/destroy', method: :delete }
   end
 

data/test/helpers/list_column_helpers_test.rb

@@ -34,8 +34,10 @@ class ListColumnHelpersTest < ActionView::TestCase
     value.each { |v| v.stubs(:to_label).returns(v) }
     assert_equal '1, 2, 3, … (4)', format_association_value(value, @association_column, value.size)
     @config.list.stubs(:association_join_text => ',<br/>')
+    remove_instance_variable :@_association_join_text
     assert_equal '1,&lt;br/&gt;2,&lt;br/&gt;3,&lt;br/&gt;… (4)', format_association_value(value, @association_column, value.size)
-    @config.list.stubs(:association_join_text => ',<br/>'.html_safe)
+    @config.list.stubs(:association_join_text => ',<br/>'.html_safe) # rubocop:disable Rails/OutputSafety
+    remove_instance_variable :@_association_join_text
     assert_equal '1,<br/>2,<br/>3,<br/>… (4)', format_association_value(value, @association_column, value.size)
   end
 

data/test/misc/active_record_permissions_test.rb

@@ -91,7 +91,7 @@ class ActiveRecordPermissionsTest < MiniTest::Test
   #   symbols are: is (a)bsent, returns (f)alse, returns (t)rue, or n/a (_)
   def test_method_combinations_with_default_true
     old_permission = nil
-    ActiveScaffold.set_defaults do |config|
+    ActiveScaffold.defaults do |config|
       old_permission = config.security.default_permission
       config.security.default_permission = true
     end
@@ -134,17 +134,13 @@ class ActiveRecordPermissionsTest < MiniTest::Test
     miss(@model.authorized_for?(:crud_type => :read, :column => :b1), 'ttf')
     pass(@model.authorized_for?(:crud_type => :read, :column => :a1), 'ttt')
 
-    ActiveScaffold.set_defaults do |config|
+    ActiveScaffold.defaults do |config|
       config.security.default_permission = old_permission
     end
   end
 
   def test_method_combinations_with_default_false
-    old_permission = nil
-    ActiveScaffold.set_defaults do |config|
-      old_permission = config.security.default_permission
-      config.security.default_permission = false
-    end
+    ActiveScaffold::Config::Core.security.stubs(default_permission: false)
 
     miss(@model.authorized_for?(:column => :a3), '_a_')
     miss(@model.authorized_for?(:column => :a2), '_f_')
@@ -183,10 +179,6 @@ class ActiveRecordPermissionsTest < MiniTest::Test
     pass(@model.authorized_for?(:crud_type => :read, :column => :c1), 'tta')
     miss(@model.authorized_for?(:crud_type => :read, :column => :b1), 'ttf')
     pass(@model.authorized_for?(:crud_type => :read, :column => :a1), 'ttt')
-
-    ActiveScaffold.set_defaults do |config|
-      config.security.default_permission = old_permission
-    end
   end
 
   private

data/test/misc/attribute_params_test.rb

@@ -46,6 +46,7 @@ class AttributeParamsTest < MiniTest::Test
     assert_nil model.last_name
     assert_equal buildings.map(&:id), model.building_ids
     assert_equal buildings.map(&:id), model.buildings.map(&:id)
+    assert_equal model, model.buildings[0].owner
     assert model.save
     assert_equal 2, model.reload.buildings_count
 
@@ -134,6 +135,7 @@ class AttributeParamsTest < MiniTest::Test
     assert_equal 'Name', model.first_name
     assert model.floor.present?
     assert_equal floor.id, model.floor.id
+    assert_equal model, model.floor.tenant
     assert_nil floor.reload.tenant_id, 'tenant_id should not be saved yet'
     assert model.save
     assert_equal model.id, floor.reload.tenant_id, 'tenant_id should be saved'
@@ -224,6 +226,7 @@ class AttributeParamsTest < MiniTest::Test
     assert_equal 3, model.floors.size
     assert_equal floor.id, model.floors.first.id
     assert_equal [nil, *people.map(&:id)], model.floors.map(&:tenant_id)
+    assert_equal model, model.floors[0].building
     assert model.save
     assert_equal [1, 1], people.map(&:reload).map(&:floors_count)
     assert_equal 3, model.reload.floors_count
@@ -299,6 +302,7 @@ class AttributeParamsTest < MiniTest::Test
     assert_equal 'First', model.first_name
     assert model.car.present?
     assert model.car.new_record?
+    assert_equal model, model.car.person
     assert model.save
     assert model.car.persisted?
 
@@ -417,15 +421,15 @@ class AttributeParamsTest < MiniTest::Test
       record = record.class.find(record.id) if record.persisted?
       new_record = @controller.update_record_from_params(record, build_action_columns(record, action, columns), params)
       yield if block_given?
-      Thread.current[:constraint_columns] = nil
+      ActiveScaffold::Registry.constraint_columns.clear
     end
     new_record
   end
 
   def build_action_columns(record, action, *columns)
-    controller = ActiveScaffold::Core.active_scaffold_controller_for record.class
-    controller.active_scaffold_config.send(action).columns = columns
-    controller.active_scaffold_config.send(action).columns
+    config = @controller.active_scaffold_config_for record.class
+    config.send(action).columns = columns
+    config.send(action).columns
   end
 end
 
@@ -447,11 +451,11 @@ class Controller
     @flash ||= ActionDispatch::Flash::FlashHash.new
   end
 
-  def params_hash?(v)
-    v.is_a? Hash
+  def params_hash?(value)
+    value.is_a? Hash
   end
 
-  def params_hash(v)
-    v
+  def params_hash(value)
+    value
   end
 end