active_scaffold 3.4.43 → 3.5.0

data/test/misc/calculation_test.rb

@@ -1,27 +1,5 @@
 require 'test_helper'
-
-class ClassWithFinder
-  include ActiveScaffold::Finder
-  def conditions_for_collection; end
-
-  def conditions_from_params; end
-
-  def conditions_from_constraints; end
-
-  def joins_for_collection; end
-
-  def custom_finder_options
-    {}
-  end
-
-  def beginning_of_chain
-    active_scaffold_config.model
-  end
-
-  def conditional_get_support?; end
-
-  def params; {}; end
-end
+require 'class_with_finder'
 
 class CalculationTest < MiniTest::Test
   def setup
@@ -31,8 +9,7 @@ class CalculationTest < MiniTest::Test
     @buildings << Building.create
 
     @klass = ClassWithFinder.new
-    @klass.stubs(:active_scaffold_config).returns(mock { stubs(:model).returns(Building) })
-    @klass.stubs(:active_scaffold_session_storage).returns({})
+    @klass.active_scaffold_config.stubs(:model).returns(Building)
   end
 
   def teardown
@@ -42,20 +19,20 @@ class CalculationTest < MiniTest::Test
   def test_calculation_with_conditions
     @klass.expects(:conditions_for_collection).returns(['"buildings"."name" LIKE ? OR "people"."first_name" LIKE ?', '%foo%', '%foo%'])
     @klass.expects(:active_scaffold_references).returns([:owner])
-    @klass.active_scaffold_config.expects(:list).returns(mock { stubs(:count_includes).returns(nil) })
+    @klass.active_scaffold_config.expects(:list).returns(mock.tap { |m| m.stubs(:count_includes).returns(nil) })
 
-    column = mock { stubs(:field).returns('"buildings"."id"') }
-    @klass.active_scaffold_config.expects(:columns).returns(mock { stubs(:"[]").returns(column) })
+    column = mock.tap { |m| m.stubs(:field).returns('"buildings"."id"') }
+    @klass.active_scaffold_config.expects(:columns).returns(mock.tap { |m| m.stubs(:"[]").returns(column) })
     query = @klass.send :calculate_query
     assert_equal 2, query.count
   end
 
   def test_calculation_without_conditions
     @klass.stubs(:active_scaffold_references).returns([:owner])
-    @klass.active_scaffold_config.expects(:list).returns(mock { stubs(:count_includes).returns(nil) })
+    @klass.active_scaffold_config.expects(:list).returns(mock.tap { |m| m.stubs(:count_includes).returns(nil) })
 
-    column = mock { stubs(:field).returns('"buildings"."id"') }
-    @klass.active_scaffold_config.expects(:columns).returns(mock { stubs(:"[]").returns(column) })
+    column = mock.tap { |m| m.stubs(:field).returns('"buildings"."id"') }
+    @klass.active_scaffold_config.expects(:columns).returns(mock.tap { |m| m.stubs(:"[]").returns(column) })
     query = @klass.send :calculate_query
     assert_equal Building.count, query.count
   end

data/test/misc/configurable_test.rb

@@ -1,8 +1,9 @@
 require 'test_helper'
 
 class ConfigurableClass
-  FOO = 'bar'
+  FOO = 'bar'.freeze
   def foo; FOO end
+
   def self.foo; FOO end
 end
 
@@ -19,7 +20,7 @@ class ConfigurableTest < MiniTest::Test
   ## constants and methods for tests to check against
   ##
   def hello; 'world' end
-  HELLO = 'world'
+  HELLO = 'world'.freeze
 
   def test_instance_configuration
     configurable_class = IncludedClass.new

data/test/misc/constraints_test.rb

@@ -4,7 +4,15 @@ module ModelStubs
   class ModelStub < ActiveRecord::Base
     self.abstract_class = true
     def self.columns; @columns ||= [ColumnMock.new('foo', '')] end
+
     def self.columns_hash; @hash ||= Hash[@columns.map { |c| [c.name, c] }] end
+
+    if respond_to? :type_for_attribute
+      def self.type_for_attribute(column_name)
+        defined?(ActiveModel::Type) ? ActiveModel::Type::String.new : super
+      end
+    end
+
     def self.table_name
       @table_name || to_s.split('::').last.underscore.pluralize
     end
@@ -83,7 +91,8 @@ end
 
 class ConstraintsTestObject
   # stub out what the mixin expects to find ...
-  def self.before_filter(*); end
+  def self.before_action(*); end
+
   def self.helper_method(*); end
   attr_accessor :active_scaffold_preload
   attr_accessor :active_scaffold_references
@@ -106,6 +115,10 @@ class ConstraintsTestObject
     @active_scaffold_habtm_joins = []
     @params = {}
   end
+
+  def params_hash?(v)
+    v.is_a? Hash
+  end
 end
 
 class ConstraintsTest < MiniTest::Test
@@ -116,60 +129,58 @@ class ConstraintsTest < MiniTest::Test
   def test_constraint_conditions_for_default_associations
     @test_object.active_scaffold_config = config_for('user')
     # has_one (vs belongs_to)
-    assert_constraint_condition({:subscription => 5}, [{'subscriptions.id' => 5}], 'find the user with subscription #5')
+    assert_constraint_condition({:subscription => 5}, [{'subscriptions' => {'id' => 5}}], 'find the user with subscription #5')
     # habtm (vs habtm)
-    assert_constraint_condition({:roles => 4}, [{'roles.id' => 4}], 'find all users with role #4')
+    assert_constraint_condition({:roles => 4}, [{'roles' => {'id' => 4}}], 'find all users with role #4')
     # has_one (vs polymorphic)
-    assert_constraint_condition({:address => 11}, [{'addresses.id' => 11}], 'find the user with address #11')
+    assert_constraint_condition({:address => 11}, [{'addresses' => {'id' => 11}}], 'find the user with address #11')
     # reverse of a has_many :through
-    assert_constraint_condition({:subscription => {:service => 5}}, [{'services.id' => 5}], 'find all users subscribed to service #5')
+    assert_constraint_condition({:subscription => {:service => 5}}, [{'services' => {'id' => 5}}], 'find all users subscribed to service #5')
     assert(@test_object.active_scaffold_references.include?(:subscription => :service), 'multi-level association include')
 
     @test_object.active_scaffold_config = config_for('subscription')
     # belongs_to (vs has_one)
-    assert_constraint_condition({:user => 2}, [{'subscriptions.user_id' => 2}], 'find the subscription for user #2')
+    assert_constraint_condition({:user => 2}, [{'subscriptions' => {'user_id' => 2}}], 'find the subscription for user #2')
     # belongs_to (vs has_many)
-    assert_constraint_condition({:service => 1}, [{'subscriptions.service_id' => 1}], 'find all subscriptions for service #1')
+    assert_constraint_condition({:service => 1}, [{'subscriptions' => {'service_id' => 1}}], 'find all subscriptions for service #1')
 
     @test_object.active_scaffold_config = config_for('service')
     # has_many (vs belongs_to)
-    assert_constraint_condition({:subscriptions => 10}, [{'subscriptions.id' => 10}], 'find the service with subscription #10')
+    assert_constraint_condition({:subscriptions => 10}, [{'subscriptions' => {'id' => 10}}], 'find the service with subscription #10')
     # has_many :through (through has_many)
-    assert_constraint_condition({:users => 7}, [{'users.id' => 7}], 'find the service with user #7')
+    assert_constraint_condition({:users => 7}, [{'users' => {'id' => 7}}], 'find the service with user #7')
 
     @test_object.active_scaffold_config = config_for('address')
     # belongs_to :polymorphic => true
-    @test_object.params[:parent_model] = 'ModelStubs::User'
-    assert_constraint_condition({:addressable => 14}, [{'addresses.addressable_id' => 14, 'addresses.addressable_type' => 'ModelStubs::User'}], 'find all addresses for user #14')
+    assert_constraint_condition({:addressable => ['ModelStubs::User', 14]}, [{'addresses' => {'addressable_id' => 14, 'addressable_type' => 'ModelStubs::User'}}], 'find all addresses for user #14')
   end
 
   def test_constraint_conditions_for_configured_associations
     @test_object.active_scaffold_config = config_for('other_user')
     # has_one (vs belongs_to)
-    assert_constraint_condition({:other_subscription => 5}, [{'subscriptions.id' => 5}], 'find the user with subscription #5')
+    assert_constraint_condition({:other_subscription => 5}, [{'subscriptions' => {'id' => 5}}], 'find the user with subscription #5')
     # habtm (vs habtm)
-    assert_constraint_condition({:other_roles => 4}, [{'roles.id' => 4}], 'find all users with role #4')
+    assert_constraint_condition({:other_roles => 4}, [{'roles' => {'id' => 4}}], 'find all users with role #4')
     # has_one (vs polymorphic)
-    assert_constraint_condition({:other_address => 11}, [{'addresses.id' => 11}], 'find the user with address #11')
+    assert_constraint_condition({:other_address => 11}, [{'addresses' => {'id' => 11}}], 'find the user with address #11')
     # reverse of a has_many :through
-    assert_constraint_condition({:other_subscription => {:other_service => 5}}, [{'services.id' => 5}], 'find all users subscribed to service #5')
+    assert_constraint_condition({:other_subscription => {:other_service => 5}}, [{'services' => {'id' => 5}}], 'find all users subscribed to service #5')
 
     @test_object.active_scaffold_config = config_for('other_subscription')
     # belongs_to (vs has_one)
-    assert_constraint_condition({:other_user => 2}, [{'subscriptions.user_id' => 2}], 'find the subscription for user #2')
+    assert_constraint_condition({:other_user => 2}, [{'subscriptions' => {'user_id' => 2}}], 'find the subscription for user #2')
     # belongs_to (vs has_many)
-    assert_constraint_condition({:other_service => 1}, [{'subscriptions.service_id' => 1}], 'find all subscriptions for service #1')
+    assert_constraint_condition({:other_service => 1}, [{'subscriptions' => {'service_id' => 1}}], 'find all subscriptions for service #1')
 
     @test_object.active_scaffold_config = config_for('other_service')
     # has_many (vs belongs_to)
-    assert_constraint_condition({:other_subscriptions => 10}, [{'subscriptions.id' => 10}], 'find the service with subscription #10')
+    assert_constraint_condition({:other_subscriptions => 10}, [{'subscriptions' => {'id' => 10}}], 'find the service with subscription #10')
     # has_many :through (through has_many)
-    assert_constraint_condition({:other_users => 7}, [{'users.id' => 7}], 'find the service with user #7')
+    assert_constraint_condition({:other_users => 7}, [{'users' => {'id' => 7}}], 'find the service with user #7')
 
     @test_object.active_scaffold_config = config_for('other_address')
     # belongs_to :polymorphic => true
-    @test_object.params[:parent_model] = 'ModelStubs::OtherUser'
-    assert_constraint_condition({:other_addressable => 14}, [{'addresses.other_addressable_id' => 14, 'addresses.other_addressable_type' => 'ModelStubs::OtherUser'}], 'find all addresses for user #14')
+    assert_constraint_condition({:other_addressable => ['ModelStubs::OtherUser', 14]}, [{'addresses' => {'other_addressable_id' => 14, 'other_addressable_type' => 'ModelStubs::OtherUser'}}], 'find all addresses for user #14')
   end
 
   def test_constraint_conditions_for_normal_attributes
@@ -181,7 +192,7 @@ class ConstraintsTest < MiniTest::Test
     @test_object.active_scaffold_config = config_for('primary_key_location')
     # user = ModelStubs::PrimaryKeyUser.new(:id => 1, :name => 'User Name')
     ModelStubs::PrimaryKeyUser.expects(:find).with(1).returns(stub(:id => 1, :name => 'User Name'))
-    assert_constraint_condition({'user' => 1}, [{'primary_key_locations.username' => 'User Name'}], 'association with primary-key constraint')
+    assert_constraint_condition({'user' => 1}, [{'primary_key_locations' => {'username' => 'User Name'}}], 'association with primary-key constraint')
   end
 
   protected

data/test/misc/convert_numbers_format_test.rb

@@ -1,20 +1,34 @@
 require 'test_helper'
+require 'active_scaffold_config_mock'
 
 class NumberModel < ActiveRecord::Base
   include ActiveScaffold::ActiveRecordPermissions::ModelUserAccess::Model
   def self.columns
     @columns ||= [ColumnMock.new('id', '', 'int(11)'), ColumnMock.new('number', '', 'double(10,2)')]
   end
+
   def self.columns_hash
-    @hash ||= Hash[@columns.map { |c| [c.name, c] }]
+    @columns_hash ||= Hash[columns.map { |c| [c.name, c] }]
+  end
+
+  def self.load_schema!
+    columns_hash.each do |name, column|
+      define_attribute(
+        name,
+        connection.lookup_cast_type_from_column(column),
+        default: column.default
+      )
+    end
   end
 end
 
 class ConvertNumbersFormatTest < MiniTest::Test
+  include ActiveScaffoldConfigMock
   include ActiveScaffold::AttributeParams
   include ActiveScaffold::Finder
 
   def setup
+    NumberModel.load_schema! if Rails.version >= '5.0'
     I18n.backend.store_translations :en, :number => {:format => {
       :delimiter => ',',
       :separator => '.'
@@ -46,7 +60,7 @@ class ConvertNumbersFormatTest < MiniTest::Test
     assert_equal 0.1, convert_number('0.1')
     assert_equal 0.345, convert_number('0.345')
     assert_equal 0.345, convert_number('+0.345')
-    assert_equal -0.345, convert_number('-0.345')
+    assert_equal(-0.345, convert_number('-0.345'))
     assert_equal 9.345, convert_number('9.345')
     assert_equal 9.1, convert_number('9.1')
     assert_equal 90.1, convert_number('90.1')
@@ -56,7 +70,7 @@ class ConvertNumbersFormatTest < MiniTest::Test
     I18n.locale = :en
     assert_equal 1000, convert_number('1,000')
     assert_equal 1000, convert_number('+1,000')
-    assert_equal -1000, convert_number('-1,000')
+    assert_equal(-1000, convert_number('-1,000'))
     assert_equal 1_000_000, convert_number('1,000,000')
   end
 
@@ -65,7 +79,7 @@ class ConvertNumbersFormatTest < MiniTest::Test
     assert_equal 1234.1, convert_number('1,234.1')
     assert_equal 1234.1, convert_number('1,234.100')
     assert_equal 1234.345, convert_number('+1,234.345')
-    assert_equal -1234.345, convert_number('-1,234.345')
+    assert_equal(-1234.345, convert_number('-1,234.345'))
     assert_equal 1_234_000.1, convert_number('1,234,000.100')
   end
 
@@ -74,7 +88,7 @@ class ConvertNumbersFormatTest < MiniTest::Test
     assert_equal 0.1, convert_number('.1')
     assert_equal 0.1, convert_number('0.1')
     assert_equal 0.12, convert_number('+0.12')
-    assert_equal -0.12, convert_number('-0.12')
+    assert_equal(-0.12, convert_number('-0.12'))
     assert_equal 9.1, convert_number('9.1')
     assert_equal 90.1, convert_number('90.1')
   end
@@ -86,7 +100,7 @@ class ConvertNumbersFormatTest < MiniTest::Test
     assert_equal 0.1, convert_number('0,1')
     assert_equal 0.345, convert_number('0,345')
     assert_equal 0.345, convert_number('+0,345')
-    assert_equal -0.345, convert_number('-0,345')
+    assert_equal(-0.345, convert_number('-0,345'))
     assert_equal 9.1, convert_number('9,1')
     assert_equal 90.1, convert_number('90,1')
     assert_equal 9.1, convert_number('9,100')
@@ -96,7 +110,7 @@ class ConvertNumbersFormatTest < MiniTest::Test
     I18n.locale = :es
     assert_equal 1000, convert_number('1.000')
     assert_equal 1000, convert_number('+1.000')
-    assert_equal -1000, convert_number('-1.000')
+    assert_equal(-1000, convert_number('-1.000'))
     assert_equal 1_000_000, convert_number('1.000.000')
   end
 
@@ -105,7 +119,7 @@ class ConvertNumbersFormatTest < MiniTest::Test
     assert_equal 1230.1, convert_number('1.230,1')
     assert_equal 1230.1, convert_number('1.230,100')
     assert_equal 1234.345, convert_number('+1.234,345')
-    assert_equal -1234.345, convert_number('-1.234,345')
+    assert_equal(-1234.345, convert_number('-1.234,345'))
     assert_equal 1_234_000.1, convert_number('1.234.000,100')
   end
 
@@ -114,7 +128,7 @@ class ConvertNumbersFormatTest < MiniTest::Test
     assert_equal 0.1, convert_number('.1', :currency)
     assert_equal 0.1, convert_number('0.1', :currency)
     assert_equal 0.12, convert_number('+0.12', :currency)
-    assert_equal -0.12, convert_number('-0.12', :currency)
+    assert_equal(-0.12, convert_number('-0.12', :currency))
     assert_equal 9.1, convert_number('9.1', :currency)
     assert_equal 90.1, convert_number('90.1', :currency)
   end
@@ -126,7 +140,7 @@ class ConvertNumbersFormatTest < MiniTest::Test
     assert_equal 0.1, convert_number('0,1', :currency)
     assert_equal 0.345, convert_number('0,345', :currency)
     assert_equal 0.345, convert_number('+0,345', :currency)
-    assert_equal -0.345, convert_number('-0,345', :currency)
+    assert_equal(-0.345, convert_number('-0,345', :currency))
     assert_equal 9.1, convert_number('9,1', :currency)
     assert_equal 90.1, convert_number('90,1', :currency)
     assert_equal 9.1, convert_number('9,100', :currency)
@@ -146,4 +160,8 @@ class ConvertNumbersFormatTest < MiniTest::Test
     update_record_from_params(record, @config.create.columns, HashWithIndifferentAccess.new(:number => value))
     record.number
   end
+
+  def params_hash?(v)
+    v.is_a? Hash
+  end
 end

data/test/misc/finder_test.rb

@@ -1,33 +1,10 @@
 require 'test_helper'
-
-class ClassWithFinder
-  include ActiveScaffold::Finder
-  def conditions_for_collection; end
-
-  def conditions_from_params; end
-
-  def conditions_from_constraints; end
-
-  def joins_for_collection; end
-
-  def custom_finder_options
-    {}
-  end
-
-  def beginning_of_chain
-    active_scaffold_config.model
-  end
-
-  def conditional_get_support?; end
-
-  def params; {}; end
-end
+require 'class_with_finder'
 
 class FinderTest < MiniTest::Test
   def setup
     @klass = ClassWithFinder.new
-    @klass.stubs(:active_scaffold_config).returns(mock { stubs(:model).returns(ModelStub) })
-    @klass.stubs(:active_scaffold_session_storage).returns({})
+    @klass.active_scaffold_config.stubs(model: ModelStub)
   end
 
   def test_create_conditions_for_columns
@@ -35,21 +12,21 @@ class FinderTest < MiniTest::Test
       ActiveScaffold::DataStructures::Column.new(:a, ModelStub),
       ActiveScaffold::DataStructures::Column.new(:b, ModelStub)
     ]
-    tokens = %w(foo bar)
+    tokens = %w[foo bar]
 
     expected_conditions = [
       ['"model_stubs"."a" LIKE ? OR "model_stubs"."b" LIKE ?', '%foo%', '%foo%'],
       ['"model_stubs"."a" LIKE ? OR "model_stubs"."b" LIKE ?', '%bar%', '%bar%']
     ]
-    assert_equal expected_conditions, ClassWithFinder.create_conditions_for_columns(tokens, columns)
+    assert_equal expected_conditions, ClassWithFinder.conditions_for_columns(tokens, columns)
 
     expected_conditions = [
       '"model_stubs"."a" LIKE ? OR "model_stubs"."b" LIKE ?',
       '%foo%', '%foo%'
     ]
-    assert_equal [expected_conditions], ClassWithFinder.create_conditions_for_columns('foo', columns)
+    assert_equal [expected_conditions], ClassWithFinder.conditions_for_columns('foo', columns)
 
-    assert_equal nil, ClassWithFinder.create_conditions_for_columns('foo', [])
+    assert_nil ClassWithFinder.conditions_for_columns('foo', [])
   end
 
   def test_method_sorting

data/test/misc/parse_datetime_test.rb

@@ -0,0 +1,160 @@
+require 'test_helper'
+require 'active_scaffold_config_mock'
+
+class DateTimeModel < ActiveRecord::Base
+  include ActiveScaffold::ActiveRecordPermissions::ModelUserAccess::Model
+  def self.columns
+    @columns ||= [ColumnMock.new('id', '', 'int(11)'), ColumnMock.new('run_at', '', 'datetime')]
+  end
+
+  def self.columns_hash
+    @columns_hash ||= Hash[columns.map { |c| [c.name, c] }]
+  end
+
+  def self.load_schema!
+    columns_hash.each do |name, column|
+      define_attribute(
+        name,
+        connection.lookup_cast_type_from_column(column),
+        default: column.default
+      )
+    end
+  end
+end
+
+class ParseDatetimeTest < MiniTest::Test
+  include ActiveScaffoldConfigMock
+  include ActiveScaffold::AttributeParams
+  include ActiveScaffold::Finder
+
+  def setup
+    DateTimeModel.load_schema! if Rails.version >= '5.0'
+    spanish = {
+      time: {
+        formats: {picker: '%a, %d %b %Y %H:%M:%S'}
+      },
+      date: {
+        day_names: %w[Domingo Lunes Martes Miércoles Jueves Viernes Sábado],
+        abbr_day_names: %w[Dom Lun Mar Mié Jue Vie Sáb],
+        month_names: [nil, 'Enero', 'Febrero', 'Marzo', 'Abril', 'Mayo', 'Junio', 'Julio', 'Agosto', 'Septiembre', 'Octubre', 'Noviembre', 'Diciembre'],
+        abbr_month_names: [nil, 'Ene', 'Feb', 'Mar', 'Abr', 'May', 'Jun', 'Jul', 'Ago', 'Sep', 'Oct', 'Nov', 'Dic'],
+        formats: {default: '%Y-%m-%d', long: '%d de %B de %Y'}
+      }
+    }
+    I18n.backend.store_translations :es, spanish
+
+    @config = config_for('date_time_model')
+    @config.create.columns.set_columns @config.columns
+  end
+
+  def teardown
+    I18n.locale = :en
+  end
+
+  def test_translate_to_english
+    I18n.locale = :es
+    assert_equal 'Mon, 03 Apr 2017 16:30:26', translate_datetime('Lun, 03 Abr 2017 16:30:26')
+    assert_equal 'Fri, 24 Mar 2017 16:30:26', translate_datetime('Vie, 24 Mar 2017 16:30:26')
+    assert_equal 'Tue, 28 Mar 2017 16:30:26', translate_datetime('Mar, 28 Mar 2017 16:30:26')
+  end
+
+  def test_translate_to_english_with_different_order
+    I18n.locale = :es
+    format = '%d %b %Y, %a, %H:%M:%S'
+    assert_equal '03 Apr 2017, Mon, 16:30:26', translate_datetime('03 Abr 2017, Lun, 16:30:26', format)
+    assert_equal '24 Mar 2017, Fri, 16:30:26', translate_datetime('24 Mar 2017, Vie, 16:30:26', format)
+    assert_equal '28 Mar 2017, Tue, 16:30:26', translate_datetime('28 Mar 2017, Mar, 16:30:26', format)
+  end
+
+  def test_translate_to_english_with_words
+    I18n.locale = :es
+    format = '%A, %d de %B %Y, %H:%M:%S'
+    assert_equal 'Monday, 03 de April de 2017, 16:30:26', translate_datetime('Lunes, 03 de Abril de 2017, 16:30:26', format)
+    assert_equal 'Friday, 24 de March de 2017, 16:30:26', translate_datetime('Viernes, 24 de Marzo de 2017, 16:30:26', format)
+    assert_equal 'Tuesday, 28 de March de 2017, 16:30:26', translate_datetime('Martes, 28 de Marzo de 2017, 16:30:26', format)
+  end
+
+  def test_condition_for_spanish_datetime
+    with_js_framework :jquery do
+      I18n.locale = :es
+      assert_equal Time.zone.local(2017, 4, 3, 16, 30, 26), condition_value('Lun, 03 Abr 2017 16:30:26')
+      assert_equal Time.zone.local(2017, 3, 24, 16, 30, 26), condition_value('Vie, 24 Mar 2017 16:30:26')
+      assert_equal Time.zone.local(2017, 3, 28, 16, 30, 26), condition_value('Mar, 28 Mar 2017 16:30:26')
+    end
+  end
+
+  def test_condition_for_english_datetime
+    with_js_framework :jquery do
+      assert_equal Time.zone.local(2017, 4, 3, 16, 30, 26), condition_value('Mon, 03 Apr 2017 16:30:26')
+      assert_equal Time.zone.local(2017, 3, 24, 16, 30, 26), condition_value('Fri, 24 Mar 2017 16:30:26')
+      assert_equal Time.zone.local(2017, 3, 28, 16, 30, 26), condition_value('Tue, 28 Mar 2017 16:30:26')
+    end
+  end
+
+  def test_condition_for_english_datetime_without_time
+    with_js_framework :jquery do
+      assert_equal Time.zone.local(2017, 4, 3, 0, 0, 0), condition_value('Mon, 03 Apr 2017')
+      assert_equal Time.zone.local(2017, 3, 24, 0, 0, 0), condition_value('Fri, 24 Mar 2017')
+      assert_equal Time.zone.local(2017, 3, 28, 0, 0, 0), condition_value('Tue, 28 Mar 2017')
+    end
+  end
+
+  def test_condition_for_default_datetime_without_time
+    assert_equal Time.zone.local(2017, 4, 3, 0, 0, 0), condition_value('2017-04-03')
+    assert_equal Time.zone.local(2017, 3, 24, 0, 0, 0), condition_value('2017-03-24')
+    assert_equal Time.zone.local(2017, 3, 28, 0, 0, 0), condition_value('2017-03-28')
+  end
+
+  def test_condition_for_english_datetime_without_seconds
+    with_js_framework :jquery do
+      assert_equal Time.zone.local(2017, 4, 3, 16, 30), condition_value('Mon, 03 Apr 2017 16:30')
+      assert_equal Time.zone.local(2017, 3, 24, 16, 30), condition_value('Fri, 24 Mar 2017 16:30')
+      assert_equal Time.zone.local(2017, 3, 28, 16, 30), condition_value('Tue, 28 Mar 2017 16:30')
+    end
+  end
+
+  def test_condition_for_default_datetime_without_seconds
+    assert_equal Time.zone.local(2017, 4, 3, 16, 30, 0), condition_value('2017-04-03 16:30')
+    assert_equal Time.zone.local(2017, 3, 24, 16, 30, 0), condition_value('2017-03-24 16:30')
+    assert_equal Time.zone.local(2017, 3, 28, 16, 30, 0), condition_value('2017-03-28 16:30')
+  end
+
+  def test_condition_for_time
+    assert_equal Time.current.change(hour: 16, min: 30), condition_value('16:30')
+    assert_equal Time.current.change(hour: 16, min: 30, sec: 26), condition_value('16:30:26')
+  end
+
+  def test_condition_for_datetime_with_zone
+    assert_equal DateTime.new(2017, 4, 8, 16, 30, 0, '+0300'), condition_value('2017-04-08 16:30 +0300')
+  end
+
+  def test_condition_for_spanish_date
+    @config.columns[:run_at].options[:format] = :long
+    I18n.locale = :es
+    assert_equal Date.new(2017, 4, 3), condition_value('03 de Abril de 2017', :to_date)
+    assert_equal Date.new(2017, 3, 24), condition_value('24 de Marzo de 2017', :to_date)
+    assert_equal Date.new(2017, 3, 28), condition_value('28 de Marzo de 2017', :to_date)
+  end
+
+  def test_condition_for_english_date
+    @config.columns[:run_at].options[:format] = :long
+    assert_equal Date.new(2017, 4, 3), condition_value('April 03, 2017', :to_date)
+    assert_equal Date.new(2017, 3, 24), condition_value('March 24, 2017', :to_date)
+    assert_equal Date.new(2017, 3, 28), condition_value('March 28, 2017', :to_date)
+  end
+
+  private
+
+  def translate_datetime(value, format = nil)
+    format ||= I18n.t('time.formats.picker')
+    self.class.translate_days_and_months(value, format)
+  end
+
+  def condition_value(value, conversion = nil)
+    self.class.condition_value_for_datetime(@config.columns[:run_at], value, conversion || :to_time)
+  end
+
+  def params_hash?(v)
+    v.is_a? Hash
+  end
+end