active_sanity 0.1.1 → 0.2.0

data/CHANGELOG.md

@@ -0,0 +1,18 @@
+## 0.2.0
+
+* Add Rails ~3.1 compatibility. Pull Request [#6][] by [@skateinmars][].
+
+## 0.1.1
+
+* Fix bug where records stored with STI would be duplicated in the
+  database. Issue [#1][]. [@vraravam][]
+
+## 0.1.0
+
+Initial release.
+
+<!--- The following link definition list is generated by PimpMyChangelog --->
+[#1]: https://github.com/versapay/active_sanity/issues/1
+[#6]: https://github.com/versapay/active_sanity/issues/6
+[@skateinmars]: https://github.com/skateinmars
+[@vraravam]: https://github.com/vraravam

data/Gemfile

@@ -2,3 +2,8 @@ source "http://rubygems.org"
 
 # Specify your gem's dependencies in active_sanity.gemspec
 gemspec
+
+group :development do
+  gem 'rails', '~> 3.1.0'
+end
+

data/README.md

@@ -1,8 +1,15 @@
 # Active Sanity
 
+[![Build Status](https://secure.travis-ci.org/versapay/active_sanity.png)](http://travis-ci.org/versapay/active_sanity)
+
 Perform a sanity check on your database through active record
 validation.
 
+## Requirements
+
+ActiveSanity 0.2.0 requires Rails ~ 3.1
+ActiveSanity 0.1.1 requires Rails ~ 3.0
+
 ## Install
 
 Add the following line to your Gemfile
@@ -31,14 +38,6 @@ The output might look like the following:
     Flight      | 123 | { "arrival_time" => ["can't be nil"], "departure_time" => ["is invalid"] }
     Flight      | 323 | { "arrival_time" => ["can't be nil"] }
 
-## Known issues
-
-There is a bug in Rails 3.0.5 with the unserialization of OrderedHash
-storing arrays: only the last error of a given attribute gets retrieved
-from the database.
-
-See https://rails.lighthouseapp.com/projects/8994-ruby-on-rails/tickets/6646-orderedhash-serialization-does-not-work-when-storing-arrays 
-
 ## Contribute & Dev environment
 
 Usual fork & pull request.
@@ -47,7 +46,7 @@ This gem is quite simple so I experiment using features only. To run the
 acceptance test suite, just run:
 
     bundle install
-    cucumber features
+    RAILS_ENV=test cucumber features
 
 Using features only was kinda handsome until I had to deal with two
 different database schema (with / without the table invalid_records) in

data/Rakefile

@@ -5,7 +5,7 @@ task :default => :features
 
 desc "Run features"
 task :features do
-  raise "Failed!" unless system('bundle exec cucumber features')
+  raise "Failed!" unless system('export RAILS_ENV=test && bundle exec cucumber features')
 end
 
 desc "Clean test rails app"

data/active_sanity.gemspec

@@ -13,7 +13,7 @@ Gem::Specification.new do |s|
   s.description = %q{Performs a Sanity Check of your database by logging all invalid Active Records}
   s.homepage    = "https://github.com/versapay/active_sanity"
 
-  s.add_dependency "rails", ">=3.0.0"
+  s.add_dependency "rails", ">=3.1.0"
 
   s.add_development_dependency "rspec"
   s.add_development_dependency "cucumber"

data/features/check_sanity.feature

@@ -22,5 +22,5 @@ Feature: Check sanity
     And the first author's username is empty and the first post category_id is nil
     When I run "rake db:check_sanity"
     Then I should see the following invalid records:
-      | User     | 1 | {:username=>["can't be blank", "is too short (minimum is 3 characters)", "can't be blank", "can't be blank", "is too short (minimum is 3 characters)"]} |
+      | User     | 1 | {:username=>["can't be blank", "is too short (minimum is 3 characters)"]} |
       | Post     | 1 | {:category=>["can't be blank"]} |

data/features/check_sanity_with_db_storage.feature

@@ -22,7 +22,7 @@ Feature: Check sanity with db storage
     And the first author's username is empty and the first post category_id is nil
     When I run "rake db:check_sanity"
     Then the table "invalid_records" should contain:
-      | User     | 1 | {:username=>["is too short (minimum is 3 characters)"]} |
+      | User     | 1 | {:username=>["can't be blank", "is too short (minimum is 3 characters)"]} |
       | Post     | 1 | {:category=>["can't be blank"]} |
 
   Scenario: Check sanity on database with invalid records now valid
@@ -30,7 +30,7 @@ Feature: Check sanity with db storage
     And the first author's username is empty and the first post category_id is nil
     When I run "rake db:check_sanity"
     Then the table "invalid_records" should contain:
-      | User     | 1 | {:username=>["is too short (minimum is 3 characters)"]} |
+      | User     | 1 | {:username=>["can't be blank", "is too short (minimum is 3 characters)"]} |
       | Post     | 1 | {:category=>["can't be blank"]} |
 
     Given the first author's username is "Greg"
@@ -44,12 +44,12 @@ Feature: Check sanity with db storage
     And the first author's username is empty and the first post category_id is nil
     When I run "rake db:check_sanity"
     Then the table "invalid_records" should contain:
-      | User     | 1 | {:username=>["is too short (minimum is 3 characters)"]} |
+      | User     | 1 | {:username=>["can't be blank", "is too short (minimum is 3 characters)"]} |
       | Post     | 1 | {:category=>["can't be blank"]} |
 
     Given the first post category is set
     And the first post title is empty
     When I run "rake db:check_sanity"
     Then the table "invalid_records" should contain:
-      | User     | 1 | {:username=>["is too short (minimum is 3 characters)"]} |
+      | User     | 1 | {:username=>["can't be blank", "is too short (minimum is 3 characters)"]} |
       | Post     | 1 | {:title=>["can't be blank"]} |

data/features/step_definitions/rails_app.rb

@@ -1,7 +1,7 @@
 def setup_rails_app
   return if File.directory?("test/rails_app")
 
-  unless system "bundle exec rails new test/rails_app -m test/rails_template.rb"
+  unless system "bundle exec rails new test/rails_app -m test/rails_template.rb && cd ./test/rails_app && RAILS_ENV=test rake db:migrate"
     system("rm -fr test/rails_app")
     raise "Failed to generate test/rails_app"
   end
@@ -15,18 +15,21 @@ Given /^I have a rails app using 'active_sanity'$/ do
   setup_rails_app
 
   require './test/rails_app/config/environment'
+
+  # Reset connection
+  ActiveRecord::Base.connection.reconnect!
 end
 
 Given /^I have a rails app using 'active_sanity' with db storage$/ do
   setup_rails_app
 
-  raise unless system("cd ./test/rails_app && rails generate active_sanity && rake db:migrate")
+  raise unless system("cd ./test/rails_app && rails generate active_sanity && RAILS_ENV=test rake db:migrate")
 
   require './test/rails_app/config/environment'
 
   # Reset connection
   ActiveRecord::Base.connection.reconnect!
-  InvalidRecord.table_exists?
+  InvalidRecord.table_exists? # Looks up if table exists.
 end
 
 Given /^the database contains a few valid records$/ do
@@ -57,7 +60,7 @@ end
 
 
 When /^I run "([^"]*)"$/ do |command|
-  puts @output = `cd ./test/rails_app && #{command}; echo "RETURN:$?"`
+  puts @output = `cd ./test/rails_app && export RAILS_ENV=test && bundle exec #{command} --trace; echo "RETURN:$?"`
   raise unless @output['RETURN:0']
 end
 
@@ -86,21 +89,7 @@ Then /^the table "([^"]*)" should contain:$/ do |_, table|
     invalid_record.should be_an_instance_of(InvalidRecord)
     errors = eval(errors)
     errors.each do |k, v|
-      begin
-        invalid_record.validation_errors[k].should == v
-      rescue RSpec::Expectations::ExpectationNotMetError => e
-        # A bug in serialization of ordered hash get rid of the array of
-        # errors. The following is stored in the db:
-        # --- !omap 
-        #   - :username: can't be blank
-        #   - :username: is too short (minimum is 3 characters)
-        #
-        #   https://rails.lighthouseapp.com/projects/8994-ruby-on-rails/tickets/6646-orderedhash-serialization-does-not-work-when-storing-arrays
-        #
-        # You actually get the last error on an attribute only
-        # 
-        invalid_record.validation_errors[k].should == v.last
-      end
+      invalid_record.validation_errors[k].should == v
     end
   end
 end

data/features/support/env.rb

@@ -6,7 +6,7 @@ Bundler.setup
 
 if File.directory?("test/rails_app")
   Dir.chdir("test/rails_app") do
-    raise unless system("rm -f db/migrate/*create_invalid_records.rb && rake db:drop db:create db:migrate")
+    raise unless system("rm -f db/migrate/*create_invalid_records.rb && RAILS_ENV=test rake db:drop db:create db:migrate")
   end
 end
 

data/lib/active_sanity/checker.rb

@@ -26,7 +26,7 @@ module ActiveSanity
 
     protected
 
-    # Require all files under /app/models. 
+    # Require all files under /app/models.
     # All models under /lib are required when the rails app loads.
     def load_all_models
       Dir["#{Rails.root}/app/models/**/*.rb"].each { |file_path| require file_path rescue nil }
@@ -101,7 +101,7 @@ module ActiveSanity
       invalid_record = InvalidRecord.where(:record_type => type_of(record), :record_id => record.id).first
       invalid_record ||= InvalidRecord.new
       invalid_record.record = record
-      invalid_record.validation_errors = record.errors
+      invalid_record.validation_errors = record.errors.messages
       invalid_record.save!
     end
 
@@ -110,7 +110,7 @@ module ActiveSanity
     end
 
     def pretty_errors(record)
-      record.errors.inspect.sub(/^#<OrderedHash (.*)>$/, '\1')
+      record.errors.messages.inspect.sub(/^#<OrderedHash (.*)>$/, '\1')
     end
   end
 end

data/lib/active_sanity/version.rb

@@ -1,3 +1,3 @@
 module ActiveSanity
-  VERSION = "0.1.1"
+  VERSION = "0.2.0"
 end

metadata

@@ -1,93 +1,71 @@
---- !ruby/object:Gem::Specification 
+--- !ruby/object:Gem::Specification
 name: active_sanity
-version: !ruby/object:Gem::Version 
-  hash: 25
-  prerelease: false
-  segments: 
-  - 0
-  - 1
-  - 1
-  version: 0.1.1
+version: !ruby/object:Gem::Version
+  version: 0.2.0
+  prerelease: 
 platform: ruby
-authors: 
+authors:
 - VersaPay
 - Philippe Creux
 autorequire: 
 bindir: bin
 cert_chain: []
-
-date: 2011-09-06 00:00:00 -07:00
-default_executable: 
-dependencies: 
-- !ruby/object:Gem::Dependency 
+date: 2012-05-25 00:00:00.000000000 Z
+dependencies:
+- !ruby/object:Gem::Dependency
   name: rails
-  prerelease: false
-  requirement: &id001 !ruby/object:Gem::Requirement 
+  requirement: &70154013012080 !ruby/object:Gem::Requirement
     none: false
-    requirements: 
-    - - ">="
-      - !ruby/object:Gem::Version 
-        hash: 7
-        segments: 
-        - 3
-        - 0
-        - 0
-        version: 3.0.0
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: 3.1.0
   type: :runtime
-  version_requirements: *id001
-- !ruby/object:Gem::Dependency 
-  name: rspec
   prerelease: false
-  requirement: &id002 !ruby/object:Gem::Requirement 
+  version_requirements: *70154013012080
+- !ruby/object:Gem::Dependency
+  name: rspec
+  requirement: &70154013011660 !ruby/object:Gem::Requirement
     none: false
-    requirements: 
-    - - ">="
-      - !ruby/object:Gem::Version 
-        hash: 3
-        segments: 
-        - 0
-        version: "0"
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
   type: :development
-  version_requirements: *id002
-- !ruby/object:Gem::Dependency 
-  name: cucumber
   prerelease: false
-  requirement: &id003 !ruby/object:Gem::Requirement 
+  version_requirements: *70154013011660
+- !ruby/object:Gem::Dependency
+  name: cucumber
+  requirement: &70154013011180 !ruby/object:Gem::Requirement
     none: false
-    requirements: 
-    - - ">="
-      - !ruby/object:Gem::Version 
-        hash: 3
-        segments: 
-        - 0
-        version: "0"
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
   type: :development
-  version_requirements: *id003
-- !ruby/object:Gem::Dependency 
-  name: sqlite3
   prerelease: false
-  requirement: &id004 !ruby/object:Gem::Requirement 
+  version_requirements: *70154013011180
+- !ruby/object:Gem::Dependency
+  name: sqlite3
+  requirement: &70154013010760 !ruby/object:Gem::Requirement
     none: false
-    requirements: 
-    - - ">="
-      - !ruby/object:Gem::Version 
-        hash: 3
-        segments: 
-        - 0
-        version: "0"
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
   type: :development
-  version_requirements: *id004
-description: Performs a Sanity Check of your database by logging all invalid Active Records
-email: 
+  prerelease: false
+  version_requirements: *70154013010760
+description: Performs a Sanity Check of your database by logging all invalid Active
+  Records
+email:
 - philippe.creux@versapay.com
 executables: []
-
 extensions: []
-
 extra_rdoc_files: []
-
-files: 
+files:
 - .gitignore
+- CHANGELOG.md
 - Gemfile
 - README.md
 - Rakefile
@@ -105,43 +83,34 @@ files:
 - lib/generators/active_sanity/active_sanity_generator.rb
 - lib/generators/active_sanity/templates/create_invalid_records.rb
 - test/rails_template.rb
-has_rdoc: true
 homepage: https://github.com/versapay/active_sanity
 licenses: []
-
 post_install_message: 
 rdoc_options: []
-
-require_paths: 
+require_paths:
 - lib
-required_ruby_version: !ruby/object:Gem::Requirement 
+required_ruby_version: !ruby/object:Gem::Requirement
   none: false
-  requirements: 
-  - - ">="
-    - !ruby/object:Gem::Version 
-      hash: 3
-      segments: 
-      - 0
-      version: "0"
-required_rubygems_version: !ruby/object:Gem::Requirement 
+  requirements:
+  - - ! '>='
+    - !ruby/object:Gem::Version
+      version: '0'
+required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
-  requirements: 
-  - - ">="
-    - !ruby/object:Gem::Version 
-      hash: 3
-      segments: 
-      - 0
-      version: "0"
+  requirements:
+  - - ! '>='
+    - !ruby/object:Gem::Version
+      version: '0'
 requirements: []
-
 rubyforge_project: 
-rubygems_version: 1.3.7
+rubygems_version: 1.8.11
 signing_key: 
 specification_version: 3
 summary: Checks Sanity of Active Record records
-test_files: 
+test_files:
 - features/check_sanity.feature
 - features/check_sanity_with_db_storage.feature
 - features/step_definitions/rails_app.rb
 - features/support/env.rb
 - test/rails_template.rb
+has_rdoc: