active_rest_client 1.0.9 → 1.1.0

data/spec/lib/validation_spec.rb

@@ -17,86 +17,86 @@ describe "ActiveRestClient::Validation" do
     a = SimpleValidationExample.new
     a.first_name = nil
     a.valid?
-    expect(a.errors[:first_name].size).to eq(1)
+    expect(a._errors[:first_name].size).to eq(1)
   end
 
   it "should be valid if a required value is present" do
     a = SimpleValidationExample.new
     a.first_name = "John"
     a.valid?
-    expect(a.errors[:first_name]).to be_empty
+    expect(a._errors[:first_name]).to be_empty
   end
 
   it "should be invalid if a length within value is outside the range" do
     a = SimpleValidationExample.new(password:"12345")
     a.valid?
-    expect(a.errors[:password].size).to eq(1)
+    expect(a._errors[:password].size).to eq(1)
   end
 
   it "should be valid if a length within value is inside the range" do
     a = SimpleValidationExample.new(password:"123456")
     a.valid?
-    expect(a.errors[:password].size).to eq(0)
+    expect(a._errors[:password].size).to eq(0)
   end
 
   it "should be invalid if a length is below the minimum" do
     a = SimpleValidationExample.new(post_code:"12345")
     a.valid?
-    expect(a.errors[:post_code].size).to eq(1)
+    expect(a._errors[:post_code].size).to eq(1)
   end
 
   it "should be valid if a length is above or equal to the minimum and below the maximum" do
     a = SimpleValidationExample.new(post_code:"123456")
     a.valid?
-    expect(a.errors[:post_code].size).to eq(0)
+    expect(a._errors[:post_code].size).to eq(0)
   end
 
   it "should be invalid if a length is above the maximum" do
     a = SimpleValidationExample.new(post_code:"123456789")
     a.valid?
-    expect(a.errors[:post_code].size).to eq(1)
+    expect(a._errors[:post_code].size).to eq(1)
   end
 
   it "should be able to validate that a field is numeric" do
     a = SimpleValidationExample.new(salary:"Bob")
     a.valid?
-    expect(a.errors[:salary].size).to be > 0
+    expect(a._errors[:salary].size).to be > 0
   end
 
   it "should be able to validate that a numeric field is above or equal to a minimum" do
     a = SimpleValidationExample.new(salary:10_000)
     a.valid?
-    expect(a.errors[:salary].size).to be > 0
+    expect(a._errors[:salary].size).to be > 0
   end
 
   it "should be able to validate that a numeric field is above or equal to a minimum" do
     a = SimpleValidationExample.new(salary:100_000)
     a.valid?
-    expect(a.errors[:salary].size).to be > 0
+    expect(a._errors[:salary].size).to be > 0
   end
 
   it "should be invalid when a block adds an error" do
     class ValidationExample1 < OpenStruct
       include ActiveRestClient::Validation
       validates :first_name do |object, name, value|
-        object.errors[name] << "must be over 4 chars long" if value.length <= 4
+        object._errors[name] << "must be over 4 chars long" if value.length <= 4
       end
     end
     a = ValidationExample1.new(first_name:"John")
     a.valid?
-    expect(a.errors[:first_name].size).to eq(1)
+    expect(a._errors[:first_name].size).to eq(1)
   end
 
   it "should be valid when a block doesn't add an error" do
     class ValidationExample2 < OpenStruct
       include ActiveRestClient::Validation
       validates :first_name do |object, name, value|
-        object.errors[name] << "must be over 4 chars long" if value.length <= 4
+        object._errors[name] << "must be over 4 chars long" if value.length <= 4
       end
     end
     a = ValidationExample2.new(first_name:"Johnny")
     a.valid?
-    expect(a.errors[:first_name]).to be_empty
+    expect(a._errors[:first_name]).to be_empty
   end
 
   it "should call valid? before making a request" do

data/spec/spec_helper.rb

@@ -55,3 +55,34 @@ class TestCacheStore
     end
   end
 end
+
+class FaradayResponseMock < ::ActiveRestClient::FaradayResponseProxy
+  # The FaradayResponseMock is setup to automatically resolve all calls by default.
+  # By setting auto_resolve to false it allows the spec to control when the response
+  # is resolved, which simulates what it is like when inside a Faraday in_parallel block.
+  def initialize(response, auto_resolve=true)
+    super(response)
+    @auto_resolve = auto_resolve
+    @finished = false
+  end
+
+  def on_complete
+    if @auto_resolve
+      @finished = true
+      yield(@response)
+    else
+      @callback = Proc.new
+    end
+  end
+
+  # This is exactly what is called on responses after a Faraday in_parallel block ends.
+  # This method simulates the end of in_parallel block.
+  def finish
+    @finished = true
+    @callback.call(@response)
+  end
+
+  def finished?
+    @finished
+  end
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: active_rest_client
 version: !ruby/object:Gem::Version
-  version: 1.0.9
+  version: 1.1.0
 platform: ruby
 authors:
 - Which Ltd
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-05-07 00:00:00.000000000 Z
+date: 2015-06-26 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -165,6 +165,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: 1.3.1
+- !ruby/object:Gem::Dependency
+  name: typhoeus
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: multi_json
   requirement: !ruby/object:Gem::Requirement
@@ -257,6 +271,7 @@ files:
 - lib/active_rest_client/proxy_base.rb
 - lib/active_rest_client/recording.rb
 - lib/active_rest_client/request.rb
+- lib/active_rest_client/request_delegator.rb
 - lib/active_rest_client/request_filtering.rb
 - lib/active_rest_client/result_iterator.rb
 - lib/active_rest_client/validation.rb