active_rest_client 1.0.6 → 1.0.7

data/spec/lib/result_iterator_spec.rb

@@ -29,9 +29,9 @@ describe ActiveRestClient::ResultIterator do
 
   it "should implement any?" do
     result = ActiveRestClient::ResultIterator.new
-    expect(result.any?).to be_false
+    expect(result.any?).to be_falsey
     result << "a"
-    expect(result.any?).to be_true
+    expect(result.any?).to be_truthy
   end
 
   it "should implement items" do
@@ -64,10 +64,18 @@ describe ActiveRestClient::ResultIterator do
 
   it "should implement empty?" do
     result = ActiveRestClient::ResultIterator.new
-    expect(result.empty?).to be_true
+    expect(result.empty?).to be_truthy
     result << "a"
     result << "z"
-    expect(result.empty?).to be_false
+    expect(result.empty?).to be_falsey
+  end
+
+  it "should implement reverse" do
+    result = ActiveRestClient::ResultIterator.new
+    result << "a"
+    result << "z"
+    expect(result.reverse.first).to eq("z")
+    expect(result.reverse.last).to eq("a")
   end
 
   it "should implement direct index access" do
@@ -83,7 +91,7 @@ describe ActiveRestClient::ResultIterator do
     100.times do |n|
       result << n
     end
-    expect(result.shuffle.first == result.shuffle.first && result.shuffle.first == result.shuffle.first).to_not be_true
+    expect(result.shuffle.first == result.shuffle.first && result.shuffle.first == result.shuffle.first).to_not be_truthy
   end
 
   it "can parallelise calls to each item" do
@@ -101,4 +109,25 @@ describe ActiveRestClient::ResultIterator do
     expect(end_time-start_time).to be < (6*delay)
     expect(response).to eq([6,4,2])
   end
+
+  it "raises an error if you call paginate without WillPaginate installed" do
+    result = ActiveRestClient::ResultIterator.new
+    result << 3
+    expect{result.paginate}.to raise_error
+  end
+
+  it "returns a WillPaginate::Collection if you call paginate with WillPaginate installed" do
+    result = ActiveRestClient::ResultIterator.new
+    result << 3
+
+    module ::WillPaginate
+      class Collection ; end
+    end
+    allow(::WillPaginate).to receive(:per_page).and_return(10)
+    collection = double("WillPaginate::Collection")
+    allow(collection).to receive(:create).with(page: 1, per_page: 2).and_return(collection)
+    allow(::WillPaginate::Collection).to receive(:create).and_return(collection)
+    expect(result.paginate(page: 1, per_page: 2)).to eq(collection)
+    Object.send(:remove_const, :WillPaginate)
+  end
 end

data/spec/lib/validation_spec.rb

@@ -106,7 +106,7 @@ describe "ActiveRestClient::Validation" do
       validates :name, presence:true
     end
 
-    ValidationExample3.any_instance.should_receive(:valid?)
+    expect_any_instance_of(ValidationExample3).to receive(:valid?)
     object = ValidationExample3.new
     expect { object.create }.to raise_exception(ActiveRestClient::ValidationFailedException)
   end

data/spec/spec_helper.rb

@@ -16,13 +16,22 @@ RSpec.configure do |config|
   config.color = true
   # config.formatter     = 'documentation'
 
-  config.treat_symbols_as_metadata_keys_with_true_values = true
-
   # Run specs in random order to surface order dependencies. If you find an
   # order dependency and want to debug it, you can fix the order by providing
   # the seed, which is printed after each run.
   #     --seed 1234
   config.order = 'random'
+
+  config.mock_with :rspec do |mocks|
+    # In RSpec 3, `any_instance` implementation blocks will be yielded the receiving
+    # instance as the first block argument to allow the implementation block to use
+    # the state of the receiver.
+    # In RSpec 2.99, to maintain compatibility with RSpec 3 you need to either set
+    # this config option to `false` OR set this to `true` and update your
+    # `any_instance` implementation blocks to account for the first block argument
+    # being the receiving instance.
+    mocks.yield_receiver_to_any_instance_implementation_blocks = true
+  end
 end
 
 class TestCacheStore

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: active_rest_client
 version: !ruby/object:Gem::Version
-  version: 1.0.6
+  version: 1.0.7
 platform: ruby
 authors:
 - Which Ltd
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-01-09 00:00:00.000000000 Z
+date: 2015-03-04 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -45,14 +45,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2'
+        version: '3'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2'
+        version: '3'
 - !ruby/object:Gem::Dependency
   name: webmock
   requirement: !ruby/object:Gem::Requirement
@@ -200,7 +200,7 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: 0.4.9
-  type: :development
+  type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
@@ -285,7 +285,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.2.2
+rubygems_version: 2.4.5
 signing_key: 
 specification_version: 4
 summary: This gem is for accessing REST services in an ActiveRecord style.  ActiveResource