active_rest_client 1.0.3 → 1.0.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 95a7b0745cf0433d0d39a71335488abf9d5c7db7
-  data.tar.gz: 186afb738e60e270b25dae6963e476cfb97b27f7
+  metadata.gz: 168401e841f472c8c7dbb6295e9a7b6f87e10712
+  data.tar.gz: eb08bff09d6e74f4c3f1dc3a6933113e726cd620
 SHA512:
-  metadata.gz: 7638217032e8783304954e8cd3aac40d2bd7df4a0a8ac2d824c24480a544b0a3d1e4255aad45ddeaed8d20d2f408c4abfb01c847d819f62971c8e83737927425
-  data.tar.gz: 458acc1e2864a505f281a194d87dfe70dff2b1415ba72adb5ca3e12246f8ad39b4e5e52f402bd5d2696c39e01a075d0cbe34d4c03470d76fa8873d056f467103
+  metadata.gz: ca279962a442b496caa49d6dff757966bde80df37d7ef9d24e721a64f547a98c5200e4e0e8bf24136255ac7103797831b38c5b83f9da3897fddf739b004d72a8
+  data.tar.gz: 4deb89b8022c5da47c761df1a3853bb16b77949676b1f090cf87150ab0d8389c8b4297a3f22cd61ced2d1c1033add4e271cda532ac629c319158db0b28201013

data/README.md

@@ -198,6 +198,31 @@ If you need to, you can access properties of the HAL association.  By default ju
 @person.students[0]._hal_attributes("title")
 ```
 
+#### Association Type 4 - Nested Resources
+
+It's common to have resources that are logically children of other resources. For example, suppose that your API includes these endpoints:
+
+| HTTP Verb | Path                        |                                          |
+|-----------|-----------------------------|------------------------------------------|
+| POST      | /magazines/:magazine_id/ads | create a new ad belonging to a magazine  |
+| GET       | /magazines/:magazine_id/ads | display a list of all ads for a magazine |
+
+In these cases, your child class will contain the following:
+
+```ruby
+class Ad < ActiveRestClient::Base
+  post :create, "/magazines/:magazine_id/ads"
+  get :all, "/magazines/:magazine_id/ads"
+end
+```
+
+You can then access Ads by specifying their magazine IDs:
+
+```ruby
+Add.all(magazine_id: 1)
+Add.create(magazine_id: 1, title: "My Add Title")
+```
+
 #### Combined Example
 
 OK, so let's say you have an API for getting articles.  Each article has a property called `title` (which is a string) and a property `images` which includes a list of URIs.  Following this URI would take you to a image API that returns the image's `filename` and `filesize`.  We'll also assume this is a HAL compliant API. We would declare our two models (one for articles and one for images) like the following:

data/lib/active_rest_client/logger.rb

@@ -29,7 +29,7 @@ module ActiveRestClient
     end
 
     def self.info(message)
-      if defined?(Rails) && Rails.respond_to?(:logger)
+      if defined?(Rails) && Rails.respond_to?(:logger) && Rails.logger
         Rails.logger.info(message)
       elsif @logfile
         File.open(@logfile, "a") do |f|

data/lib/active_rest_client/request.rb

@@ -274,9 +274,9 @@ module ActiveRestClient
 
     def handle_response(response)
       @response = response
-      @response.status ||= 200
+      status = @response.status || 200
 
-      if (200..399).include? @response.status
+      if (200..399).include?(status)
         if @method[:options][:plain]
           return @response = response.body
         elsif is_json_response?
@@ -287,7 +287,7 @@ module ActiveRestClient
           end
           result = generate_new_object
         else
-          raise ResponseParseException.new(status:@response.status, body:@response.body)
+          raise ResponseParseException.new(status:status, body:@response.body)
         end
       else
         if is_json_response?
@@ -295,22 +295,21 @@ module ActiveRestClient
         else
           error_response = @response.body
         end
-        if @response.status == 400
-          raise HTTPBadRequestClientException.new(status:@response.status, result:error_response, url:@url)
-        elsif @response.status == 401
-          raise HTTPUnauthorisedClientException.new(status:@response.status, result:error_response, url:@url)
-        elsif @response.status == 403
-          raise HTTPForbiddenClientException.new(status:@response.status, result:error_response, url:@url)
-        elsif @response.status == 404
-          raise HTTPNotFoundClientException.new(status:@response.status, result:error_response, url:@url)
-        elsif (400..499).include? @response.status
-          raise HTTPClientException.new(status:@response.status, result:error_response, url:@url)
-        elsif (500..599).include? @response.status
-          raise HTTPServerException.new(status:@response.status, result:error_response, url:@url)
+        if status == 400
+          raise HTTPBadRequestClientException.new(status:status, result:error_response, url:@url)
+        elsif status == 401
+          raise HTTPUnauthorisedClientException.new(status:status, result:error_response, url:@url)
+        elsif status == 403
+          raise HTTPForbiddenClientException.new(status:status, result:error_response, url:@url)
+        elsif status == 404
+          raise HTTPNotFoundClientException.new(status:status, result:error_response, url:@url)
+        elsif (400..499).include? status
+          raise HTTPClientException.new(status:status, result:error_response, url:@url)
+        elsif (500..599).include? status
+          raise HTTPServerException.new(status:status, result:error_response, url:@url)
         end
       end
 
-
       result
     end
 

data/lib/active_rest_client/version.rb

@@ -1,3 +1,3 @@
 module ActiveRestClient
-  VERSION = "1.0.3"
+  VERSION = "1.0.4"
 end

data/spec/lib/request_spec.rb

@@ -69,6 +69,13 @@ describe ActiveRestClient::Request do
     ExampleClient.remove(id:1)
   end
 
+  it "should work with faraday response objects" do
+    response = Faraday::Response.new
+    response.stub(:body).and_return({}.to_json)
+    ActiveRestClient::Connection.any_instance.should_receive(:get).and_return(response)
+    expect { ExampleClient.all }.to_not raise_error
+  end
+
   it "should pass through get parameters" do
     ActiveRestClient::Connection.any_instance.should_receive(:get).with("/?debug=true", an_instance_of(Hash)).and_return(OpenStruct.new(body:'{"result":true}', headers:{}))
     ExampleClient.all debug:true

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: active_rest_client
 version: !ruby/object:Gem::Version
-  version: 1.0.3
+  version: 1.0.4
 platform: ruby
 authors:
 - Which Ltd
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-07-30 00:00:00.000000000 Z
+date: 2014-09-01 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler