active_reporter 0.6.1 → 0.6.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 760b641c323ac15a10767901f91776f8060353366c74e00333a29f76c43a622f
-  data.tar.gz: 12e2c7902056ec37e07a72c11d16261390c2aa8e56e1b7395d000d24b2617de8
+  metadata.gz: 723ed733317c2a8e7a9671f7df71388c7df0b8019824ef83a8455d1fc2358a26
+  data.tar.gz: 6897c073647fc646151861295592048449e80803ba000332a63b6a026942d770
 SHA512:
-  metadata.gz: 94f9875a81ab72172e200920213ca1de4f307f6879dc7163101d7399c5ea0cb3ba80b4b724c4c3b62b0d32daee75fe11a43a68a72d00ed1aa787a43fb3c8e6b4
-  data.tar.gz: 80d2ee5dc68fe12fc1239bab3305aa4c15ddccbb57daf74183e9e95bb05db7754b3045f927cf5eb2d673c113df1f3b6cd5d5c4b3412dd44cc9404ec891575e64
+  metadata.gz: 1d8eb39876e5f564fdf8b3522b9e1a6739052311b57f525baa4ac827fc0a3507a515c355a23f0b8d1e6280976a9f17dd654e80fb16e39278ceb82fed6fdb2d78
+  data.tar.gz: 89b76c59b8ef242536ed4758c7ff036fa35425703c57a56f1d212a72b642a5f5d24d919e2bc16c4907e93cac6e74e24d8500ca6f1d6ef2502c381cb4ab111fb0

data/Rakefile

@@ -1,22 +1,22 @@
 begin
-  require 'bundler/setup'
+  require "bundler/setup"
 rescue LoadError
-  puts 'You must `gem install bundler` and `bundle install` to run rake tasks'
+  puts "You must `gem install bundler` and `bundle install` to run rake tasks"
 end
 
-require 'rdoc/task'
+require "rdoc/task"
 
 RDoc::Task.new(:rdoc) do |rdoc|
-  rdoc.rdoc_dir = 'rdoc'
-  rdoc.title    = 'ActiveReporter'
-  rdoc.options << '--line-numbers'
-  rdoc.rdoc_files.include('README.rdoc')
-  rdoc.rdoc_files.include('lib/**/*.rb')
+  rdoc.rdoc_dir = "rdoc"
+  rdoc.title    = "ActiveReporter"
+  rdoc.options << "--line-numbers"
+  rdoc.rdoc_files.include("README.rdoc")
+  rdoc.rdoc_files.include("lib/**/*.rb")
 end
 
 Bundler::GemHelper.install_tasks
 
-require 'rspec/core/rake_task'
+require "rspec/core/rake_task"
 
 RSpec::Core::RakeTask.new(:spec)
 

data/lib/active_reporter/aggregator/array.rb

@@ -2,7 +2,7 @@ module ActiveReporter
   module Aggregator
     class Array < ActiveReporter::Aggregator::Base
       def aggregate(groups)
-        fail InvalidParamsError, 'array agg is only supported in Postgres' unless ActiveReporter.database_type == :postgres
+        fail InvalidParamsError, "array aggregator is only supported in Postgres" unless ActiveReporter.database_type == :postgres
         super
       end
 

data/lib/active_reporter/aggregator/count.rb

@@ -2,7 +2,7 @@ module ActiveReporter
   module Aggregator
     class Count < ActiveReporter::Aggregator::Base
       def function
-        "COUNT(#{'DISTINCT' if distinct} #{expression})"
+        "COUNT(#{"DISTINCT" if distinct} #{expression})"
       end
 
       def default_value
@@ -16,7 +16,7 @@ module ActiveReporter
       end
 
       def column
-        opts.fetch(:column, 'id')
+        opts.fetch(:column, "id")
       end
     end
   end

data/lib/active_reporter/aggregator/count_if.rb

@@ -2,7 +2,7 @@ module ActiveReporter
   module Aggregator
     class CountIf < ActiveReporter::Aggregator::Count
       def function
-        "COUNT(#{expression} IN (#{values.map(&:to_s).join(',')}) OR NULL)"
+        "COUNT(#{expression} IN (#{values.map(&:to_s).join(",")}) OR NULL)"
       end
 
       def default_value
@@ -16,7 +16,7 @@ module ActiveReporter
       end
 
       def column
-        super || 'id'
+        super || "id"
       end
     end
   end

data/lib/active_reporter/aggregator/ratio.rb

@@ -4,7 +4,7 @@ module ActiveReporter
       attr_reader :numerator, :denominator
 
       def function
-        "(#{numerator}/NULLIF(#{denominator},0))"
+        "(#{numerator}/NULLIF(#{denominator},0)::FLOAT)"
       end
 
       private

data/lib/active_reporter/aggregator.rb

@@ -1,9 +1,9 @@
-require 'active_reporter/aggregator/base'
-require 'active_reporter/aggregator/array'
-require 'active_reporter/aggregator/average'
-require 'active_reporter/aggregator/count'
-require 'active_reporter/aggregator/count_if'
-require 'active_reporter/aggregator/max'
-require 'active_reporter/aggregator/min'
-require 'active_reporter/aggregator/ratio'
-require 'active_reporter/aggregator/sum'
+require "active_reporter/aggregator/base"
+require "active_reporter/aggregator/array"
+require "active_reporter/aggregator/average"
+require "active_reporter/aggregator/count"
+require "active_reporter/aggregator/count_if"
+require "active_reporter/aggregator/max"
+require "active_reporter/aggregator/min"
+require "active_reporter/aggregator/ratio"
+require "active_reporter/aggregator/sum"

data/lib/active_reporter/calculator.rb

@@ -1,2 +1,2 @@
-require 'active_reporter/calculator/base'
-require 'active_reporter/calculator/ratio'
+require "active_reporter/calculator/base"
+require "active_reporter/calculator/ratio"

data/lib/active_reporter/dimension/base.rb

@@ -71,7 +71,7 @@ module ActiveReporter
       end
 
       def order(relation)
-        relation.order("#{order_expression} #{sort_order} #{null_order}")
+        relation.order(Arel.sql("#{order_expression} #{sort_order} #{null_order}"))
       end
 
       def sort_desc?
@@ -79,7 +79,7 @@ module ActiveReporter
       end
 
       def sort_order
-        sort_desc? ? 'DESC' : 'ASC'
+        sort_desc? ? "DESC" : "ASC"
       end
 
       def nulls_last?
@@ -90,7 +90,7 @@ module ActiveReporter
 
       def null_order
         return unless ActiveReporter.database_type == :postgres
-        nulls_last? ? 'NULLS LAST' : 'NULLS FIRST'
+        nulls_last? ? "NULLS LAST" : "NULLS FIRST"
       end
 
       def params

data/lib/active_reporter/dimension/bin/set.rb

@@ -21,7 +21,7 @@ module ActiveReporter
             when /^([^,]+),(.+)$/ then new($1, $2)
             when /^([^,]+),$/     then new($1, nil)
             when /^,(.+)$/        then new(nil, $1)
-            when ',', nil         then new(nil, nil)
+            when ",", nil         then new(nil, nil)
             else
               raise "Unexpected SQL bin format #{value}"
             end
@@ -104,8 +104,8 @@ module ActiveReporter
 
         def [](key)
           case key.to_s
-          when 'min' then min
-          when 'max' then max
+          when "min" then min
+          when "max" then max
           end
         end
 

data/lib/active_reporter/dimension/bin/table.rb

@@ -35,7 +35,7 @@ module ActiveReporter
         end
 
         def any_contain(expr)
-          map { |bin| bin.contains_sql(expr) }.join(' OR ')
+          map { |bin| bin.contains_sql(expr) }.join(" OR ")
         end
       end
     end

data/lib/active_reporter/dimension/bin.rb

@@ -1,4 +1,4 @@
-require 'active_reporter/dimension/base'
+require "active_reporter/dimension/base"
 
 module ActiveReporter
   module Dimension
@@ -9,15 +9,34 @@ module ActiveReporter
         self.class::MAX_BINS
       end
 
+      # report values are greater than or equal to min, grouped by bin_width
       def min
         @min ||= filter_min || report.records.minimum(expression)
       end
       alias bin_start min
 
+      # report values are less than max, grouped by bin_width
       def max
         @max ||= filter_max || report.records.maximum(expression)
       end
 
+      def bin_end
+        @bin_end ||= if max.blank? || min.blank? || min > max
+          nil
+        else
+          bin_edge = bin_start + bin_width
+
+          loop do
+            break if bin_edge >= max
+            bin_edge += bin_width
+          end
+
+          bin_edge += bin_width unless filter_values_for(:max).present? # # # figure out why we need this??
+
+          bin_edge
+        end
+      end
+
       def filter_min
         filter_values_for(:min).min
       end
@@ -95,23 +114,12 @@ module ActiveReporter
       end
 
       def autopopulate_bins
-        return [] if bin_start.blank? || max.blank?
-
-        bin_max = filter_values_for(:max).present? ? (max - bin_width) : max
+        return [] if bin_start.blank? || bin_end.blank?
         
-        bin_count = (bin_max - bin_start)/(bin_width)
+        bin_count = ((bin_end - bin_start)/(bin_width)).to_i
         invalid_param!(:bin_width, "is too small for the domain; would generate #{bin_count.to_i} bins") if bin_count > max_bins
 
-        bin_edge = bin_start
-        bins = []
-
-        loop do
-          break if bin_edge > bin_max
-
-          bin = { min: bin_edge, max: bin_edge + bin_width }
-          bins << bin
-          bin_edge = bin[:max]
-        end
+        bins = bin_count.times.map { |i| { min: (bin_start + (bin_width*i)), max: (bin_start + (bin_width*i.next)) } }
 
         bins.reverse! if sort_desc?
         ( nulls_last? ? bins.push(nil) : bins.unshift(nil) ) if data_contains_nil?

data/lib/active_reporter/dimension/category.rb

@@ -1,4 +1,4 @@
-require 'active_reporter/dimension/base'
+require "active_reporter/dimension/base"
 
 module ActiveReporter
   module Dimension

data/lib/active_reporter/dimension/enum.rb

@@ -1,4 +1,4 @@
-require 'active_reporter/dimension/category'
+require "active_reporter/dimension/category"
 
 module ActiveReporter
   module Dimension

data/lib/active_reporter/dimension/number.rb

@@ -1,4 +1,4 @@
-require 'active_reporter/dimension/bin'
+require "active_reporter/dimension/bin"
 
 module ActiveReporter
   module Dimension
@@ -9,8 +9,8 @@ module ActiveReporter
         super
 
         if params.key?(:bin_width)
-          invalid_param!(:bin_width, 'must be numeric') unless ActiveReporter.numeric?(params[:bin_width])
-          invalid_param!(:bin_width, 'must be greater than 0') unless params[:bin_width].to_f > 0
+          invalid_param!(:bin_width, "must be numeric") unless ActiveReporter.numeric?(params[:bin_width])
+          invalid_param!(:bin_width, "must be greater than 0") unless params[:bin_width].to_f > 0
         end
       end
 

data/lib/active_reporter/dimension/time.rb

@@ -1,12 +1,12 @@
-require 'active_reporter/inflector'
-require 'active_reporter/dimension/bin'
+require "active_reporter/inflector"
+require "active_reporter/dimension/bin"
 
 module ActiveReporter
   module Dimension
     class Time < Bin
       STEPS = %i(seconds minutes hours days weeks months years)
       BIN_STEPS = (STEPS - [:seconds]).map { |step| step.to_s.singularize(:_gem_active_reporter) }
-      DURATION_PATTERN = /\A\d+ (?:#{STEPS.map{ |step| "#{step}?" }.join('|')})\z/
+      DURATION_PATTERN = /\A\d+ (?:#{STEPS.map{ |step| "#{step}?" }.join("|")})\z/
 
       def validate_params!
         super
@@ -78,7 +78,7 @@ module ActiveReporter
 
       class Set < Bin::Set
         def parse(value)
-          ::Time.zone.parse(value.to_s.gsub('"', ''))
+          ::Time.zone.parse(value.to_s.gsub('"', ""))
         end
 
         def cast(value)

data/lib/active_reporter/dimension.rb

@@ -1,8 +1,8 @@
-require 'active_reporter/dimension/base'
-require 'active_reporter/dimension/bin'
-require 'active_reporter/dimension/bin/set'
-require 'active_reporter/dimension/bin/table'
-require 'active_reporter/dimension/time'
-require 'active_reporter/dimension/number'
-require 'active_reporter/dimension/category'
-require 'active_reporter/dimension/enum'
+require "active_reporter/dimension/base"
+require "active_reporter/dimension/bin"
+require "active_reporter/dimension/bin/set"
+require "active_reporter/dimension/bin/table"
+require "active_reporter/dimension/time"
+require "active_reporter/dimension/number"
+require "active_reporter/dimension/category"
+require "active_reporter/dimension/enum"

data/lib/active_reporter/evaluator.rb

@@ -1,2 +1,2 @@
-require 'active_reporter/evaluator/base'
-require 'active_reporter/evaluator/block'
+require "active_reporter/evaluator/base"
+require "active_reporter/evaluator/block"

data/lib/active_reporter/inflector.rb

@@ -4,5 +4,5 @@ ActiveSupport::Inflector.inflections(:_gem_active_reporter) do |inflect|
     inflect.instance_variable_set("@#{var}", sys_inflect.send(var).dup)
   end
 
-  inflect.uncountable 'delta'
+  inflect.uncountable "delta"
 end

data/lib/active_reporter/report/aggregation.rb

@@ -29,7 +29,6 @@ module ActiveReporter
 
       def source_data
         @source_data ||= aggregators.values.reduce(groups) do |relation, aggregator|
-          # append each aggregator into the base relation (groups)
           relation.merge(aggregator.aggregate(base_relation))
         end
       end
@@ -39,12 +38,11 @@ module ActiveReporter
       def aggregate
         tracker_dimension_key = :_tracker_dimension
 
-        if trackable? && trackers.any?
+        if trackable? && trackers.any? && prior_bin_report.source_data.present?
           prior_obj = prior_bin_report.source_data.first
           prior_row = prior_bin_report.hashed_data.first.with_indifferent_access
 
-          results_key_prefix = groupers.map { |g| g.extract_sql_value(prior_obj) }
-          prior_row[tracker_dimension_key] = results_key_prefix[0..-2]
+          prior_row[tracker_dimension_key] = groupers.without(tracker_dimension).map { |g| g.extract_sql_value(prior_obj) }
         else
           prior_obj = nil
           prior_row = {}
@@ -87,7 +85,7 @@ module ActiveReporter
           # "author.id" value (bin) changes the tracker is reset so we do not track changes from the last day of each
           # "author.id" to the first day of the next "author.id".
           if trackable?
-            current_row[tracker_dimension_key] = results_key_prefix[0..-2]
+            current_row[tracker_dimension_key] = groupers.without(tracker_dimension).map { |g| g.extract_sql_value(current_obj) }
 
             if current_row[tracker_dimension_key] == prior_row[tracker_dimension_key] && bins_are_adjacent?(current_obj, prior_obj)
               trackers.each do |name, tracker|
@@ -199,11 +197,11 @@ module ActiveReporter
 
         results.deep_merge!(results.collect do |row, value|
           calculators.collect do |name, calculator|
-            row_data = hash_raw_row(row, value, ['totals'])
+            row_data = hash_raw_row(row, value, ["totals"])
             calc_report = parent_report.total_report
 
             parent_row = match_parent_row_for_calculator(row_data, calc_report, calculator)
-            [['totals', name.to_s], calculator.calculate(row_data, parent_row)] unless parent_row.nil?
+            [["totals", name.to_s], calculator.calculate(row_data, parent_row)] unless parent_row.nil?
           end
         end.flatten(1).to_h) unless parent_report.nil?
 
@@ -241,9 +239,9 @@ module ActiveReporter
         # tracker? Even if there is a "correct" method for one report it may not be correct for a different report. The
         # same problem applies to strings. Which character is after "z"? The ASCII hex value is "{", which would work
         # fine for ordering, but maybe not for determining when a tracker should be reset. Additionally, we need to
-        # deal with strings of different lengths. Alphabetically you could order 'A', 'AA', 'AAA', 'B' but how do know
-        # when to reset the tracker? If we get a new value of 'AAAA' we have entirelly new values used to calculate the
-        # tracker value for the 'B' row, effectivally making the tracker values irrelevent.
+        # deal with strings of different lengths. Alphabetically you could order "A", "AA", "AAA", "B" but how do know
+        # when to reset the tracker? If we get a new value of "AAAA" we have entirelly new values used to calculate the
+        # tracker value for the "B" row, effectivally making the tracker values irrelevent.
         # Even going back to the integer example, the value allowed to be stored increments by 1, but there is no
         # guerentee that these are the actual values being used in the field.
         # For these reasons we will not attempt to track any dimension that does not specifically specify a bin width.
@@ -270,7 +268,7 @@ module ActiveReporter
       end
 
       def trackable?
-        @trackable ||= tracker_dimension.is_a?(ActiveReporter::Dimension::Bin) && tracker_dimension.min.present?
+        @trackable ||= tracker_dimension&.min.present?
       end
 
       def evaluatable?
@@ -278,7 +276,9 @@ module ActiveReporter
       end
 
       def tracker_dimension
-        @tracker_dimension ||= groupers.last
+        @tracker_dimension ||= (groupers.reverse + dimensions.values).detect do |dimension|
+          dimension.is_a?(ActiveReporter::Dimension::Bin) && %i[min max bin_width].all? { |a| dimension.try(a).present? }
+        end
       end
 
       def prior_bin_report

data/lib/active_reporter/report/definition.rb

@@ -1,4 +1,4 @@
-require 'active_reporter/inflector'
+require "active_reporter/inflector"
 
 module ActiveReporter
   class Report
@@ -6,7 +6,7 @@ module ActiveReporter
       extend ActiveSupport::Concern
 
       METRICS = %i[aggregator calculator dimension tracker evaluator].collect do |type|
-        metrics = Dir.glob(File.join(__dir__, '..', type.to_s, '*.rb')).collect { |file| File.basename(file, '.rb') }.without(*%w[base bin]).collect(&:to_sym).sort.freeze
+        metrics = Dir.glob(File.join(__dir__, "..", type.to_s, "*.rb")).collect { |file| File.basename(file, ".rb") }.without(*%w[base bin]).collect(&:to_sym).sort.freeze
         [type, const_set(type.to_s.upcase, metrics)]
       end.to_h.sort.freeze
 
@@ -102,7 +102,7 @@ module ActiveReporter
 
         # block_evaluator(:chargeback_ratio) { |row| supplemental_report_data.detect { |data| data[:id] == row[:id] }[:count] / row[:count] }
         def evaluator(name, evaluator_class, opts = {})
-          raise 'needs block' unless opts.include?(:block)
+          raise "needs block" unless opts.include?(:block)
           evaluators[name.to_sym] = { axis_class: evaluator_class, opts: opts }
         end
 
@@ -124,20 +124,20 @@ module ActiveReporter
             class_eval <<-METRIC_HELPERS, __FILE__, __LINE__ + 1
               def #{mertic}_#{type}(name, opts = {}, &block)
                 opts[:block] = block if block_given?
-                #{type}(name, #{(type.to_s + '/' + mertic.to_s.singularize(:_gem_active_reporter)).camelize.sub(/.*\./, "")}, opts)
+                #{type}(name, #{(type.to_s + "/" + mertic.to_s.singularize(:_gem_active_reporter)).camelize.sub(/.*\./, "")}, opts)
               end
             METRIC_HELPERS
           end
         end
 
         def default_report_model
-          name.demodulize.sub(/Report$/, '').constantize
+          name.demodulize.sub(/Report$/, "").constantize
         rescue NameError
           raise $!, "#{$!} cannot be used as `report_on` class, please configure `report_on` in the report class", $!.backtrace
         end
 
         def default_model
-          name.demodulize.sub(/Report$/, '').constantize
+          name.demodulize.sub(/Report$/, "").constantize
         end
 
         def report_model

data/lib/active_reporter/report/validation.rb

@@ -1,5 +1,5 @@
-require 'active_reporter/inflector'
-require 'active_reporter/invalid_params_error'
+require "active_reporter/inflector"
+require "active_reporter/invalid_params_error"
 
 module ActiveReporter
   class Report
@@ -19,11 +19,11 @@ module ActiveReporter
       end
 
       def validate_configuration!
-        incomplete_message = ['You must declare at least one aggregator or tracker, and at lease one dimension to initialize a report', 'See the README for more details']
+        incomplete_message = ["You must declare at least one aggregator or tracker, and at lease one dimension to initialize a report", "See the README for more details"]
 
         raise ActiveReporter::InvalidParamsError, ["#{self.class.name} does not declare any aggregators or trackers"].concat(incomplete_message).join(". ") if aggregators.empty?
         raise ActiveReporter::InvalidParamsError, ["#{self.class.name} does not declare any dimensions"].concat(incomplete_message).join(". ") if dimensions.except(:totals).empty?
-        raise ActiveReporter::InvalidParamsError, 'parent_report must be included in order to process calculations' if calculators.any? && parent_report.nil?
+        raise ActiveReporter::InvalidParamsError, "parent_report must be included in order to process calculations" if calculators.any? && parent_report.nil?
       end
 
       def validate_aggregators!
@@ -38,10 +38,13 @@ module ActiveReporter
         end
 
         calculators.values.each do |calculator|
-          if calculator.aggregator.nil?
+          case
+          when calculator.aggregator.nil?
             add_invalid_param_error(:calculator, ":#{calculator.name} must define an aggregator (should be in #{self.class.aggregator.keys})")
-          elsif aggregators.exclude?(calculator.aggregator)
+          when self.class.aggregators.exclude?(calculator.aggregator)
             add_invalid_param_error(:calculator, ":#{calculator.name} defines an invalid aggregator :#{calculator.aggregator} (should be in #{self.class.aggregators.keys})")
+          when params.include?(:aggregators) && aggregators.exclude?(calculator.aggregator)
+            params[:aggregators].push(calculator.aggregator)
           end
         end
       end
@@ -52,14 +55,22 @@ module ActiveReporter
         end
 
         trackers.values.each do |tracker|
-          if tracker.aggregator.nil?
+          case
+          when tracker.aggregator.nil?
             add_invalid_param_error(:tracker, ":#{tracker.name} must define an aggregator (should be in #{self.class.aggregator.keys})")
-          elsif aggregators.exclude?(tracker.aggregator)
+          when self.class.aggregators.exclude?(tracker.aggregator)
             add_invalid_param_error(:tracker, ":#{tracker.name} defines an invalid aggregator :#{tracker.aggregator} (should be in #{self.class.aggregators.keys})")
+          when params.include?(:aggregators) && aggregators.exclude?(tracker.aggregator)
+            params[:aggregators].push(tracker.aggregator)
           end
 
-          if tracker.prior_aggregator.present? && aggregators.exclude?(tracker.prior_aggregator)
-            add_invalid_param_error(:tracker, ":#{tracker.name} defines an invalid prior aggregator :#{tracker.prior_aggregator} (should be in #{self.class.aggregators.keys})")
+          if tracker.opts.include?(:prior_aggregator)
+            case
+            when self.class.aggregators.exclude?(tracker.prior_aggregator)
+              add_invalid_param_error(:tracker, ":#{tracker.name} defines an invalid prior aggregator :#{tracker.prior_aggregator} (should be in #{self.class.aggregators.keys})")
+            when params.include?(:aggregators) && aggregators.exclude?(tracker.prior_aggregator)
+              params[:aggregators].push(tracker.prior_aggregator)
+            end
           end
         end
       end
@@ -70,8 +81,8 @@ module ActiveReporter
           invalid_groupers_message = [
             [
               invalid_groupers.to_sentence,
-              (invalid_groupers.one? ? 'is not a' : 'are not'), 'valid', 'dimension'.pluralize(invalid_groupers.count, :_gem_active_reporter)
-            ].join(' '),
+              (invalid_groupers.one? ? "is not a" : "are not"), "valid", "dimension".pluralize(invalid_groupers.count, :_gem_active_reporter)
+            ].join(" "),
             "declared dimension include #{dimensions.keys.to_sentence}"
           ].join(". ")
           add_invalid_param_error(:groupers, invalid_groupers_message)
@@ -79,11 +90,11 @@ module ActiveReporter
       end
 
       def validate_parent_report!
-        add_invalid_param_error(:parent_report, 'must be an instance of ActiveReporter::Report') unless parent_report.nil? || parent_report.kind_of?(ActiveReporter::Report)
+        add_invalid_param_error(:parent_report, "must be an instance of ActiveReporter::Report") unless parent_report.nil? || parent_report.kind_of?(ActiveReporter::Report)
       end
 
       def validate_total_report!
-        add_invalid_param_error(:total_report, 'must be an instance of ActiveReporter::Report') unless @total_report.nil? || @total_report.kind_of?(ActiveReporter::Report)
+        add_invalid_param_error(:total_report, "must be an instance of ActiveReporter::Report") unless @total_report.nil? || @total_report.kind_of?(ActiveReporter::Report)
       end
 
       private
@@ -103,7 +114,7 @@ module ActiveReporter
       end
 
       def error_message
-        (["The report configuration contains the following #{'error'.pluralize(errors.count, :_gem_active_reporter)}:"] + errors).join("\n - ")
+        (["The report configuration contains the following #{"error".pluralize(errors.count, :_gem_active_reporter)}:"] + errors).join("\n - ")
       end
     end
   end

data/lib/active_reporter/report.rb

@@ -1,4 +1,4 @@
-Dir.glob(File.join(__dir__, 'report', '*.rb')).each { |file| require file }
+Dir.glob(File.join(__dir__, "report", "*.rb")).each { |file| require file }
 
 module ActiveReporter
   class Report
@@ -18,8 +18,8 @@ module ActiveReporter
       # When using a Calculator you may need the parent report data. Pass in a ActiveReporter::Report object when
       # instantiating a new ActiveReporter::Report instance as :parent_report. This will allow you to calculate a data
       # based on the #total_report of this passed :parent_report. For example, if the parent report includes a sum
-      # aggregated 'views' column, the child report can use Report::Calculator::Ratio to caluclate the ratio of 'views'
-      # on a given row versus the total 'views' from the parent report.
+      # aggregated "views" column, the child report can use Report::Calculator::Ratio to caluclate the ratio of "views"
+      # on a given row versus the total "views" from the parent report.
       @parent_report = @params.delete(:parent_report)
       @parent_groupers = @params.delete(:parent_groupers) || ( grouper_names & Array(parent_report&.grouper_names) )
 

data/lib/active_reporter/serializer/base.rb

@@ -1,4 +1,4 @@
-require 'active_reporter/inflector'
+require "active_reporter/inflector"
 
 module ActiveReporter
   module Serializer
@@ -13,7 +13,7 @@ module ActiveReporter
       # on the aggregators or dimension name.
 
       def human_aggregator_label(aggregators)
-        aggregators.keys.collect { |aggregator| aggregator.to_s.humanize }.join(' ')
+        aggregators.keys.collect { |aggregator| aggregator.to_s.humanize }.join(" ")
       end
 
       def human_dimension_label(dimension)
@@ -62,8 +62,8 @@ module ActiveReporter
 
       def time_formats
         {
-          minutes: '%F %k:%M', hours: '%F %k', days: '%F',
-          weeks: 'week of %F', months: '%Y-%m', years: '%Y'
+          minutes: "%F %k:%M", hours: "%F %k", days: "%F",
+          weeks: "week of %F", months: "%Y-%m", years: "%Y"
         }
       end
 
@@ -95,8 +95,8 @@ module ActiveReporter
         report.filters.flat_map do |dimension|
           human_dimension_label(dimension) + " = " + dimension.filter_values.map do |value|
             human_dimension_value_label(dimension, value)
-          end.to_sentence(last_word_connector: ', or ')
-        end.join('; ')
+          end.to_sentence(last_word_connector: ", or ")
+        end.join("; ")
       end
     end
   end

data/lib/active_reporter/serializer/csv.rb

@@ -1,4 +1,4 @@
-require 'csv'
+require "csv"
 
 module ActiveReporter
   module Serializer
@@ -11,7 +11,7 @@ module ActiveReporter
       end
 
       def save(filename = self.filename)
-        File.open(filename, 'w') { |f| f.write data }
+        File.open(filename, "w") { |f| f.write data }
       end
 
       def filename