active_remote 7.0.0 → 7.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 2f5d6d1d6040bd75c0cca252f6a01f6b0890a820a0fa790b39ebbd1169d1d170
-  data.tar.gz: 19a2409dd136d2f444702b5643ef892cbaf0fbc78cdc6778d843b478ab61b302
+  metadata.gz: 92aae53e06ad0e55d689420b7efd5d7bbeb506bde19cd5e32ef2a5157fb9e163
+  data.tar.gz: 604eb816304b23dd82ca760192206d3b6e62a1cc188a647e5f8fb69589f99d6c
 SHA512:
-  metadata.gz: 6c89162b7d9d677f769fea69caf1da05b79cc761edeff2ea4254cb00c28ca79e9cd145d5bf9c61ec4f4992ce11efd39c287006b5e3fabda08809466b1b57e47c
-  data.tar.gz: ae1efa2152a5a0f7100c9bab0aac160047d28a9104e76bee18ae0ccb7befbea534c8810ae336baaa4161ec1f03c6730eb029f86df1538c04b768e868467f6a98
+  metadata.gz: 435df01b39e8d571419743146b7941349f08d585505b4112d298fd670946e5565f5a78cbf595dcf699c7be809d5fac44e1e5f14a512d689a1cb85d0722b67d2c
+  data.tar.gz: cb2d8876f0aa28df71309ae3f53f2e4542ce4dddc6a428dc5c19d1c58d733fbbcf03a3b9afb14ccef33cdf17d29d39c6532595f1eea6ed138a03f4de94260d71

data/.github/workflows/{ruby.yml → main.yml}

@@ -6,22 +6,31 @@
 # GitHub recommends pinning actions to a commit SHA.
 # To get a newer version, you will need to update the SHA.
 # You can also reference a tag or branch, but the action may change without warning.
-
-name: Ruby CI
+name: ci
 
 on:
   push:
-    branches: [ master ]
+    branches: [main]
   pull_request:
-    branches: [ master ]
+    branches: [main]
 
 jobs:
+  lint:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4
+      - uses: ruby/setup-ruby@v1
+        with:
+          ruby-version: "3.1"
+          bundler-cache: true
+      - run: bundle exec standardrb --parallel --format github
   test:
     runs-on: ubuntu-latest
     strategy:
       fail-fast: false
       matrix:
-        ruby: [2.5, 2.6, 2.7, head, debug, jruby-9.3, jruby-9.4, jruby-head, truffleruby, truffleruby-head]
+        ruby:
+          [2.7, 3.0, 3.1, head, debug, jruby-9.4, jruby-head, truffleruby-head]
     continue-on-error: ${{ endsWith(matrix.ruby, 'head') || matrix.ruby == 'debug' }}
     steps:
       - uses: actions/checkout@v4
@@ -29,4 +38,4 @@ jobs:
         with:
           ruby-version: ${{ matrix.ruby }}
       - run: bundle install
-      - run: bundle rspec
+      - run: bundle exec rspec

data/.rubocop.yml

@@ -1,28 +1,3 @@
-# Styles are inherited from Mad Rubocop
-
+---
 inherit_gem:
-  mad_rubocop: .rubocop.yml
-
-# Styles that are modified from the defaults
-AllCops:
-  TargetRubyVersion: 3.1
-  Exclude:
-    - "**/*.pb.rb"
-
-Style/BlockDelimiters:
-  Description: >-
-                Avoid using {...} for multi-line blocks (multiline chaining is always ugly).
-                Prefer {...} over do...end for single-line blocks.
-  Exclude:
-    - "spec/**/*"
-
-Style/HashSyntax:
-  Description: >-
-                 Prefer Ruby 1.8 hash syntax { :a => 1, :b => 2 } over 1.9 syntax { a: 1, b: 2 }.
-  EnforcedStyle: hash_rockets
-  Exclude:
-    - "Gemfile"
-
-Layout/SpaceAroundOperators:
-  Exclude:
-    - "*.gemspec"
+  standard: config/ruby-3.1.yml

data/.standard.yml

@@ -0,0 +1,2 @@
+parallel: true # default: false
+format: progress # default: Standard::Formatter

data/CHANGES.md

@@ -1,80 +1,217 @@
-# ActiveRemote Changes
+# Changelog
 
-5.0.0
-----------
+All notable changes to this project will be documented in this file.
 
-- Use Active Model attributes [#72]
-- Use type casting from Active Model (custom types must be registered) [#71]
-- Use query attributes from Active Record (string values such as 'FALSE', and '0' are now considered present) [#71]
-- Drop support for Rails 4.2 (versions will match Rails version moving forward) [#71]
+The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.0/),
+and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
-3.3.1
-----------
+## [Unreleased]
 
-- Fix unknown type error in Protobuf serializer [#70]
+## [7.1.0] - 2024-12-04
 
-3.3.0
-----------
+### Changed
+
+- Update to ActiveModel 7.1 [#100](https://github.com/liveh2o/active_remote/pulls/100)
+
+### Added
+
+- Add `find_by` to the `Search` module to return the first record without raising `RemoteRecordNotFound` [#83](https://github.com/liveh2o/active_remote/pull/83)
+
+## [7.0.0] - 2024-06-15
+
+### Changed
+
+- Update to ActiveModel 7.0 [#96](https://github.com/liveh2o/active_remote/pulls/96)
+
+## [6.1.2] - 2024-06-15
+
+### Added
+
+- Add Ruby 3.1 compatibility [9477268](https://github.com/liveh2o/active_remote/commit/9477268)
+
+## [6.1.1] - 2022-09-07
+
+### Fixed
+
+- Revert the reader and writer methods so they can be overridden [#95](https://github.com/liveh2o/active_remote/pull/95)
+
+## [6.1.0] - 2022-08-24
+
+### Changed
+
+- Update to ActiveModel 6.1
+
+## [6.0.3] - 2024-06-15
+
+### Added
+
+- Add Ruby 3.1 compatibility [45d8e26](https://github.com/liveh2o/active_remote/commit/45d8e26)
+
+## [6.0.2] - 2022-06-17
+
+### Fixed
+
+- Fix association writer method (so it actually works) [85b369a](https://github.com/liveh2o/active_remote/commit/85b369a)
+
+## [6.0.1] - 2022-02-11
+
+### Changed
+
+- Pin to ActiveModel 6.0 (specs fail under 6.1)
+
+## [6.0.0]- 2022-02-10
+
+### Changed
+
+- Update to ActiveModel 6.x
+
+## [5.2.0] - 2020-05-21
+
+### Changed
+
+- Update to ActiveModel 5.2 to get major speed gains [#68](https://github.com/liveh2o/active_remote/pull/68)
+
+### Removed
+
+- Drop support for Rails 5.1
+- Remove development dependency on protobuf-nats
+
+## [5.1.1] - 2019-04-16
+
+### Changed
+
+- Include response errors in RemoteRecordNotSaved exception [#75](https://github.com/liveh2o/active_remote/pull/75)
+
+## [5.1.0] - 2019-01-26
+
+### Removed
+
+- Drop support for Rails 5.0
+
+## [5.0.1] - 2019-04-16
+
+### Changed
+
+- Include response errors in RemoteRecordNotSaved exception [#75](https://github.com/liveh2o/active_remote/pull/75)
+
+## [5.0.0] - 2019-01-26
+
+### Added
+
+- Use Active Model attributes [#72](https://github.com/liveh2o/active_remote/pull/72)
+- Use type casting from Active Model (custom types must be registered) [#71](https://github.com/liveh2o/active_remote/pull/71)
+- Use query attributes from Active Record (string values such as 'FALSE', and '0' are now considered present) [#71](https://github.com/liveh2o/active_remote/pull/71)
+- Add ability to execute remote calls on current object [#74](https://github.com/liveh2o/active_remote/pull/74)
+
+### Fixed
+
+Make query attributes more permissive [#73](https://github.com/liveh2o/active_remote/pull/73)
+
+### Removed
+
+- Drop support for Rails 4.2 (versions will match Rails version moving forward) [#71](https://github.com/liveh2o/active_remote/pull/71)
+
+## [3.3.3] - 2020-01-10
+
+### Added
+
+- Register big_integer type [#76](https://github.com/liveh2o/active_remote/pull/76)
+
+## [3.3.2] - 2019-04-16
+
+### Changed
+
+- Include response errors in RemoteRecordNotSaved exception [#75](https://github.com/liveh2o/active_remote/pull/75)
+
+## [3.3.1] - 2019-01-08
+
+### Fixed
+
+- Fix unknown type error in Protobuf serializer [#70](https://github.com/liveh2o/active_remote/pull/70)
+
+## [3.3.0] - 2019-01-08
+
+### Added
 
 - Add support for registering types that can be used to define attributes without using the existing `:type` or
-  `:typecaster` options  `attribute :name, :string` [#69]
+  `:typecaster` options `attribute :name, :string` [#69](https://github.com/liveh2o/active_remote/pull/69)
+
+## [3.2.2] - 2018-12-31
 
-3.2.2
-----------
+### Fixed
 
-- Speed up boolean typecasting [#67, @abrandoned]
+- Speed up boolean typecasting [#67, @abrandoned](https://github.com/liveh2o/active_remote/pull/67)
 
-3.2.1
-----------
+## [3.2.1] - 2018-11-11
+
+### Changed
 
 - Use `:remote_call` instead of of `rpc.execute` in persistence, search
 
-3.2.0
-----------
+## [3.2.0] - 2018-10-30
+
+### Added
+
+- Add ability to override default RPC endpoints [#66](https://github.com/liveh2o/active_remote/pull/66)
+
+### Changed
 
-- Add ability to override default RPC endpoints [#66]
 - Require Active Model 4.x to 5.1 for compatibility
 
-3.1.3
-----------
+## [3.1.3] - 2018-07-10
+
+### Changed
 
 - Require Active Model 4.x for compatibility
-- Cache and dup default attributes instead of building from scratch (4x speed boost on initialize) [#63, @film42]
 
-3.1.2
-----------
+### Fixed
+
+- Cache and dup default attributes instead of building from scratch (4x speed boost on initialize) [#63, @film42](https://github.com/liveh2o/active_remote/pull/63)
+
+## [3.1.2] - 2018-02-28
+
+### Fixed
+
+- Allow primary_key to be set on create [#61, @mattnichols](https://github.com/liveh2o/active_remote/pull/61)
+- Change the behavior of DateTime types to gracefully handle invalid dates [#62, @brianstien](https://github.com/liveh2o/active_remote/pull/61)
+
+## [3.1.1] - 2017-05-05
+
+### Fixed
+
+- Guard against undefined method errors in the Protobuf adapter [#59, @brianstien](https://github.com/liveh2o/active_remote/pull/59)
+
+## [3.1.0] - 2017-04-27
+
+### Added
+
+- Bubble up the type of error given from Protobuf instead of a generic `ActiveRemoteError` [#58, @ryanbjones](https://github.com/liveh2o/active_remote/pull/58)
 
-- Allow primary_key to be set on create [#61, @mattnichols]
-- Change the behavior of DateTime types to gracefully handle invalid dates [#62, @brianstien]
+## [3.0.0] - 2017-03-02
 
-3.1.1
-----------
+### Fixed
 
-- Guard against undefined method errors in the Protobuf adapter [#59, @brianstien]
+- Improve performance of many methods including `respond_to?` and `new`. [#50](https://github.com/liveh2o/active_remote/pull/50)
+- Change to internals of typecasting. Declaring `attribute :name, :type => Integer`
+  will no longer affect performance negatively. [#56](https://github.com/liveh2o/active_remote/pull/56)
 
-3.1.0
-----------
+### Changed
 
-- Bubble up the type of error given from Protobuf instead of a generic `ActiveRemoteError` [#58, @ryanbjones]
+- Refactor of attribute storage internals [#50](https://github.com/liveh2o/active_remote/pull/50)
+- Refactor of instantiate from RPC codepath [#56](https://github.com/liveh2o/active_remote/pull/56)
 
-3.0.0
-----------
+### Removed
 
-- Remove dependency on ActiveAttr [#48]
-- Remove attribute defaults feature [#50]
-- Remove core exts [#49]
+- Remove dependency on ActiveAttr [#48](https://github.com/liveh2o/active_remote/pull/48)
+- Remove attribute defaults feature [#50](https://github.com/liveh2o/active_remote/pull/50)
+- Remove core exts [#49](https://github.com/liveh2o/active_remote/pull/49)
 - Remove deprecated rpc methods `.request`, `.request_type`, #execute`, `#remote_call`
-  These methods are handled by the rpc adater now. [#49]
-- Remove deprecated method `._active_remote_search_args` [#49]
-- Remove deprecated `.parse_records` method [#49]
-- Remove publication, `#publishable_hash` method [#49]
-- Drop support for Rails 3 mass assignment protection.  Add support for strong param
-  enforcement for Rails 4+. [#50]
-- Improve performance of many methods including `respond_to?` and `new`. [#50]
-- Refactor of attribute storage internals [#50]
-- Remove a method was was doign dirty tracking twice [#52]
-- Extracted bulk methods to active_remote-bulk [#54]
-- Removed search callbacks [#55]
-- Refactor of instantiate from rpc codepath [#56]
-- Change to internals of typecasting.  Declaring `attribute :name, :type => Integer`
-  will no longer affect performance negatively. [#56]
+  These methods are handled by the rpc adater now. [#49](https://github.com/liveh2o/active_remote/pull/49)
+- Remove deprecated method `._active_remote_search_args` [#49](https://github.com/liveh2o/active_remote/pull/49)
+- Remove deprecated `.parse_records` method [#49](https://github.com/liveh2o/active_remote/pull/49)
+- Remove publication, `#publishable_hash` method [#49](https://github.com/liveh2o/active_remote/pull/49)
+- Drop support for Rails 3 mass assignment protection. Add support for strong param
+  enforcement for Rails 4+. [#50](https://github.com/liveh2o/active_remote/pull/50)
+- Remove a method that was doing dirty tracking twice [#52](https://github.com/liveh2o/active_remote/pull/52)
+- Extracted bulk methods to active_remote-bulk [#54](https://github.com/liveh2o/active_remote/pull/54)
+- Removed search callbacks [#55](https://github.com/liveh2o/active_remote/pull/55)

data/README.md

@@ -1,4 +1,6 @@
-[![Build Status](https://travis-ci.org/liveh2o/active_remote.svg?branch=master)](https://travis-ci.org/liveh2o/active_remote)
+![CI](https://github.com/liveh2o/active_remote/actions/workflows/main.yml/badge.svg)
+[![Ruby Style Guide](https://img.shields.io/badge/code_style-standard-brightgreen.svg)](https://github.com/standardrb/standard)
+[![Gem Version](https://badge.fury.io/rb/active_remote.svg)](https://badge.fury.io/rb/active_remote)
 
 # Active Remote
 
@@ -6,7 +8,7 @@ Active Remote provides [Active Record](https://github.com/rails/rails/tree/maste
 
 Active Remote provides a base class that when subclassed, provides the functionality you need to setup your remote model. Because Active Remote provides model persistence between RPC services, it uses a GUID to retrieve records and establish associations. So Active Remote expects your RPC data format to provide a :guid field that can be used to identify your remote models.
 
-Unlike Active Record, Active Remote doesn't have access to a database table to create attribute mappings. So you'll need to do a little setup to let Active Remote know how to persist your model*.
+Unlike Active Record, Active Remote doesn't have access to a database table to create attribute mappings. So you'll need to do a little setup to let Active Remote know how to persist your model\*.
 
 ```Ruby
   # Given a product record that has :guid & :name fields:
@@ -21,7 +23,7 @@ Unlike Active Record, Active Remote doesn't have access to a database table to c
   end
 ```
 
-_*Using Ruby's inherited hook, you could build an attribute mapper to setup your remote models for you._
+_\*Using Ruby's inherited hook, you could build an attribute mapper to setup your remote models for you._
 
 Like Active Record, Active Remote relies heavily on naming conventions and standard CRUD actions. It expects models name to map to it's service (e.g Product => ProductService) and will infer the service name automatically.
 
@@ -50,7 +52,7 @@ Like Active Record, Active Remote relies heavily on naming conventions and stand
   end
 ```
 
- You can, of course override it if need be:
+You can, of course override it if need be:
 
 ```Ruby
   # If you have a custom service:
@@ -78,7 +80,6 @@ Or install it yourself as:
 
     $ gem install active_remote
 
-
 ## Contributing
 
 1. Fork it

data/Rakefile

@@ -2,16 +2,13 @@
 require "bundler/gem_tasks"
 require "protobuf/tasks"
 require "rspec/core/rake_task"
-require "rubocop/rake_task"
-
-desc "Run cops"
-::RuboCop::RakeTask.new(:rubocop)
+require "standard/rake"
 
 desc "Run specs"
 ::RSpec::Core::RakeTask.new(:spec)
 
 desc "Run cops and specs (default)"
-task :default => [:rubocop, :spec]
+task default: [:standard, :spec]
 
 desc "Remove protobuf definitions that have been compiled"
 task :clean do

data/active_remote.gemspec

@@ -1,20 +1,17 @@
-# -*- encoding: utf-8 -*-
-
 $LOAD_PATH.push File.expand_path("lib", __dir__)
 require "active_remote/version"
 
 Gem::Specification.new do |s|
-  s.name          = "active_remote"
-  s.version       = ActiveRemote::VERSION
-  s.authors       = ["Adam Hutchison"]
-  s.email         = ["liveh2o@gmail.com"]
-  s.homepage      = "https://github.com/liveh2o/active_remote"
-  s.summary       = "Active Record for your platform"
-  s.description   = "Active Remote provides Active Record-like object-relational mapping over RPC. It was written for use with Google Protocol Buffers, but could be extended to use any RPC data format."
+  s.name = "active_remote"
+  s.version = ActiveRemote::VERSION
+  s.authors = ["Adam Hutchison"]
+  s.email = ["liveh2o@gmail.com"]
+  s.homepage = "https://github.com/liveh2o/active_remote"
+  s.summary = "Active Record for your platform"
+  s.description = "Active Remote provides Active Record-like object-relational mapping over RPC. It was written for use with Google Protocol Buffers, but could be extended to use any RPC data format."
 
-  s.files         = `git ls-files`.split("\n")
-  s.test_files    = `git ls-files -- {test,spec,features}/*`.split("\n")
-  s.executables   = `git ls-files -- bin/*`.split("\n").map { |f| File.basename(f) }
+  s.files = `git ls-files`.split("\n")
+  s.executables = `git ls-files -- bin/*`.split("\n").map { |f| File.basename(f) }
   s.require_paths = ["lib"]
 
   s.required_ruby_version = ">= 2.7.0"
@@ -22,20 +19,20 @@ Gem::Specification.new do |s|
   ##
   # Dependencies
   #
-  s.add_dependency "activemodel", "~> 7.0", "< 7.1"
-  s.add_dependency "activesupport", "~> 7.0", "< 7.1"
+  s.add_dependency "activemodel", "~> 7.1.0"
+  s.add_dependency "activesupport", "~> 7.1.0"
   s.add_dependency "protobuf", ">= 3.0"
 
   ##
   # Development Dependencies
   #
-  s.add_development_dependency "rake"
-  s.add_development_dependency "rspec", ">= 3.3.0"
+  s.add_development_dependency "benchmark-ips"
+  s.add_development_dependency "protobuf-rspec", ">= 1.1.2"
+  s.add_development_dependency "pry"
   s.add_development_dependency "rspec-its"
   s.add_development_dependency "rspec-pride", ">= 3.1.0"
-  s.add_development_dependency "mad_rubocop"
-  s.add_development_dependency "pry"
-  s.add_development_dependency "protobuf-rspec", ">= 1.1.2"
+  s.add_development_dependency "rspec", ">= 3.3.0"
   s.add_development_dependency "simplecov"
-  s.add_development_dependency "benchmark-ips"
+  s.add_development_dependency "standard"
+  s.add_development_dependency "rake"
 end

data/lib/active_remote/association.rb

@@ -131,10 +131,10 @@ module ActiveRemote
         raise "Could not find attribute: '#{options[:scope]}' on #{associated_class}" unless associated_class.public_instance_methods.include?(options[:scope])
       end
 
-    private
+      private
 
       def create_association_writer(associated_klass, options = {})
-        define_method("#{associated_klass}=") do |new_value|
+        define_method(:"#{associated_klass}=") do |new_value|
           raise "New value must be an array" if options[:has_many] == true && new_value.class != Array
 
           instance_variable_set(:"@#{associated_klass}", new_value)
@@ -156,7 +156,7 @@ module ActiveRemote
             instance_variable_set(:"@#{associated_klass}", value)
           end
 
-          return value
+          value
         end
 
         create_association_writer(associated_klass, options)

data/lib/active_remote/base.rb

@@ -43,7 +43,7 @@ module ActiveRemote
     include ::ActiveRemote::Validations
     include ::ActiveModel::Validations::Callbacks
 
-    define_model_callbacks :initialize, :only => :after
+    define_model_callbacks :initialize, only: :after
 
     def initialize(attributes = {})
       super
@@ -107,23 +107,23 @@ module ActiveRemote
       # We check defined?(@attributes) not to issue warnings if the object is
       # allocated but not initialized.
       inspection = if defined?(@attributes) && @attributes
-                     attribute_names.collect do |name, _|
-                       if attribute?(name)
-                         "#{name}: #{attribute_for_inspect(name)}"
-                       else
-                         name
-                       end
-                     end.compact.join(", ")
-                   else
-                     "not initialized"
-                   end
+        attribute_names.collect do |name, _|
+          if attribute?(name)
+            "#{name}: #{attribute_for_inspect(name)}"
+          else
+            name
+          end
+        end.compact.join(", ")
+      else
+        "not initialized"
+      end
 
       "#<#{self.class} #{inspection}>"
     end
 
     # Returns a hash of the given methods with their names as keys and returned values as values.
     def slice(*methods)
-      Hash[methods.flatten.map! { |method| [method, public_send(method)] }].with_indifferent_access
+      methods.flatten.map! { |method| [method, public_send(method)] }.to_h.with_indifferent_access
     end
   end
 

data/lib/active_remote/dirty.rb

@@ -62,7 +62,7 @@ module ActiveRemote
       enable_dirty_tracking
     end
 
-  private
+    private
 
     # Wether or not changes are currently being tracked for this class.
     #
@@ -74,7 +74,7 @@ module ActiveRemote
     # ActiveModel::Dirty.
     #
     def attribute=(name, value)
-      send("#{name}_will_change!") if _active_remote_track_changes? && value != self[name]
+      send(:"#{name}_will_change!") if _active_remote_track_changes? && value != self[name]
       super
     end
 

data/lib/active_remote/dsl.rb

@@ -20,32 +20,32 @@ module ActiveRemote
       end
 
       def endpoint_for_create(endpoint)
-        endpoints :create => endpoint
+        endpoints create: endpoint
       end
 
       def endpoint_for_delete(endpoint)
-        endpoints :delete => endpoint
+        endpoints delete: endpoint
       end
 
       def endpoint_for_destroy(endpoint)
-        endpoints :destroy => endpoint
+        endpoints destroy: endpoint
       end
 
       def endpoint_for_search(endpoint)
-        endpoints :search => endpoint
+        endpoints search: endpoint
       end
 
       def endpoint_for_update(endpoint)
-        endpoints :update => endpoint
+        endpoints update: endpoint
       end
 
       def endpoints(endpoints_hash = nil)
         @endpoints ||= {
-          :create => :create,
-          :delete => :delete,
-          :destroy => :destroy,
-          :search => :search,
-          :update => :update
+          create: :create,
+          delete: :delete,
+          destroy: :destroy,
+          search: :search,
+          update: :update
         }
         @endpoints.merge!(endpoints_hash) if endpoints_hash.present?
         @endpoints
@@ -114,7 +114,7 @@ module ActiveRemote
         @service_name ||= _determine_service_name
       end
 
-    private
+      private
 
       # Combine the namespace and service values, constantize them and return
       # the class constant.
@@ -127,12 +127,12 @@ module ActiveRemote
       end
 
       def _determine_service_name
-        underscored_name = self.name.underscore
-        "#{underscored_name}_service".to_sym
+        underscored_name = name.underscore
+        :"#{underscored_name}_service"
       end
     end
 
-  private
+    private
 
     # Private convenience methods for accessing DSL methods in instances
     #