active_remote 5.1.0 → 5.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 79fc272a53cfeaeb9c1cabc3860657360ac537a39815b2e3b53da98254518e07
-  data.tar.gz: 4dc0a14fbdd1a5c4d07cbe262689cb5622104f6414f1a584ee7d541de42e667f
+  metadata.gz: 0d01c0d9e90a995d69eca7eb4fc5778033dc78b6c2a1a2ed1472f828833d1ffb
+  data.tar.gz: 3304e91fb6c6dbf24955f5f84bccf1f19e4fb2f9a9a16a8a58c0dc41416f9e18
 SHA512:
-  metadata.gz: ea415297179445230b15ffa0d804ff1f22204a06e41e331f3230750d55965c424826eefba645361961e111c45abedc098c6e915d333fb894fe0f7dc9a046c09c
-  data.tar.gz: 6bdef12e26e50cf41e8f84e83c12ba7771d3d43153117c1b1bbefa5e1fda3807e1d532b696f384dfb80695c7565c20da40653cd2f8bb41dbe835bd27e8191747
+  metadata.gz: 6ac0f959ee3b70f396917d360c8b1c28c663530dc0b4d1f8b890ce277e401663208a80da549917f204a7a6f628b60cdb8e278d348f884b33d87ea5bc17503e56
+  data.tar.gz: d5db551ce3a30686ebe5bc529e2511a8e1b20b669d7ffd2b4b666f24d94bcbfec3b06cbda7787f03f469d5c87ffc7f7ce53b100f401795aea5f18cfa450d5850

data/lib/active_remote/errors.rb

@@ -43,6 +43,16 @@ module ActiveRemote
   # Raised by ActiveRemove::Base.save! and ActiveRemote::Base.create! methods
   # when remote record cannot be saved because it is invalid.
   class RemoteRecordNotSaved < ActiveRemoteError
+    attr_reader :record
+
+    def initialize(message_or_record = nil)
+      message = message_or_record
+      if message_or_record.is_a?(::ActiveRemote::Base)
+        @record = message_or_record
+        message = @record.errors.full_messages.join(", ")
+      end
+      super(message)
+    end
   end
 
   class UnknownAttributeError < ActiveRemoteError

data/lib/active_remote/persistence.rb

@@ -198,7 +198,7 @@ module ActiveRemote
     # Also runs any before/after save callbacks that are defined.
     #
     def save!(*args)
-      save(*args) || raise(RemoteRecordNotSaved)
+      save(*args) || fail(RemoteRecordNotSaved, self)
     end
 
     # Returns true if the record doesn't have errors; otherwise, returns false.

data/lib/active_remote/version.rb

@@ -1,3 +1,3 @@
 module ActiveRemote
-  VERSION = "5.1.0"
+  VERSION = "5.1.1"
 end

data/spec/lib/active_remote/errors_spec.rb

@@ -0,0 +1,31 @@
+require "spec_helper"
+
+describe ::ActiveRemote::RemoteRecordNotSaved do
+  let(:record) { ::Tag.new }
+
+  before do
+    record.errors[:base] << "Some error one!"
+    record.errors[:base] << "Some error two!"
+  end
+
+  context "when an active remote record is used" do
+    it "uses embedded errors in message" do
+      expect { fail(::ActiveRemote::RemoteRecordNotSaved, record) }
+        .to raise_error(ActiveRemote::RemoteRecordNotSaved, "Some error one!, Some error two!")
+    end
+  end
+
+  context "when a string is used" do
+    it "uses the string in the error message" do
+      expect { fail(::ActiveRemote::RemoteRecordNotSaved, "something bad happened") }
+        .to raise_error(ActiveRemote::RemoteRecordNotSaved, "something bad happened")
+    end
+  end
+
+  context "when no message is used" do
+    it "raises the error" do
+      expect { raise(::ActiveRemote::RemoteRecordNotSaved) }
+        .to raise_error(ActiveRemote::RemoteRecordNotSaved)
+    end
+  end
+end

data/spec/lib/active_remote/persistence_spec.rb

@@ -314,9 +314,16 @@ describe ::ActiveRemote::Persistence do
     end
 
     context "when the record is not saved" do
+      let(:errors) {
+        [Generic::Error.new(:field => "name", :message => "Error one!"),
+         Generic::Error.new(:field => "name", :message => "Error two!")]
+      }
+      let(:response) { Generic::Remote::Tag.new(:errors => errors) }
+      before { allow(rpc).to receive(:execute).and_return(response) }
+
       it "raises an exception" do
-        allow(subject).to receive(:save).and_return(false)
-        expect { subject.save! }.to raise_error(ActiveRemote::RemoteRecordNotSaved)
+        expect { subject.save! }
+          .to raise_error(ActiveRemote::RemoteRecordNotSaved, "Name Error one!, Name Error two!")
       end
     end
   end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: active_remote
 version: !ruby/object:Gem::Version
-  version: 5.1.0
+  version: 5.1.1
 platform: ruby
 authors:
 - Adam Hutchison
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-01-26 00:00:00.000000000 Z
+date: 2019-04-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activemodel
@@ -228,6 +228,7 @@ files:
 - spec/lib/active_remote/base_spec.rb
 - spec/lib/active_remote/dirty_spec.rb
 - spec/lib/active_remote/dsl_spec.rb
+- spec/lib/active_remote/errors_spec.rb
 - spec/lib/active_remote/integration_spec.rb
 - spec/lib/active_remote/persistence_spec.rb
 - spec/lib/active_remote/primary_key_spec.rb
@@ -281,7 +282,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.2
+rubyforge_project: 
+rubygems_version: 2.7.6
 signing_key: 
 specification_version: 4
 summary: Active Record for your platform
@@ -291,6 +293,7 @@ test_files:
 - spec/lib/active_remote/base_spec.rb
 - spec/lib/active_remote/dirty_spec.rb
 - spec/lib/active_remote/dsl_spec.rb
+- spec/lib/active_remote/errors_spec.rb
 - spec/lib/active_remote/integration_spec.rb
 - spec/lib/active_remote/persistence_spec.rb
 - spec/lib/active_remote/primary_key_spec.rb