active_remote 3.3.1 → 3.3.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 5ea2e2dce8e74426f1b128de526fc94673e8fcb21e23fd61052519f13bf2eb98
-  data.tar.gz: b317461ce80a81012b55475147b6c746d2aa9708dedf8173631d21fda6c5950b
+  metadata.gz: c58546bd68ea6b44a52688282a95a40b1734cd71d67c651ec29329527abf3e84
+  data.tar.gz: 5cb91fb55081d8b59ec24f946c87fdcc64c12d31b822b93261937631a00c99ca
 SHA512:
-  metadata.gz: 6db4dd2c80db0fbfbb768e90464cc900b77a9e490a647b922122adc254ded925ccfc1376e796460f988c690ce19c85f51149ae7015dd92a91d174d1e19933f70
-  data.tar.gz: 3ab7fb289b55326ebe7897189d205f03d6d3863c5d557d8768d4c84a6ee0c77ae8ca335bb0354be827d3920d83b7b88828a5c8cddb393b4f3948e28256e8d766
+  metadata.gz: 1fcf39ec901d0ae3d4b39e5c9715705b80a368db2a6f2048e1eca668647d5d7f8d456c99708b279d2ee5430ef62fd5d1cf6c087d919030fecd838b374e00410d
+  data.tar.gz: 001fd0f7e5576f878537930191126b4621c9b61c1353775d27ea625fcfa3913213d48283d94f5c9043d7a9c0bac07646ff0f8e453e0a563f3a9afd32991ea1d9

data/lib/active_remote/errors.rb

@@ -43,6 +43,16 @@ module ActiveRemote
   # Raised by ActiveRemove::Base.save! and ActiveRemote::Base.create! methods
   # when remote record cannot be saved because it is invalid.
   class RemoteRecordNotSaved < ActiveRemoteError
+    attr_reader :record
+
+    def initialize(message_or_record = nil)
+      message = message_or_record
+      if message_or_record.is_a?(::ActiveRemote::Base)
+        @record = message_or_record
+        message = @record.errors.full_messages.join(", ")
+      end
+      super(message)
+    end
   end
 
   class UnknownAttributeError < ActiveRemoteError

data/lib/active_remote/persistence.rb

@@ -184,7 +184,7 @@ module ActiveRemote
     # Also runs any before/after save callbacks that are defined.
     #
     def save!(*args)
-      save(*args) || raise(RemoteRecordNotSaved)
+      save(*args) || fail(RemoteRecordNotSaved, self)
     end
 
     # Returns true if the record doesn't have errors; otherwise, returns false.

data/lib/active_remote/version.rb

@@ -1,3 +1,3 @@
 module ActiveRemote
-  VERSION = "3.3.1"
+  VERSION = "3.3.2"
 end

data/spec/lib/active_remote/errors_spec.rb

@@ -0,0 +1,31 @@
+require "spec_helper"
+
+describe ::ActiveRemote::RemoteRecordNotSaved do
+  let(:record) { ::Tag.new }
+
+  before do
+    record.errors[:base] << "Some error one!"
+    record.errors[:base] << "Some error two!"
+  end
+
+  context "when an active remote record is used" do
+    it "uses embedded errors in message" do
+      expect { fail(::ActiveRemote::RemoteRecordNotSaved, record) }
+        .to raise_error(ActiveRemote::RemoteRecordNotSaved, "Some error one!, Some error two!")
+    end
+  end
+
+  context "when a string is used" do
+    it "uses the string in the error message" do
+      expect { fail(::ActiveRemote::RemoteRecordNotSaved, "something bad happened") }
+        .to raise_error(ActiveRemote::RemoteRecordNotSaved, "something bad happened")
+    end
+  end
+
+  context "when no message is used" do
+    it "raises the error" do
+      expect { raise(::ActiveRemote::RemoteRecordNotSaved) }
+        .to raise_error(ActiveRemote::RemoteRecordNotSaved)
+    end
+  end
+end

data/spec/lib/active_remote/persistence_spec.rb

@@ -259,9 +259,16 @@ describe ::ActiveRemote::Persistence do
     end
 
     context "when the record is not saved" do
+      let(:errors) {
+        [Generic::Error.new(:field => "name", :message => "Error one!"),
+         Generic::Error.new(:field => "name", :message => "Error two!")]
+      }
+      let(:response) { Generic::Remote::Tag.new(:errors => errors) }
+      before { allow(rpc).to receive(:execute).and_return(response) }
+
       it "raises an exception" do
-        allow(subject).to receive(:save).and_return(false)
-        expect { subject.save! }.to raise_error(ActiveRemote::RemoteRecordNotSaved)
+        expect { subject.save! }
+          .to raise_error(ActiveRemote::RemoteRecordNotSaved, "Name Error one!, Name Error two!")
       end
     end
   end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: active_remote
 version: !ruby/object:Gem::Version
-  version: 3.3.1
+  version: 3.3.2
 platform: ruby
 authors:
 - Adam Hutchison
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-01-08 00:00:00.000000000 Z
+date: 2019-04-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activemodel
@@ -232,6 +232,7 @@ files:
 - spec/lib/active_remote/base_spec.rb
 - spec/lib/active_remote/dirty_spec.rb
 - spec/lib/active_remote/dsl_spec.rb
+- spec/lib/active_remote/errors_spec.rb
 - spec/lib/active_remote/integration_spec.rb
 - spec/lib/active_remote/persistence_spec.rb
 - spec/lib/active_remote/primary_key_spec.rb
@@ -287,7 +288,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.7.8
+rubygems_version: 2.7.6
 signing_key: 
 specification_version: 4
 summary: Active Record for your platform
@@ -297,6 +298,7 @@ test_files:
 - spec/lib/active_remote/base_spec.rb
 - spec/lib/active_remote/dirty_spec.rb
 - spec/lib/active_remote/dsl_spec.rb
+- spec/lib/active_remote/errors_spec.rb
 - spec/lib/active_remote/integration_spec.rb
 - spec/lib/active_remote/persistence_spec.rb
 - spec/lib/active_remote/primary_key_spec.rb