active_remote 2.4.0 → 3.0.0.pre1

data/spec/lib/active_remote/query_attribute_spec.rb

@@ -0,0 +1,171 @@
+require "spec_helper"
+
+describe ::ActiveRemote::QueryAttributes do
+  subject { ::Author.new }
+
+  describe "#query_attribute" do
+    it "raises when getting an undefined attribute" do
+      expect { subject.query_attribute(:foobar) }.to raise_error(::ActiveRemote::UnknownAttributeError)
+    end
+
+    it "is false when the attribute is false" do
+      subject.name = false
+      expect(subject.name?).to eq false
+    end
+
+    it "is true when the attribute is true" do
+      subject.name = true
+      expect(subject.name?).to eq true
+    end
+
+    it "is false when the attribute is nil" do
+      subject.name = nil
+      expect(subject.name?).to eq false
+    end
+
+    it "is true when the attribute is an Object" do
+      subject.name = Object.new
+      expect(subject.name?).to eq true
+    end
+
+    it "is false when the attribute is an empty string" do
+      subject.name = ""
+      expect(subject.name?).to eq false
+    end
+
+    it "is true when the attribute is a non-empty string" do
+      subject.name = "Chris"
+      expect(subject.name?).to eq true
+    end
+
+    it "is false when the attribute is 0" do
+      subject.name = 0
+      expect(subject.name?).to eq false
+    end
+
+    it "is true when the attribute is 1" do
+      subject.name = 1
+      expect(subject.name?).to eq true
+    end
+
+    it "is false when the attribute is 0.0" do
+      subject.name = 0.0
+      expect(subject.name?).to eq false
+    end
+
+    it "is true when the attribute is 0.1" do
+      subject.name = 0.1
+      expect(subject.name?).to eq true
+    end
+
+    it "is false when the attribute is a zero BigDecimal" do
+      subject.name = BigDecimal.new("0.0")
+      expect(subject.name?).to eq false
+    end
+
+    it "is true when the attribute is a non-zero BigDecimal" do
+      subject.name = BigDecimal.new("0.1")
+      expect(subject.name?).to eq true
+    end
+
+    it "is true when the attribute is -1" do
+      subject.name = -1
+      expect(subject.name?).to eq true
+    end
+
+    it "is false when the attribute is -0.0" do
+      subject.name = -0.0
+      expect(subject.name?).to eq false
+    end
+
+    it "is true when the attribute is -0.1" do
+      subject.name = -0.1
+      expect(subject.name?).to eq true
+    end
+
+    it "is false when the attribute is a negative zero BigDecimal" do
+      subject.name = BigDecimal.new("-0.0")
+      expect(subject.name?).to eq false
+    end
+
+    it "is true when the attribute is a negative BigDecimal" do
+      subject.name = BigDecimal.new("-0.1")
+      expect(subject.name?).to eq true
+    end
+
+    it "is false when the attribute is '0'" do
+      subject.name = "0"
+      expect(subject.name?).to eq false
+    end
+
+    it "is true when the attribute is '1'" do
+      subject.name = "1"
+      expect(subject.name?).to eq true
+    end
+
+    it "is false when the attribute is '0.0'" do
+      subject.name = "0.0"
+      expect(subject.name?).to eq false
+    end
+
+    it "is true when the attribute is '0.1'" do
+      subject.name = "0.1"
+      expect(subject.name?).to eq true
+    end
+
+    it "is true when the attribute is '-1'" do
+      subject.name = "-1"
+      expect(subject.name?).to eq true
+    end
+
+    it "is false when the attribute is '-0.0'" do
+      subject.name = "-0.0"
+      expect(subject.name?).to eq false
+    end
+
+    it "is true when the attribute is '-0.1'" do
+      subject.name = "-0.1"
+      expect(subject.name?).to eq true
+    end
+
+    it "is true when the attribute is 'true'" do
+      subject.name = "true"
+      expect(subject.name?).to eq true
+    end
+
+    it "is false when the attribute is 'false'" do
+      subject.name = "false"
+      expect(subject.name?).to eq false
+    end
+
+    it "is true when the attribute is 't'" do
+      subject.name = "t"
+      expect(subject.name?).to eq true
+    end
+
+    it "is false when the attribute is 'f'" do
+      subject.name = "f"
+      expect(subject.name?).to eq false
+    end
+
+    it "is true when the attribute is 'T'" do
+      subject.name = "T"
+      expect(subject.name?).to eq true
+    end
+
+    it "is false when the attribute is 'F'" do
+      subject.name = "F"
+      expect(subject.name?).to eq false
+    end
+
+    it "is true when the attribute is 'TRUE'" do
+      subject.name = "TRUE"
+      expect(subject.name?).to eq true
+    end
+
+    it "is false when the attribute is 'FALSE" do
+      subject.name = "FALSE"
+      expect(subject.name?).to eq false
+    end
+  end
+end

data/spec/lib/active_remote/rpc_spec.rb

@@ -1,95 +1,53 @@
 require 'spec_helper'
 
-describe ActiveRemote::RPC do
-  subject { Tag.new }
+describe ::ActiveRemote::RPC do
+  subject { ::Tag.new }
 
-  describe ".remote_call" do
-    let(:args) { double(:args) }
-    let(:response) { double(:response) }
-
-    let(:rpc) { ::ActiveRemote::RPCAdapters::ProtobufAdapter.new(::Tag.service_class) }
-
-    before { allow(rpc).to receive(:execute).and_return(response) }
-    before { allow(::Tag).to receive(:rpc).and_return(rpc) }
-
-    it "calls the given RPC method" do
-      expect(Tag.rpc).to receive(:execute).with(:remote_method, args)
-      Tag.remote_call(:remote_method, args)
-    end
+  describe ".build_from_rpc" do
+    let(:new_attributes) { { :name => "test" } }
 
-    it "returns the response" do
-      allow(Tag.rpc).to receive(:execute).and_return(response)
-      expect(Tag.remote_call(:remote_method, args)).to eq response
-    end
-  end
-
-  describe ".request" do
-    let(:attributes) { Hash.new }
-
-    it "builds an RPC request" do
-      expect(Tag.request(:create, attributes)).to eq Generic::Remote::Tag.new(attributes)
-    end
-  end
-
-  describe ".request_type" do
-    it "fetches the request type for the given RPC method" do
-      expect(Tag.request_type(:search)).to eq Generic::Remote::TagRequest
-    end
-  end
-
-  describe "#execute" do
-    let(:request) { double(:request) }
-
-    it "calls the given RPC method" do
-      mock_remote_service(Tag.service_class, :create, :response => double(:to_hash => {}))
-      subject.execute(:create, request)
+    context "missing attributes from rpc" do
+      it "initializes to nil" do
+        expect(::Tag.build_from_rpc(new_attributes)).to include("guid" => nil)
+      end
     end
 
-    it "sets the last request" do
-      mock_remote_service(Tag.service_class, :create, :response => double(:to_hash => {}))
+    context "extra attributes from rpc" do
+      let(:new_attributes) { { :foobar => "test" } }
 
-      subject.execute(:create, request)
-      expect(subject.last_request).to eq(request)
+      it "ignores unknown attributes" do
+        expect(::Tag.build_from_rpc(new_attributes)).to_not include("foobar" => "test")
+      end
     end
 
-    context "when request args is a hash" do
-      let(:args){ Hash.new }
-      let(:request) { double(:request) }
+    context "typecasted attributes" do
+      let(:new_attributes) { { :birthday => "2017-01-01" } }
 
-      before {
-        allow(subject).to receive(:request).and_return(request)
-        mock_remote_service(Tag.service_class, :create, :response => double(:to_hash => {}))
-      }
-
-      it "creates a request" do
-        expect(subject).to receive(:request).with(:create, args)
-        subject.execute(:create, args)
+      it "calls the typecasters" do
+        expect(
+          ::TypecastedAuthor.build_from_rpc(new_attributes)
+        ).to include("birthday" => "2017-01-01".to_datetime)
       end
     end
+  end
 
-    context "when a request succeeds" do
-      let(:success_response) { double(:status => 'success', :awesome_town => true, :to_hash => {}) }
-
-      before {
-        mock_remote_service(Tag.service_class, :create, :response => success_response)
-      }
+  describe ".remote_call" do
+    let(:args) { double(:args) }
+    let(:response) { double(:response) }
 
-      it "sets the last response" do
-        subject.execute(:create, request)
-        expect(subject.last_response).to eq(success_response)
-      end
-    end
+    let(:rpc) { ::ActiveRemote::RPCAdapters::ProtobufAdapter.new(::Tag.service_class) }
 
-    context "when a request fails" do
-      let(:error_response) { double(:error, :message => "Boom goes the dynamite!") }
+    before { allow(rpc).to receive(:execute).and_return(response) }
+    before { allow(::Tag).to receive(:rpc).and_return(rpc) }
 
-      before {
-        mock_remote_service(Tag.service_class, :create, :error => error_response)
-      }
+    it "calls the given RPC method" do
+      expect(::Tag.rpc).to receive(:execute).with(:remote_method, args)
+      ::Tag.remote_call(:remote_method, args)
+    end
 
-      it "raises an exception" do
-        expect { subject.execute(:create, request) }.to raise_error(ActiveRemote::ActiveRemoteError)
-      end
+    it "returns the response" do
+      allow(::Tag.rpc).to receive(:execute).and_return(response)
+      expect(::Tag.remote_call(:remote_method, args)).to eq response
     end
   end
 end

data/spec/lib/active_remote/search_spec.rb

@@ -65,27 +65,6 @@ describe ActiveRemote::Search do
     end
   end
 
-  describe "#_active_remote_search" do
-    let(:args) { Hash.new }
-
-    subject { Tag.new }
-
-    before {
-      allow(rpc).to receive(:execute).and_return(response)
-      allow(Tag).to receive(:rpc).and_return(rpc)
-    }
-
-    it "runs callbacks" do
-      expect(subject).to receive(:run_callbacks).with(:search)
-      subject._active_remote_search(args)
-    end
-
-    it "executes the search" do
-      expect(rpc).to receive(:execute).with(:search, args)
-      subject._active_remote_search(args)
-    end
-  end
-
   describe "#reload" do
     let(:args) { attributes.slice('guid', 'user_guid') }
     let(:attributes) { HashWithIndifferentAccess.new(:guid => 'foo', :name => 'bar', :updated_at => nil, :user_guid => 'baz') }

data/spec/lib/active_remote/serialization_spec.rb

@@ -30,27 +30,4 @@ describe ActiveRemote::Serialization do
       end
     end
   end
-
-  describe "#add_errors_from_response" do
-    subject { Tag.new }
-
-    context "when the response responds to :errors" do
-      let(:error) { Generic::Error.new(:field => 'name', :message => 'Boom!') }
-      let(:response) { Generic::Remote::Tag.new(:errors => [ error ]) }
-
-      it "adds errors to the active remote object" do
-        expect(subject).to receive(:add_errors).with(response.errors)
-        subject.add_errors_from_response(response)
-      end
-    end
-
-    context "when the response does not respond to :errors" do
-      let(:response_without_errors) { double(:response_without_errors) }
-
-      it "does not add errors" do
-        expect(subject).to_not receive(:add_errors)
-        subject.add_errors_from_response(response_without_errors)
-      end
-    end
-  end
 end

data/spec/support/models/no_attributes.rb

@@ -0,0 +1,2 @@
+class NoAttributes < ::ActiveRemote::Base
+end

data/spec/support/models.rb

@@ -2,6 +2,7 @@ require 'support/models/message_with_options'
 require 'support/models/author'
 require 'support/models/default_author'
 require 'support/models/category'
+require 'support/models/no_attributes'
 require 'support/models/post'
 require 'support/models/tag'
 require 'support/models/typecasted_author'

metadata

@@ -1,43 +1,43 @@
 --- !ruby/object:Gem::Specification
 name: active_remote
 version: !ruby/object:Gem::Version
-  version: 2.4.0
+  version: 3.0.0.pre1
 platform: ruby
 authors:
 - Adam Hutchison
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-02-20 00:00:00.000000000 Z
+date: 2017-02-24 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
-  name: active_attr
+  name: activemodel
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '0.8'
+        version: '4.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '0.8'
+        version: '4.0'
 - !ruby/object:Gem::Dependency
   name: activesupport
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '3.2'
+        version: '4.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '3.2'
+        version: '4.0'
 - !ruby/object:Gem::Dependency
   name: protobuf
   requirement: !ruby/object:Gem::Requirement
@@ -155,42 +155,41 @@ description: Active Remote provides Active Record-like object-relational mapping
   to use any RPC data format.
 email:
 - liveh2o@gmail.com
-executables: []
+executables:
+- console
 extensions: []
 extra_rdoc_files: []
 files:
 - ".gitignore"
 - ".rspec"
+- ".travis.yml"
+- CHANGES.md
 - Gemfile
 - LICENSE
 - README.md
 - Rakefile
 - active_remote.gemspec
+- bin/console
 - lib/active_remote.rb
 - lib/active_remote/association.rb
-- lib/active_remote/attribute_defaults.rb
+- lib/active_remote/attribute_assignment.rb
+- lib/active_remote/attribute_definition.rb
 - lib/active_remote/attributes.rb
 - lib/active_remote/base.rb
-- lib/active_remote/bulk.rb
 - lib/active_remote/config.rb
-- lib/active_remote/core_ext.rb
-- lib/active_remote/core_ext/date.rb
-- lib/active_remote/core_ext/date_time.rb
-- lib/active_remote/core_ext/integer.rb
 - lib/active_remote/dirty.rb
 - lib/active_remote/dsl.rb
 - lib/active_remote/errors.rb
 - lib/active_remote/integration.rb
 - lib/active_remote/persistence.rb
 - lib/active_remote/primary_key.rb
-- lib/active_remote/publication.rb
+- lib/active_remote/query_attributes.rb
 - lib/active_remote/railtie.rb
 - lib/active_remote/rpc.rb
 - lib/active_remote/rpc_adapters/protobuf_adapter.rb
 - lib/active_remote/scope_keys.rb
 - lib/active_remote/search.rb
 - lib/active_remote/serialization.rb
-- lib/active_remote/serializers/json.rb
 - lib/active_remote/serializers/protobuf.rb
 - lib/active_remote/typecasting.rb
 - lib/active_remote/typecasting/big_decimal_typecaster.rb
@@ -204,22 +203,19 @@ files:
 - lib/active_remote/typecasting/string_typecaster.rb
 - lib/active_remote/validations.rb
 - lib/active_remote/version.rb
-- spec/core_ext/date_time_spec.rb
 - spec/lib/active_remote/association_spec.rb
-- spec/lib/active_remote/attribute_defaults_spec.rb
+- spec/lib/active_remote/attributes_spec.rb
 - spec/lib/active_remote/base_spec.rb
-- spec/lib/active_remote/bulk_spec.rb
 - spec/lib/active_remote/dirty_spec.rb
 - spec/lib/active_remote/dsl_spec.rb
 - spec/lib/active_remote/integration_spec.rb
 - spec/lib/active_remote/persistence_spec.rb
 - spec/lib/active_remote/primary_key_spec.rb
-- spec/lib/active_remote/publication_spec.rb
+- spec/lib/active_remote/query_attribute_spec.rb
 - spec/lib/active_remote/rpc_spec.rb
 - spec/lib/active_remote/scope_keys_spec.rb
 - spec/lib/active_remote/search_spec.rb
 - spec/lib/active_remote/serialization_spec.rb
-- spec/lib/active_remote/serializers/json_spec.rb
 - spec/lib/active_remote/serializers/protobuf_spec.rb
 - spec/lib/active_remote/typecasting_spec.rb
 - spec/lib/active_remote/validations_spec.rb
@@ -236,6 +232,7 @@ files:
 - spec/support/models/category.rb
 - spec/support/models/default_author.rb
 - spec/support/models/message_with_options.rb
+- spec/support/models/no_attributes.rb
 - spec/support/models/post.rb
 - spec/support/models/tag.rb
 - spec/support/models/typecasted_author.rb
@@ -260,55 +257,13 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">="
+  - - ">"
     - !ruby/object:Gem::Version
-      version: '0'
+      version: 1.3.1
 requirements: []
 rubyforge_project: 
 rubygems_version: 2.6.10
 signing_key: 
 specification_version: 4
 summary: Active Record for your platform
-test_files:
-- spec/core_ext/date_time_spec.rb
-- spec/lib/active_remote/association_spec.rb
-- spec/lib/active_remote/attribute_defaults_spec.rb
-- spec/lib/active_remote/base_spec.rb
-- spec/lib/active_remote/bulk_spec.rb
-- spec/lib/active_remote/dirty_spec.rb
-- spec/lib/active_remote/dsl_spec.rb
-- spec/lib/active_remote/integration_spec.rb
-- spec/lib/active_remote/persistence_spec.rb
-- spec/lib/active_remote/primary_key_spec.rb
-- spec/lib/active_remote/publication_spec.rb
-- spec/lib/active_remote/rpc_spec.rb
-- spec/lib/active_remote/scope_keys_spec.rb
-- spec/lib/active_remote/search_spec.rb
-- spec/lib/active_remote/serialization_spec.rb
-- spec/lib/active_remote/serializers/json_spec.rb
-- spec/lib/active_remote/serializers/protobuf_spec.rb
-- spec/lib/active_remote/typecasting_spec.rb
-- spec/lib/active_remote/validations_spec.rb
-- spec/spec_helper.rb
-- spec/support/definitions/author.proto
-- spec/support/definitions/category.proto
-- spec/support/definitions/error.proto
-- spec/support/definitions/post.proto
-- spec/support/definitions/serializer.proto
-- spec/support/definitions/tag.proto
-- spec/support/helpers.rb
-- spec/support/models.rb
-- spec/support/models/author.rb
-- spec/support/models/category.rb
-- spec/support/models/default_author.rb
-- spec/support/models/message_with_options.rb
-- spec/support/models/post.rb
-- spec/support/models/tag.rb
-- spec/support/models/typecasted_author.rb
-- spec/support/protobuf.rb
-- spec/support/protobuf/author.pb.rb
-- spec/support/protobuf/category.pb.rb
-- spec/support/protobuf/error.pb.rb
-- spec/support/protobuf/post.pb.rb
-- spec/support/protobuf/serializer.pb.rb
-- spec/support/protobuf/tag.pb.rb
+test_files: []

data/lib/active_remote/attribute_defaults.rb

@@ -1,100 +0,0 @@
-require "active_support/concern"
-require "active_support/core_ext/object/duplicable"
-
-module ActiveRemote
-  # AttributeDefaults allows defaults to be declared for your attributes
-  #
-  # Defaults are declared by passing the :default option to the attribute
-  # class method. If you need the default to be dynamic, pass a lambda, Proc,
-  # or any object that responds to #call as the value to the :default option
-  # and the result will calculated on initialization. These dynamic defaults
-  # can depend on the values of other attributes when those attributes are
-  # assigned using MassAssignment or BlockInitialization.
-  #
-  # @example Usage
-  #   class Person
-  #     include ActiveRemote::AttributeDefaults
-  #
-  #     attribute :first_name, :default => "John"
-  #     attribute :last_name, :default => "Doe"
-  #   end
-  #
-  #   person = Person.new
-  #   person.first_name #=> "John"
-  #   person.last_name #=> "Doe"
-  #
-  # @example Dynamic Default
-  #   class Event
-  #     include ActiveAttr::MassAssignment
-  #     include ActiveRemote::AttributeDefaults
-  #
-  #     attribute :start_date
-  #     attribute :end_date, :default => lambda { start_date }
-  #   end
-  #
-  #   event = Event.new(:start_date => Date.parse("2012-01-01"))
-  #   event.end_date.to_s #=> "2012-01-01"
-  #
-  module AttributeDefaults
-    extend ActiveSupport::Concern
-
-    # Applies the attribute defaults
-    #
-    # Applies all the default values to any attributes not yet set, avoiding
-    # any attribute setter logic, such as dirty tracking.
-    #
-    # @example Usage
-    #   class Person
-    #     include ActiveRemote::AttributeDefaults
-    #
-    #     attribute :first_name, :default => "John"
-    #   end
-    #
-    #   person = Person.new
-    #   person.first_name #=> "John"
-    #
-    def apply_defaults(defaults=attribute_defaults)
-      @attributes ||= {}
-      defaults.each do |name, value|
-        # instance variable is used here to avoid any dirty tracking in attribute setter methods
-        @attributes[name] = value if @attributes[name].nil?
-      end
-    end
-
-    # Calculates the attribute defaults from the attribute definitions
-    #
-    # @example Usage
-    #   class Person
-    #     include ActiveAttr::AttributeDefaults
-    #
-    #     attribute :first_name, :default => "John"
-    #   end
-    #
-    #   Person.new.attribute_defaults #=> {"first_name"=>"John"}
-    #
-    def attribute_defaults
-      attributes_map { |name| _attribute_default name }
-    end
-
-    # Applies attribute default values
-    #
-    def initialize(*)
-      super
-      apply_defaults
-    end
-
-    private
-
-    # Calculates an attribute default
-    #
-    def _attribute_default(attribute_name)
-      default = self.class.attributes[attribute_name][:default]
-
-      case
-      when default.respond_to?(:call) then instance_exec(&default)
-      when default.duplicable? then default.dup
-      else default
-      end
-    end
-  end
-end