active_remote 2.2.0 → 2.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: ad233ac94027246310c94addc5e595b1cb6d25fb
-  data.tar.gz: 0a1985fd4e52f98fb757fccdb04ccd097ee4abd4
+  metadata.gz: c89356033a37c579df65b431907bfdff0754d560
+  data.tar.gz: 3c31cbc7d4f0ac128112374a4baf7fe847d18adf
 SHA512:
-  metadata.gz: 7dabce988979749626a43fa3ddcfbaa2df930f8c70e57c172e6a89c7390d9ab11e47def151c2b7773cf486572b719affcb41e329e0aca7e40a00a16389c6172c
-  data.tar.gz: 9c57148a75afc5dd51f5ec5a6d31e96c446888153099c38cc970a2d04a57431a194022fcd88a21d057c319e11f5d20d6e6563b4b5f87cf8b4fef2af1a72202ca
+  metadata.gz: 96e1753ea1f51bbe1a64bc40dc39c76d9cb35f2dd27be42cfecb3b4628c8953819fe590b1c480439db6422208e2bad84dfa3913c230d054b1e7af1b209fc16d5
+  data.tar.gz: 300112bd7a7cb192297ef6f668d7366f2d9d6acd2ab9f0de377ad75ac1ca8d893e1d46b15363e8cc023f691713441e4c62c671f38663ce01c8f4ef1084edd986

data/.rspec

@@ -1,2 +1,3 @@
 --order rand
---format RSpec::Pride
+--require rspec/pride
+--format PrideFormatter

data/active_remote.gemspec

@@ -26,12 +26,11 @@ Gem::Specification.new do |s|
   ##
   # Development Dependencies
   #
-  s.add_development_dependency "better_receive"
   s.add_development_dependency "rake"
-  s.add_development_dependency "rspec"
+  s.add_development_dependency "rspec", ">= 3.3.0"
   s.add_development_dependency "rspec-its"
-  s.add_development_dependency "rspec-pride"
+  s.add_development_dependency "rspec-pride", ">= 3.1.0"
   s.add_development_dependency "pry"
-  s.add_development_dependency "protobuf-rspec", ">= 1.0"
+  s.add_development_dependency "protobuf-rspec", ">= 1.1.2"
   s.add_development_dependency "simplecov"
 end

data/lib/active_remote/persistence.rb

@@ -202,6 +202,22 @@ module ActiveRemote
       return ! has_errors?
     end
 
+    # Updates a single attribute and saves the record.
+    # This is especially useful for boolean flags on existing records. Also note that
+    #
+    # * Validation is skipped.
+    # * Callbacks are invoked.
+    # * Updates all the attributes that are dirty in this object.
+    #
+    # This method raises an ActiveRemote::ReadOnlyRemoteRecord  if the
+    # attribute is marked as readonly.
+    def update_attribute(name, value)
+      raise ReadOnlyRemoteRecord if readonly?
+      name = name.to_s
+      send("#{name}=", value)
+      save(:validate => false)
+    end
+
     # Updates the attributes of the remote record from the passed-in hash and
     # saves the remote record. If the object is invalid, it will have error
     # messages and false will be returned.
@@ -210,6 +226,7 @@ module ActiveRemote
       assign_attributes(attributes)
       save
     end
+    alias_method :update, :update_attributes
 
     # Updates the attributes of the remote record from the passed-in hash and
     # saves the remote record. If the object is invalid, an
@@ -219,13 +236,14 @@ module ActiveRemote
       assign_attributes(attributes)
       save!
     end
+    alias_method :update!, :update_attributes!
 
   private
 
     # Handles creating a remote object and serializing it's attributes and
     # errors from the response.
     #
-    def create
+    def remote_create
       run_callbacks :create do
         # Use the getter here so we get the type casting.
         new_attributes = attributes
@@ -247,14 +265,14 @@ module ActiveRemote
     #
     def create_or_update(*args)
       raise ReadOnlyRemoteRecord if readonly?
-      new_record? ? create : update(*args)
+      new_record? ? remote_create : remote_update(*args)
     end
 
     # Handles updating a remote object and serializing it's attributes and
     # errors from the response. Only attributes with the given attribute names
     # (plus :guid) will be updated. Defaults to all attributes.
     #
-    def update(attribute_names = @attributes.keys)
+    def remote_update(attribute_names = @attributes.keys)
       run_callbacks :update do
         # Use the getter here so we get the type casting.
         updated_attributes = attributes

data/lib/active_remote/search.rb

@@ -134,9 +134,7 @@ module ActiveRemote
     # Reload this record from the remote service.
     #
     def reload
-      response = self.class.find(scope_key_hash)
-
-      fresh_object = self.class.instantiate(response.to_hash)
+      fresh_object = self.class.find(scope_key_hash)
       @attributes.update(fresh_object.instance_variable_get('@attributes'))
     end
   end

data/lib/active_remote/version.rb

@@ -1,3 +1,3 @@
 module ActiveRemote
-  VERSION = "2.2.0"
+  VERSION = "2.3.0"
 end

data/spec/lib/active_remote/association_spec.rb

@@ -47,18 +47,18 @@ describe ActiveRemote::Association do
         end
 
         context 'when user_guid doesnt exist on model 'do
-          before { allow(subject).to receive(:respond_to?).with("user_guid").and_return(false) }
+          before { allow(subject.class).to receive_message_chain(:public_instance_methods, :include?).with(:user_guid).and_return(false) }
 
           it 'raises an error' do
-            expect {subject.user}.to raise_error
+            expect {subject.user}.to raise_error(::RuntimeError, /Could not find attribute/)
           end
         end
 
         context 'when user_guid doesnt exist on associated model 'do
-          before { Author.stub_chain(:public_instance_methods, :include?).with(:user_guid).and_return(false) }
+          before { allow(Author).to receive_message_chain(:public_instance_methods, :include?).with(:user_guid).and_return(false) }
 
           it 'raises an error' do
-            expect {subject.user}.to raise_error
+            expect {subject.user}.to raise_error(::RuntimeError, /Could not find attribute/)
           end
         end
       end
@@ -154,15 +154,15 @@ describe ActiveRemote::Association do
         before { allow(subject).to receive(:respond_to?).with("user_guid").and_return(false) }
 
         it 'raises an error' do
-          expect {subject.user_posts}.to raise_error
+          expect {subject.user_posts}.to raise_error(::ActiveAttr::UnknownAttributeError)
         end
       end
 
       context 'when user_guid doesnt exist on associated model 'do
-        before { Post.stub_chain(:public_instance_methods, :include?).with(:user_guid).and_return(false) }
+        before { allow(Post).to receive_message_chain(:public_instance_methods, :include?).with(:user_guid).and_return(false) }
 
         it 'raises an error' do
-          expect {subject.user_posts}.to raise_error
+          expect {subject.user_posts}.to raise_error(::RuntimeError, /Could not find attribute/)
         end
       end
     end
@@ -237,15 +237,15 @@ describe ActiveRemote::Association do
         before { allow(subject).to receive(:respond_to?).with("user_guid").and_return(false) }
 
         it 'raises an error' do
-          expect {subject.chief_editor}.to raise_error
+          expect {subject.chief_editor}.to raise_error(::ActiveAttr::UnknownAttributeError)
         end
       end
 
       context 'when user_guid doesnt exist on associated model 'do
-        before { Author.stub_chain(:public_instance_methods, :include?).with(:user_guid).and_return(false) }
+        before { allow(Author).to receive_message_chain(:public_instance_methods, :include?).with(:user_guid).and_return(false) }
 
         it 'raises an error' do
-          expect {subject.chief_editor}.to raise_error
+          expect {subject.chief_editor}.to raise_error(::RuntimeError, /Could not find attribute/)
         end
       end
     end

data/spec/lib/active_remote/bulk_spec.rb

@@ -6,15 +6,15 @@ describe ActiveRemote::Bulk do
     let(:response) { double(:response, :records => []) }
     let(:rpc) { ::ActiveRemote::RPCAdapters::ProtobufAdapter.new(::Tag.service_class) }
 
-    before { rpc.better_stub(:execute).and_return(response) }
-    before { ::Tag.better_stub(:rpc).and_return(rpc) }
+    before { allow(rpc).to receive(:execute).and_return(response) }
+    before { allow(::Tag).to receive(:rpc).and_return(rpc) }
 
     context "given an empty array" do
       let(:parsed_records) { { :records => records } }
       let(:records) { [] }
 
       it "calls #{bulk_method} with parsed records" do
-        rpc.better_receive(:execute).with(bulk_method, parsed_records)
+        expect(rpc).to receive(:execute).with(bulk_method, parsed_records)
         Tag.__send__(bulk_method, records)
       end
     end
@@ -25,7 +25,7 @@ describe ActiveRemote::Bulk do
       let(:records) { [ hash_record ] }
 
       it "calls #{bulk_method} with parsed records" do
-        rpc.better_receive(:execute).with(bulk_method, parsed_records)
+        expect(rpc).to receive(:execute).with(bulk_method, parsed_records)
         Tag.__send__(bulk_method, records)
       end
     end
@@ -36,7 +36,7 @@ describe ActiveRemote::Bulk do
       let(:remote_record) { double(:remote, :attributes => {}) }
 
       it "calls #{bulk_method} with parsed records" do
-        rpc.better_receive(:execute).with(bulk_method, parsed_records)
+        expect(rpc).to receive(:execute).with(bulk_method, parsed_records)
         Tag.__send__(bulk_method, records)
       end
     end
@@ -47,7 +47,7 @@ describe ActiveRemote::Bulk do
       let(:tags) { Generic::Remote::Tags.new(:records => [ tag ]) }
 
       it "calls #{bulk_method} with parsed records" do
-        rpc.better_receive(:execute).with(bulk_method, parsed_records)
+        expect(rpc).to receive(:execute).with(bulk_method, parsed_records)
         Tag.__send__(bulk_method, tags)
       end
     end

data/spec/lib/active_remote/dirty_spec.rb

@@ -47,7 +47,7 @@ describe ActiveRemote::Dirty do
     subject { Post.new(:name => 'foo') }
 
     before {
-      allow(Post).to receive(:find).and_return({})
+      allow(Post).to receive(:find).and_return(Post.new(:name => 'foo'))
       subject.reload
     }
 

data/spec/lib/active_remote/persistence_spec.rb

@@ -2,13 +2,13 @@ require 'spec_helper'
 
 describe ActiveRemote::Persistence do
   let(:rpc) { Tag.new }
+  let(:response_without_errors) { HashWithIndifferentAccess.new(:errors => []) }
 
   subject { Tag.new }
 
   before {
-    rpc.better_stub(:execute).and_return(HashWithIndifferentAccess.new)
-    allow_any_instance_of(HashWithIndifferentAccess).to receive(:errors).and_return([])
-    Tag.better_stub(:rpc).and_return(rpc)
+    allow(rpc).to receive(:execute).and_return(response_without_errors)
+    allow(Tag).to receive(:rpc).and_return(rpc)
   }
   after { allow(Tag).to receive(:rpc).and_call_original }
 
@@ -61,7 +61,7 @@ describe ActiveRemote::Persistence do
       let(:error) { Generic::Error.new(:field => 'name', :message => 'Boom!') }
       let(:response) { Generic::Remote::Tag.new(:errors => [ error ]) }
 
-      before { rpc.better_stub(:execute).and_return(response) }
+      before { allow(rpc).to receive(:execute).and_return(response) }
 
       it "adds the errors to the record" do
         subject.delete
@@ -84,7 +84,7 @@ describe ActiveRemote::Persistence do
       let(:error) { Generic::Error.new(:field => 'name', :message => 'Boom!') }
       let(:response) { Generic::Remote::Tag.new(:errors => [ error ]) }
 
-      before { rpc.better_stub(:execute).and_return(response) }
+      before { allow(rpc).to receive(:execute).and_return(response) }
 
       it "raises an exception" do
         expect { subject.delete! }.to raise_error(ActiveRemote::ActiveRemoteError)
@@ -109,7 +109,7 @@ describe ActiveRemote::Persistence do
       let(:error) { Generic::Error.new(:field => 'name', :message => 'Boom!') }
       let(:response) { Generic::Remote::Tag.new(:errors => [ error ]) }
 
-      before { rpc.better_stub(:execute).and_return(response) }
+      before { allow(rpc).to receive(:execute).and_return(response) }
 
       it "adds the errors to the record" do
         subject.destroy
@@ -132,7 +132,7 @@ describe ActiveRemote::Persistence do
       let(:error) { Generic::Error.new(:field => 'name', :message => 'Boom!') }
       let(:response) { Generic::Remote::Tag.new(:errors => [ error ]) }
 
-      before { rpc.better_stub(:execute).and_return(response) }
+      before { allow(rpc).to receive(:execute).and_return(response) }
 
       it "raises an exception" do
         expect { subject.destroy! }.to raise_error(ActiveRemote::ActiveRemoteError)
@@ -199,6 +199,7 @@ describe ActiveRemote::Persistence do
 
   describe "#save" do
     it "runs save callbacks" do
+      allow(subject).to receive(:run_callbacks).with(:validation).and_return(true)
       expect(subject).to receive(:run_callbacks).with(:save)
       subject.save
     end
@@ -226,14 +227,14 @@ describe ActiveRemote::Persistence do
 
     context "when the record is saved" do
       it "returns true" do
-        subject.better_stub(:has_errors?) { false }
+        allow(subject).to receive(:has_errors?) { false }
         expect(subject.save).to be_truthy
       end
     end
 
     context "when the record is not saved" do
       it "returns false" do
-        subject.better_stub(:has_errors?) { true }
+        allow(subject).to receive(:has_errors?) { true }
         expect(subject.save).to be_falsey
       end
     end
@@ -282,6 +283,36 @@ describe ActiveRemote::Persistence do
     end
   end
 
+  describe "#update_attribute" do
+    let(:tag) { Tag.allocate.instantiate({:guid => "123"}) }
+
+    before { allow(Tag.rpc).to receive(:execute).and_return(HashWithIndifferentAccess.new) }
+    after { allow(Tag.rpc).to receive(:execute).and_call_original }
+
+    it "runs update callbacks" do
+      expect(tag).to receive(:after_update_callback)
+      tag.update_attribute(:name, "foo")
+    end
+
+    it "updates a remote record" do
+      expect(Tag.rpc).to receive(:execute).with(:update, tag.scope_key_hash)
+      tag.update_attribute(:name, "foo")
+    end
+
+    before { allow(subject).to receive(:save) }
+    after { allow(subject).to receive(:save).and_call_original }
+
+    it "assigns new attributes" do
+      expect(subject).to receive(:name=).with("foo")
+      subject.update_attribute(:name, "foo")
+    end
+
+    it "saves the record" do
+      expect(subject).to receive(:save)
+      subject.update_attribute(:name, "foo")
+    end
+  end
+
   describe "#update_attributes" do
     let(:attributes) { HashWithIndifferentAccess.new(:name => 'bar') }
     let(:tag) { Tag.allocate.instantiate({:guid => "123"}) }

data/spec/lib/active_remote/rpc_spec.rb

@@ -9,8 +9,8 @@ describe ActiveRemote::RPC do
 
     let(:rpc) { ::ActiveRemote::RPCAdapters::ProtobufAdapter.new(::Tag.service_class) }
 
-    before { rpc.better_stub(:execute).and_return(response) }
-    before { ::Tag.better_stub(:rpc).and_return(rpc) }
+    before { allow(rpc).to receive(:execute).and_return(response) }
+    before { allow(::Tag).to receive(:rpc).and_return(rpc) }
 
     it "calls the given RPC method" do
       expect(Tag.rpc).to receive(:execute).with(:remote_method, args)

data/spec/lib/active_remote/scope_keys_spec.rb

@@ -17,7 +17,7 @@ describe ActiveRemote::ScopeKeys do
   end
 
   describe ".scope_keys" do
-    before { Tag.better_stub(:_scope_keys).and_return(_scope_keys) }
+    before { allow(Tag).to receive(:_scope_keys).and_return(_scope_keys) }
 
     it "combines primary key with _scope_keys" do
       expect(Tag.scope_keys).to eq(['guid'] + _scope_keys)
@@ -33,7 +33,7 @@ describe ActiveRemote::ScopeKeys do
   describe "#scope_key_hash" do
     let(:scope_key_hash) { { 'guid' => 'TAG-123', 'user_guid' => 'USR-123' } }
 
-    before { tag.better_stub(:scope_keys).and_return(scope_keys) }
+    before { allow(tag).to receive(:scope_keys).and_return(scope_keys) }
 
     it "returns a attribute hash of scope_keys" do
       expect(tag.scope_key_hash).to eq(scope_key_hash)

data/spec/lib/active_remote/search_spec.rb

@@ -43,8 +43,8 @@ describe ActiveRemote::Search do
       let(:args) { Hash.new }
       let(:rpc) { ::ActiveRemote::RPCAdapters::ProtobufAdapter.new(::Tag.service_class) }
 
-      before { rpc.better_stub(:execute).and_return(response) }
-      before { ::Tag.better_stub(:rpc).and_return(rpc) }
+      before { allow(rpc).to receive(:execute).and_return(response) }
+      before { allow(::Tag).to receive(:rpc).and_return(rpc) }
 
       it "searches with the given args" do
         expect(Tag.rpc).to receive(:execute).with(:search, args)
@@ -60,7 +60,7 @@ describe ActiveRemote::Search do
       let(:request) { double(:request) }
 
       it "raises an exception" do
-        expect { described_class.search(request) }.to raise_exception
+        expect { Tag.search(request) }.to raise_error(::RuntimeError, /Invalid parameter/)
       end
     end
   end
@@ -72,7 +72,7 @@ describe ActiveRemote::Search do
 
     before {
       allow(rpc).to receive(:execute).and_return(response)
-      Tag.better_stub(:rpc).and_return(rpc)
+      allow(Tag).to receive(:rpc).and_return(rpc)
     }
 
     it "runs callbacks" do
@@ -92,10 +92,10 @@ describe ActiveRemote::Search do
 
     subject { Tag.new(args) }
 
-    before { Tag.better_stub(:find).and_return(attributes) }
+    before { allow(Tag).to receive(:find).and_return(Tag.new(attributes)) }
 
     it "reloads the record" do
-      Tag.better_receive(:find).with(subject.scope_key_hash)
+      expect(Tag).to receive(:find).with(subject.scope_key_hash)
       subject.reload
     end
 

data/spec/lib/active_remote/serialization_spec.rb

@@ -39,7 +39,7 @@ describe ActiveRemote::Serialization do
       let(:response) { Generic::Remote::Tag.new(:errors => [ error ]) }
 
       it "adds errors to the active remote object" do
-        subject.better_receive(:add_errors).with(response.errors)
+        expect(subject).to receive(:add_errors).with(response.errors)
         subject.add_errors_from_response(response)
       end
     end
@@ -48,7 +48,7 @@ describe ActiveRemote::Serialization do
       let(:response_without_errors) { double(:response_without_errors) }
 
       it "does not add errors" do
-        subject.better_not_receive(:add_errors)
+        expect(subject).to_not receive(:add_errors)
         subject.add_errors_from_response(response_without_errors)
       end
     end

data/spec/spec_helper.rb

@@ -17,4 +17,13 @@ require 'support/models'
 
 RSpec.configure do |config|
   config.include Protobuf::RSpec::Helpers
+
+  # Turn deprecation warnings into errors with full backtrace.
+  config.raise_errors_for_deprecations!
+
+  # Verifies the existance of any stubbed methods, replaces better_receive and better_stub
+  # https://www.relishapp.com/rspec/rspec-mocks/v/3-1/docs/verifying-doubles/partial-doubles
+  config.mock_with :rspec do |mocks|
+    mocks.verify_partial_doubles = true
+  end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: active_remote
 version: !ruby/object:Gem::Version
-  version: 2.2.0
+  version: 2.3.0
 platform: ruby
 authors:
 - Adam Hutchison
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-05-14 00:00:00.000000000 Z
+date: 2016-06-09 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: active_attr
@@ -52,20 +52,6 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '3.0'
-- !ruby/object:Gem::Dependency
-  name: better_receive
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
@@ -86,14 +72,14 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 3.3.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 3.3.0
 - !ruby/object:Gem::Dependency
   name: rspec-its
   requirement: !ruby/object:Gem::Requirement
@@ -114,14 +100,14 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 3.1.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 3.1.0
 - !ruby/object:Gem::Dependency
   name: pry
   requirement: !ruby/object:Gem::Requirement
@@ -142,14 +128,14 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '1.0'
+        version: 1.1.2
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '1.0'
+        version: 1.1.2
 - !ruby/object:Gem::Dependency
   name: simplecov
   requirement: !ruby/object:Gem::Requirement
@@ -264,7 +250,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.6
+rubygems_version: 2.5.1
 signing_key: 
 specification_version: 4
 summary: Active Record for your platform