active_remote 2.1.0.rc1 → 2.1.0.rc2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 9db0dc04521916e66ca566f9ece9b5f0cc8e803e
-  data.tar.gz: aea18e2d9200b988918570898a95fb0a47ed15aa
+  metadata.gz: 4ad2b0b5cc487a370172d15c33f1a09fdc81e676
+  data.tar.gz: 5f61ffc37e948bdb97ee80290c8f74c4193cdf35
 SHA512:
-  metadata.gz: bead40af9673772592780b3a7b62252815fcd0805e2988a5d7d4b6f9d2a3eb32975e3fd2b50f1937096d32c1c053ae5ff8567959861f5c87aeac01cdd27b0b57
-  data.tar.gz: 56d7903986b4bbb33a3c703a833441d44dd76210a560bb48c9e12d72ac9fff3da23276ba3958752d4b8a8b30507f0c44185c4a57fa289c3fbf89dc20698ce330
+  metadata.gz: 3447b324f221b6d18b1470ea1661222bc0afe04629ae6e6f137f5642c7f5ca7f2dac2f2f58825e1f698be6b721e025dd3780413fca8a75f1b0939ef9f6b7b61b
+  data.tar.gz: 17ba0f511feebdd491a69f54c0386fb1a919e91577b76a6ab3bee29d5c119c1ce0d0c18fb2059d4fe382cec63df670b605ccdc2cb4b9cee45e08425d2a7f1748

data/lib/active_remote/persistence.rb

@@ -78,7 +78,7 @@ module ActiveRemote
       raise ReadOnlyRemoteRecord if readonly?
       response = rpc.execute(:delete, scope_key_hash)
 
-      add_errors(response.errors)
+      add_errors_from_response(response)
 
       return success? ? freeze : false
     end
@@ -103,7 +103,7 @@ module ActiveRemote
       raise ReadOnlyRemoteRecord if readonly?
       response = rpc.execute(:destroy, scope_key_hash)
 
-      add_errors(response.errors)
+      add_errors_from_response(response)
 
       return success? ? freeze : false
     end
@@ -234,7 +234,7 @@ module ActiveRemote
         response = rpc.execute(:create, new_attributes)
 
         assign_attributes(response.to_hash)
-        add_errors(response.errors)
+        add_errors_from_response(response)
 
         @new_record = has_errors?
         success?
@@ -264,7 +264,7 @@ module ActiveRemote
         response = rpc.execute(:update, updated_attributes)
 
         assign_attributes(response.to_hash)
-        add_errors(response.errors)
+        add_errors_from_response(response)
 
         success?
       end

data/lib/active_remote/serialization.rb

@@ -22,8 +22,7 @@ module ActiveRemote
       end
     end
 
-    # Examine the given response and add any errors to our internal errors
-    # list.
+    # Add the given errors to our internal errors list
     #
     # ====Examples
     #
@@ -43,12 +42,20 @@ module ActiveRemote
       end
     end
 
-    # DEPRECATED – Use :add_errors instead
+    # Examine the given response and add any errors to our internal errors
+    # list.
+    #
+    # ====Examples
+    #
+    #   response = remote_call(:action_that_returns_errors, { :stuff => 'foo' })
+    #
+    #   add_errors_from_response(response)
     #
     def add_errors_from_response(response = nil)
-      warn 'DEPRECATED Model#add_errors_from_response is deprecated and will be removed in Active Remote 3.0. Use Model#add_errors instead'
-
-      response ||= last_response
+      unless response
+        warn 'DEPRECATED calling Model#add_errors_from_response without args is deprecated and will be removed in Active Remote 3.0.'
+        response = last_response
+      end
 
       add_errors(response.errors) if response.respond_to?(:errors)
     end

data/lib/active_remote/version.rb

@@ -1,3 +1,3 @@
 module ActiveRemote
-  VERSION = "2.1.0.rc1"
+  VERSION = "2.1.0.rc2"
 end

data/spec/lib/active_remote/serialization_spec.rb

@@ -30,4 +30,27 @@ describe ActiveRemote::Serialization do
       end
     end
   end
+
+  describe "#add_errors_from_response" do
+    subject { Tag.new }
+
+    context "when the response responds to :errors" do
+      let(:error) { Generic::Error.new(:field => 'name', :message => 'Boom!') }
+      let(:response) { Generic::Remote::Tag.new(:errors => [ error ]) }
+
+      it "adds errors to the active remote object" do
+        subject.better_receive(:add_errors).with(response.errors)
+        subject.add_errors_from_response(response)
+      end
+    end
+
+    context "when the response does not respond to :errors" do
+      let(:response_without_errors) { double(:response_without_errors) }
+
+      it "does not add errors" do
+        subject.better_not_receive(:add_errors)
+        subject.add_errors_from_response(response_without_errors)
+      end
+    end
+  end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: active_remote
 version: !ruby/object:Gem::Version
-  version: 2.1.0.rc1
+  version: 2.1.0.rc2
 platform: ruby
 authors:
 - Adam Hutchison
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-03-12 00:00:00.000000000 Z
+date: 2014-03-17 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: active_attr