active_remote 1.3.3 → 1.4.0

data/lib/active_remote/association.rb

@@ -38,10 +38,10 @@ module ActiveRemote
       #   end
       #
       def belongs_to(belongs_to_klass, options={})
-        perform_association( belongs_to_klass, options ) do |klass, obj|
+        perform_association(belongs_to_klass, options) do |klass, object|
           foreign_key = options.fetch(:foreign_key) { :"#{belongs_to_klass}_guid" }
-          association_guid = obj.read_attribute(foreign_key)
-          klass.search(:guid => association_guid).first
+          association_guid = object.read_attribute(foreign_key)
+          klass.search(:guid => association_guid).first if association_guid
         end
       end
 
@@ -76,9 +76,9 @@ module ActiveRemote
       #   end
       #
       def has_many(has_many_class, options={})
-        perform_association( has_many_class, options ) do |klass, obj|
-          foreign_key = options.fetch(:foreign_key) { :"#{obj.class.name.demodulize.underscore}_guid" }
-          klass.search(foreign_key => obj.guid)
+        perform_association( has_many_class, options ) do |klass, object|
+          foreign_key = options.fetch(:foreign_key) { :"#{object.class.name.demodulize.underscore}_guid" }
+          object.guid ? klass.search(foreign_key => object.guid) : []
         end
       end
 
@@ -112,9 +112,9 @@ module ActiveRemote
       #   end
       #
       def has_one(has_one_klass, options={})
-        perform_association( has_one_klass, options ) do |klass, obj|
-          foreign_key = options.fetch(:foreign_key) { :"#{obj.class.name.demodulize.underscore}_guid" }
-          klass.search(foreign_key => obj.guid).first
+        perform_association(has_one_klass, options) do |klass, object|
+          foreign_key = options.fetch(:foreign_key) { :"#{object.class.name.demodulize.underscore}_guid" }
+          klass.search(foreign_key => object.guid).first if object.guid
         end
       end
 

data/lib/active_remote/dirty.rb

@@ -51,6 +51,15 @@ module ActiveRemote
       end
     end
 
+    # Override #write_attribute (along with #[]=) so we can provide support for
+    # ActiveModel::Dirty.
+    #
+    def write_attribute(name, value)
+      __send__("#{name}_will_change!") unless value == self[name]
+      super
+    end
+    alias_method :[]=, :write_attribute
+
   private
 
     # Override ActiveAttr's attribute= method so we can provide support for

data/lib/active_remote/version.rb

@@ -1,3 +1,3 @@
 module ActiveRemote
-  VERSION = "1.3.3"
+  VERSION = "1.4.0"
 end

data/spec/lib/active_remote/association_spec.rb

@@ -1,144 +1,168 @@
-require 'spec_helper'
+require "spec_helper"
 
 describe ActiveRemote::Association do
   let(:record) { double(:record) }
   let(:records) { [ record ] }
 
-  describe '.belongs_to' do
-
-    context 'simple association' do
-      let(:author_guid) { 'AUT-123' }
+  describe ".belongs_to" do
+    context "simple association" do
+      let(:author_guid) { "AUT-123" }
 
       subject { Post.new(:author_guid => author_guid) }
+
       it { should respond_to(:author) }
 
-      it 'searches the associated model for a single record' do
+      it "searches the associated model for a single record" do
         Author.should_receive(:search).with(:guid => subject.author_guid).and_return(records)
         subject.author.should eq record
       end
 
-      it 'memoizes the result record' do
+      it "memoizes the result record" do
         Author.should_receive(:search).once.with(:guid => subject.author_guid).and_return(records)
         3.times { subject.author.should eq record }
       end
 
-      context 'when the search is empty' do
-        it 'returns a nil' do
+      context "when guid is nil" do
+        subject { Post.new }
+
+        it "returns nil" do
+          subject.author.should be_nil
+        end
+      end
+
+      context "when the search is empty" do
+        it "returns a nil" do
           Author.should_receive(:search).with(:guid => subject.author_guid).and_return([])
           subject.author.should be_nil
         end
       end
     end
 
-    context 'specific association with class name' do
-      let(:author_guid) { 'AUT-456' }
+    context "specific association with class name" do
+      let(:author_guid) { "AUT-456" }
 
       subject { Post.new(:author_guid => author_guid) }
       it { should respond_to(:coauthor) }
 
-      it 'searches the associated model for a single record' do
+      it "searches the associated model for a single record" do
         Author.should_receive(:search).with(:guid => subject.author_guid).and_return(records)
         subject.author.should eq record
       end
     end
 
-    context 'specific association with class name and foreign_key' do
-      let(:author_guid) { 'AUT-456' }
+    context "specific association with class name and foreign_key" do
+      let(:author_guid) { "AUT-456" }
 
       subject { Post.new(:author_guid => author_guid) }
       it { should respond_to(:bestseller) }
 
-      it 'searches the associated model for a single record' do
+      it "searches the associated model for a single record" do
         Author.should_receive(:search).with(:guid => subject.bestseller_guid).and_return(records)
         subject.author.should eq record
       end
     end
-
   end
 
-  describe '.has_many' do
+  describe ".has_many" do
     let(:records) { [ record, record, record ] }
-    let(:guid) { 'AUT-123' }
+    let(:guid) { "AUT-123" }
 
     subject { Author.new(:guid => guid) }
+
     it { should respond_to(:posts) }
 
-    it 'searches the associated model for all associated records' do
+    it "searches the associated model for all associated records" do
       Post.should_receive(:search).with(:author_guid => subject.guid).and_return(records)
       subject.posts.should eq records
     end
 
-    it 'memoizes the result record' do
+    it "memoizes the result record" do
       Post.should_receive(:search).once.with(:author_guid => subject.guid).and_return(records)
       3.times { subject.posts.should eq records }
     end
 
-    context 'when the search is empty' do
-      it 'returns the empty set' do
+    context "when guid is nil" do
+      subject { Author.new }
+
+      it "returns []" do
+        subject.posts.should eq []
+      end
+    end
+
+    context "when the search is empty" do
+      it "returns the empty set" do
         Post.should_receive(:search).with(:author_guid => subject.guid).and_return([])
         subject.posts.should be_empty
       end
     end
 
-    context 'specific association with class name' do
+    context "specific association with class name" do
       it { should respond_to(:flagged_posts) }
 
-      it 'searches the associated model for a single record' do
+      it "searches the associated model for a single record" do
         Post.should_receive(:search).with(:author_guid => subject.guid).and_return([])
         subject.flagged_posts.should be_empty
       end
     end
 
-    context 'specific association with class name and foreign_key' do
+    context "specific association with class name and foreign_key" do
       it { should respond_to(:bestseller_posts) }
 
-      it 'searches the associated model for multiple record' do
+      it "searches the associated model for multiple record" do
         Post.should_receive(:search).with(:bestseller_guid => subject.guid).and_return(records)
         subject.bestseller_posts.should eq(records)
       end
     end
   end
 
-  describe '.has_one' do
-    let(:guid) { 'PST-123' }
+  describe ".has_one" do
+    let(:guid) { "PST-123" }
 
     subject { Post.new(:guid => guid) }
+
     it { should respond_to(:category) }
 
-    it 'searches the associated model for all associated records' do
+    it "searches the associated model for all associated records" do
       Category.should_receive(:search).with(:post_guid => subject.guid).and_return(records)
       subject.category.should eq record
     end
 
-    it 'memoizes the result record' do
+    it "memoizes the result record" do
       Category.should_receive(:search).once.with(:post_guid => subject.guid).and_return(records)
       3.times { subject.category.should eq record }
     end
 
-    context 'when the search is empty' do
-      it 'returns a nil value' do
+    context "when guid is nil" do
+      subject { Post.new }
+
+      it "returns nil" do
+        subject.category.should be_nil
+      end
+    end
+
+    context "when the search is empty" do
+      it "returns a nil value" do
         Category.should_receive(:search).with(:post_guid => subject.guid).and_return([])
         subject.category.should be_nil
       end
     end
 
-    context 'specific association with class name' do
+    context "specific association with class name" do
       it { should respond_to(:main_category) }
 
-      it 'searches the associated model for a single record' do
+      it "searches the associated model for a single record" do
         Category.should_receive(:search).with(:post_guid => subject.guid).and_return(records)
         subject.main_category.should eq record
       end
     end
 
-    context 'specific association with class name and foreign_key' do
+    context "specific association with class name and foreign_key" do
       it { should respond_to(:default_category) }
 
-      it 'searches the associated model for a single record' do
+      it "searches the associated model for a single record" do
         Category.should_receive(:search).with(:template_post_guid => subject.guid).and_return(records)
         subject.default_category.should eq record
       end
     end
   end
-
 end

data/spec/lib/active_remote/dirty_spec.rb

@@ -0,0 +1,105 @@
+require 'spec_helper'
+
+describe ActiveRemote::Dirty do
+  context "when writing attributes through the setter" do
+    subject { Post.new(:name => 'foo') }
+
+    before {
+      subject.previous_changes.try(:clear)
+      subject.changed_attributes.try(:clear)
+    }
+
+    context "when the value changes" do
+      before { subject.name = 'bar' }
+
+      its(:name_changed?) { should be_true }
+    end
+
+    context "when the value doesn't change" do
+      before { subject.name = 'foo' }
+
+      its(:name_changed?) { should be_false }
+    end
+  end
+
+  context "when writing attributes directly" do
+    subject { Post.new(:name => 'foo') }
+
+    before {
+      subject.previous_changes.try(:clear)
+      subject.changed_attributes.try(:clear)
+    }
+
+    context "when the value changes" do
+      before { subject[:name] = 'bar' }
+
+      its(:name_changed?) { should be_true }
+    end
+
+    context "when the value doesn't change" do
+      before { subject[:name] = 'foo' }
+
+      its(:name_changed?) { should be_false }
+    end
+  end
+
+  describe "#reload" do
+    subject { Post.new(:name => 'foo') }
+
+    before {
+      subject.stub(:last_response).and_return({})
+      subject.stub(:execute)
+      subject.reload
+    }
+
+    its(:changes) { should be_empty }
+  end
+
+  describe "#save" do
+    let!(:changes) { subject.changes }
+
+    subject { Post.new(:name => 'foo') }
+
+    before {
+      subject.stub(:create_or_update).and_return(true)
+      subject.save
+    }
+
+    its(:previous_changes) { should eq changes }
+    its(:changes) { should be_empty }
+  end
+
+  describe "#save!" do
+    let!(:changes) { subject.changes }
+
+    subject { Post.new(:name => 'foo') }
+
+    before {
+      subject.stub(:save).and_return(true)
+      subject.save!
+    }
+
+    its(:previous_changes) { should eq changes }
+    its(:changes) { should be_empty }
+  end
+
+  describe "#serialize_records" do
+    let(:post) { Post.new }
+    let(:record) { ::Generic::Remote::Post.new(:name => 'foo') }
+    let(:response) { double(:response, :records => [ record ]) }
+
+    before {
+      post.stub(:last_response).and_return(response)
+    }
+
+    it "clears previous changes" do
+      records = post.serialize_records
+      records.first.previous_changes.should be_nil
+    end
+
+    it "clears changes" do
+      records = post.serialize_records
+      records.first.changes.should be_empty
+    end
+  end
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: active_remote
 version: !ruby/object:Gem::Version
-  version: 1.3.3
+  version: 1.4.0
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-01-27 00:00:00.000000000 Z
+date: 2013-02-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: active_attr
@@ -178,6 +178,7 @@ files:
 - spec/lib/active_remote/association_spec.rb
 - spec/lib/active_remote/base_spec.rb
 - spec/lib/active_remote/bulk_spec.rb
+- spec/lib/active_remote/dirty_spec.rb
 - spec/lib/active_remote/dsl_spec.rb
 - spec/lib/active_remote/persistence_spec.rb
 - spec/lib/active_remote/rpc_spec.rb
@@ -218,7 +219,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: 432433655534443133
+      hash: -2137387569376097013
 required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
   requirements:
@@ -227,7 +228,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: 432433655534443133
+      hash: -2137387569376097013
 requirements: []
 rubyforge_project: 
 rubygems_version: 1.8.24
@@ -239,6 +240,7 @@ test_files:
 - spec/lib/active_remote/association_spec.rb
 - spec/lib/active_remote/base_spec.rb
 - spec/lib/active_remote/bulk_spec.rb
+- spec/lib/active_remote/dirty_spec.rb
 - spec/lib/active_remote/dsl_spec.rb
 - spec/lib/active_remote/persistence_spec.rb
 - spec/lib/active_remote/rpc_spec.rb