active_record_survey 0.1.0 → 0.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 240ce460ae63c7c51f4a360cbe24280df0b5f502
-  data.tar.gz: 9420ee37dc83a9cc95e8dbfaa245129671b4443b
+  metadata.gz: dd8d08ee8e2a5a3187e5c5aa11eee88f01f32768
+  data.tar.gz: caffbf9c42a143567168a2d2dae25bc439d06173
 SHA512:
-  metadata.gz: 1add51d1fc6436ac5060a9de61af79d0778169dc7432b01939595cb898a9c9b043e7325dccb05c2d3a6b87791713b1228face4ee1b7c9fdf616a88c84b8a5ab9
-  data.tar.gz: 8e008c6a8f146e3e705d6ddd789945b10460d759a617a71d5f397f7b4638367ecb555aaff1ccc076ba83df3c157e74784056f504f2525a198d58ee44eb20178b
+  metadata.gz: fa4a3bd1c105be6a800f57b94c5cd508f2dac3f73a4dcfb4878173627ef91a666900d1271dd9c362d1661b955e283eefb1f100b8555bb4c28b9e882f825c9a23
+  data.tar.gz: 9b75335474d05f2b7aac0c9fffd60ca02b48bb30f2dab8e3aff5614747bc11e91dc775e12307ead5ec3b197dc5a4df1eb0e93890f26fca6ffd25a9783f84df8b

data/README.md

@@ -1,3 +1,6 @@
+[![Gem Version](https://badge.fury.io/rb/active_record_survey.svg)](http://badge.fury.io/rb/active_record_survey)
+[![Build Status](https://travis-ci.org/butchmarshall/active_record_survey.svg?branch=master)](https://travis-ci.org/butchmarshall/active_record_survey)
+
 # ActiveRecordSurvey
 
 An attempt at a more versatile data structure for making and taking surveys.

data/lib/active_record_survey.rb

@@ -13,6 +13,8 @@ require "active_record_survey/node"
 require "active_record_survey/node/question"
 require "active_record_survey/node/answer"
 require "active_record_survey/node/answer/text"
+require "active_record_survey/node/answer/rank"
+require "active_record_survey/node/answer/scale"
 require "active_record_survey/node/answer/boolean"
 
 require "active_record_survey/node_map"

data/lib/active_record_survey/node.rb

@@ -6,7 +6,9 @@ module ActiveRecordSurvey
 
 		# By default all values are accepted
 		def validate_instance_node(instance_node)
-			true
+			!self.node_validations.collect { |node_validation|
+				node_validation.validate_instance_node(instance_node, self)
+			}.include?(false)
 		end
 
 		# Whether there is a valid answer path from this node to the root node for the instance

data/lib/active_record_survey/node/answer/boolean.rb

@@ -3,6 +3,8 @@ module ActiveRecordSurvey
 	class Node::Answer::Boolean < Node::Answer
 		# Only boolean values
 		def validate_instance_node(instance_node)
+			# super - all validations on this node pass
+			super &&
 			!instance_node.value.to_s.match(/^[0|1]$/).nil?
 		end
 	end

data/lib/active_record_survey/node/answer/rank.rb

@@ -0,0 +1,12 @@
+module ActiveRecordSurvey
+	# Rank in relation to parent/children
+	class Node::Answer::Rank < Node::Answer
+		# Accept integer or empty values
+		def validate_instance_node(instance_node)
+			# super - all validations on this node pass
+			super &&
+			(instance_node.value.to_s.empty? ||
+			!instance_node.value.to_s.match(/^\d+$/).nil?)
+		end
+	end
+end

data/lib/active_record_survey/node/answer/scale.rb

@@ -1,5 +1,11 @@
 module ActiveRecordSurvey
 	# Can hold a value on a scale (e.g. from 0-10)
 	class Node::Answer::Scale < Node::Answer
+		# Accept integer, float, or empty values
+		def validate_instance_node(instance_node)
+			# super - all validations on this node pass
+			super &&
+			(instance_node.value.to_s.empty? || !instance_node.value.to_s.match(/^(\d+(\.\d+)?)$/).nil?)
+		end
 	end
 end

data/lib/active_record_survey/node_validation.rb

@@ -3,5 +3,10 @@ module ActiveRecordSurvey
 	class NodeValidation < ::ActiveRecord::Base
 		self.table_name = "active_record_survey_node_validations"
 		belongs_to :node, :class_name => "ActiveRecordSurvey::Node", :foreign_key => :active_record_survey_node_id
+		
+		# By default everything is valid! WOOO!
+		def validate_instance_node(instance_node, node = nil)
+			true
+		end
 	end
 end

data/lib/active_record_survey/node_validation/maximum_length.rb

@@ -1,4 +1,9 @@
 module ActiveRecordSurvey
-	class NodeValidation::MaximumLength < Node
+	# Ensure the instance_node has a length less than the maximum
+	class NodeValidation::MaximumLength < NodeValidation
+		# Validate the instance_node value
+		def validate_instance_node(instance_node, node = nil)
+			instance_node.value.to_s.length <= self.value.to_i
+		end
 	end
 end

data/lib/active_record_survey/node_validation/maximum_value.rb

@@ -1,4 +1,10 @@
 module ActiveRecordSurvey
-	class NodeValidation::MaximumValue < Node
+	# Ensure the instance_node has a value less than the maximum
+	class NodeValidation::MaximumValue < NodeValidation
+		# Validate the instance_node value is less than the maximum
+		def validate_instance_node(instance_node, node = nil)
+			!instance_node.value.to_s.empty? &&
+			instance_node.value.to_f <= self.value.to_f
+		end
 	end
 end

data/lib/active_record_survey/node_validation/minimum_length.rb

@@ -1,4 +1,9 @@
 module ActiveRecordSurvey
-	class NodeValidation::MinimumLength < Node
+	# Ensure the instance_node has a value greater than the minimum
+	class NodeValidation::MinimumLength < NodeValidation
+		# Validate the instance_node value is greater than the minimum
+		def validate_instance_node(instance_node, node = nil)
+			instance_node.value.to_s.length >= self.value.to_i
+		end
 	end
 end

data/lib/active_record_survey/node_validation/minimum_value.rb

@@ -1,4 +1,10 @@
 module ActiveRecordSurvey
-	class NodeValidation::MinimumValue < Node
+	# Ensure the instance_node has a value greater than the minimum
+	class NodeValidation::MinimumValue < NodeValidation
+		# Validate the instance_node value is greater than the minimum
+		def validate_instance_node(instance_node, node = nil)
+			!instance_node.value.to_s.empty? &&
+			instance_node.value.to_f >= self.value.to_f
+		end
 	end
 end

data/lib/active_record_survey/version.rb

@@ -1,3 +1,3 @@
 module ActiveRecordSurvey
-	VERSION = "0.1.0"
+	VERSION = "0.1.1"
 end

data/spec/active_record_survey/node/answer/boolean_spec.rb

@@ -1,6 +1,6 @@
 require 'spec_helper'
 
-describe ActiveRecordSurvey::Node::Answer::Boolean, :focus => true do
+describe ActiveRecordSurvey::Node::Answer::Boolean do
 	describe 'a boolean survey is' do
 		before(:all) do
 			@survey = ActiveRecordSurvey::Survey.new

data/spec/active_record_survey/node/answer/scale_spec.rb

@@ -0,0 +1,159 @@
+require 'spec_helper'
+
+describe ActiveRecordSurvey::Node::Answer::Scale, :focus => true do
+	describe 'survey is' do
+		before(:all) do
+			@survey = ActiveRecordSurvey::Survey.new
+
+			@q1 = ActiveRecordSurvey::Node::Question.new(:text => "Please select one")
+			@q1_a1 = ActiveRecordSurvey::Node::Answer::Scale.new(:text => "How much do you like dogs?")
+			@q1_a2 = ActiveRecordSurvey::Node::Answer::Scale.new(:text => "How much do you like cats?")
+			@q1_a3 = ActiveRecordSurvey::Node::Answer::Scale.new(:text => "How much do you like mice?")
+
+			nodes = @survey.build_question(@q1, [@q1_a1])
+			nodes = @survey.build_question(@q1_a2, [], nodes[1])
+			nodes = @survey.build_question(@q1_a3, [], nodes[0])
+
+			@survey.save
+		end
+
+		describe 'valid when' do
+			it 'accepts an integer value' do
+				instance = ActiveRecordSurvey::Instance.new(:survey => @survey)
+				instance.instance_nodes.build(
+					:instance => instance,
+					:node => @q1_a1,
+					:value => 100
+				)
+				instance.save
+
+				expect(instance.valid?).to be(true)
+			end
+
+			it 'accepts a float value' do
+				instance = ActiveRecordSurvey::Instance.new(:survey => @survey)
+				instance.instance_nodes.build(
+					:instance => instance,
+					:node => @q1_a1,
+					:value => 10.5
+				)
+				instance.save
+
+				expect(instance.valid?).to be(true)
+			end
+
+			it 'accepts an empty value' do
+				instance = ActiveRecordSurvey::Instance.new(:survey => @survey)
+				instance.instance_nodes.build(
+					:instance => instance,
+					:node => @q1_a1,
+				)
+				instance.save
+
+				expect(instance.valid?).to be(true)
+			end
+
+			describe ActiveRecordSurvey::NodeValidation::MinimumValue do
+				describe 'valid when' do
+					it 'has a value greater than the minimum' do
+						@q1_a1.node_validations << ActiveRecordSurvey::NodeValidation::MinimumValue.new(
+							:node => @q1_a1,
+							:value => 4
+						)
+						instance = ActiveRecordSurvey::Instance.new(:survey => @survey)
+						instance.instance_nodes.build(
+							:instance => instance,
+							:node => @q1_a1,
+							:value => 5,
+						)
+						instance.save
+		
+						expect(instance.valid?).to be(true)
+					end
+				end
+
+				describe 'invalid when' do
+					it 'has a value less than the minimum' do
+						@q1_a1.node_validations << ActiveRecordSurvey::NodeValidation::MinimumValue.new(
+							:node => @q1_a1,
+							:value => 6
+						)
+						instance = ActiveRecordSurvey::Instance.new(:survey => @survey)
+						instance.instance_nodes.build(
+							:instance => instance,
+							:node => @q1_a1,
+							:value => 5,
+						)
+						instance.save
+
+						expect(instance.valid?).to be(false)
+					end
+				end
+			end
+
+			describe ActiveRecordSurvey::NodeValidation::MaximumValue do
+				describe 'valid when' do
+					it 'has a value less than the maximum' do
+						@q1_a1.node_validations << ActiveRecordSurvey::NodeValidation::MaximumValue.new(
+							:node => @q1_a1,
+							:value => 15
+						)
+						instance = ActiveRecordSurvey::Instance.new(:survey => @survey)
+						instance.instance_nodes.build(
+							:instance => instance,
+							:node => @q1_a1,
+							:value => 8,
+						)
+						instance.save
+
+						expect(instance.valid?).to be(true)
+					end
+				end
+
+				describe 'invalid when' do
+					it 'has a value greater than the maximum' do
+						@q1_a1.node_validations << ActiveRecordSurvey::NodeValidation::MaximumValue.new(
+							:node => @q1_a1,
+							:value => 15
+						)
+						instance = ActiveRecordSurvey::Instance.new(:survey => @survey)
+						instance.instance_nodes.build(
+							:instance => instance,
+							:node => @q1_a1,
+							:value => 20,
+						)
+						instance.save
+
+						expect(instance.valid?).to be(false)
+					end
+				end
+			end
+		end
+
+		describe 'invalid when' do
+			it 'rejects an alphabetical value' do
+				instance = ActiveRecordSurvey::Instance.new(:survey => @survey)
+				instance.instance_nodes.build(
+					:instance => instance,
+					:node => @q1_a1,
+					:value => "1a2"
+				)
+				instance.save
+
+				expect(instance.valid?).to be(false)
+			end
+
+			it 'rejects when not answered in order' do
+				instance = ActiveRecordSurvey::Instance.new(:survey => @survey)
+				instance.instance_nodes.build(
+					:instance => instance,
+					:node => @q1_a2,
+					:value => 20
+				)
+				instance.save
+
+				expect(instance.valid?).to be(false)
+			end
+		end
+	end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: active_record_survey
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.1.1
 platform: ruby
 authors:
 - Butch Marshall
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-09-23 00:00:00.000000000 Z
+date: 2015-09-24 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
@@ -126,6 +126,7 @@ files:
 - lib/active_record_survey/node.rb
 - lib/active_record_survey/node/answer.rb
 - lib/active_record_survey/node/answer/boolean.rb
+- lib/active_record_survey/node/answer/rank.rb
 - lib/active_record_survey/node/answer/scale.rb
 - lib/active_record_survey/node/answer/text.rb
 - lib/active_record_survey/node/question.rb
@@ -142,6 +143,7 @@ files:
 - lib/generators/active_record_survey/next_migration_version.rb
 - lib/generators/active_record_survey/templates/migration_0.1.0.rb
 - spec/active_record_survey/node/answer/boolean_spec.rb
+- spec/active_record_survey/node/answer/scale_spec.rb
 - spec/active_record_survey/survey_spec.rb
 - spec/active_record_survey_spec.rb
 - spec/spec_helper.rb
@@ -171,6 +173,7 @@ specification_version: 4
 summary: Surveys using activerecord
 test_files:
 - spec/active_record_survey/node/answer/boolean_spec.rb
+- spec/active_record_survey/node/answer/scale_spec.rb
 - spec/active_record_survey/survey_spec.rb
 - spec/active_record_survey_spec.rb
 - spec/spec_helper.rb