active_record_sql_unionizer 0.0.2 → 0.0.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 6edeb9257c4226bca2f11ddf5f60659ebecd58b2
-  data.tar.gz: a8ea988d3fc032efdae9a2c6361c1929bd0cf7a8
+  metadata.gz: 491f97c676df938bddad121f8f81b80da7d2c825
+  data.tar.gz: 499cb2e56377a4edaf55110e5086b3104cbb9902
 SHA512:
-  metadata.gz: 20096ba4f489c6646f714fec2d9616442e96025e466bc83ec0e248342fa3e9b67423d894653ce58d2e218d609fd4109944be64b0f1a1bd58749ea51a2ec99f09
-  data.tar.gz: ab817088c9827fad57ffe147bb4d5d1fa462146489221d5222e75da105f2cb03cf7eb52771f23699772ce842ffee3eeb52d1928ce14c3cea26d0d6b5aba9bdaf
+  metadata.gz: d66d5f208c71708d333ef9e82a4e7a101eae75a28f30540872f8251b90e5d21cf9636ee70ec409e9a7d4eeba52983a216922123d3d24631c35d9f7f22b9327cd
+  data.tar.gz: 1938ab1c27c16b181c4ec1f45eacdb6c2ccfe31c6cca8b6f375fef1cad6ec0713a5b989ed4161d77032ad664ce6b825886f47684a14da680cb88b988a9e1eceb

data/lib/active_record_sql_unionizer/active_record_sql_unionizer.rb

@@ -21,8 +21,10 @@ module ActiveRecordSqlUnionizer
                 query
               when Symbol
                 unionizer_helper.handle_symbol_arg(self, query)
-              else
+              when ActiveRecord::Relation
                 query.to_sql
+              else
+                raise(UnionizerError.new(type: :unknown_arg_type))
             end
 
         "(#{query_string})"
@@ -35,6 +37,9 @@ module ActiveRecordSqlUnionizer
     end
   end
 
+
+  private
+
   class UnionizerHelper
     #for 'private' methods/ readability
 
@@ -52,11 +57,11 @@ module ActiveRecordSqlUnionizer
     # @param [Symbol] arg
     #
     # @return [String, UnionizerError]
-    def handle_symbol_arg(klass, arg)
-      if klass.respond_to?(arg)
-        klass.send(arg).to_sql
+    def handle_symbol_arg(klass, method_name)
+      if klass.respond_to?(method_name)
+        klass.send(method_name).to_sql
       else
-        raise(UnionizerError.new(klass.to_s, arg))
+        raise(UnionizerError.new(type: :bad_method, class: klass.to_s, method_name: method_name))
       end
     end
 
@@ -74,8 +79,12 @@ module ActiveRecordSqlUnionizer
     # @param [Symbol] method_name
     #
     # @return [UnionizerError]
-    def initialize(klass_name, method_name)
-      msg = "ActiveRecordSqlUnionizer expected #{klass_name} to respond to #{method_name}, but it does not"
+    def initialize(options)
+      if options[:type] == :unknown_arg_type
+        msg = "ActiveRecordSqlUnionizer received an arguement that was not a SQL string, ActiveRecord::Relation, or scoping method name"
+      elsif options[:type] == :bad_method
+        msg = "ActiveRecordSqlUnionizer expected #{options[:class]} to respond to #{options[:method_name]}, but it does not"
+      end
       super(msg)
     end
   end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: active_record_sql_unionizer
 version: !ruby/object:Gem::Version
-  version: 0.0.2
+  version: 0.0.3
 platform: ruby
 authors:
 - Jeff Hostetler
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-12-22 00:00:00.000000000 Z
+date: 2018-01-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord