active_record_query_fixer 0.0.5 → 0.0.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 19fa73e1ddacc9003ee2eb47d734a7352db57ba07cc3289058f59accb3f6c35f
-  data.tar.gz: dab480dc00323d18ea6e407514f0d5af914319eaed54a39e251d6198e8c25513
+  metadata.gz: 286f64ce0867ac277cd2b0483b86336feeecc0ef1b1bfcb505fe180ceea0037a
+  data.tar.gz: d27dfa1586fa4014ceeaeebb221f0e130b65664ae4236d67a57922fdfe4a1475
 SHA512:
-  metadata.gz: 71e5ca9135ba7667b3e7da108a9b2543116afa23e8ab1b50a0d0d1a37a291aba82859739c43d2cc1021d29a2466b60ce00633b7624c4a8c17265f97962aa66c9
-  data.tar.gz: af90fa1f50f0ef0edaa15e95543ec087a870ef0cef1ac79cfcac981eceb56f9a3c4492b3f3a58db7a01306b236f791642b9a3aff2ea554eed28252f52a29f6ac
+  metadata.gz: 305e9f4a2626d28488593418e5e53f6047675557f2cce27bee031cd22f907704bf188ce820dbfc9017a34cb5f6bfce217c6c6e55eb7c08e7a60a1083fb26d668
+  data.tar.gz: b2068204ae6b377ee409d6a36bd97c8851bb22c742a41ae9f33c36490d09f5777b271e9b1ecb83116b7f87d67f0cbd9edde98c90a2ebfc250c3782eb24865af3

data/lib/active_record_query_fixer.rb

@@ -23,7 +23,7 @@ class ActiveRecordQueryFixer
     @query = @query.group(@query.model.arel_table[@query.model.primary_key])
 
     @query.values[:order]&.each do |order|
-      @query = @query.group(extract_table_and_column_from_expression(order))
+      @query = @query.group(extract_table_and_column_from_expression(order)) if group_by_order?(order)
     end
 
     self
@@ -77,6 +77,10 @@ private
   def fix_reference_group?
     @query.values[:references].present? && @query.values[:group].present?
   end
+
+  def group_by_order?(order)
+    !order.match?(/\A\s*(COUNT|SUM)\(/i)
+  end
 end
 
 ActiveRecord::Relation.include ActiveRecordQueryFixer::RelationExtentions

data/lib/active_record_query_fixer/version.rb

@@ -1,3 +1,3 @@
 class ActiveRecordQueryFixer
-  VERSION = "0.0.5".freeze
+  VERSION = "0.0.6".freeze
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: active_record_query_fixer
 version: !ruby/object:Gem::Version
-  version: 0.0.5
+  version: 0.0.6
 platform: ruby
 authors:
 - kaspernj
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-12-04 00:00:00.000000000 Z
+date: 2019-09-22 00:00:00.000000000 Z
 dependencies: []
 description: A library for automatically added `.select` on a column used for `.distinct`
   or automatically adding `.group` for a column used for order.