active_record_patch_first_or_create 0.0.4 → 1.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: c4c3527b478c90a4703461e25825ec2c791915ee
-  data.tar.gz: 18c3d931f8d3488462230f4b362e20dcfda45f06
+  metadata.gz: c5478264fa26b04687d1f600cec8ebcf8c26cf68
+  data.tar.gz: 26c207ae53c67c8b4b128d5c7d81aeeac0e598f8
 SHA512:
-  metadata.gz: cd7c194effb1086fae26b403052a3aa68687204cd7307c82b5b908fda6ecd945ff9159e6b4a8d7185feb7d78b98ca14f038d41d8481b18f2e0f055d585c8a08f
-  data.tar.gz: d2082aa45475d5b30a535dac09aae845b6a9c65f6696cbe369be4de0e57d7fea8a3f1e4338ac1e1c9ecb81efce03902f86cf0bc8aa59a31aa61c3e909e747daa
+  metadata.gz: 7742d1e4bc569d0288d14bb27e64755acacac0718edc1355efc5003ec31cecf6859c4e23bc61b8c4c2dac4705edcb6b8592d19c07a1bb87ed50d11613f57cb2a
+  data.tar.gz: 125ae54308548403d7ef4993f5ae457c786a55f94314ceb0a2e93fe237e7889ec9c11f572439e6eefe63e3ffe53997220352bfc6731bd596b9d438a978e3aa5e

data/Gemfile

@@ -2,3 +2,17 @@ source 'https://rubygems.org'
 
 # Specify your gem's dependencies in active_record_patch_first_or_create.gemspec
 gemspec
+
+group :testing do
+  gem "pry"
+  gem "pry-doc"
+
+  gem "guard"
+  gem "guard-minitest"
+  gem "guard-yard"
+
+  gem "rb-fsevent"
+  gem "terminal-notifier-guard"
+
+  gem 'simplecov', :require => false
+end

data/README.md

@@ -1,6 +1,6 @@
 # ActiveRecordPatchFirstOrCreate
 
-TODO: Write a gem description
+Real atomic first_or_create/find_or_create_by for Rails
 
 ## Installation
 
@@ -16,14 +16,25 @@ Or install it yourself as:
 
     $ gem install active_record_patch_first_or_create
 
+## Solution
+
+We find out that methods like first_or_create or find_or_create_by are not atomic, you can check docs here
+
+"Please note *this method is not atomic*, it runs first a SELECT, and if there are no results an INSERT is attempted. If there are other threads or processes there is a race condition between both calls and it could be the case that you end up with two similar records."
+
 ## Usage
 
-TODO: Write usage instructions here
+Finds the first record with the given attributes, or creates a record with the attributes if one is not found:
+
+# Find the first user with uid "abc123" or create a new one.
+User.where(uid: 'abc123').atomic_first_or_create(name: 'John', uid: 'abc123')
+# => #<User id: 1, uid: "abc123", name: 'John'>
 
-## Contributing
+# Find the first user with uid "abc123" or create a new one.
+# We already have one so the existing record will be returned.
+User.where(uid: 'abc123').atomic_first_or_create(name: 'John', uid: 'abc123')
+# => #<User id: 1, uid: "abc123", name: 'John'>
 
-1. Fork it ( http://github.com/<my-github-username>/active_record_patch_first_or_create/fork )
-2. Create your feature branch (`git checkout -b my-new-feature`)
-3. Commit your changes (`git commit -am 'Add some feature'`)
-4. Push to the branch (`git push origin my-new-feature`)
-5. Create new Pull Request
+# Find the first user with uid "abc1234" or create a new one
+User.where(uid: 'abc123').atomic_first_or_create(name: 'Johansson', uid: 'abc1234')
+# => #<User id: 2, uid: "abc1234", name: 'Johansson'>

data/Rakefile

@@ -1 +1,7 @@
 require "bundler/gem_tasks"
+require "rake/testtask"
+
+Rake::TestTask.new do |t|
+  t.libs << "test"
+  t.test_files = FileList['test/**/test_*.rb']
+end

data/active_record_patch_first_or_create.gemspec

@@ -20,4 +20,9 @@ Gem::Specification.new do |spec|
 
   spec.add_development_dependency "bundler", "~> 1.5"
   spec.add_development_dependency "rake", "~> 0"
+  spec.add_development_dependency "minitest"
+  spec.add_development_dependency "mocha"
+  spec.add_development_dependency "webmock"
+  spec.add_development_dependency "activerecord"
+  spec.add_development_dependency "sqlite3"
 end

data/lib/active_record_patch_first_or_create.rb

@@ -31,7 +31,7 @@ end
 
 module ActiveRecord
   class Relation
-    def atomic_first_or_create(attributes = nil, &block)
+    def atomic_first_or_create(attributes = nil)
       ActiveRecordPatchFirstOrCreate.first_or_create(self, attributes)
     end
   end

data/lib/active_record_patch_first_or_create/version.rb

@@ -1,3 +1,3 @@
 module ActiveRecordPatchFirstOrCreate
-  VERSION = "0.0.4"
+  VERSION = "1.0.0"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: active_record_patch_first_or_create
 version: !ruby/object:Gem::Version
-  version: 0.0.4
+  version: 1.0.0
 platform: ruby
 authors:
 - NDrive DevOps Team
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-05-07 00:00:00.000000000 Z
+date: 2014-05-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -38,6 +38,76 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: minitest
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: mocha
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: webmock
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: activerecord
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: sqlite3
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 description: This patch provides first_or_create method to be atomic, once the default
   one isn't!!!
 email: