active_record_migrations 5.0.0.1.pre.optimistic → 5.0.0.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 0c2328cd7436b833ea5792737def813f1ccf6f61
-  data.tar.gz: 198fa286927c074400dcaa3df32b9ed16aa1fd11
+  metadata.gz: 47912ffbd2b1cd1519c1ff6d5a86313c373ab505
+  data.tar.gz: cc0f033e669b7de79ceb7d0ff12388bb44213b54
 SHA512:
-  metadata.gz: ecc7b2ed0818f9e7ce96b3c24f057a569092b6febd1ac23668152b093a0fd868ef99fed966a7f37b1bdc9a1c0689204e562da08b8a507da9a320d04e317de900
-  data.tar.gz: 1c38744b93d9ebd6ce8563667a6aa8b655e19fd996cc45a86a2130676c9ec7385bbf73934b22c8144b77d31ae8f32c71a2539f7ccb64654ea2cad73f9a62573e
+  metadata.gz: c8a44c00a493baa65b49d03d557e9f5fad273a265c3f4c284d0a26046b3982167177f4c19a243d224791d20a4108add3be20ab5d39e2b58b35c9a37836999bcb
+  data.tar.gz: 1d92313a577082c99c19dcd826f49151c483daf4779e1a03d6436d58df91557a9919a2c0349194369ce9b9bcccf8e33b46b8ffea92168a7dd8207bdfdc5c5939

data/README.md

@@ -2,19 +2,11 @@
 
 Allows you to use ActiveRecord migrations in non-Rails projects.
 
-This branch is for the _optimistic_ version, assuming the internals of AR migrations we rely on
-won't change until the next major version. However, we can't really promiss the related AR
-migrations code won't change in minor or patch versions of AR. That's why we can't release this
-branch as a final version.
-
-But at least you should be able to try it with basically any AR version in case you have to deal
-with conflicts.
-
 ## Installation
 
 Add this line to your application's Gemfile (run `bundle init` if you don't have one):
 
-    gem 'active_record_migrations', '5.0.0.1.pre.optimistic'
+    gem 'active_record_migrations'
     gem 'sqlite3' # or 'pg', 'mysql2', ...
 
 And then execute:
@@ -48,7 +40,7 @@ will be created under `db/migrate`. If you want to keep with the defaults, creat
 ```
 
 If you prefer to specify your settings in plain Ruby, add this to your Rakefile,
-before calling `ActiveRecordMigrations.load_taks`:
+before calling `ActiveRecordMigrations.load_tasks`:
 
 ```ruby
 ActiveRecordMigrations.configure do |c|
@@ -79,10 +71,18 @@ You can specify the environment by setting the `db` environment variable:
 
 ## Versioning
 
-For final releases, the version follows ActiveRecord versions plus a patch version from our own.
-For instance, if AR version is 4.0.1, this gem will be versioned 4.0.1.x with x starting in 0.
+The version follows ActiveRecord versions plus a patch version from our own. For instance, if
+AR version is 4.0.1, this gem will be versioned 4.0.1.x with x starting in 0.
+
+## I can't find a release for the AR version we rely on
+
+We have to use pessimistic versioning because we rely on internal details of AR migrations in
+order to override the migrations path. So far the internal implementation since 4.0.0.0 hasn't
+changed, so if you're interested on another version with optimistic versioning dependency in
+order to have more flexibility you should check out the [optimistic](../../tree/optimistic) branch.
 
-This branch however won't use pessimistic locking so that you have some flexibility if you need.
+I've already tried to merge the required changes to AR itself a few times but after having my
+pull requests ignored a few times without feedback I gave up.
 
 ## Contributing
 

data/active_record_migrations.gemspec

@@ -20,14 +20,15 @@ Gem::Specification.new do |spec|
 
   spec.add_development_dependency "bundler"
   spec.add_dependency "rake"
+  # spec.add_dependency "railties", "~> 5.0.0"
+  # spec.add_dependency "activerecord", "~> 5.0.0"
   # We rely on a kind of monkey patch for allowing us to override the migrations path.
-  # The final releases fix on an specific version of AR and check if the override of
+  # So it's better to fix on an specific version of AR and check if the override of
   # ActiveRecord::Generators::MigrationGenerator#create_migration_file is correct
   # before upgrading AR dependency. See ARM::Generators::MigrationGenerator impl.
-  # The "optimistic" versions allow more flexibility to support other AR versions but
-  # on the other side we can't really guarantee that it will actually work since it depends
-  # on internal implementation of AR migrations that could change any time.
-  spec.add_dependency "railties", ">= 4.0.0", "< 6.0"
-  spec.add_dependency "activerecord", ">= 4.0.0", "< 6.0"
+  #spec.add_dependency "railties", "5.0.0"
+  #spec.add_dependency "activerecord", "5.0.0"
+  spec.add_dependency "railties", "5.0.0"
+  spec.add_dependency "activerecord", "5.0.0"
 end
 

data/lib/active_record_migrations.rb

@@ -5,10 +5,6 @@ require 'rails'
 require 'rails/application'
 require 'active_record_migrations/configurations'
 
-# those requires are missing from AR but are required:
-require 'zlib'
-require 'digest'
-
 module ActiveRecordMigrations
   include ActiveRecord::Tasks
 

data/lib/active_record_migrations/version.rb

@@ -1,3 +1,3 @@
 module ActiveRecordMigrations
-  VERSION = "5.0.0.1-optimistic"
+  VERSION = "5.0.0.1"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: active_record_migrations
 version: !ruby/object:Gem::Version
-  version: 5.0.0.1.pre.optimistic
+  version: 5.0.0.1
 platform: ruby
 authors:
 - Rodrigo Rosenfeld Rosas
@@ -42,42 +42,30 @@ dependencies:
   name: railties
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: 4.0.0
-    - - "<"
+    - - '='
       - !ruby/object:Gem::Version
-        version: '6.0'
+        version: 5.0.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - '='
       - !ruby/object:Gem::Version
-        version: 4.0.0
-    - - "<"
-      - !ruby/object:Gem::Version
-        version: '6.0'
+        version: 5.0.0
 - !ruby/object:Gem::Dependency
   name: activerecord
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - '='
       - !ruby/object:Gem::Version
-        version: 4.0.0
-    - - "<"
-      - !ruby/object:Gem::Version
-        version: '6.0'
+        version: 5.0.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: 4.0.0
-    - - "<"
+    - - '='
       - !ruby/object:Gem::Version
-        version: '6.0'
+        version: 5.0.0
 description: ActiveRecord Stand-alone migrations
 email:
 - rr.rosas@gmail.com
@@ -111,9 +99,9 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">"
+  - - ">="
     - !ruby/object:Gem::Version
-      version: 1.3.1
+      version: '0'
 requirements: []
 rubyforge_project: 
 rubygems_version: 2.5.1