active_record_host_pool 1.2.0 → 1.2.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: f5dcc0c95ead619555c18514507bf2711f7790c7e120570a5daaadf6506f1250
-  data.tar.gz: 37d82a6b2c495872cfa5522bd588c7dd047afa5b9cdc376acd9a9c96aba21d44
+  metadata.gz: 6c8a74e78b05f5094b89403c7e77ebbe40802ebeeec9f8ea724cdf3527c20dea
+  data.tar.gz: 8e8e5c3ba32256bcf5c39e974bb8565ae464bad9aafa41d0ad5309802d226dc2
 SHA512:
-  metadata.gz: dd36a23cbb9636ba2dda0f303776715e05aef42ddecafa583388b32c7c11adcae6a0285743eede486712559d20309fa5fe834bd44a9bc539c2cc985c3f80c344
-  data.tar.gz: d18bec930c1c6358d310461bd958fa3d92baee83e7de0d629783610809aea7f552ef98a1cc7482707cd8eaef4d592321a00f2210302132c31fead5d27b471962
+  metadata.gz: d3c9ed0921dae7152f1de4e498edd761960b81038c8d46a32674949fe152d8dd2b9ad8a836322d8cabf6f05a3484e9297a535553dc8c888109958fdb00eacea9
+  data.tar.gz: fcb8f19f314456e8dc293a6233650723da2f6bad8548fba12671827d12bd1c3842cb555d2b2ca413488cadf9099b8b491b01ef256279099a3a3a0473b4507701

data/lib/active_record_host_pool/connection_adapter_mixin.rb

@@ -33,11 +33,11 @@ module ActiveRecordHostPool
     end
 
     def self.ruby2_keywords(*); end unless respond_to?(:ruby2_keywords, true)
-    ruby2_keywords def execute_with_switching(*args)
+    ruby2_keywords def execute_with_switching(*args, **kwargs)
       if _host_pool_current_database && !_no_switch
         _switch_connection
       end
-      execute_without_switching(*args)
+      execute_without_switching(*args, **kwargs)
     end
 
     def drop_database_with_no_switching(*args)

data/lib/active_record_host_pool/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module ActiveRecordHostPool
-  VERSION = "1.2.0"
+  VERSION = "1.2.1"
 end

data/test/helper.rb

@@ -5,7 +5,7 @@ require 'minitest/autorun'
 
 require 'active_record_host_pool'
 require 'logger'
-require 'mocha/minitest'
+require 'minitest/mock_expectations'
 require 'phenix'
 
 ENV['RAILS_ENV'] = 'test'
@@ -20,6 +20,8 @@ RAILS_6_1_WITH_NON_LEGACY_CONNECTION_HANDLING =
 
 ActiveRecord::Base.logger = Logger.new(File.dirname(__FILE__) + '/test.log')
 
+Thread.abort_on_exception = true
+
 # BEGIN preventing_writes? patch
 ## Rails 6.1 by default does not allow writing to replica databases which prevents
 ## us from properly setting up the test databases. This patch is used in test/schema.rb

data/test/test_arhp.rb

@@ -122,18 +122,22 @@ class ActiveRecordHostPoolTest < Minitest::Test
 
   def test_no_switch_when_creating_db
     conn = Pool1DbA.connection
-    conn.expects(:execute_without_switching)
-    conn.expects(:_switch_connection).never
-    assert conn._host_pool_current_database
-    conn.create_database(:some_args)
+    assert_called(conn, :execute_without_switching) do
+      refute_called(conn, :_switch_connection) do
+        assert conn._host_pool_current_database
+        conn.create_database(:some_args)
+      end
+    end
   end
 
   def test_no_switch_when_dropping_db
     conn = Pool1DbA.connection
-    conn.expects(:execute_without_switching)
-    conn.expects(:_switch_connection).never
-    assert conn._host_pool_current_database
-    conn.drop_database(:some_args)
+    assert_called(conn, :execute_without_switching) do
+      refute_called(conn, :_switch_connection) do
+        assert conn._host_pool_current_database
+        conn.drop_database(:some_args)
+      end
+    end
   end
 
   def test_underlying_assumption_about_test_db
@@ -163,8 +167,9 @@ class ActiveRecordHostPoolTest < Minitest::Test
     thread_id = switch_to_klass.connection.select_value('select @@pseudo_thread_id')
 
     # now, disable our auto-switching and trigger a mysql reconnect
-    switch_to_klass.connection.unproxied.stubs(:_switch_connection).returns(true)
-    Pool2DbD.connection.execute("KILL #{thread_id}")
+    switch_to_klass.connection.unproxied.stub(:_switch_connection, true) do
+      Pool2DbD.connection.execute("KILL #{thread_id}")
+    end
 
     # and finally, did mysql reconnect correctly?
     puts "\nAnd now we end up on #{current_database(switch_to_klass)}" if debug_me
@@ -174,7 +179,8 @@ class ActiveRecordHostPoolTest < Minitest::Test
   def test_release_connection
     pool = ActiveRecord::Base.connection_pool
     conn = pool.connection
-    pool.expects(:checkin).with(conn)
-    pool.release_connection
+    assert_called_with(pool, :checkin, [conn]) do
+      pool.release_connection
+    end
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: active_record_host_pool
 version: !ruby/object:Gem::Version
-  version: 1.2.0
+  version: 1.2.1
 platform: ruby
 authors:
 - Benjamin Quorning
@@ -11,7 +11,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2022-10-13 00:00:00.000000000 Z
+date: 2022-12-23 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
@@ -76,19 +76,19 @@ dependencies:
       - !ruby/object:Gem::Version
         version: 5.10.0
 - !ruby/object:Gem::Dependency
-  name: mocha
+  name: minitest-mock_expectations
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.4.0
+        version: 1.1.3
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.4.0
+        version: 1.1.3
 - !ruby/object:Gem::Dependency
   name: phenix
   requirement: !ruby/object:Gem::Requirement
@@ -131,20 +131,6 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: 0.80.0
-- !ruby/object:Gem::Dependency
-  name: shoulda
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
 description: ''
 email:
 - bquorning@zendesk.com