active_record_extended 1.3.0 → 1.3.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 69a8ed712b33088a8aa79eb2d89ba86f645882d085d3bb752fb997eb1888b6af
-  data.tar.gz: a60306c9e2551606772007b683dee9477d7c87545569647c47a78e45a92b21bc
+  metadata.gz: 2c136dceff4eb13a4c368aef03c70ae74bf3c856d3dadaa38e468e3f3369455d
+  data.tar.gz: 1d7f194a4760a812e2a6aa22f20e1a62914e68d1fcb52cb223d724104597cc31
 SHA512:
-  metadata.gz: 5530aaaf8f2f45aa1f7daaed6398eeac033cd50c3fb542a427dac4b9097c6ebffe08928f6d7a13bacdf9e04509f26f85ed607d4622e16423ced1308e079a2cf7
-  data.tar.gz: 8ca7691c2c23da13e8f1a409eeb5528ed47f01736f4cabbefa06fe441f56cae24ff504b1a0b31996645ef6bba7e2c308e1a8ee6254ee795d3a5fdbd15b0de57b
+  metadata.gz: a0d6e454d6c2dc91d28472cc1911043bc62a94e554d85bc77b0cdbbdedcc4158f7f6f43164a7cd5b27d8609ececf4b532f9a4ebe26c725267c77de4b1c201d38
+  data.tar.gz: 28980520ea5779c79a9fd131157a5b2cdecba1d1fa8464dbba34ef299501094e97db64db303c5d0ad51cf3cb2a52b130562a71d64f866e67f6446ce79082de74

data/lib/active_record_extended/utilities/support.rb

@@ -81,7 +81,7 @@ module ActiveRecordExtended
         else
           replicate_klass = from.respond_to?(:unscoped) ? from.unscoped : @scope.unscoped
           replicate_klass.from(from.dup, reference_key)
-        end
+        end.unscope(:where)
       end
 
       # Will carry defined CTE tables from the nested sub-query and gradually pushes it up to the parents query stack

data/lib/active_record_extended/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module ActiveRecordExtended
-  VERSION = "1.3.0"
+  VERSION = "1.3.1"
 end

data/spec/sql_inspections/json_sql_spec.rb

@@ -53,6 +53,13 @@ RSpec.describe "JSON Methods SQL Queries" do
         end
       end
     end
+
+    context "when the subquery is a STI record type" do
+      it "should not append sti 'type IN(..)' where clauses to the nested query" do
+        query = User.select_row_to_json(AdminSti.where(id: 10), cast_with: :array, key: :convert_this, as: :results).to_sql
+        expect(query).to match_regex(/SELECT \(ARRAY\(SELECT ROW_TO_JSON\("convert_this"\) FROM \(.*\) convert_this\)\) AS .+/)
+      end
+    end
   end
 
   describe ".json_build_object" do

data/spec/support/models.rb

@@ -20,6 +20,12 @@ class User < ApplicationRecord
   #
 end
 
+class StiRecord < ApplicationRecord
+  # t.string "type"
+end
+
+class AdminSti < StiRecord; end
+
 module Namespaced
   def self.table_name_prefix
     "namespaced_"

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: active_record_extended
 version: !ruby/object:Gem::Version
-  version: 1.3.0
+  version: 1.3.1
 platform: ruby
 authors:
 - George Protacio-Karaszi
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-09-04 00:00:00.000000000 Z
+date: 2019-10-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord