active_record_extended 0.7.0 → 1.0.0

data/spec/sql_inspections/json_sql_spec.rb

@@ -0,0 +1,46 @@
+# frozen_string_literal: true
+
+require "spec_helper"
+
+RSpec.describe "JSON Methods SQL Queries" do
+  let(:single_with)      { /^WITH .all_others. AS(?!.*WITH \w?)/mi }
+  let(:override_with)    { /^WITH .all_others. AS \(.+WHERE .people.\..id. = 10\)/mi }
+
+  describe ".select_row_to_json" do
+    context "when a subquery contains a CTE table" do
+      let(:cte_person) { Person.with(all_others: Person.where.not(id: 1)).where(id: 2) }
+
+      it "should push the CTE to the callee's level" do
+        query = Person.select_row_to_json(cte_person, as: :results).to_sql
+        expect(query).to match_regex(single_with)
+      end
+
+      it "should favor the parents CTE table if names collide" do
+        query = Person.with(all_others: Person.where(id: 10))
+        query = query.select_row_to_json(cte_person, as: :results).to_sql
+
+        expect(query).to match_regex(single_with)
+        expect(query).to match_regex(override_with)
+      end
+    end
+  end
+
+  describe ".json_build_object" do
+    context "when a subquery contains a CTE table" do
+      let(:cte_person) { Person.with(all_others: Person.where.not(id: 1)).where(id: 2) }
+
+      it "should push the CTE to the callee's level" do
+        query = Person.json_build_object(:peoples, cte_person).to_sql
+        expect(query).to match_regex(single_with)
+      end
+
+      it "should favor the parents CTE table if names collide" do
+        query = Person.with(all_others: Person.where(id: 10))
+        query = query.json_build_object(:peoples, cte_person).to_sql
+
+        expect(query).to match_regex(single_with)
+        expect(query).to match_regex(override_with)
+      end
+    end
+  end
+end

data/spec/sql_inspections/unionize_sql_spec.rb

@@ -0,0 +1,124 @@
+# frozen_string_literal: true
+
+require "spec_helper"
+
+RSpec.describe "Union SQL Queries" do
+  let(:person)       { Person.where(id: 1) }
+  let(:other_person) { Person.where("id = 2") }
+
+  shared_examples_for "unions" do
+    it { is_expected.to eq("( (#{person.to_sql}) #{described_union} (#{other_person.to_sql}) )") }
+  end
+
+  shared_examples_for "piping nest CTE tables" do
+    let(:cte_person)    { Person.with(all_others: Person.where.not(id: 1)).where(id: 2) }
+    let(:method)        { raise "Required to override this method!" }
+    let(:single_with)   { /^WITH .all_others. AS(?!.*WITH \w?)/mi }
+    let(:override_with) { /^WITH .all_others. AS \(.+WHERE .people.\..id. = 10\)/mi }
+
+    it "should push the CTE to the callee's level" do
+      query = Person.send(method.to_sym, cte_person, other_person).to_sql
+      expect(query).to match_regex(single_with)
+    end
+
+    it "should favor the parents CTE table if names collide" do
+      query = Person.with(all_others: Person.where(id: 10))
+      query = query.send(method.to_sym, cte_person, other_person).to_sql
+
+      expect(query).to match_regex(single_with)
+      expect(query).to match_regex(override_with)
+    end
+  end
+
+  describe ".union" do
+    let!(:described_union)     { "UNION" }
+    subject(:described_method) { Person.union(person, other_person).to_union_sql }
+    it_behaves_like "unions"
+    it_behaves_like "piping nest CTE tables" do
+      let!(:method) { :union }
+    end
+  end
+
+  describe ".union.all" do
+    let!(:described_union)     { "UNION ALL" }
+    subject(:described_method) { Person.union.all(person, other_person).to_union_sql }
+    it_behaves_like "unions"
+    it_behaves_like "piping nest CTE tables" do
+      let!(:method) { :union_all }
+    end
+  end
+
+  describe ".union.except" do
+    let!(:described_union)     { "EXCEPT" }
+    subject(:described_method) { Person.union.except(person, other_person).to_union_sql }
+    it_behaves_like "unions"
+    it_behaves_like "piping nest CTE tables" do
+      let!(:method) { :union_except }
+    end
+  end
+
+  describe "union.intersect" do
+    let!(:described_union)     { "INTERSECT" }
+    subject(:described_method) { Person.union.intersect(person, other_person).to_union_sql }
+    it_behaves_like "unions"
+    it_behaves_like "piping nest CTE tables" do
+      let!(:method) { :union_intersect }
+    end
+  end
+
+  describe "union.as" do
+    context "when a union.as has been called" do
+      subject(:described_method) do
+        Person.select("happy_people.id").union(person, other_person).union.as(:happy_people).to_sql
+      end
+
+      it "should alias the union from clause to 'happy_people'" do
+        expect(described_method).to match_regex(/FROM \(+.+\) UNION \(.+\)+ happy_people$/)
+        expect(described_method).to match_regex(/^SELECT happy_people\.id FROM.+happy_people$/)
+      end
+    end
+
+    context "when user.as hasn't been called" do
+      subject(:described_method) { Person.select(:id).union(person, other_person).to_sql }
+
+      it "should retain the actual class calling table name as the union alias" do
+        expect(described_method).to match_regex(/FROM \(+.+\) UNION \(.+\)+ people$/)
+        expect(described_method).to match_regex(/^SELECT \"people\"\.\"id\" FROM.+people$/)
+      end
+    end
+  end
+
+  describe "union.order" do
+    context "when rendering with .to_union_sql" do
+      subject(:described_method) { Person.union(person, other_person).union.order(:id, name: :desc).to_union_sql }
+
+      it "Should append an 'ORDER BY' to the end of the union statements" do
+        expect(described_method).to match_regex(/^\(+.+\) UNION \(.+\) \) ORDER BY id, name DESC$/)
+      end
+    end
+
+    context "when rendering with .to_sql" do
+      subject(:described_method) { Person.union(person, other_person).union.order(:id, name: :desc).to_sql }
+
+      it "Should append an 'ORDER BY' to the end of the union statements" do
+        expect(described_method).to match_regex(/FROM \(+.+\) UNION \(.+\) \) ORDER BY id, name DESC\) people$/)
+      end
+    end
+
+    context "when a there are multiple union statements" do
+      let(:query_regex) { /(?<=\)\s(ORDER BY)) id/ }
+
+      it "should only append an order by to the very end of a union statements" do
+        query = Person.union.order(id: :asc, tags: :desc)
+                      .union(person.order(id: :asc, tags: :desc))
+                      .union(person.order(:id, :tags))
+                      .union(other_person.order(id: :desc, tags: :desc))
+                      .to_union_sql
+
+        index = query.index(query_regex)
+        expect(index).to be_truthy
+        expect(query[index..-1]).to eq(" id ASC, tags DESC")
+      end
+    end
+  end
+end

data/spec/support/models.rb

@@ -1,25 +1,48 @@
 # frozen_string_literal: true
 
-class Person < ActiveRecord::Base
+class ApplicationRecord < ActiveRecord::Base
+  self.abstract_class = true
+end
+
+class Person < ApplicationRecord
   has_many :hm_tags, class_name: "Tag"
   has_one :profile_l, class_name: "ProfileL"
   has_one :profile_r, class_name: "ProfileR"
+  # attributes
+  # t.string   "tags",         array: true
+  # t.integer  "number",       default: 0
+  # t.integer  "personal_id"
+  # t.hstore   "data"
+  # t.jsonb    "jsonb_data"
+  # t.inet     "ip"
+  # t.cidr     "subnet"
+  #
 end
 
-class Tag < ActiveRecord::Base
+class Tag < ApplicationRecord
   belongs_to :person
+  # attributes: tag_number
 end
 
-class ProfileL < ActiveRecord::Base
+class ProfileL < ApplicationRecord
   belongs_to :person
   has_one :version, as: :versionable, class_name: "VersionControl"
+  # attributes
+  # t.integer :likes
+  #
 end
 
-class ProfileR < ActiveRecord::Base
+class ProfileR < ApplicationRecord
   belongs_to :person
   has_one :version, as: :versionable, class_name: "VersionControl"
+  # attributes
+  # t.integer :dislikes
+  #
 end
 
-class VersionControl < ActiveRecord::Base
+class VersionControl < ApplicationRecord
   belongs_to :versionable, polymorphic: true, optional: false
+  # attributes
+  # t.jsonb :source, default: {}, null: false
+  #
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: active_record_extended
 version: !ruby/object:Gem::Version
-  version: 0.7.0
+  version: 1.0.0
 platform: ruby
 authors:
 - George Protacio-Karaszi
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-09-22 00:00:00.000000000 Z
+date: 2019-03-23 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
@@ -70,16 +70,22 @@ dependencies:
   name: bundler
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
         version: '1.16'
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '2.1'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
         version: '1.16'
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '2.1'
 - !ruby/object:Gem::Dependency
   name: database_cleaner
   requirement: !ruby/object:Gem::Requirement
@@ -148,6 +154,7 @@ files:
 - README.md
 - lib/active_record_extended.rb
 - lib/active_record_extended/active_record.rb
+- lib/active_record_extended/active_record/relation_patch.rb
 - lib/active_record_extended/arel.rb
 - lib/active_record_extended/arel/nodes.rb
 - lib/active_record_extended/arel/predications.rb
@@ -159,8 +166,11 @@ files:
 - lib/active_record_extended/query_methods/any_of.rb
 - lib/active_record_extended/query_methods/either.rb
 - lib/active_record_extended/query_methods/inet.rb
+- lib/active_record_extended/query_methods/json.rb
+- lib/active_record_extended/query_methods/unionize.rb
 - lib/active_record_extended/query_methods/where_chain.rb
 - lib/active_record_extended/query_methods/with_cte.rb
+- lib/active_record_extended/utilities.rb
 - lib/active_record_extended/version.rb
 - spec/active_record_extended_spec.rb
 - spec/query_methods/any_of_spec.rb
@@ -168,6 +178,8 @@ files:
 - spec/query_methods/either_spec.rb
 - spec/query_methods/hash_query_spec.rb
 - spec/query_methods/inet_query_spec.rb
+- spec/query_methods/json_spec.rb
+- spec/query_methods/unionize_spec.rb
 - spec/query_methods/with_cte_spec.rb
 - spec/spec_helper.rb
 - spec/sql_inspections/any_of_sql_spec.rb
@@ -175,6 +187,8 @@ files:
 - spec/sql_inspections/arel/inet_spec.rb
 - spec/sql_inspections/contains_sql_queries_spec.rb
 - spec/sql_inspections/either_sql_spec.rb
+- spec/sql_inspections/json_sql_spec.rb
+- spec/sql_inspections/unionize_sql_spec.rb
 - spec/sql_inspections/with_cte_sql_spec.rb
 - spec/support/database_cleaner.rb
 - spec/support/models.rb
@@ -209,6 +223,8 @@ test_files:
 - spec/query_methods/either_spec.rb
 - spec/query_methods/hash_query_spec.rb
 - spec/query_methods/inet_query_spec.rb
+- spec/query_methods/json_spec.rb
+- spec/query_methods/unionize_spec.rb
 - spec/query_methods/with_cte_spec.rb
 - spec/spec_helper.rb
 - spec/sql_inspections/any_of_sql_spec.rb
@@ -216,6 +232,8 @@ test_files:
 - spec/sql_inspections/arel/inet_spec.rb
 - spec/sql_inspections/contains_sql_queries_spec.rb
 - spec/sql_inspections/either_sql_spec.rb
+- spec/sql_inspections/json_sql_spec.rb
+- spec/sql_inspections/unionize_sql_spec.rb
 - spec/sql_inspections/with_cte_sql_spec.rb
 - spec/support/database_cleaner.rb
 - spec/support/models.rb