active_record_doctor 1.5.0 → 1.6.0

data/test/support/assertions.rb

@@ -0,0 +1,11 @@
+class ActiveSupport::TestCase
+  private
+
+  def run_task
+    self.class.name.sub(/Test$/, '').constantize.run.first
+  end
+
+  def assert_result(expected_result)
+    assert_equal(expected_result.sort_by(&:to_s), run_task.sort_by(&:to_s))
+  end
+end

data/test/support/forking_test.rb

@@ -0,0 +1,28 @@
+class ActiveSupport::TestCase
+  def run
+    read_io, write_io = IO.pipe
+    read_io.binmode
+    write_io.binmode
+
+    if fork
+      # Parent: load the result sent from the child
+
+      write_io.close
+      result = Marshal.load(read_io)
+      read_io.close
+
+      Process.wait
+    else
+      # Child: just run normally, dump the result, and exit the process to
+      # avoid double-reporting.
+      result = super
+
+      read_io.close
+      Marshal.dump(result, write_io)
+      write_io.close
+      exit
+    end
+
+    result
+  end
+end

data/test/support/temping.rb

@@ -0,0 +1,25 @@
+require 'temping'
+
+class ActiveSupport::TestCase
+  teardown do
+    Temping.teardown
+  end
+end
+
+# Temping 3.10.0 is broken because it removes the tables in the order of
+# creation which fails if foreign key constraints are present.
+class Temping
+  class << self
+    alias_method :old_teardown, :teardown
+
+    def teardown
+      @model_klasses.reverse!
+      old_teardown
+
+      # This hack is required to avoid leaking temporary model classes defined
+      # by Temping. If we don't clear the cache then they'll be kept around and
+      # returned as valid models which will break tests.
+      ActiveSupport::DescendantsTracker.class_variable_get(:@@direct_descendants).clear
+    end
+  end
+end

data/test/test_helper.rb

@@ -11,10 +11,3 @@ Minitest.backtrace_filter = Minitest::BacktraceFilter.new
 
 # Load support files
 Dir["#{File.dirname(__FILE__)}/support/**/*.rb"].each { |f| require f }
-
-# Load fixtures from the engine
-if ActiveSupport::TestCase.respond_to?(:fixture_path=)
-  ActiveSupport::TestCase.fixture_path = File.expand_path("../fixtures", __FILE__)
-  ActionDispatch::IntegrationTest.fixture_path = ActiveSupport::TestCase.fixture_path
-  ActiveSupport::TestCase.fixtures :all
-end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: active_record_doctor
 version: !ruby/object:Gem::Version
-  version: 1.5.0
+  version: 1.6.0
 platform: ruby
 authors:
 - Greg Navis
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-12-30 00:00:00.000000000 Z
+date: 2018-10-30 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: railties
@@ -54,6 +54,20 @@ dependencies:
         version: '4.2'
 - !ruby/object:Gem::Dependency
   name: pg
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "<="
+      - !ruby/object:Gem::Version
+        version: '0.20'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "<="
+      - !ruby/object:Gem::Version
+        version: '0.20'
+- !ruby/object:Gem::Dependency
+  name: temping
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -77,24 +91,29 @@ files:
 - README.md
 - Rakefile
 - lib/active_record_doctor.rb
-- lib/active_record_doctor/compatibility.rb
 - lib/active_record_doctor/printers.rb
 - lib/active_record_doctor/printers/io_printer.rb
 - lib/active_record_doctor/railtie.rb
 - lib/active_record_doctor/tasks.rb
+- lib/active_record_doctor/tasks/base.rb
 - lib/active_record_doctor/tasks/extraneous_indexes.rb
 - lib/active_record_doctor/tasks/missing_foreign_keys.rb
+- lib/active_record_doctor/tasks/missing_non_null_constraint.rb
+- lib/active_record_doctor/tasks/missing_presence_validation.rb
+- lib/active_record_doctor/tasks/missing_unique_indexes.rb
 - lib/active_record_doctor/tasks/undefined_table_references.rb
 - lib/active_record_doctor/tasks/unindexed_deleted_at.rb
 - lib/active_record_doctor/tasks/unindexed_foreign_keys.rb
 - lib/active_record_doctor/version.rb
 - lib/generators/active_record_doctor/add_indexes/USAGE
 - lib/generators/active_record_doctor/add_indexes/add_indexes_generator.rb
-- lib/tasks/active_record_doctor_tasks.rake
+- lib/tasks/active_record_doctor.rake
 - test/active_record_doctor/printers/io_printer_test.rb
 - test/active_record_doctor/tasks/extraneous_indexes_test.rb
 - test/active_record_doctor/tasks/missing_foreign_keys_test.rb
-- test/active_record_doctor/tasks/undefined_table_references_test.rb
+- test/active_record_doctor/tasks/missing_non_null_constraint_test.rb
+- test/active_record_doctor/tasks/missing_presence_validation_test.rb
+- test/active_record_doctor/tasks/missing_unique_indexes_test.rb
 - test/active_record_doctor/tasks/unindexed_deleted_at_test.rb
 - test/active_record_doctor/tasks/unindexed_foreign_keys_test.rb
 - test/dummy/README.rdoc
@@ -104,11 +123,6 @@ files:
 - test/dummy/app/controllers/application_controller.rb
 - test/dummy/app/helpers/application_helper.rb
 - test/dummy/app/models/application_record.rb
-- test/dummy/app/models/comment.rb
-- test/dummy/app/models/contract.rb
-- test/dummy/app/models/employer.rb
-- test/dummy/app/models/profile.rb
-- test/dummy/app/models/user.rb
 - test/dummy/app/views/layouts/application.html.erb
 - test/dummy/bin/bundle
 - test/dummy/bin/rails
@@ -134,10 +148,6 @@ files:
 - test/dummy/config/locales/en.yml
 - test/dummy/config/routes.rb
 - test/dummy/config/secrets.yml
-- test/dummy/db/migrate/20160213101213_create_employers.rb
-- test/dummy/db/migrate/20160213101221_create_users.rb
-- test/dummy/db/migrate/20160213101232_create_profiles.rb
-- test/dummy/db/migrate/20160604081452_create_comments.rb
 - test/dummy/db/migrate/base_migration.rb
 - test/dummy/db/schema.rb
 - test/dummy/log/development.log
@@ -146,7 +156,9 @@ files:
 - test/dummy/public/422.html
 - test/dummy/public/500.html
 - test/dummy/public/favicon.ico
-- test/support/spy_printer.rb
+- test/support/assertions.rb
+- test/support/forking_test.rb
+- test/support/temping.rb
 - test/test_helper.rb
 homepage: https://github.com/gregnavis/active_record_doctor
 licenses:
@@ -168,7 +180,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.5.2
+rubygems_version: 2.4.5
 signing_key: 
 specification_version: 4
 summary: A cure for your Active Record ailments.
@@ -178,8 +190,10 @@ test_files:
 - test/active_record_doctor/tasks/unindexed_deleted_at_test.rb
 - test/active_record_doctor/tasks/missing_foreign_keys_test.rb
 - test/active_record_doctor/tasks/extraneous_indexes_test.rb
-- test/active_record_doctor/tasks/undefined_table_references_test.rb
+- test/active_record_doctor/tasks/missing_non_null_constraint_test.rb
+- test/active_record_doctor/tasks/missing_presence_validation_test.rb
 - test/active_record_doctor/tasks/unindexed_foreign_keys_test.rb
+- test/active_record_doctor/tasks/missing_unique_indexes_test.rb
 - test/dummy/README.rdoc
 - test/dummy/log/development.log
 - test/dummy/log/test.log
@@ -192,18 +206,9 @@ test_files:
 - test/dummy/app/assets/stylesheets/application.css
 - test/dummy/app/assets/javascripts/application.js
 - test/dummy/app/views/layouts/application.html.erb
-- test/dummy/app/models/profile.rb
-- test/dummy/app/models/comment.rb
-- test/dummy/app/models/contract.rb
-- test/dummy/app/models/employer.rb
-- test/dummy/app/models/user.rb
 - test/dummy/app/models/application_record.rb
 - test/dummy/db/schema.rb
-- test/dummy/db/migrate/20160213101213_create_employers.rb
-- test/dummy/db/migrate/20160604081452_create_comments.rb
 - test/dummy/db/migrate/base_migration.rb
-- test/dummy/db/migrate/20160213101232_create_profiles.rb
-- test/dummy/db/migrate/20160213101221_create_users.rb
 - test/dummy/public/404.html
 - test/dummy/public/500.html
 - test/dummy/public/422.html
@@ -229,4 +234,6 @@ test_files:
 - test/dummy/config/boot.rb
 - test/dummy/Rakefile
 - test/dummy/config.ru
-- test/support/spy_printer.rb
+- test/support/temping.rb
+- test/support/forking_test.rb
+- test/support/assertions.rb

data/lib/active_record_doctor/compatibility.rb

@@ -1,11 +0,0 @@
-module ActiveRecordDoctor
-  module Compatibility
-    def connection_tables
-      if Rails::VERSION::MAJOR == 5
-        connection.data_sources
-      else
-        connection.tables
-      end
-    end
-  end
-end

data/lib/tasks/active_record_doctor_tasks.rake

@@ -1,27 +0,0 @@
-require "active_record_doctor/tasks/unindexed_foreign_keys"
-require "active_record_doctor/tasks/extraneous_indexes"
-require "active_record_doctor/tasks/missing_foreign_keys"
-require "active_record_doctor/tasks/undefined_table_references"
-require "active_record_doctor/tasks/unindexed_deleted_at"
-
-namespace :active_record_doctor do
-  task :unindexed_foreign_keys => :environment do
-    ActiveRecordDoctor::Tasks::UnindexedForeignKeys.run
-  end
-
-  task :extraneous_indexes => :environment do
-    ActiveRecordDoctor::Tasks::ExtraneousIndexes.run
-  end
-
-  task :missing_foreign_keys => :environment do
-    ActiveRecordDoctor::Tasks::MissingForeignKeys.run
-  end
-
-  task :undefined_table_references => :environment do
-    exit(ActiveRecordDoctor::Tasks::UndefinedTableReferences.run)
-  end
-
-  task :unindexed_soft_delete => :environment do
-    ActiveRecordDoctor::Tasks::UnindexedDeletedAt.run
-  end
-end

data/test/active_record_doctor/tasks/undefined_table_references_test.rb

@@ -1,19 +0,0 @@
-require 'test_helper'
-
-require 'active_record_doctor/tasks/undefined_table_references'
-
-class ActiveRecordDoctor::Tasks::UndefinedTableReferencesTest < ActiveSupport::TestCase
-  def test_undefined_table_references_are_reported
-    result = run_task
-
-    assert_equal([Contract], result)
-  end
-
-  private
-
-  def run_task
-    printer = SpyPrinter.new
-    ActiveRecordDoctor::Tasks::UndefinedTableReferences.new(printer: printer).run
-    printer.undefined_table_references
-  end
-end

data/test/dummy/app/models/comment.rb

@@ -1,3 +0,0 @@
-class Comment < ActiveRecord::Base
-  belongs_to :commentable, polymorphic: true
-end

data/test/dummy/app/models/contract.rb

@@ -1,3 +0,0 @@
-class Contract < ApplicationRecord
-  self.table_name = 'contract_records'
-end

data/test/dummy/app/models/employer.rb

@@ -1,2 +0,0 @@
-class Employer < ActiveRecord::Base
-end

data/test/dummy/app/models/profile.rb

@@ -1,2 +0,0 @@
-class Profile < ActiveRecord::Base
-end

data/test/dummy/app/models/user.rb

@@ -1,3 +0,0 @@
-class User < ActiveRecord::Base
-  belongs_to :profile
-end

data/test/dummy/db/migrate/20160213101213_create_employers.rb

@@ -1,15 +0,0 @@
-require_relative 'base_migration'
-
-class CreateEmployers < BaseMigration
-  def change
-    create_table :employers do |t|
-      t.string :name
-      t.datetime :deleted_at
-
-      t.timestamps null: false
-    end
-
-    add_index :employers, :id, where: 'deleted_at IS NULL'
-    add_index :employers, :name, where: 'deleted_at IS NULL'
-  end
-end

data/test/dummy/db/migrate/20160213101221_create_users.rb

@@ -1,23 +0,0 @@
-require_relative 'base_migration'
-
-class CreateUsers < BaseMigration
-  def change
-    create_table :users do |t|
-      t.string :email
-      t.string :first_name
-      t.string :last_name
-      t.references :profile, foreign_key: false
-      t.references :employer, foreign_key: true
-      t.string :country_code, null: false
-
-      t.timestamps null: false
-    end
-    add_index :users, [:last_name, :first_name, :email]
-    add_index :users, [:last_name, :first_name]
-    add_index :users, [:last_name, :first_name], unique: true, name: :unique_index_on_users_last_name_and_first_name
-    add_index :users, :last_name
-    add_index :users, :email
-    add_index :users, :email, unique: true, name: :unique_index_on_users_email
-    add_index :users, [:employer_id, :country_code]
-  end
-end

data/test/dummy/db/migrate/20160213101232_create_profiles.rb

@@ -1,15 +0,0 @@
-require_relative 'base_migration'
-
-class CreateProfiles < BaseMigration
-  def change
-    create_table :profiles do |t|
-      t.string :first_name
-      t.string :last_name
-      t.datetime :deleted_at
-
-      t.timestamps null: false
-    end
-
-    add_index :profiles, [:first_name, :last_name]
-  end
-end

data/test/dummy/db/migrate/20160604081452_create_comments.rb

@@ -1,11 +0,0 @@
-require_relative 'base_migration'
-
-class CreateComments < BaseMigration
-  def change
-    create_table :comments do |t|
-      t.references :commentable, polymorphic: true, index: true
-
-      t.timestamps null: false
-    end
-  end
-end

data/test/support/spy_printer.rb

@@ -1,52 +0,0 @@
-class SpyPrinter
-  attr_reader :unindexed_foreign_keys, :extraneous_indexes,
-    :missing_foreign_keys, :undefined_table_references, :unindexed_deleted_at
-
-  def initialize
-    @unindexed_foreign_keys = nil
-    @extraneous_indexes = nil
-    @missing_foreign_keys = nil
-    @undefined_table_references = nil
-    @unindexed_deleted_at = nil
-  end
-
-  def print_unindexed_foreign_keys(argument)
-    if @unindexed_foreign_keys
-      fail("print_unindexed_foreign_keys cannot be called twice")
-    else
-      @unindexed_foreign_keys = argument
-    end
-  end
-
-  def print_extraneous_indexes(argument)
-    if @extraneous_indexes
-      fail("print_extraneous_indexes cannot be called twice")
-    else
-      @extraneous_indexes = argument
-    end
-  end
-
-  def print_missing_foreign_keys(argument)
-    if @missing_foreign_keys
-      fail("print_missing_foreign_keys cannot be called twice")
-    else
-      @missing_foreign_keys = argument
-    end
-  end
-
-  def print_undefined_table_references(argument)
-    if @undefined_table_references
-      fail("print_undefined_table_references cannot be called twice")
-    else
-      @undefined_table_references = argument
-    end
-  end
-
-  def print_unindexed_deleted_at(argument)
-    if @unindexed_deleted_at
-      fail("print_unindexed_deleted_at cannot be called twice")
-    else
-      @unindexed_deleted_at = argument
-    end
-  end
-end