active_record_doctor 1.12.0 → 1.14.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: d848e296c39f7994781bd645261eb45235450be36058fbdf7368ec6358ebeba5
-  data.tar.gz: a63cbbfe5b43fb3bf6daeaba24a6298073643d5b5c96696c27c084106fe54594
+  metadata.gz: 89e283c2844a768587302646735a080d8db2b3514775083cc6bc74a25e7aff18
+  data.tar.gz: 975a75da213c565dba3ee7918ffe64d5b75d812059b8080d6a5134a2fb27028f
 SHA512:
-  metadata.gz: 47411eea54d4c21329459dc7490090a535c53e9f3be912268ceed2f6e2588246cb07c9b90e758559d9b0c08de319f3dc6a4735c79511bc30c2ec7b058104c08e
-  data.tar.gz: 9596cb799a4346b3ec60562876750990b486efc7daebfda0834b028bf2db9075f04bf6b028185df6076ede3a7227cb9755a6ac9e8db609431d063261f3c0732d
+  metadata.gz: ca4a89d161ef3a57ee325ea6551417b9e542967d2f932f383eca6e7394ba99f02cf08ac9cd699e98f1f59018669405220fe1175f80d31f60576fc606d2d3f5f6
+  data.tar.gz: 70644778b22b9fe2892d12704cdfb3d81337702e8770ca94f8410694e3a8b12ad931bc511bc5188f77726849fca7c87c1ce8fec059d647ea4225adf6ab1363ef

data/README.md

@@ -55,7 +55,7 @@ ActiveRecordDoctor::Rake::Task.new do |task|
   task.deps = []
 
   # A path to your active_record_doctor configuration file.
-  task.config_path = ::Rails.root.join(".active_record_doctor")
+  task.config_path = ::Rails.root.join(".active_record_doctor.rb")
 
   # A Proc called right before running detectors that should ensure your Active
   # Record models are preloaded and a database connection is ready.
@@ -111,7 +111,7 @@ If you want to use the default configuration then you don't have to do anything.
 Just run `active_record_doctor` in your project directory.
 
 If you want to customize the tool you should create a file named
-`.active_record_doctor` in your project root directory with content like:
+`.active_record_doctor.rb` in your project root directory with content like:
 
 ```ruby
 ActiveRecordDoctor.configure do
@@ -144,6 +144,33 @@ as extraneous.
 Configuration options for each detector are listed below. They can also be
 obtained via the help mechanism described in the previous section.
 
+### Regexp-Based Ignores
+
+Settings like `ignore_tables`, `ignore_indexes`, and so on accept list of
+identifiers to ignore. These can be either:
+
+1. Strings - in which case an exact match is needed.
+2. Regexps - which are matched against object names, and matching ones are
+   excluded from output.
+
+For example, to ignore all tables starting with `legacy_` you can write:
+
+```ruby
+ActiveRecordDoctor.configure do
+  global :ignore_tables, [
+    # Ignore internal Rails-related tables.
+    "ar_internal_metadata",
+    "schema_migrations",
+    "active_storage_blobs",
+    "active_storage_attachments",
+    "action_text_rich_texts",
+
+    # Ignore all legacy tables.
+    /^legacy_/
+  ]
+end
+```
+
 ### Indexing Unindexed Foreign Keys
 
 Foreign keys should be indexed unless it's proven ineffective. However, Rails

data/lib/active_record_doctor/config/loader.rb

@@ -27,7 +27,7 @@ module ActiveRecordDoctor # :nodoc:
       end
 
       # The same global can be used by multiple detectors so we must remove
-      # duplicates to ensure they aren't reported mutliple times via the user
+      # duplicates to ensure they aren't reported multiple times via the user
       # interface (e.g. in error messages).
       recognized_globals.uniq!
 

data/lib/active_record_doctor/detectors/base.rb

@@ -170,7 +170,7 @@ module ActiveRecordDoctor
             case
             when model.name.start_with?("HABTM_")
               log("#{model.name} - has-belongs-to-many model; skipping")
-            when except.include?(model.name)
+            when ignored?(model.name, except)
               log("#{model.name} - ignored via the configuration; skipping")
             when abstract && !model.abstract_class?
               log("#{model.name} - non-abstract model; skipping")
@@ -200,7 +200,7 @@ module ActiveRecordDoctor
         log(message) do
           indexes.each do |index|
             case
-            when except.include?(index.name)
+            when ignored?(index.name, except)
               log("#{index.name} - ignored via the configuration; skipping")
             when multicolumn_only && !index.columns.is_a?(Array)
               log("#{index.name} - single-column index; skipping")
@@ -217,7 +217,7 @@ module ActiveRecordDoctor
         log("Iterating over attributes of #{model.name}") do
           connection.columns(model.table_name).each do |column|
             case
-            when except.include?("#{model.name}.#{column.name}")
+            when ignored?("#{model.name}.#{column.name}", except)
               log("#{model.name}.#{column.name} - ignored via the configuration; skipping")
             when type && !Array(type).include?(column.type)
               log("#{model.name}.#{column.name} - ignored due to the #{column.type} type; skipping")
@@ -234,7 +234,7 @@ module ActiveRecordDoctor
         log("Iterating over columns of #{table_name}") do
           connection.columns(table_name).each do |column|
             case
-            when except.include?("#{table_name}.#{column.name}")
+            when ignored?("#{table_name}.#{column.name}", except)
               log("#{column.name} - ignored via the configuration; skipping")
             when only.nil? || only.include?(column.name)
               log(column.name.to_s) do
@@ -266,7 +266,7 @@ module ActiveRecordDoctor
         log("Iterating over tables") do
           tables.each do |table|
             case
-            when except.include?(table)
+            when ignored?(table, except)
               log("#{table} - ignored via the configuration; skipping")
             else
               log(table) do
@@ -280,7 +280,7 @@ module ActiveRecordDoctor
       def each_data_source(except: [])
         log("Iterating over data sources") do
           connection.data_sources.each do |data_source|
-            if except.include?(data_source)
+            if ignored?(data_source, except)
               log("#{data_source} - ignored via the configuration; skipping")
             else
               log(data_source) do
@@ -303,7 +303,7 @@ module ActiveRecordDoctor
 
           associations.each do |association|
             case
-            when except.include?("#{model.name}.#{association.name}")
+            when ignored?("#{model.name}.#{association.name}", except)
               log("#{model.name}.#{association.name} - ignored via the configuration; skipping")
             when through && !association.is_a?(ActiveRecord::Reflection::ThroughReflection)
               log("#{model.name}.#{association.name} - is not a through association; skipping")
@@ -321,6 +321,10 @@ module ActiveRecordDoctor
           end
         end
       end
+
+      def ignored?(name, patterns)
+        patterns.any? { |pattern| pattern === name } # rubocop:disable Style/CaseEquality
+      end
     end
   end
 end

data/lib/active_record_doctor/detectors/incorrect_boolean_presence_validation.rb

@@ -5,7 +5,7 @@ require "active_record_doctor/detectors/base"
 module ActiveRecordDoctor
   module Detectors
     class IncorrectBooleanPresenceValidation < Base # :nodoc:
-      @description = "detect persence (instead of inclusion) validators on boolean columns"
+      @description = "detect presence (instead of inclusion) validators on boolean columns"
       @config = {
         ignore_models: {
           description: "models whose validators should not be checked",

data/lib/active_record_doctor/detectors/incorrect_dependent_option.rb

@@ -38,8 +38,8 @@ module ActiveRecordDoctor
         when :invalid_through
           "ensure #{model}.#{association} is configured correctly - #{associated_models[0]}.#{association} may be undefined"
         when :destroy_async
-          "don't use `dependent: :destroy_async` on #{model}.#{association} or remove the foreign key from #{table_name}.#{column_name} - "\
-            "associated models will be deleted in the same transaction along with #{model}"
+          "don't use `dependent: :destroy_async` on #{model}.#{association} or remove the foreign key from #{table_name}.#{column_name} - " \
+          "associated models will be deleted in the same transaction along with #{model}"
         when :suggest_destroy
           "use `dependent: :destroy` or similar on #{model}.#{association} - associated #{models_part} callbacks that are currently skipped"
         when :suggest_delete
@@ -96,8 +96,13 @@ module ActiveRecordDoctor
             when :destroy_async
               foreign_key = foreign_key(association.klass.table_name, model.table_name)
               if foreign_key
-                problem!(model: model.name, association: association.name,
-                         table_name: foreign_key.from_table, column_name: foreign_key.column, problem: :destroy_async)
+                problem!(
+                  model: model.name,
+                  association: association.name,
+                  table_name: foreign_key.from_table,
+                  column_name: foreign_key.column,
+                  problem: :destroy_async
+                )
               end
             when :destroy
               if destroyable_models.empty? && deletable_models.present?

data/lib/active_record_doctor/detectors/mismatched_foreign_key_type.rb

@@ -29,7 +29,7 @@ module ActiveRecordDoctor
           each_foreign_key(table) do |foreign_key|
             from_column = column(table, foreign_key.column)
 
-            next if config(:ignore_columns).include?("#{table}.#{from_column.name}")
+            next if ignored?("#{table}.#{from_column.name}", config(:ignore_columns))
 
             to_table = foreign_key.to_table
             to_column = column(to_table, foreign_key.primary_key)

data/lib/active_record_doctor/detectors/missing_non_null_constraint.rb

@@ -26,14 +26,14 @@ module ActiveRecordDoctor
         table_models = models.select(&:table_exists?).group_by(&:table_name)
 
         table_models.each do |table, models|
-          next if config(:ignore_tables).include?(table)
+          next if ignored?(table, config(:ignore_tables))
 
           concrete_models = models.reject do |model|
             model.abstract_class? || sti_base_model?(model)
           end
 
           connection.columns(table).each do |column|
-            next if config(:ignore_columns).include?("#{table}.#{column.name}")
+            next if ignored?("#{table}.#{column.name}", config(:ignore_columns))
             next if !column.null
             next if !concrete_models.all? { |model| non_null_needed?(model, column) }
             next if not_null_check_constraint_exists?(table, column)

data/lib/active_record_doctor/detectors/missing_unique_indexes.rb

@@ -24,8 +24,8 @@ module ActiveRecordDoctor
         when :validations
           "add a unique index on #{table}(#{columns.join(', ')}) - validating uniqueness in #{model.name} without an index can lead to duplicates"
         when :case_insensitive_validations
-          "add a unique expression index on #{table}(#{columns.join(', ')}) - validating case-insensitive uniqueness in #{model.name} "\
-            "without an expression index can lead to duplicates (a regular unique index is not enough)"
+          "add a unique expression index on #{table}(#{columns.join(', ')}) - validating case-insensitive uniqueness in #{model.name} " \
+          "without an expression index can lead to duplicates (a regular unique index is not enough)"
         when :has_ones
           "add a unique index on #{table}(#{columns.join(', ')}) - using `has_one` in #{model.name} without an index can lead to duplicates"
         end
@@ -70,8 +70,12 @@ module ActiveRecordDoctor
               if case_sensitive
                 problem!(model: model, table: model.table_name, columns: columns, problem: :validations)
               else
-                problem!(model: model, table: model.table_name, columns: columns,
-                         problem: :case_insensitive_validations)
+                problem!(
+                  model: model,
+                  table: model.table_name,
+                  columns: columns,
+                  problem: :case_insensitive_validations
+                )
               end
             end
           end
@@ -81,7 +85,7 @@ module ActiveRecordDoctor
       def has_ones_without_indexes # rubocop:disable Naming/PredicateName
         each_model do |model|
           each_association(model, type: :has_one, has_scope: false, through: false) do |has_one|
-            next if config(:ignore_models).include?(has_one.klass.name)
+            next if ignored?(has_one.klass.name, config(:ignore_models))
 
             columns =
               if has_one.options[:as]
@@ -89,10 +93,11 @@ module ActiveRecordDoctor
               else
                 [has_one.foreign_key.to_s]
               end
-            next if ignore_columns.include?("#{model.name}(#{columns.join(',')})")
+            next if ignored?("#{has_one.klass.name}(#{columns.join(',')})", ignore_columns)
 
             table_name = has_one.klass.table_name
             next if unique_index?(table_name, columns)
+            next if Array(connection.primary_key(table_name)) == columns
 
             problem!(model: model, table: table_name, columns: columns, problem: :has_ones)
           end
@@ -136,7 +141,11 @@ module ActiveRecordDoctor
 
       def ignore_columns
         @ignore_columns ||= config(:ignore_columns).map do |column|
-          column.gsub(" ", "")
+          if column.is_a?(String)
+            column.gsub(" ", "")
+          else
+            column
+          end
         end
       end
 

data/lib/active_record_doctor/detectors/unindexed_foreign_keys.rb

@@ -30,6 +30,7 @@ module ActiveRecordDoctor
             next unless named_like_foreign_key?(column) || foreign_key?(table, column)
             next if indexed?(table, column)
             next if indexed_as_polymorphic?(table, column)
+            next if connection.primary_key(table) == column.name
 
             type_column_name = type_column_name(column)
 

data/lib/active_record_doctor/logger/hierarchical.rb

@@ -9,7 +9,7 @@ module ActiveRecordDoctor
       end
 
       def log(message)
-        @io.puts("  " * @nesting + message.to_s)
+        @io.puts(("  " * @nesting) + message.to_s)
         return if !block_given?
 
         @nesting += 1

data/lib/active_record_doctor/railtie.rb

@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
 module ActiveRecordDoctor
-  class Railtie < Rails::Railtie
+  class Railtie < Rails::Railtie # :nodoc:
     rake_tasks do
       load "tasks/active_record_doctor.rake"
     end

data/lib/active_record_doctor/rake/task.rb

@@ -68,9 +68,41 @@ module ActiveRecordDoctor
       end
 
       def config
-        @config ||= begin
-          path = config_path && File.exist?(config_path) ? config_path : nil
-          ActiveRecordDoctor.load_config_with_defaults(path)
+        @config ||=
+          ActiveRecordDoctor.load_config_with_defaults(effective_config_path)
+      end
+
+      def effective_config_path
+        if config_path.nil?
+          # No explicit config_path was set, so we're trying to use defaults.
+          legacy_default_path = Rails.root.join(".active_record_doctor")
+          new_default_path = Rails.root.join(".active_record_doctor.rb")
+
+          # First, if the legacy file exists we'll use it but show a warning.
+          if legacy_default_path.exist?
+            warn(<<~WARN.squish)
+              DEPRECATION WARNING: active_record_doctor is using the default
+              configuration file located in #{legacy_default_path.basename}. However,
+              that default will change to #{new_default_path.basename} in the future.
+
+              In order to avoid errors, please rename the file from
+              #{legacy_default_path.basename} to #{new_default_path.basename}.
+            WARN
+
+            return legacy_default_path
+          end
+
+          # Second, if the legacy file does NOT exist, but the new one does then
+          # we'll use that.
+          if new_default_path.exist?
+            return new_default_path
+          end
+
+          # Otherwise, there's no configuration file in use.
+          nil
+        else
+          # If an explicit configuration file was set then we use it as is.
+          config_path
         end
       end
 

data/lib/active_record_doctor/runner.rb

@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
 module ActiveRecordDoctor # :nodoc:
-  # An excecution environment for active_record_doctor that provides a config
+  # An execution environment for active_record_doctor that provides a config
   # and an output device for use by detectors.
   class Runner
     # io is injected via constructor parameters to facilitate testing.

data/lib/active_record_doctor/utils.rb

@@ -13,8 +13,8 @@ module ActiveRecordDoctor
 
       def expression_indexes_unsupported?(connection = ActiveRecord::Base.connection)
         (ActiveRecord::VERSION::STRING < "5.0") ||
-          # Active Record < 6 is unable to correctly parse expression indexes for MySQL.
-          (mysql?(connection) && ActiveRecord::VERSION::STRING < "6.0")
+          # Active Record is unable to correctly parse expression indexes for MySQL.
+          (mysql?(connection) && ActiveRecord::VERSION::STRING < "7.1")
       end
     end
   end

data/lib/active_record_doctor/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module ActiveRecordDoctor
-  VERSION = "1.12.0"
+  VERSION = "1.14.0"
 end

data/lib/tasks/active_record_doctor.rake

@@ -19,6 +19,5 @@ ActiveRecordDoctor::Rake::Task.new do |task|
   # This file is imported when active_record_doctor is being used as part of a
   # Rails app so it's the right place for all Rails-specific settings.
   task.deps = [:environment]
-  task.config_path = ::Rails.root.join(".active_record_doctor")
-  task.setup = -> { ::Rails.application.eager_load! }
+  task.setup = -> { Rails.application.eager_load! }
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: active_record_doctor
 version: !ruby/object:Gem::Version
-  version: 1.12.0
+  version: 1.14.0
 platform: ruby
 authors:
 - Greg Navis
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2023-07-27 00:00:00.000000000 Z
+date: 2023-12-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
@@ -58,14 +58,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.3.0
+        version: 1.1.4
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.3.0
+        version: 1.1.4
 - !ruby/object:Gem::Dependency
   name: railties
   requirement: !ruby/object:Gem::Requirement
@@ -100,28 +100,28 @@ dependencies:
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 1.0.0.rc1
+        version: 2.0.0.rc2
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 1.0.0.rc1
+        version: 2.0.0.rc2
 - !ruby/object:Gem::Dependency
   name: rubocop
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.14.0
+        version: 1.57.1
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.14.0
+        version: 1.57.1
 description:
 email:
 - contact@gregnavis.com
@@ -164,29 +164,11 @@ files:
 - lib/generators/active_record_doctor/add_indexes/USAGE
 - lib/generators/active_record_doctor/add_indexes/add_indexes_generator.rb
 - lib/tasks/active_record_doctor.rake
-- test/active_record_doctor/config/loader_test.rb
-- test/active_record_doctor/config_test.rb
-- test/active_record_doctor/detectors/disable_test.rb
-- test/active_record_doctor/detectors/extraneous_indexes_test.rb
-- test/active_record_doctor/detectors/incorrect_boolean_presence_validation_test.rb
-- test/active_record_doctor/detectors/incorrect_dependent_option_test.rb
-- test/active_record_doctor/detectors/incorrect_length_validation_test.rb
-- test/active_record_doctor/detectors/mismatched_foreign_key_type_test.rb
-- test/active_record_doctor/detectors/missing_foreign_keys_test.rb
-- test/active_record_doctor/detectors/missing_non_null_constraint_test.rb
-- test/active_record_doctor/detectors/missing_presence_validation_test.rb
-- test/active_record_doctor/detectors/missing_unique_indexes_test.rb
-- test/active_record_doctor/detectors/short_primary_key_type_test.rb
-- test/active_record_doctor/detectors/undefined_table_references_test.rb
-- test/active_record_doctor/detectors/unindexed_deleted_at_test.rb
-- test/active_record_doctor/detectors/unindexed_foreign_keys_test.rb
-- test/active_record_doctor/runner_test.rb
-- test/generators/active_record_doctor/add_indexes/add_indexes_generator_test.rb
-- test/setup.rb
 homepage: https://github.com/gregnavis/active_record_doctor
 licenses:
 - MIT
-metadata: {}
+metadata:
+  rubygems_mfa_required: 'true'
 post_install_message:
 rdoc_options: []
 require_paths:
@@ -202,27 +184,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.4.10
+rubygems_version: 3.3.26
 signing_key:
 specification_version: 4
 summary: Identify database issues before they hit production.
-test_files:
-- test/active_record_doctor/config/loader_test.rb
-- test/active_record_doctor/config_test.rb
-- test/active_record_doctor/detectors/disable_test.rb
-- test/active_record_doctor/detectors/extraneous_indexes_test.rb
-- test/active_record_doctor/detectors/incorrect_boolean_presence_validation_test.rb
-- test/active_record_doctor/detectors/incorrect_dependent_option_test.rb
-- test/active_record_doctor/detectors/incorrect_length_validation_test.rb
-- test/active_record_doctor/detectors/mismatched_foreign_key_type_test.rb
-- test/active_record_doctor/detectors/missing_foreign_keys_test.rb
-- test/active_record_doctor/detectors/missing_non_null_constraint_test.rb
-- test/active_record_doctor/detectors/missing_presence_validation_test.rb
-- test/active_record_doctor/detectors/missing_unique_indexes_test.rb
-- test/active_record_doctor/detectors/short_primary_key_type_test.rb
-- test/active_record_doctor/detectors/undefined_table_references_test.rb
-- test/active_record_doctor/detectors/unindexed_deleted_at_test.rb
-- test/active_record_doctor/detectors/unindexed_foreign_keys_test.rb
-- test/active_record_doctor/runner_test.rb
-- test/generators/active_record_doctor/add_indexes/add_indexes_generator_test.rb
-- test/setup.rb
+test_files: []

data/test/active_record_doctor/config/loader_test.rb

@@ -1,120 +0,0 @@
-# frozen_string_literal: true
-
-class ActiveRecordDoctor::LoaderTest < Minitest::Test
-  def test_load_config
-    config_path = config_file(<<-CONFIG)
-      ActiveRecordDoctor.configure do |config|
-        config.global :ignore_tables, ["schema_migrations"]
-
-        config.detector :extraneous_indexes, ignore_tables: ["users"]
-      end
-    CONFIG
-
-    config = ActiveRecordDoctor.load_config(config_path)
-
-    assert_equal(
-      { ignore_tables: ["schema_migrations"] },
-      config.globals
-    )
-    assert_equal(
-      { extraneous_indexes: { ignore_tables: ["users"] } },
-      config.detectors
-    )
-  end
-
-  def test_load_config_raises_when_configuration_file_missing
-    exc = assert_raises(ActiveRecordDoctor::Error::ConfigurationFileMissing) do
-      ActiveRecordDoctor.load_config("/tmp/config.rb")
-    end
-    assert_equal("/tmp/config.rb", exc.config_path)
-  end
-
-  def test_load_config_raises_when_configuration_file_raises
-    config_path = config_file("1/0")
-
-    assert_raises(ActiveRecordDoctor::Error::ConfigurationError) do
-      ActiveRecordDoctor.load_config(config_path)
-    end
-  end
-
-  def test_load_config_raises_when_configure_not_called
-    config_path = config_file("# configure is not called")
-
-    assert_raises(ActiveRecordDoctor::Error::ConfigureNotCalled) do
-      ActiveRecordDoctor.load_config(config_path)
-    end
-  end
-
-  def test_load_config_raises_when_configure_called_twice
-    config_path = config_file(<<-CONFIG)
-      ActiveRecordDoctor.configure { |config| }
-      ActiveRecordDoctor.configure { |config| }
-    CONFIG
-
-    assert_raises(ActiveRecordDoctor::Error::ConfigureCalledTwice) do
-      ActiveRecordDoctor.load_config(config_path)
-    end
-  end
-
-  def test_load_config_raises_when_unrecognized_global_set
-    config_path = config_file(<<-CONFIG)
-      ActiveRecordDoctor.configure do |config|
-        config.global :user, "acme"
-      end
-    CONFIG
-
-    assert_raises(ActiveRecordDoctor::Error::UnrecognizedGlobalSetting) do
-      ActiveRecordDoctor.load_config(config_path)
-    end
-  end
-
-  def test_load_config_raises_when_global_set_twice
-    config_path = config_file(<<-CONFIG)
-      ActiveRecordDoctor.configure do |config|
-        config.global :ignore_tables, ["schema_migrations"]
-        config.global :ignore_tables, ["schema_migrations"]
-      end
-    CONFIG
-
-    assert_raises(ActiveRecordDoctor::Error::DuplicateGlobalSetting) do
-      ActiveRecordDoctor.load_config(config_path)
-    end
-  end
-
-  def test_load_config_raises_when_configured_unrecognized_detector
-    config_path = config_file(<<-CONFIG)
-      ActiveRecordDoctor.configure do |config|
-        config.detector :other_performance_issues, {}
-      end
-    CONFIG
-
-    assert_raises(ActiveRecordDoctor::Error::UnrecognizedDetectorName) do
-      ActiveRecordDoctor.load_config(config_path)
-    end
-  end
-
-  def test_load_config_raises_when_detector_configured_twice
-    config_path = config_file(<<-CONFIG)
-      ActiveRecordDoctor.configure do |config|
-        config.detector :extraneous_indexes, ignore_tables: ["users"]
-        config.detector :extraneous_indexes, ignore_tables: ["users"]
-      end
-    CONFIG
-
-    assert_raises(ActiveRecordDoctor::Error::DetectorConfiguredTwice) do
-      ActiveRecordDoctor.load_config(config_path)
-    end
-  end
-
-  def test_load_config_raises_when_provided_unrecognized_detector_setting
-    config_path = config_file(<<-CONFIG)
-      ActiveRecordDoctor.configure do |config|
-        config.detector :extraneous_indexes, { delay: 1 }
-      end
-    CONFIG
-
-    assert_raises(ActiveRecordDoctor::Error::UnrecognizedDetectorSettings) do
-      ActiveRecordDoctor.load_config(config_path)
-    end
-  end
-end