active_record_compose 0.1.3 → 0.1.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 5d96a1edcbffbf687a7ba72f269c4c56f82ed09cd822d6e37780ed483a885db1
-  data.tar.gz: 8d0b1af5a534cc3f4d12217c01c593c8e7d8d4afef766e858efbf4a5e78cb689
+  metadata.gz: 1638c67c9c0cebca26544e01db7b210a0bde69d581471d3fbe771ada25c124b9
+  data.tar.gz: d7c43f6b81793f349a2f4e33132616b8dca2971a607d49ecedaa102fed1b1f5f
 SHA512:
-  metadata.gz: '099e7bc7b1dfe5335c059bb79ccde1834ae528ba55ff3b2dfd33b32f9637c704fd7f55085f3ad8d7d49735ee0dd81a272f46d62f5bc57def995c4e51da279159'
-  data.tar.gz: 6618050e453d8f132b842e5132a0e2b232f3a8deff1d4957215ab0433aa82d58f06cd7d727ad29ee22360ee5fe3b74dac375903d4b71b8379d2b8269128b0fef
+  metadata.gz: 9b9aca1764d28fdeb52b0d32fdc6fb0ca13e6c1891efd47335f18660935b36ae64be28cb1a6db08bf1b8b0d3d65aa9daa94bccdea03982112fd59386e57e7e50
+  data.tar.gz: 6888e57191546c7d698bde1f2741f280b930d8b8f1f648c02ec0cd025d54a8f89d88bb4dd1cbe0feaf0e37e5f1fd8d4885032259481536edcd73aad1d067aed8

data/CHANGELOG.md

@@ -1,5 +1,13 @@
 ## [Unreleased]
 
+## [0.1.5] - 2024-01-11
+
+- when invalid, raises ActiveRecord::RecordInvalid on #save!
+
+## [0.1.4] - 2024-01-10
+
+- remove uniquely defined exception class.
+
 ## [0.1.3] - 2024-01-09
 
 - fix documentation uri.

data/lib/active_record_compose/model.rb

@@ -12,8 +12,6 @@ module ActiveRecordCompose
 
     include ActiveRecordCompose::DelegateAttribute
 
-    class_attribute :error_class_on_save_error, instance_writer: false, default: ActiveRecordCompose::RecordNotSaved
-
     define_model_callbacks :save
     define_model_callbacks :create
     define_model_callbacks :update
@@ -30,7 +28,11 @@ module ActiveRecordCompose
       save_in_transaction { run_callbacks(:save) { save_models } }
     end
 
-    def save! = save || raise(error_class_on_save_error.new('Failed to save the model.', self))
+    def save!
+      valid? || raise_validation_error
+
+      save_in_transaction { run_callbacks(:save) { save_models } } || raise_on_save_error
+    end
 
     # Behavior is same to `#save`, but `before_create` and `after_create` hooks fires.
     #
@@ -67,7 +69,10 @@ module ActiveRecordCompose
     # Behavior is same to `#create`, but raises an exception prematurely on failure.
     #
     def create!(attributes = {})
-      create(attributes) || raise(error_class_on_save_error.new('Failed to create the model.', self))
+      assign_attributes(attributes)
+      valid? || raise_validation_error
+
+      save_in_transaction { run_callbacks(:save) { run_callbacks(:create) { save_models } } } || raise_on_save_error
     end
 
     # Behavior is same to `#save`, but `before_update` and `after_update` hooks fires.
@@ -105,7 +110,10 @@ module ActiveRecordCompose
     # Behavior is same to `#update`, but raises an exception prematurely on failure.
     #
     def update!(attributes = {})
-      update(attributes) || raise(error_class_on_save_error.new('Failed to update the model.', self))
+      assign_attributes(attributes)
+      valid? || raise_validation_error
+
+      save_in_transaction { run_callbacks(:save) { run_callbacks(:update) { save_models } } } || raise_on_save_error
     end
 
     private
@@ -131,5 +139,9 @@ module ActiveRecordCompose
     end
 
     def save_models = wrapped_models.all? { _1.save! }
+
+    def raise_validation_error = raise ActiveRecord::RecordInvalid, self
+
+    def raise_on_save_error = raise ActiveRecord::RecordNotSaved.new('Failed to save the model.', self)
   end
 end

data/lib/active_record_compose/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module ActiveRecordCompose
-  VERSION = '0.1.3'
+  VERSION = '0.1.5'
 end

data/lib/active_record_compose.rb

@@ -3,7 +3,6 @@
 require 'active_record'
 
 require_relative 'active_record_compose/version'
-require_relative 'active_record_compose/error'
 require_relative 'active_record_compose/inner_model'
 require_relative 'active_record_compose/inner_model_collection'
 require_relative 'active_record_compose/model'

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: active_record_compose
 version: !ruby/object:Gem::Version
-  version: 0.1.3
+  version: 0.1.5
 platform: ruby
 authors:
 - hamajyotan
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2024-01-09 00:00:00.000000000 Z
+date: 2024-01-11 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
@@ -54,7 +54,6 @@ files:
 - Rakefile
 - lib/active_record_compose.rb
 - lib/active_record_compose/delegate_attribute.rb
-- lib/active_record_compose/error.rb
 - lib/active_record_compose/inner_model.rb
 - lib/active_record_compose/inner_model_collection.rb
 - lib/active_record_compose/model.rb
@@ -66,7 +65,7 @@ metadata:
   homepage_uri: https://github.com/hamajyotan/active_record_compose
   source_code_uri: https://github.com/hamajyotan/active_record_compose
   changelog_uri: https://github.com/hamajyotan/active_record_compose/blob/main/CHANGELOG.md
-  documentation_uri: https://www.rubydoc.info/gems/active_record_compose/0.1.3
+  documentation_uri: https://www.rubydoc.info/gems/active_record_compose/0.1.5
   rubygems_mfa_required: 'true'
 post_install_message:
 rdoc_options: []

data/lib/active_record_compose/error.rb

@@ -1,14 +0,0 @@
-# frozen_string_literal: true
-
-module ActiveRecordCompose
-  class Error < ::StandardError; end
-
-  class RecordNotSaved < ::ActiveRecordCompose::Error
-    def initialize(message, record)
-      super(message)
-      @record = record
-    end
-
-    attr_reader :record
-  end
-end