active_record-updated_at 0.0.1 → 0.0.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 395371ee4b162e5c5bf8235811222b4097e6ead7
-  data.tar.gz: d2b3362724771f82de0efb358348025eaf937da7
+  metadata.gz: e7e02ac57f228b518bd7cc7126a8cd6671f69378
+  data.tar.gz: 23a49a276233f00325ab7ab31b72ace2c3b6eb57
 SHA512:
-  metadata.gz: b859883939d611983f98be7d5495e0aaad6888f443548ac7a5fb8bf05e17ba9f5b95ef72d7ff7b006eb982b857e0728c71c53a75f2d5b53f290761fdd98d0f0b
-  data.tar.gz: 5d9496e37271d9e5c1e0c1b84a03be46cb4b98bd6c6aaaf519d4e0c07abbdc5b037925d85dbcee7eaaf6702cdafcf6357cc2a34878c05514b6eba88e79fdb81f
+  metadata.gz: 56b39e970c3d9e6db9ab23e4bf5ca9091543f8ec07916b9f3875d892f68af0e6d88be8bff500b736aba3eb276f47da5949a76fc08e1b8e677269347a808c7dcd
+  data.tar.gz: e86f9f6f381e4dc9487e3c187b98d300453c260b24e84cce02553cc75e70597c233f9259ee6464bbc0c8be19bf1cd381e8b97b564fac2b3c0ffacf973c3de601

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    active_record-updated_at (0.0.1)
+    active_record-updated_at (0.0.2)
       activerecord
 
 GEM

data/README.md

@@ -1,7 +1,7 @@
 # ![LendingHome](https://cloud.githubusercontent.com/assets/2419/19467866/7efa93a8-94c8-11e6-93e7-4375dbb8a7bc.png) active_record-updated_at
 [![Code Climate](https://codeclimate.com/github/LendingHome/active_record-updated_at/badges/gpa.svg)](https://codeclimate.com/github/LendingHome/active_record-updated_at) [![Coverage](https://codeclimate.com/github/LendingHome/active_record-updated_at/badges/coverage.svg)](https://codeclimate.com/github/LendingHome/active_record-updated_at) [![Gem Version](https://badge.fury.io/rb/active_record-updated_at.svg)](http://badge.fury.io/rb/active_record-updated_at)
 
-> Touch `updated_at` by default with calls to `update_column(s)` and `update_all`
+> Touch `updated_at` by default with calls to `update_all` and `update_column(s)`
 
 ## Installation
 
@@ -19,7 +19,7 @@ The default `ActiveRecord` behavior does not touch `updated_at` when the followi
 * `ActiveRecord::Base#update_columns`
 * `ActiveRecord::Relation#update_all`
 
-We **rarely ever have a case to modify data WITHOUT touching `updated_at`** so this gem enables the touching behavior by default. For those rare occassions that we don't want the touching we can wrap these calls in a `disable` block explicitly:
+We **rarely ever have a case to modify data WITHOUT touching `updated_at`** so this gem enables the touching behavior by default. For those rare occasions that we don't want the touching we can wrap these calls in a `disable` block explicitly:
 
 ```ruby
 ActiveRecord::UpdatedAt.disable { User.update_all(role: "member") }

data/active_record-updated_at.gemspec

@@ -11,7 +11,7 @@ Gem::Specification.new do |s|
   s.required_ruby_version = ">= 2.0.0"
   s.summary               = "Touch `updated_at` by default with calls to `update_column(s)` and `update_all`"
   s.test_files            = `git ls-files -- spec/*`.split("\n")
-  s.version               = "0.0.1"
+  s.version               = "0.0.2"
 
   s.add_dependency "activerecord"
 end

data/lib/active_record-updated_at.rb

@@ -3,15 +3,17 @@ require_relative "active_record/updated_at/relation"
 
 module ActiveRecord
   module UpdatedAt
-    ActiveRecord::Relation.send(:prepend, Relation)
+    ActiveRecord::Relation.send(:include, Relation)
+
+    STATE = "#{name}::DISABLED".freeze
 
     class << self
       def disable(state = true)
-        disabled_was = @disabled
-        @disabled = state
+        disabled_was = Thread.current[STATE]
+        Thread.current[STATE] = state
         yield
       ensure
-        @disabled = disabled_was
+        Thread.current[STATE] = disabled_was
       end
 
       def enable(&block)
@@ -19,7 +21,7 @@ module ActiveRecord
       end
 
       def enabled?
-        !@disabled
+        !Thread.current[STATE]
       end
     end
   end

data/lib/active_record/updated_at/relation.rb

@@ -1,7 +1,27 @@
 module ActiveRecord
   module UpdatedAt
     module Relation
-      def update_all(query, *args, &block)
+      def self.included(base)
+        base.class_eval do
+          # We were originally using `prepend` to inject this behavior
+          # directly into the `update_all` method but this was causing
+          # `SystemStackError` exceptions when loaded alongside other
+          # gems like `newrelic_rpm` which uses alias method chains.
+          #
+          # It's unlikely NewRelic will change their API anytime soon
+          # since they have to support older versions of Ruby which do
+          # not support `prepend` so we'll use this deprecated style
+          # of method injection.
+          #
+          # Newer versions of ActiveRecord have already deprecated the
+          # old `alias_method_chain` method so we're doing it manually
+          # here to avoid deprecation warnings.
+          alias_method :update_all_without_updated_at, :update_all
+          alias_method :update_all, :update_all_with_updated_at
+        end
+      end
+
+      def update_all_with_updated_at(query, *args, &block)
         attribute_exists = column_names.include?("updated_at")
         already_specified = Array(query).flatten.grep(/\bupdated_at\b/).any?
         enabled = UpdatedAt.enabled?
@@ -19,7 +39,7 @@ module ActiveRecord
           end
         end
 
-        super
+        update_all_without_updated_at(query, *args, &block)
       end
     end
   end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: active_record-updated_at
 version: !ruby/object:Gem::Version
-  version: 0.0.1
+  version: 0.0.2
 platform: ruby
 authors:
 - LendingHome
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-11-09 00:00:00.000000000 Z
+date: 2016-11-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord