active_record-pg_generate_series 0.1.1 → 0.1.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 822623f5320e70fc69f92567ca61147dc712256e
-  data.tar.gz: 3724a26faee2d872b87146ab39bf546cbf7042b1
+  metadata.gz: d9174923b9800d2bbe387a990d821623dd588fb2
+  data.tar.gz: cf2171a8c525c9cf5bc0034e8572025037b755fc
 SHA512:
-  metadata.gz: c185a24725301a526edf31fc59fd2d20f99d874c059b05de4a4af7f6fd454df702f7b33eb222d5fd30fb39f767c90b4e799653dbb445ba7e8d289aefc3030e30
-  data.tar.gz: a5caacd0085dd2af2b50b435033482ea16e5ad1df1d145a5fe358008d31012f284788b4ff290496080b92d44cce9907d8cde26f590045c6f613dfd51e588cc27
+  metadata.gz: ddc6aee50a0941fd1eaadb7e0920df4093743cbe253f451c2cab733f05214989ba9cebaac830e630a473f28fbb51fa935e613848e3a1ab4e786408de21486b8d
+  data.tar.gz: e8101995e0f940943e0f5993c46e88cb5e4516c48c8eef26c97322cf40b35da60961cab0026d6b4f579b7412c198e259b384abe1b35d30ca449f445c0a5a37a5

data/.codeclimate.yml

@@ -0,0 +1,16 @@
+---
+engines:
+  duplication:
+    enabled: true
+    config:
+      languages:
+      - ruby
+  fixme:
+    enabled: true
+  rubocop:
+    enabled: true
+ratings:
+  paths:
+  - "**.rb"
+exclude_paths:
+- spec/

data/.rubocop.yml

@@ -0,0 +1,63 @@
+AllCops:
+  DisplayCopNames: true
+
+##################### Linting #############################
+
+##################### Metrics #############################
+
+Metrics/AbcSize:
+  Max: 20
+
+Metrics/BlockLength:
+  Exclude:
+    - 'spec/**/*'
+    - '*.gemspec'
+
+Metrics/LineLength:
+  Max: 120
+
+Metrics/MethodLength:
+  Max: 30
+
+Metrics/ParameterLists:
+  CountKeywordArgs: false
+
+##################### Performance #############################
+
+Performance/FlatMap:
+  EnabledForFlattenWithoutParams: false
+
+Performance/RedundantBlockCall:
+  Enabled: false
+
+##################### Rails ##################################
+
+Rails/SafeNavigation:
+  ConvertTry: true
+
+Rails/SaveBang:
+  Enabled: true
+
+##################### Security ##################################
+
+Security/YAMLLoad:
+  Enabled: false
+
+##################### Style #################################
+
+Style/AutoResourceCleanup:
+  Enabled: true
+
+Style/Encoding:
+  Enabled: true
+  EnforcedStyle: never
+
+Style/IfUnlessModifier:
+  Enabled: false
+
+Style/MultilineMethodCallIndentation:
+  Enabled: false
+
+##################### Bundler #################################
+Bundler/OrderedGems:
+  Enabled: false

data/.travis.yml

@@ -16,9 +16,14 @@ sudo: false
 services:
   - postgresql
 
-before_install: gem update bundler --no-document
-before_script: 'bundle exec ruby bin/db_setup.rb'
-script: 'bundle exec rake spec'
+before_install:
+  - 'gem update bundler --no-document'
+before_script:
+ - 'bundle exec ruby bin/db_setup.rb'
+script:
+  - 'bundle exec rspec'
+after_success:
+  - 'bundle exec codeclimate-test-reporter'
 
 cache: bundler
 

data/CHANGELOG.md

@@ -0,0 +1,14 @@
+# Change logs
+
+## v0.1.2
+
+* Add rubocop and fix its offenses. (#4)
+* Add codeclimate and fix its errors. (#5, #6)
+
+## v0.1.1
+
+* Add frozen string literal comment. (#3)
+
+## v0.1.0
+
+* First release.

data/Gemfile

@@ -1,4 +1,8 @@
 source 'https://rubygems.org'
 
-# Specify your gem's dependencies in active_record-pg_generate_series.gemspec
+group :test do
+  gem 'simplecov'
+  gem 'codeclimate-test-reporter', '~> 1.0.0'
+end
+
 gemspec

data/README.md

@@ -1,6 +1,10 @@
 # ActiveRecord::PgGenerateSeries
 
+[![Gem Version](https://badge.fury.io/rb/active_record-pg_generate_series.svg)](https://badge.fury.io/rb/active_record-pg_generate_series)
 [![Build Status](https://travis-ci.org/ryu39/active_record-pg_generate_series.svg?branch=master)](https://travis-ci.org/ryu39/active_record-pg_generate_series)
+[![Code Climate](https://codeclimate.com/github/ryu39/active_record-pg_generate_series/badges/gpa.svg)](https://codeclimate.com/github/ryu39/active_record-pg_generate_series)
+[![Test Coverage](https://codeclimate.com/github/ryu39/active_record-pg_generate_series/badges/coverage.svg)](https://codeclimate.com/github/ryu39/active_record-pg_generate_series/coverage)
+[![Issue Count](https://codeclimate.com/github/ryu39/active_record-pg_generate_series/badges/issue_count.svg)](https://codeclimate.com/github/ryu39/active_record-pg_generate_series)
 
 This gem adds a feature which inserts records using PostgreSQL [GENERATE_SERIES](https://www.postgresql.org/docs/current/static/functions-srf.html) function to ActiveRecord.
 

data/Rakefile

@@ -1,6 +1,8 @@
-require "bundler/gem_tasks"
-require "rspec/core/rake_task"
+require 'bundler/gem_tasks'
+require 'rspec/core/rake_task'
+require 'rubocop/rake_task'
 
 RSpec::Core::RakeTask.new(:spec)
+RuboCop::RakeTask.new(:spec)
 
-task :default => :spec
+task default: :spec

data/active_record-pg_generate_series.gemspec

@@ -1,4 +1,3 @@
-# coding: utf-8
 lib = File.expand_path('../lib', __FILE__)
 $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 require 'active_record/pg_generate_series/version'
@@ -9,8 +8,8 @@ Gem::Specification.new do |spec|
   spec.authors       = ['ryu39']
   spec.email         = ['dev.ryu39@gmail.com']
 
-  spec.summary       = %q{Add a feature which inserts records using PostgreSQL generate_series function to ActiveRecord}
-  spec.description   = <<EOS.gsub("\n", ' ')
+  spec.summary       = 'Add a feature which inserts records using PostgreSQL generate_series function to ActiveRecord'
+  spec.description   = <<EOS.tr("\n", ' ')
 This gem adds a feature which inserts records using PostgreSQL generate_series function to ActiveRecord.
 Insertion using generate_series function is very fast, so it is useful
 when you want to insert simple but many and many record, e.g. prepare for performance test.
@@ -30,6 +29,7 @@ EOS
   spec.add_development_dependency 'bundler', '~> 1.13'
   spec.add_development_dependency 'rake', '~> 10.0'
   spec.add_development_dependency 'rspec', '>= 3.5'
+  spec.add_development_dependency 'rubocop'
   spec.add_development_dependency 'pry'
   spec.add_development_dependency 'pg'
   spec.add_development_dependency 'activerecord-import'

data/bin/benchmark.rb

@@ -10,21 +10,23 @@ require 'benchmark'
 
 RECORD_NUM = 10_000
 
+def build_user(num)
+  User.new(name: "name#{num + 1}", age: num + 1, birth_date: Date.today + num + 1)
+end
+
 User.delete_all
 
 GC.disable
 Benchmark.bm(36) do |x|
   x.report('iteration of ActiveRecord::Base#save') do
     RECORD_NUM.times do |i|
-      user = User.new(name: "name#{i + 1}", age: i + 1, birth_date: Date.today + i + 1)
+      user = build_user(i)
       user.save(validate: false)
     end
   end
 
   x.report('bulk insert(activerecord-import)') do
-    users = RECORD_NUM.times.map do |i|
-      User.new(name: "name#{i + 1}", age: i + 1, birth_date: Date.today + i + 1)
-    end
+    users = Array.new(RECORD_NUM) { |i| build_user(i) }
     User.import(users)
   end
 

data/bin/db_setup.rb

@@ -4,7 +4,7 @@ require 'yaml'
 require 'active_record'
 
 config_file = File.expand_path('../../database.yml', __FILE__)
-config = YAML::load(ERB.new(IO.read(config_file)).result)['db']
+config = YAML.load(ERB.new(IO.read(config_file)).result)['db']
 
 ActiveRecord::Base.establish_connection(config.merge('database' => 'postgres'))
 ActiveRecord::Base.connection.drop_database(config['database'])

data/connect_db.rb

@@ -4,6 +4,6 @@ require 'yaml'
 require 'active_record'
 
 config_file = File.expand_path('../database.yml', __FILE__)
-config = YAML::load(ERB.new(IO.read(config_file)).result)['db']
+config = YAML.load(ERB.new(IO.read(config_file)).result)['db']
 
 ActiveRecord::Base.establish_connection(config)

data/gemfiles/active_record_32.gemfile

@@ -2,4 +2,9 @@ source 'https://rubygems.org'
 
 gem 'activerecord', '~> 3.2.0', require: 'active_record'
 
+group :test do
+  gem 'simplecov'
+  gem 'codeclimate-test-reporter', '~> 1.0.0'
+end
+
 gemspec path: '../'

data/gemfiles/active_record_42.gemfile

@@ -1,5 +1,9 @@
 source 'https://rubygems.org'
 
 gem 'activerecord', '~> 4.2.0', require: 'active_record'
+group :test do
+  gem 'simplecov'
+  gem 'codeclimate-test-reporter', '~> 1.0.0'
+end
 
 gemspec path: '../'

data/gemfiles/active_record_50.gemfile

@@ -1,5 +1,9 @@
 source 'https://rubygems.org'
 
 gem 'activerecord', '~> 5.0.0', require: 'active_record'
+group :test do
+  gem 'simplecov'
+  gem 'codeclimate-test-reporter', '~> 1.0.0'
+end
 
 gemspec path: '../'

data/lib/active_record/pg_generate_series/extension.rb

@@ -3,6 +3,7 @@ require 'active_record/pg_generate_series/sql_builder'
 
 module ActiveRecord
   module PgGenerateSeries
+    # A ActiveRecord::Base extension module to use PostgreSQL GENERATE_SERIES function.
     module Extension
       # Execute INSERT SQL using GENERATE_SERIES function
       #

data/lib/active_record/pg_generate_series/sql_builder.rb

@@ -3,6 +3,7 @@ require 'forwardable'
 
 module ActiveRecord
   module PgGenerateSeries
+    # SQL builder using PostgreSQL GENERATE_SERIES function.
     class SqlBuilder
       extend Forwardable
       def_delegators :@ar_class, :connection, :sanitize, :quoted_table_name
@@ -27,7 +28,7 @@ module ActiveRecord
 INSERT INTO
   #{quoted_table_name} (#{@select_items.keys.map { |col| connection.quote_column_name(col) }.join(',')})
 SELECT
-  #{@select_items.map { |_, val| "#{val.is_a?(Raw) ? val.str : sanitize(val)}" }.join(",\n  ")}
+  #{@select_items.values.map { |val| val.is_a?(Raw) ? val.str : sanitize(val) }.join(",\n  ")}
 FROM
   GENERATE_SERIES(#{@first.to_i}, #{@last.to_i}, #{@step.to_i}) AS #{connection.quote_column_name(@seq_name)}
 ;
@@ -36,6 +37,7 @@ EOS
 
       private
 
+      # no doc
       class Raw
         attr_reader :str
 

data/lib/active_record/pg_generate_series/version.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 module ActiveRecord
   module PgGenerateSeries
-    VERSION = '0.1.1'
+    VERSION = '0.1.2'.freeze
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: active_record-pg_generate_series
 version: !ruby/object:Gem::Version
-  version: 0.1.1
+  version: 0.1.2
 platform: ruby
 authors:
 - ryu39
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2017-02-27 00:00:00.000000000 Z
+date: 2017-03-26 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
@@ -66,6 +66,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '3.5'
+- !ruby/object:Gem::Dependency
+  name: rubocop
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: pry
   requirement: !ruby/object:Gem::Requirement
@@ -118,9 +132,12 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
+- ".codeclimate.yml"
 - ".gitignore"
 - ".rspec"
+- ".rubocop.yml"
 - ".travis.yml"
+- CHANGELOG.md
 - CODE_OF_CONDUCT.md
 - Gemfile
 - LICENSE.txt