active_record-mod_sql_log_subscriber 0.1.1 → 0.1.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: c54b21fd7a68cb5810c3133e11c170252c498c50ac5ca27636d12ed22a5dd66c
-  data.tar.gz: 3d1dd5f24f747bd4ec8e16275ceb50f50250113b858b42c958bd993d338166fe
+  metadata.gz: 4db0c79ca185a749a8aed8dc821e28f3c7de8ef6932e4069b3dfd904fb588e9e
+  data.tar.gz: 80524d959e775f16eef4dd27775e2612f3fe2f6d17d3a64e1e6fbfe1cc4250c5
 SHA512:
-  metadata.gz: 679d7aba887b8640ae1fdce95d63ea51b3e2c3c2c0f70695666c9f493f9e0dc4e15a7518fc5666def3511ace0b259e75f99e33cacf04b13547293a23336bf063
-  data.tar.gz: 587fb2221a219be48a20216faa56c1d3c4ba7afeb43dba7abe485502d715c93671c494bd038daa5c4351a885eb37e39755a86b0d48da6d30643e86eb06efefa7
+  metadata.gz: 7d5ec3e856157e2587e39f8d64a66f91eb1ebe094a66c7e533bc41466b4f7bdd2e9841c965ca04db34bce67ae1050444afa51f186b0a229d720737fa218ef387
+  data.tar.gz: ed104846206719ec342e6c74df977283eb04b1230bf5d1578275c5e93a46f4daca4f1ba7dec2f54c1aeb0360797a4dd0ff8c78d3fbf728c049588cfe66b69408

data/README.md

@@ -25,6 +25,10 @@ The mod-SQL is shown as follows.
 * I want to write logs only mod-SQL(INSERT, UPDATE, DELETE, ...) and transaction SQL(BEGIN, COMMIT, ROLLBACK, ...).
   So I create this gem.
 
+## Requirements
+
+* Rails >= 5.1.5
+
 ## Installation
 
 Add this line to your application's Gemfile:
@@ -89,18 +93,18 @@ $ bin/console
 
 > User.create!(name: 'name', age: 20, birth_date: Date.new(2000, 1, 1))
 # => I, [2019-02-05T11:04:07.489057 #42019]  INFO -- : begin transaction
-#    I, [2019-02-05T11:04:07.490495 #42019]  INFO -- : INSERT INTO "users" ("name", "age", "birth_date", "created_at", "updated_at") VALUES (?, ?, ?, ?, ?)  [["name", "name"], ["age", 20], ["birth_date", "2000-01-01"], ["created_at", "2019-02-05 02:04:07.489226"], ["updated_at", "2019-02-05 02:04:07.489226"]]
+#    I, [2019-02-05T11:04:07.490495 #42019]  INFO -- : INSERT INTO "users" ("name", "age", "birth_date", "created_at", "updated_at") VALUES (?, ?, ?, ?, ?)  ["name", 20, "2000-01-01", "2019-02-20 05:00:13.175405", "2019-02-20 05:00:13.175405"]
 #    I, [2019-02-05T11:04:07.492610 #42019]  INFO -- : commit transaction
 
 > user = User.last # => no log
 > user.update_attributes(name: 'new name')
 # => I, [2019-02-05T11:04:52.971503 #42019]  INFO -- : begin transaction
-#    I, [2019-02-05T11:04:52.973071 #42019]  INFO -- : UPDATE "users" SET "name" = ?, "updated_at" = ? WHERE "users"."id" = ?  [["name", "new name"], ["updated_at", "2019-02-05 02:04:52.971865"], ["id", 2]]
+#    I, [2019-02-05T11:04:52.973071 #42019]  INFO -- : UPDATE "users" SET "name" = ?, "updated_at" = ? WHERE "users"."id" = ?  ["new name", "2019-02-20 05:00:37.983816", 2]
 #    I, [2019-02-05T11:04:52.974081 #42019]  INFO -- : commit transaction
 
 > user.destroy
 # => I, [2019-02-05T11:05:13.765564 #42019]  INFO -- : begin transaction
-#    I, [2019-02-05T11:05:13.775460 #42019]  INFO -- : DELETE FROM "users" WHERE "users"."id" = ?  [["id", 2]]
+#    I, [2019-02-05T11:05:13.775460 #42019]  INFO -- : DELETE FROM "users" WHERE "users"."id" = ?  [2]
 #    I, [2019-02-05T11:05:13.776722 #42019]  INFO -- : commit transaction
 ```
 

data/lib/active_record/mod_sql_log_subscriber.rb

@@ -10,7 +10,7 @@ module ActiveRecord
   class ModSqlLogSubscriber < ::ActiveRecord::LogSubscriber
     include ActiveSupport::Configurable
 
-    VERSION = "0.1.1"
+    VERSION = "0.1.2"
 
     config_accessor :disable, :log_level, :log_format, :target_statements
 
@@ -31,7 +31,7 @@ module ActiveRecord
       return if IGNORE_PAYLOAD_NAMES.include?(payload[:name])
       return unless target_sql_checker.match?(sql)
 
-      binds = extract_binds(payload)
+      binds = type_casted_binds(payload[:type_casted_binds])
       send(self.log_level, formatter.call(sql, binds))
     end
 
@@ -41,18 +41,6 @@ module ActiveRecord
       @target_sql_checker ||= /\A\s*(#{self.target_statements.join('|')})/mi
     end
 
-    def extract_binds(payload)
-      binds = []
-      unless (payload[:binds] || []).empty?
-        casted_params = type_casted_binds(payload[:type_casted_binds])
-        payload[:binds].zip(casted_params).map do |attr, value|
-          key, val = render_bind(attr, value)
-          binds << [key, val]
-        end
-      end
-      binds
-    end
-
     def formatter
       @formatter ||=
         case self.log_format

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: active_record-mod_sql_log_subscriber
 version: !ruby/object:Gem::Version
-  version: 0.1.1
+  version: 0.1.2
 platform: ruby
 authors:
 - ryu39
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2019-02-05 00:00:00.000000000 Z
+date: 2019-02-20 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport