active_record-json_has_many 0.2.0 → 0.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: ae2083de42d457a0126dfae281028cf4160ec7b3
-  data.tar.gz: e9150e43a9833bbedacdc28303ad70e586fd107c
+  metadata.gz: e953ea9f7439ad1d939a2c065d03e5510e04c65d
+  data.tar.gz: b0a96975541b75458b1e9837c1cc91c53ac57ef9
 SHA512:
-  metadata.gz: fd9f6774aa2a44b6596db207a3b157dd457a71b0b21b6fc4ebe77c17f761b376e5bcd19636d70826c0e6b3e03cf282b25862865b29f379dba8b173eedbf5895b
-  data.tar.gz: 0fda3ea696b950060de99a9f2ef91d713653bcc8d72487a5f4fc64672f04dfeae14eeadfa080fe53275b4f0c9be0dd7d3a5f00e24227e10fdac500a0808b6236
+  metadata.gz: 10bb7e01b55aadeb1ed1e9fcc95a5ffe453a1bc6a57a0a0a05cfceb074cad179ff8ed81e0ad88a4cf5d3a3657b2aa7042e561529541518fe137f0f9c155477f9
+  data.tar.gz: 9e8a1cd7323123abb4d1cb3d224e5457a9d57878cf7bcbb2c719e3f9eccba9c6f92cd0caef102b44627292cdce475afd2f7e2ea937fc980ba6571c65dbe16f56

data/README.md

@@ -5,34 +5,32 @@
 
 Instead of keeping the foreign keys on the children, or in a many-to-many join table, let's keep them in a JSON array on the parent.
 
-## Installation
-
-Add this line to your application's Gemfile:
-
-    gem 'active_record-json_has_many'
-
-And then execute:
-
-    $ bundle
+## Usage
 
-Or install it yourself as:
+```ruby
+require "active_record/json_has_many"
 
-    $ gem install active_record-json_has_many
+ActiveRecord::Schema.define do
+  create_table :parents do |t|
+    t.text :child_ids
+  end
 
-## Usage
+  create_table :children
+end
 
-```ruby
 class Parent < ActiveRecord::Base
   json_has_many :children
 end
 ```
 
-This will add some methods:
+This will add some familiar `has_many`-style methods:
 
 ```ruby
+parent.children = [Child.create!, Child.create!, Child.create!]
+parent.children #=> [#<Child id: 1>, #<Child id: 2>, #<Child id: 3>]
+
 parent.child_ids = [1,2,3]
 parent.child_ids #=> [1,2,3]
-parent.children => [<Child id=1>, <Child id=2>, Child id=3>]
 ```
 
 ## Requirements

data/active_record-json_has_many.gemspec

@@ -25,5 +25,6 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency "rake"
   spec.add_development_dependency "rspec"
   spec.add_development_dependency "sqlite3"
+  spec.add_development_dependency "byebug"
 end
 

data/lib/active_record/json_has_many.rb

@@ -7,17 +7,13 @@ module ActiveRecord
     def json_has_many(many, class_name: nil)
       one = many.to_s.singularize
       one_ids = :"#{one}_ids"
+      one_ids_equals = :"#{one_ids}="
       class_name ||= one.classify
+      many_equals = :"#{many}="
 
       serialize one_ids, JSON
 
-      include instance_methods(one_ids, many, class_name)
-    end
-
-    private
-
-    def instance_methods one_ids, many, class_name
-      Module.new do
+      include Module.new {
         define_method one_ids do
           super() || []
         end
@@ -25,7 +21,11 @@ module ActiveRecord
         define_method many do
           class_name.constantize.where(id: send(one_ids))
         end
-      end
+
+        define_method many_equals do |collection|
+          send one_ids_equals, collection.map(&:id)
+        end
+      }
     end
   end
 

data/lib/active_record/json_has_many/version.rb

@@ -1,5 +1,5 @@
 module ActiveRecord
   module JsonHasMany
-    VERSION = "0.2.0"
+    VERSION = "0.3.0"
   end
 end

data/spec/json_has_many_spec.rb

@@ -8,15 +8,13 @@ describe ActiveRecord::JsonHasMany do
     silence_stream(STDOUT) do
       ActiveRecord::Schema.define do
         create_table :parents do |t|
-          t.string :child_ids
-          t.string :fuzzy_ids
+          t.text :child_ids
+          t.text :fuzzy_ids
         end
 
-        create_table :children do |t|
-        end
+        create_table :children
 
-        create_table :pets do |t|
-        end
+        create_table :pets
       end
     end
 
@@ -56,6 +54,11 @@ describe ActiveRecord::JsonHasMany do
       subject.child_ids = [1,2,3]
       expect(subject.children).to eq children
     end
+
+    it "is an accessor" do
+      subject.children = children
+      expect(subject.children).to eq children
+    end
   end
 
   context "when overriding class name" do

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: active_record-json_has_many
 version: !ruby/object:Gem::Version
-  version: 0.2.0
+  version: 0.3.0
 platform: ruby
 authors:
 - Micah Geisel
@@ -94,6 +94,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: byebug
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 description: Instead of a many-to-many join table, serialize the ids into a JSON array.
 email:
 - micah@botandrose.com