active_record-associated_object 0.2.0 → 0.4.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: d7a508d24fc9467600956a207ee83775b3618ccfc8be21a9c11e1caa72a11172
-  data.tar.gz: '0360292507cf0e901140b9fe4003bd33aca10aff9d91b01b759e4ce75497a61f'
+  metadata.gz: 20d91687ec83cbc70efb318377c15ce1e2e79b28d350322b0d91ad6618073cc2
+  data.tar.gz: 59f19eea143da23bd980f0d6bca5a96670e13c7859d0db860741bf314d949822
 SHA512:
-  metadata.gz: '04940ddec3fc5446ba945df9f3daeff22550e81cf55f1e61e02b79af687adfc376f05e1148a6fb0e7ff17ab5df1a4539fe1d1c8bde456b986561df8ef4714e93'
-  data.tar.gz: 49ff34bb1945649479481ef7502585a124ee1464c67bc29f8ccb3335a53cfd0858790fbeebb976e3dfa1f055d12c085bb26ab2a7d054bed2ef51420f40cf83d5
+  metadata.gz: a41fc155e625c0d04d01f39a55a6c80155b8e275abb1c9be9ef5fac6c927cd6c36b83a13a9f621c73c344b333b246bd86e76bb49773579b2605fb1d2ede636b3
+  data.tar.gz: 3de159d609ac4ab8eedbe03d681cd6d8295ca4831c7eb4430ca760f86dfa243906bd9c7d62cc2cd60cf44ba0aa271116114703bd59a784780260d4b961f3e725

data/CHANGELOG.md

@@ -1,3 +1,46 @@
+## [0.4.0] - 2022-09-25
+
+- Extract `performs` into the `active_job-performs` gem with some fixes and extra features, but include it as a dependency.
+
+## [0.3.0] - 2022-09-25
+
+- Add `performs` to help cut down Active Job boilerplate.
+
+  ```ruby
+  class Post::Publisher < ActiveRecord::AssociatedObject
+    performs :publish, queue_as: :important
+
+    def publish
+      …
+    end
+  end
+  ```
+
+  The above is the same as writing:
+
+  ```ruby
+  class Post::Publisher < ActiveRecord::AssociatedObject
+    class Job < ApplicationJob; end
+    class PublishJob < Job
+      queue_as :important
+
+      def perform(publisher, *arguments, **options)
+        publisher.publish(*arguments, **options)
+      end
+    end
+
+    def publish_later(*arguments, **options)
+      PublishJob.perform_later(self, *arguments, **options)
+    end
+
+    def publish
+      …
+    end
+  end
+  ```
+
+  See the README for more details.
+
 ## [0.2.0] - 2022-04-21
 
 - Require a `has_object` call on the record side to associate an object.

data/Gemfile

@@ -15,3 +15,5 @@ gem "sqlite3"
 gem "kredis"
 gem "activejob"
 gem "railties"
+
+gem "minitest-sprint", "~> 1.2"

data/Gemfile.lock

@@ -1,7 +1,8 @@
 PATH
   remote: .
   specs:
-    active_record-associated_object (0.2.0)
+    active_record-associated_object (0.4.0)
+      active_job-performs
       activerecord (>= 6.1)
 
 GEM
@@ -20,6 +21,8 @@ GEM
       erubi (~> 1.4)
       rails-dom-testing (~> 2.0)
       rails-html-sanitizer (~> 1.1, >= 1.2.0)
+    active_job-performs (0.1.1)
+      activejob (>= 6.1)
     activejob (7.0.2.3)
       activesupport (= 7.0.2.3)
       globalid (>= 0.3.6)
@@ -55,10 +58,13 @@ GEM
       nokogiri (>= 1.5.9)
     method_source (1.0.0)
     minitest (5.15.0)
+    minitest-sprint (1.2.2)
+      path_expander (~> 1.1)
     nokogiri (1.13.4-arm64-darwin)
       racc (~> 1.4)
     nokogiri (1.13.4-x86_64-linux)
       racc (~> 1.4)
+    path_expander (1.1.1)
     racc (1.6.0)
     rack (2.2.3)
     rack-test (1.1.0)
@@ -95,6 +101,7 @@ DEPENDENCIES
   debug
   kredis
   minitest (~> 5.0)
+  minitest-sprint (~> 1.2)
   railties
   rake (~> 13.0)
   sqlite3

data/README.md

@@ -8,31 +8,91 @@ Associate a Ruby PORO with an Active Record class and have it quack like one. Bu
 # app/models/post.rb
 class Post < ActiveRecord::Base
   # `has_object` defines a `publisher` method that calls Post::Publisher.new(post).
-  has_object :publisher, after_touch: true, before_destroy: :prevent_post_destroy
+  has_object :publisher
 end
 
-# Create a standard PORO, but derive attributes from the Post:: namespace and its primary key.
+# app/models/post/publisher.rb
+class Post::Publisher
+  def initialize(post)
+    @post = post
+  end
+end
+```
+
+If you want Active Job, GlobalID and Kredis integration you can also have `Post::Publisher` inherit from `ActiveRecord::AssociatedObject`. This extends the standard PORO with details from the `Post::` namespace and the post primary key.
+
+```ruby
 # app/models/post/publisher.rb
 class Post::Publisher < ActiveRecord::AssociatedObject
+  # ActiveRecord::AssociatedObject defines initialize(post) automatically. It's derived from the `Post::` namespace.
+
   kredis_datetime :publish_at # Kredis integration generates a "post:publishers:<post_id>:publish_at" key.
 
-  # Both a general `record` method and a `post` method is available to access the associated post.
-  def publish_now
+  # `performs` builds a `Post::Publisher::PublishJob` and routes configs over to it.
+  performs :publish, queue_as: :important, discard_on: SomeError do
+    retry_on TimeoutError, wait: :exponentially_longer
+  end
+
+  def publish
+    # `transaction` is syntactic sugar for `post.transaction` here.
     transaction do
+      # A `post` method is generated to access the associated post. There's also a `record` alias available.
       post.update! published: true
       post.subscribers.post_published post
     end
   end
+end
+```
+
+### How `performs` removes Active Job boilerplate
+
+`performs` comes from the `active_job-performs` gem and is automatically bundled with `ActiveRecord::AssociatedObject`.
+
+With an associated object like this:
 
-  def publish_later
-    PublishJob.set(wait_until: publish_at).perform_later self
+```ruby
+class Post::Publisher < ActiveRecord::AssociatedObject
+  performs queue_as: :important
+  performs :publish
+  performs :retract
+
+  def publish
+  end
+
+  def retract(reason:)
   end
 end
+```
+
+is equivalent to:
+
+```ruby
+class Post::Publisher < ActiveRecord::AssociatedObject
+  # `performs` without a method defines a general job to share between method jobs.
+  class Job < ApplicationJob
+    queue_as :important
+  end
+
+  # Individual method jobs inherit from the `Post::Publisher::Job` defined above.
+  class PublishJob < Job
+    def perform(publisher, *arguments, **options)
+      # GlobalID integration means associated objects can be passed into jobs like Active Records, i.e. we don't have to do `post.publisher`.
+      publisher.publish(*arguments, **options)
+    end
+  end
 
-class Post::Publisher::PublishJob < ActiveJob::Base
-  def perform(publisher)
-     # Automatic integration via GlobalID means you don't have to do `post.publisher`.
-    publisher.publish_now
+  class RetractJob < Job
+    def perform(publisher, *arguments, **options)
+      publisher.retract(*arguments, **options)
+    end
+  end
+
+  def publish_later(*arguments, **options)
+    PublishJob.perform_later(self, *arguments, **options)
+  end
+
+  def retract_later(*arguments, **options)
+    RetractJob.perform_later(self, *arguments, **options)
   end
 end
 ```
@@ -44,7 +104,7 @@ end
 ```ruby
 class Post < ActiveRecord::Base
   # Callbacks can be passed too to a specific method.
-  has_object :publisher, after_touch: true, before_destroy: :prevent_post_destroy
+  has_object :publisher, after_touch: true, before_destroy: :prevent_errant_post_destroy
 
   # The above is the same as writing:
   after_touch { publisher.after_touch }
@@ -58,11 +118,17 @@ class Post::Publisher < ActiveRecord::AssociatedObject
 
   def prevent_errant_post_destroy
     # Passed callbacks can throw :abort too, and in this example prevent post.destroy.
-    throw :abort unless haha_business?
+    throw :abort if haha_business?
   end
 end
 ```
 
+## Risks of depending on this gem
+
+This gem is relatively tiny and I'm not expecting more significant changes on it, for right now. It's unofficial and not affiliated with Rails core.
+
+Though it's written and maintained by an ex-Rails core person, so I know my way in and out of Rails and how to safely extend it.
+
 ## Installation
 
 Install the gem and add to the application's Gemfile by executing:
@@ -81,7 +147,7 @@ To install this gem onto your local machine, run `bundle exec rake install`. To
 
 ## Contributing
 
-Bug reports and pull requests are welcome on GitHub at https://github.com/[USERNAME]/active_record-associated_object.
+Bug reports and pull requests are welcome on GitHub at https://github.com/kaspth/active_record-associated_object.
 
 ## License
 

data/Rakefile

@@ -1,12 +1,3 @@
 # frozen_string_literal: true
 
 require "bundler/gem_tasks"
-require "rake/testtask"
-
-Rake::TestTask.new(:test) do |t|
-  t.libs << "test"
-  t.libs << "lib"
-  t.test_files = FileList["test/**/test_*.rb"]
-end
-
-task default: :test

data/active_record-associated_object.gemspec

@@ -24,12 +24,11 @@ Gem::Specification.new do |spec|
       (f == __FILE__) || f.match(%r{\A(?:(?:bin|test|spec|features)/|\.(?:git|travis|circleci)|appveyor)})
     end
   end
-  spec.bindir = "exe"
-  spec.executables = spec.files.grep(%r{\Aexe/}) { |f| File.basename(f) }
   spec.require_paths = ["lib"]
 
   # Uncomment to register a new dependency of your gem
   spec.add_dependency "activerecord", ">= 6.1"
+  spec.add_dependency "active_job-performs"
 
   # For more information and examples about making a new gem, check out our
   # guide at: https://bundler.io/guides/creating_gem.html

data/lib/active_record/associated_object/object_association.rb

@@ -1,17 +1,23 @@
 module ActiveRecord::AssociatedObject::ObjectAssociation
+  using Module.new {
+    refine Module do
+      def extend_source_from(chunks, &block)
+        location = caller_locations(1, 1).first
+        source_chunks = Array(chunks).flat_map(&block)
+        class_eval source_chunks.join("\n\n"), location.path, location.lineno
+      end
+    end
+  }
+
   def has_object(*names, **callbacks)
-    methods = names.map do |name|
+    extend_source_from(names) do |name|
       "def #{name}; @#{name} ||= #{self.name}::#{name.to_s.classify}.new(self); end"
     end
 
-    class_eval methods.join("\n\n"), __FILE__, __LINE__ + 1
-
-    passes = names.flat_map do |name|
+    extend_source_from(names) do |name|
       callbacks.map do |callback, method|
         "#{callback} { #{name}.#{method == true ? callback : method} }"
       end
     end
-
-    class_eval passes.join("\n\n"), __FILE__, __LINE__ + 1
   end
 end

data/lib/active_record/associated_object/railtie.rb

@@ -2,12 +2,17 @@ class ActiveRecord::AssociatedObject::Railtie < Rails::Railtie
   initializer "integrations.include" do
     ActiveRecord::AssociatedObject.include Kredis::Attributes       if defined?(Kredis)
     ActiveRecord::AssociatedObject.include GlobalID::Identification if defined?(GlobalID)
+
+    ActiveSupport.on_load :active_job do
+      require "active_job/performs"
+      ActiveRecord::AssociatedObject.extend ActiveJob::Performs
+    end
   end
 
   initializer "object_association.setup" do
     ActiveSupport.on_load :active_record do
       require "active_record/associated_object/object_association"
-      ActiveRecord::Base.extend ActiveRecord::AssociatedObject::ObjectAssociation
+      extend ActiveRecord::AssociatedObject::ObjectAssociation
     end
   end
 end

data/lib/active_record/associated_object/version.rb

@@ -2,6 +2,6 @@
 
 module ActiveRecord
   class AssociatedObject
-    VERSION = "0.2.0"
+    VERSION = "0.4.0"
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: active_record-associated_object
 version: !ruby/object:Gem::Version
-  version: 0.2.0
+  version: 0.4.0
 platform: ruby
 authors:
 - Kasper Timm Hansen
 autorequire:
-bindir: exe
+bindir: bin
 cert_chain: []
-date: 2022-04-21 00:00:00.000000000 Z
+date: 2022-09-27 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
@@ -24,6 +24,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '6.1'
+- !ruby/object:Gem::Dependency
+  name: active_job-performs
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 description:
 email:
 - hey@kaspth.com
@@ -64,7 +78,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.3.11
+rubygems_version: 3.3.21
 signing_key:
 specification_version: 4
 summary: Associate a Ruby PORO with an Active Record class and have it quack like