active_recall 1.8.3 → 1.8.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 52f95d564c23b6dc54674db372b9d96d2337c8e04fb2f35914fdb5e72b286cf5
-  data.tar.gz: 0fbf28c7111877c329e7953f3593cad3e8c0ecea0682ede2f078443edd175c58
+  metadata.gz: 8e96531570c81f3e7457acc497a7db792708b6b765794e2294b00cce0bd0cfe2
+  data.tar.gz: 06c2f07e0438fc376beefe980dbdc579f06bb7d8bab77e692faed876b5a69629
 SHA512:
-  metadata.gz: 97baebcca8289c8460138360ebf3440fbd47646d74dc8c28ee77d762a7cdb91fd23f6069737058adb9dd08e38fe3323cec409e1e4a7a23c4120eee8b0a83ee95
-  data.tar.gz: 4e94302dd2412f9803167442f323f42335072a29facc90bc46db77f2650485432851b85ac087745a1e6e0c518c20abe93d049eff89531b511447ef76b0f7ec7a
+  metadata.gz: c8c4385a5646b277f27b6a90505e6f55847eba3d5e96bb32e0694f9148a018f71846d5cb9d552078a5c215965e5d72f6661f96c64885e9199ff557e77b47b059
+  data.tar.gz: 9089edaa9ef21c0d1a8750d60b223ac4cda49c075268bee4bea25493b7951c3bd31747a129a93721f0e239efb41bb9d7db3a6f96d157d9b2f95930494f812c91

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    active_recall (1.8.3)
+    active_recall (1.8.5)
       activerecord (>= 5.2.3, <= 7.1)
       activesupport (>= 5.2.3, <= 7.1)
 

data/bin/console

@@ -0,0 +1,9 @@
+#!/usr/bin/env ruby
+
+require "bundler/setup"
+require "active_recall"
+
+# You can add here some code to start an interactive console or debug session.
+# `binding.pry` from the Pry gem is often used for this purpose.
+require "irb"
+IRB.start(__FILE__)

data/lib/active_recall/algorithms/fibonacci_sequence.rb

@@ -39,7 +39,7 @@ module ActiveRecall
 
     def wrong
       {
-        box: [0, box - 1].max,
+        box: 0,
         last_reviewed: current_time,
         next_review: nil,
         times_right: times_right,

data/lib/active_recall/base.rb

@@ -1,5 +1,8 @@
 # frozen_string_literal: true
 
+require "active_record"
+require "active_support/concern"
+
 module ActiveRecall
   module Base
     extend ActiveSupport::Concern

data/lib/active_recall/models/deck.rb

@@ -9,27 +9,21 @@ module ActiveRecall
     has_many :items, class_name: "ActiveRecall::Item", dependent: :destroy
 
     def each
-      _items.each do |item|
-        if block_given?
-          yield item
-        else
-          yield item
-        end
-      end
+      _items.find_each { |item| yield item }
     end
 
     def ==(other)
       _items == other
     end
 
-    def _items
-      source_class.find(items.pluck(:source_id))
-    end
-
     def <<(source)
-      raise ArgumentError, "Word already in the stack" if include?(source)
+      attributes = {deck: self, source_id: source.id, source_type: source.class.name}
 
-      items << ActiveRecall::Item.new(deck: self, source_id: source.id, source_type: source.class.name)
+      if ActiveRecall::Item.exists?(attributes)
+        raise ArgumentError, "Word already in the stack"
+      end
+
+      items << ActiveRecall::Item.new(attributes)
     end
 
     def self.add_deck(user)
@@ -71,7 +65,7 @@ module ActiveRecall
     end
 
     def box(number)
-      source_class.find(items.where(box: number).pluck(:source_id))
+      source_class.where(id: items.where(box: number).select(:source_id))
     end
 
     def source_class
@@ -80,6 +74,10 @@ module ActiveRecall
 
     private
 
+    def _items
+      source_class.where(id: items.select(:source_id))
+    end
+
     def _review
       items
         .untested

data/lib/active_recall/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module ActiveRecall
-  VERSION = "1.8.3"
+  VERSION = "1.8.5"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: active_recall
 version: !ruby/object:Gem::Version
-  version: 1.8.3
+  version: 1.8.5
 platform: ruby
 authors:
 - Robert Gravina
@@ -9,7 +9,7 @@ authors:
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2023-06-29 00:00:00.000000000 Z
+date: 2023-08-06 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake
@@ -125,6 +125,7 @@ files:
 - README.md
 - Rakefile
 - active_recall.gemspec
+- bin/console
 - bin/setup
 - lib/active_recall.rb
 - lib/active_recall/algorithms/fibonacci_sequence.rb