active_recall 1.6.0 → 1.6.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 1784eaa3c18a644a3b7b16935626de436851355d6ec1f0ac19367ef2d789a873
-  data.tar.gz: '08e4a478783a55852dbefa1d0f6703ab2e44b4c02cd493e7091ff8cd715f4f43'
+  metadata.gz: cfa5de74ed9196b1484d8ff5829edae52adc82d7cec8c5c42b22f5c71abaae2b
+  data.tar.gz: 1e17d2f83a70bdbf4a5e0184bb89cb4f36aab98b94e0210dc9e32ce48b1769ba
 SHA512:
-  metadata.gz: d80c727f175317bb7173721981dba6eaea93e8e6a13793e3fc38ffebf0215b998c58904b936c6fb9cbd9784a3a6641ce35016402e6b85ef335f8df3c8bf622a5
-  data.tar.gz: e645b4e3cd9ee513885f3a766d7d0566efa12bae1be14e0c3593c130bc6a10083544ffdb1e71a22e9a0cd313f1415811aa9fec3c734c9839c677a367f21e91be
+  metadata.gz: 397d873582d9cd7b6591f1c2bf78888eddca83d7936020acb1d5b4d0b9ede6f9fa211b6a3b800ccb49de13c33c42e23d951bc2d3475e7870f5dd17b40f1d58f6
+  data.tar.gz: 234e542f97ca7f0454f362b59db98dec06c56ed7c93e0ae4654c48e788eb45f95466054ddc75d7862596eb24db2194d5771ff23283e0671523645242429dad88

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    active_recall (1.6.0)
+    active_recall (1.6.1)
       activerecord (>= 5.2.3, <= 6.1)
       activesupport (>= 5.2.3, <= 6.1)
 

data/README.md

@@ -116,9 +116,12 @@ user.words.next #=> nil
 
 ## Development
 
-After checking out the repo, run `bin/setup` to install dependencies. Then, run `rake spec` to run the tests. You can also run `bin/console` for an interactive prompt that will allow you to experiment.
+After checking out the repo, run `bin/setup` to install dependencies.
+Then, run `rake spec` to run the tests.
+You can also run `bin/console` for an interactive prompt that will allow you to experiment.
 
-To install this gem onto your local machine, run `bundle exec rake install`. To release a new version, update the version number in `version.rb`, and then run `bundle exec rake release`, which will create a git tag for the version, push git commits and tags, and push the `.gem` file to [rubygems.org](https://rubygems.org).
+To install this gem onto your local machine, run `bundle exec rake install`.
+To release a new version, update the version number in `version.rb`, and then run `bundle exec rake release`, which will create a git tag for the version, push git commits and tags, and push the `.gem` file to [rubygems.org](https://rubygems.org).
 
 ## Contributing
 

data/lib/active_recall/item_methods.rb

@@ -3,15 +3,11 @@
 module ActiveRecall
   module ItemMethods
     def right_answer_for!(item)
-      i = deck.items.find_by(source_id: item.id)
-      i.right!
-      i.save!
+      deck.items.find_by(source_id: item.id).right!
     end
 
     def wrong_answer_for!(item)
-      i = deck.items.find_by(source_id: item.id)
-      i.wrong!
-      i.save!
+      deck.items.find_by(source_id: item.id).wrong!
     end
   end
 end

data/lib/active_recall/models/deck.rb

@@ -42,12 +42,14 @@ module ActiveRecall
         .destroy
     end
 
+    # OPTIMIZE: Attempt in active record, rather than array of Ruby records
     def review
       %i[untested failed expired].inject([]) do |words, s|
         words += items.send(s).order(random_order_function).map(&:source)
       end
     end
 
+    # OPTIMIZE: Use optimized #review and build only the record to be returned
     def next
       word = nil
       %i[untested failed expired].each do |category|

data/lib/active_recall/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module ActiveRecall
-  VERSION = '1.6.0'
+  VERSION = '1.6.1'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: active_recall
 version: !ruby/object:Gem::Version
-  version: 1.6.0
+  version: 1.6.1
 platform: ruby
 authors:
 - Robert Gravina