active_publisher 0.4.0 → 1.0.0.pre0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 43f2f004720a93d84b71d684c9525eb8a337a2f4
-  data.tar.gz: be5c9ea51e3f4bed11905d5ac02352ef1f263330
+  metadata.gz: c47b026ffd14970af0fdd93efb07c7cc5fa6b649
+  data.tar.gz: 643480a2b1495381a8c6ccfedbdf0d249288def0
 SHA512:
-  metadata.gz: 2158504c8060d878fb152a5682d6b96831badd30ad0e40a71e67e86baa1bb696c930d783c9ba9ddb7fd005fbe63a4404310918ac4a31271f335dcbf8c3aabaa2
-  data.tar.gz: 56f42766ac91b76d93857258e854726f327f33152a71908f1870d3fc4eb7e8895b0fef44de6f3f764eea59ac99671a8dfa506f4e100fec02d613841ad31b3967
+  metadata.gz: 959a8d3a200142c30396ee065fdbb75d8d340eb8f474479c7e98c82795af5dd063eebe90a34156e7bc3e5795512ee20487d8e748ee915f19ae7eaa2a98fdf150
+  data.tar.gz: 6509995dad25e4f492b257f626cab11a3ea8b9b5b759526c24d32c10cafcf72b79c322bcd91910e6853b9955af1477345eac8a69f0669d7dfe532b5ebae47f6b

data/lib/active_publisher/async/in_memory_adapter.rb

@@ -18,11 +18,11 @@ module ActivePublisher
 
         attr_reader :async_queue
 
-        def initialize(drop_messages_when_queue_full = false, max_queue_size = 1_000_000, supervisor_interval = 0.2)
+        def initialize(back_pressure_strategy = :raise, max_queue_size = 100_000, supervisor_interval = 0.2)
           logger.info "Starting in-memory publisher adapter"
 
           @async_queue = ::ActivePublisher::Async::InMemoryAdapter::AsyncQueue.new(
-            drop_messages_when_queue_full,
+            back_pressure_strategy,
             max_queue_size,
             supervisor_interval
           )

data/lib/active_publisher/async/in_memory_adapter/async_queue.rb

@@ -2,30 +2,44 @@ module ActivePublisher
   module Async
     module InMemoryAdapter
       class AsyncQueue
+        # These strategies are used to determine what to do with messages when the queue is full.
+        # :raise - Raise an error and drop the message.
+        # :drop - Silently drop the message.
+        # :wait - Wait for space in the queue to become available.
+        BACK_PRESSURE_STRATEGIES = [:raise, :drop, :wait].freeze
+
         include ::ActivePublisher::Logging
 
-        attr_accessor :drop_messages_when_queue_full,
+        attr_accessor :back_pressure_strategy,
           :max_queue_size,
           :supervisor_interval
 
         attr_reader :consumer, :queue, :supervisor
 
-        def initialize(drop_messages_when_queue_full, max_queue_size, supervisor_interval)
-          @drop_messages_when_queue_full = drop_messages_when_queue_full
+        def initialize(back_pressure_strategy, max_queue_size, supervisor_interval)
+          self.back_pressure_strategy = back_pressure_strategy
           @max_queue_size = max_queue_size
           @supervisor_interval = supervisor_interval
           @queue = ::MultiOpQueue::Queue.new
           create_and_supervise_consumer!
         end
 
-        def push(message)
-          # default of 1_000_000 messages
-          if queue.size > max_queue_size
-            # Drop messages if the queue is full and we were configured to do so
-            return if drop_messages_when_queue_full
+        def back_pressure_strategy=(strategy)
+          fail ::ArgumentError, "Invalid back pressure strategy: #{strategy}" unless BACK_PRESSURE_STRATEGIES.include?(strategy)
+          @back_pressure_strategy = strategy
+        end
 
-            # By default we will raise an error to push the responsibility onto the caller
-            fail ::ActivePublisher::Async::InMemoryAdapter::UnableToPersistMessageError, "Queue is full, messages will be dropped."
+        def push(message)
+          if queue.size >= max_queue_size
+            case back_pressure_strategy
+            when :drop
+              return
+            when :raise
+              fail ::ActivePublisher::Async::InMemoryAdapter::UnableToPersistMessageError, "Queue is full, messages will be dropped."
+            when :wait
+              # This is a really crappy way to wait
+              sleep 0.01 until queue.size < max_queue_size
+            end
           end
 
           queue.push(message)

data/lib/active_publisher/version.rb

@@ -1,3 +1,3 @@
 module ActivePublisher
-  VERSION = "0.4.0"
+  VERSION = "1.0.0.pre0"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: active_publisher
 version: !ruby/object:Gem::Version
-  version: 0.4.0
+  version: 1.0.0.pre0
 platform: ruby
 authors:
 - Brian Stien
@@ -12,7 +12,7 @@ authors:
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2017-06-28 00:00:00.000000000 Z
+date: 2017-08-28 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bunny
@@ -145,12 +145,12 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">="
+  - - ">"
     - !ruby/object:Gem::Version
-      version: '0'
+      version: 1.3.1
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.6.12
+rubygems_version: 2.5.2
 signing_key: 
 specification_version: 4
 summary: Aims to make publishing work across MRI and jRuby painless and add some nice