active_postgres 0.9.7 → 0.9.8

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 2f7bf86efa4e32bcb1543e317bd6219983f9f42eb0ed0bf8787ff75b6a573a48
-  data.tar.gz: 8a2b2f0ec44bdfd94552dfa0fd84145b64ded472b4f421f216c86af71e2d859e
+  metadata.gz: c3d6f986ee2ac96f5cdd8b69541a5acae87733f506b10efb94c1046082b990a9
+  data.tar.gz: f64bb049c6601cf853de16c6cfeff8293ebb06d622db9633330298f02ef82135
 SHA512:
-  metadata.gz: 1d4a26f7284e14c84bcaa4d1e982da9162a25a098b15f9423b4923e7b7a9ab007112620761e5184a1da514f40495edd00647e8c2a269bbbb0511e2611e44118f
-  data.tar.gz: 4dfb7b6e19345e3324d38a798a82bdfa111001cb94736348aa88ba6146f9c3a6bc47fed8977039faefc271d412529f61995ad36f42be93b96a8789437187423e
+  metadata.gz: b07c93095ab642d39d6d658e93ef82c7ca993a30cf06b3f320d02e20dc5f45a546ffcdb2196f5bae0d1ab2051fb3a453a0a445e3e3f49b89ec1e3be9ee19f042
+  data.tar.gz: aeae944d32c7ee5f661470eaee9f66c01ef47c1bb4f578bbae0fd8d3e50f81044d24ddf49f85304a5aa6437de207aa22600cd3cc6cf7167713c5f87204e3cee9

data/CHANGELOG.md

@@ -7,6 +7,13 @@ and this project follows [Semantic Versioning](https://semver.org/).
 
 ## Unreleased
 
+## 0.9.8 - 2026-10-02
+
+### Fixed
+
+- Support explicit node IDs so repmgr identities survive primary changes and standby reordering.
+- Reject duplicate or invalid node IDs before deployment.
+
 ## 0.9.7 - 2026-09-01
 
 ### Added

data/README.md

@@ -76,6 +76,12 @@ manual-promotion while the ordinary standby retains automatic failover.
 settings before repmgr registration, avoiding a full base-backup stream from
 the primary. The `pgbackrest` component must be enabled.
 
+Set a unique positive integer `node_id` on every primary and standby entry
+before permanently changing their roles or reordering standbys. Match the
+existing IDs in `repmgr cluster show`, and keep each ID with its host after a
+switchover. Without explicit IDs, the primary defaults to 1 and standbys use
+their list position starting at 2. Duplicate or invalid IDs are rejected.
+
 Add credentials (`rails credentials:edit`):
 
 ```yaml

data/lib/active_postgres/components/repmgr.rb

@@ -28,7 +28,7 @@ module ActivePostgres
       end
 
       def uninstall_from(host)
-        node_id = host == config.primary_host ? 1 : (config.standby_hosts.index(host) || 997) + 2
+        node_id = config.node_id_for(host)
 
         ssh_executor.execute_on_host(host) do
           cluster_output = begin
@@ -98,6 +98,7 @@ module ActivePostgres
         puts '  Setting up primary with repmgr...'
 
         host = config.primary_host
+        primary_node_id = config.node_id_for(host)
         repmgr_config = config.repmgr_config_for(host)
         version = config.version
         repmgr_password = normalize_repmgr_password(secrets.resolve('repmgr_password'))
@@ -208,7 +209,7 @@ module ActivePostgres
           unless cluster_show&.match?(/primary/i)
             # Fallback: verify via repmgr metadata in the repmgr database
             db_check = executor.run_sql_on_backend(self,
-                                                   'SELECT type FROM repmgr.nodes WHERE node_id = 1;',
+                                                   "SELECT type FROM repmgr.nodes WHERE node_id = #{primary_node_id};",
                                                    postgres_user: 'postgres',
                                                    database: repmgr_db,
                                                    tuples_only: true,
@@ -250,7 +251,7 @@ module ActivePostgres
         _ = repmgr_config
         _ = secrets_obj
 
-        node_id = config.standby_hosts.index(standby_host) + 2
+        node_id = config.node_id_for(standby_host)
         repmgr_password = normalize_repmgr_password(secrets_obj.resolve('repmgr_password'))
         replication_password = normalize_replication_password(secrets_obj.resolve('replication_password'))
         if replication_user == repmgr_user && replication_password != repmgr_password
@@ -679,6 +680,7 @@ module ActivePostgres
         puts 'Verifying PostgreSQL HA cluster health...'
 
         primary_host = config.primary_host
+        primary_node_id = config.node_id_for(primary_host)
         standby_hosts = config.standby_hosts
         version = config.version
         postgres_user = config.postgres_user
@@ -709,12 +711,12 @@ module ActivePostgres
           cluster_output = capture(:sudo, '-u', 'postgres',
                                    'repmgr', '-f', '/etc/repmgr.conf', 'cluster', 'show',
                                    raise_on_non_zero_exit: false).to_s
-          # Primary always has node_id=1, check if it's registered and running
-          if cluster_output.match?(/\s+1\s+\|.*primary.*\*\s+running/i)
+          # Check the configured node identity, which survives role changes.
+          if cluster_output.match?(/\s+#{primary_node_id}\s+\|.*primary.*\*\s+running/i)
             info '✓ Primary is registered with repmgr'
           else
             db_check = executor.run_sql_on_backend(self,
-                                                   'SELECT type FROM repmgr.nodes WHERE node_id = 1 AND active IS TRUE;',
+                                                   "SELECT type FROM repmgr.nodes WHERE node_id = #{primary_node_id} AND active IS TRUE;",
                                                    postgres_user: postgres_user,
                                                    database: repmgr_db,
                                                    tuples_only: true,
@@ -951,7 +953,7 @@ module ActivePostgres
 
       def ensure_primary_registered
         host = config.primary_host
-        config.version
+        primary_node_id = config.node_id_for(host)
         is_registered = false
 
         ssh_executor.execute_on_host(host) do
@@ -965,8 +967,8 @@ module ActivePostgres
             ''
           end
 
-          if cluster_output.include?('| 1') && cluster_output.include?('primary')
-            info '✓ Primary is registered (node_id=1)'
+          if cluster_output.match?(/\b#{primary_node_id}\s+\|.*primary/)
+            info "✓ Primary is registered (node_id=#{primary_node_id})"
           else
             warn "⚠ Primary not found in cluster, assuming it's registered"
           end

data/lib/active_postgres/configuration/node_identity.rb

@@ -0,0 +1,22 @@
+module ActivePostgres
+  class Configuration
+    module NodeIdentity
+      def node_id_for(host)
+        node = node_config_for(host)
+        raise Error, "Unknown PostgreSQL host: #{host}" unless node
+
+        value = node.fetch('node_id') { host == primary_host ? 1 : standby_hosts.index(host) + 2 }
+        raise Error, "node_id for #{host} must be a positive 32-bit integer" unless value.is_a?(Integer) && value.between?(1, 2_147_483_647)
+
+        value
+      end
+
+      private
+
+      def validate_node_ids!
+        node_ids = all_hosts.map { |host| node_id_for(host) }
+        raise Error, 'PostgreSQL node_id values must be unique' unless node_ids.uniq.size == node_ids.size
+      end
+    end
+  end
+end

data/lib/active_postgres/configuration.rb

@@ -1,11 +1,13 @@
 require 'yaml'
 require_relative 'configuration/pgbackrest_policy'
 require_relative 'configuration/standby_policy'
+require_relative 'configuration/node_identity'
 
 module ActivePostgres
   class Configuration
     include PgBackRestPolicy
     include StandbyPolicy
+    include NodeIdentity
 
     attr_reader :environment, :version, :user, :ssh_key, :ssh_known_hosts_file, :ssh_host_key_verification,
                 :primary, :standbys, :jump_hosts, :components, :secrets_config, :database_config
@@ -147,6 +149,8 @@ module ActivePostgres
     def validate!
       raise Error, 'No primary host defined' unless primary_host
 
+      validate_node_ids!
+
       # Validate required secrets if components are enabled
       raise Error, 'Missing replication_password secret' if component_enabled?(:repmgr) && !secrets_config['replication_password']
       raise Error, 'Missing monitoring_password secret' if component_enabled?(:monitoring) && !secrets_config['monitoring_password']

data/lib/active_postgres/version.rb

@@ -1,3 +1,3 @@
 module ActivePostgres
-  VERSION = '0.9.7'.freeze
+  VERSION = '0.9.8'.freeze
 end

data/templates/repmgr.conf.erb

@@ -9,7 +9,7 @@
     end
   end
 %>
-node_id=<%= host == config.primary_host ? 1 : config.standby_hosts.index(host) + 2 %>
+node_id=<%= config.node_id_for(host) %>
 node_name='<%= node_label %>'
 <%
   # conninfo describes how OTHER nodes connect to THIS node

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: active_postgres
 version: !ruby/object:Gem::Version
-  version: 0.9.7
+  version: 0.9.8
 platform: ruby
 authors:
 - BoringCache
@@ -126,6 +126,7 @@ files:
 - lib/active_postgres/components/repmgr.rb
 - lib/active_postgres/components/ssl.rb
 - lib/active_postgres/configuration.rb
+- lib/active_postgres/configuration/node_identity.rb
 - lib/active_postgres/configuration/pgbackrest_policy.rb
 - lib/active_postgres/configuration/standby_policy.rb
 - lib/active_postgres/connection_pooler.rb