active_paypal_adaptive_payment 0.1.2 → 0.2.1

data/CHANGELOG.md

@@ -0,0 +1,12 @@
+## 0.2.1
+
+   - Removed action pack as a dependency
+
+## 0.2.0
+
+ - Fix tests.
+ - Added fixtures.yml.
+
+## 0.1.2
+
+ - Few typo fixes by LeviRosol

data/lib/active_merchant/billing/gateways/paypal_adaptive_payment.rb

@@ -1,308 +1,299 @@
 # -*- coding: utf-8 -*-
 dir = File.dirname(__FILE__)
-require dir + '/paypal_adaptive_payments/ext.rb'
-require dir + '/paypal_adaptive_payments/utils.rb'
-require dir + '/paypal_adaptive_payments/exceptions.rb'
-require dir + '/paypal_adaptive_payments/adaptive_payment_response.rb'
-require 'json/add/rails'
+[ '/paypal_adaptive_payments/exceptions.rb',
+  '/paypal_adaptive_payments/adaptive_payment_response.rb',
+  '/paypal_adaptive_payments/ext.rb'
+].each { |f| require File.join(dir, f) }
 
-module ActiveMerchant; module Billingl class PaypalAdaptivePaymentGateway < Gateway
+require 'money'
 
-  include AdaptivePaymentResponses
-  include AdaptiveUtils
+module ActiveMerchant #:nodoc:
+  module Billing #:nodoc:
+    class PaypalAdaptivePayment < Gateway # :nodoc:
 
-  TEST_URL = 'https://svcs.sandbox.paypal.com/AdaptivePayments/'
-  LIVE_URL = 'https://svcs.paypal.com/AdaptivePayments/'
+      TEST_URL = 'https://svcs.sandbox.paypal.com/AdaptivePayments/'
+      LIVE_URL = 'https://svcs.paypal.com/AdaptivePayments/'
 
-  # The countries the gateway supports merchants from as 2 digit ISO country codes
-  self.supported_countries = ['US']
+      EMBEDDED_FLOW_TEST_URL = 'https://www.sandbox.paypal.com/webapps/adaptivepayment/flow/pay'
+      EMBEDDED_FLOW_LIVE_URL = 'https://www.paypal.com/webapps/adaptivepayment/flow/pay'
 
-  # The homepage URL of the gateway
-  self.homepage_url = 'http://x.com/'
+      module FeesPayer
+        OPTIONS = %w(SENDER PRIMARYRECEIVER EACHRECEIVER SECONDARYONLY)
+        OPTIONS.each { |opt| const_set(opt, opt) }
+      end
 
-  # The name of the gateway
-  self.display_name = 'Paypal Adaptive Payments'
+      module PaymentType
+        TYPES = %w(DIGITALGOODS)
+        TYPES.each { |pt| const_set(pt, pt) }
+      end
 
-  attr_accessor :config_path
-  @config_path = "#{RAILS_ROOT}/config/paypal.yml"
+      # The countries the gateway supports merchants from as 2 digit ISO country codes
+      self.supported_countries = ['US']
 
-  def initialize(options = {})
-    @config = {}
-    if options.empty?
-      load_config
-    else
-      @config.merge! options
-    end
-  end
+      # The homepage URL of the gateway
+      self.homepage_url = 'http://x.com/'
 
-  def pay(options)
-    commit 'Pay', build_adaptive_payment_pay_request(options)
-  end
+      # The name of the gateway
+      self.display_name = 'Paypal Adaptive Payments'
 
-  def details_for_payment options
-    commit 'PaymentDetails', build_adaptive_payment_details_request(options)
-  end
+      def initialize(config = {})
+        requires!(config, :login, :password, :signature, :appid)
+        @config = config.dup
+        super
+      end
 
-  def refund options
-    commit 'Refund', build_adaptive_refund_details(options)
-  end
+      def pay(options)
+        commit('Pay', build_adaptive_payment_pay_request(options))
+      end
 
-  # Send a preapproval request to pay pal
-  #
-  # ==== Options
-  #
-  # * +:end_date+ - _xs:datetime_ The ending date
-  # * +:start_date+ - _xs:datetime_ The start date (defaults: current)
-  # * +:max_amount+ - _xs:decimal_ The preapproved maximum total amount of all payments.
-  # * +:currency_code+ - The currency code (defaults: USD)
-  # * +:cancel_url+ - URL to redirect the sender’s browser to after canceling the preapproval
-  # * +:return_url+ - URL to redirect the sender’s browser to after the sender has logged into PayPal and confirmed the preapproval
-  # * +:notify_url+ - The URL to which you want all IPN messages for this preapproval to be sent. (Optional)
-  #
-  # To get more details on fields see +Paypal PreApproval API+ at https://www.x.com/docs/DOC-1419
-  def preapprove_payment options
-    commit 'Preapproval', build_preapproval_payment(options)
-  end
+      def details_for_payment(options)
+        commit('PaymentDetails', build_adaptive_payment_details_request(options))
+      end
 
-  def cancel_preapproval options
-    commit 'CancelPreapproval', build_cancel_preapproval(options)
-  end
+      def refund(options)
+        commit('Refund', build_adaptive_refund_details(options))
+      end
 
-  def preapproval_details_for options
-    commit 'PreapprovalDetails', build_preapproval_details(options)
-  end
+      # Send a preapproval request to pay pal
+      #
+      # ==== Options
+      #
+      # * +:end_date+ - _xs:datetime_ The ending date
+      # * +:start_date+ - _xs:datetime_ The start date (defaults: current)
+      # * +:max_amount+ - _xs:decimal_ The preapproved maximum total amount of all payments.
+      # * +:currency_code+ - The currency code (defaults: USD)
+      # * +:cancel_url+ - URL to redirect the sender’s browser to after canceling the preapproval
+      # * +:return_url+ - URL to redirect the sender’s browser to after the sender has logged into PayPal and confirmed the preapproval
+      # * +:notify_url+ - The URL to which you want all IPN messages for this preapproval to be sent. (Optional)
+      #
+      # To get more details on fields see +Paypal PreApproval API+ at https://www.x.com/docs/DOC-1419
+      def preapprove_payment(options)
+        commit('Preapproval', build_preapproval_payment(options))
+      end
 
-  def convert_currency  options
-    commit 'ConvertCurrency', build_currency_conversion(options)
-  end
+      def cancel_preapproval(options)
+        commit('CancelPreapproval', build_cancel_preapproval(options))
+      end
 
-  #debug method, provides an easy to use debug method for the class
-  def debug
-    "Url: #{@url}\n\n JSON: #{@xml} \n\n Raw: #{@raw}"
-  end
+      def preapproval_details_for(options)
+        commit('PreapprovalDetails', build_preapproval_details(options))
+      end
 
-  private
+      def convert_currency(options)
+        commit('ConvertCurrency', build_currency_conversion(options))
+      end
 
-  #loads config from default file if it is not provided to the constructor
-  def load_config
-    raise ConfigDoesNotExist if !File.exists?(@config_path);
-    @config.merge! Yaml.load_file(@config_path)[RAILS_ENV].symbolize_keys!
-  end
+      def embedded_flow_url
+        test? ? EMBEDDED_FLOW_TEST_URL : EMBEDDED_FLOW_LIVE_URL
+      end
 
-  def build_adaptive_payment_pay_request opts
-    @xml = ''
-    xml = Builder::XmlMarkup.new :target => @xml, :indent => 2
-    xml.instruct!
-    xml.PayRequest do |x|
-      x.requestEnvelope do |x|
-        x.detailLevel 'ReturnAll'
-        x.errorLanguage opts[:error_language] ||= 'en_US'
+      #debug method, provides an easy to use debug method for the class
+      def debug
+        "Url: #{@url}\n\n Request: #{@xml} \n\n Response: #{@response.json}"
       end
-      x.actionType 'PAY'
-      x.senderEmail opts[:senderEmail]
-      x.cancelUrl opts[:cancel_url]
-      x.returnUrl opts[:return_url]
-      if opts[:notify_url]
-        x.ipnNotificationUrl opts[:notify_url]
+
+      private
+      def build_adaptive_payment_pay_request(opts)
+        @xml = ''
+        xml = Builder::XmlMarkup.new :target => @xml, :indent => 2
+        xml.instruct!
+        xml.PayRequest do |x|
+          x.requestEnvelope do |x|
+            x.detailLevel 'ReturnAll'
+            x.errorLanguage opts[:error_language] ||= 'en_US'
+          end
+          x.actionType 'PAY'
+          x.senderEmail opts[:sender_email] if opts.key?(:sender_email)
+          x.cancelUrl opts[:cancel_url]
+          x.returnUrl opts[:return_url]
+          x.ipnNotificationUrl opts[:ipn_notification_url] if opts[:ipn_notification_url]
+          x.memo opts[:memo] if opts.key?(:memo)
+          x.feesPayer opts[:fees_payer] if opts[:fees_payer]
+          x.pin opts[:pin] if opts[:pin]
+          x.currencyCode opts[:currency_code] ||= 'USD'
+          x.receiverList do |x|
+            opts[:receiver_list].each do |receiver|
+              x.receiver do |x|
+                x.email receiver[:email]
+                x.amount receiver[:amount].to_s
+                x.primary receiver[:primary] if receiver.key?(:primary)
+                x.paymentType receiver[:payment_type] if receiver.key?(:payment_type)
+                x.invoiceId receiver[:invoice_id] if receiver.key?(:invoice_id)
+              end
+            end
+          end
+          x.reverseAllParallelPaymentsOnError opts[:reverse_all_parallel_payments_on_error] || 'false'
+          x.trackingId opts[:tracking_id] if opts[:tracking_id]
+         end
       end
-      x.memo opts[:memo] if opts[:memo]
-      x.feesPayer opts[:feesPayer] if opts[:feesPayer]
-      x.pin opts[:pin] if opts[:pin]
-      x.currencyCode opts[:currency_code] ||= 'USD'
-      x.receiverList do |x|
-        opts[:receiver_list].each do |receiver|
-          x.receiver do |x|
-            x.email receiver[:email]
-            x.amount currency_to_two_places(receiver[:amount])
-            x.primary receiver[:primary] if receiver[:primary]
-            x.paymentType receiver[:payment_type] ||= 'GOODS'
-            x.invoiceId receiver[:invoice_id] if receiver[:invoice_id]
+
+      def build_adaptive_payment_details_request(opts)
+        @xml = ''
+        xml = Builder::XmlMarkup.new :target => @xml, :indent => 2
+        xml.instruct!
+        xml.PayRequest do |x|
+          x.requestEnvelope do |x|
+            x.detailLevel 'ReturnAll'
+            x.errorLanguage opts[:error_language] ||= 'en_US'
           end
+          x.payKey opts[:paykey]
         end
       end
-      x.reverseAllParallelPaymentsOnError opts[:reverse_all_parallel_payments_on_error] || 'false'
-    end
-  end
 
-  def build_adaptive_payment_details_request opts
-    @xml = ''
-    xml = Builder::XmlMarkup.new :target => @xml, :indent => 2
-    xml.instruct!
-    xml.PayRequest do |x|
-      x.requestEnvelope do |x|
-        x.detailLevel 'ReturnAll'
-        x.errorLanguage opts[:error_language] ||= 'en_US'
+      def build_adaptive_refund_details(options)
+        @xml = ''
+        xml = Builder::XmlMarkup.new :target => @xml, :indent => 2
+        xml.instruct!
+        xml.RefundRequest do |x|
+          x.requestEnvelope do |x|
+            x.detailLevel 'ReturnAll'
+            x.errorLanguage options[:error_language] ||= 'en_US'
+          end
+          x.actionType 'REFUND'
+          if options[:pay_key]
+            x.payKey options[:pay_key]
+          end
+          if options[:transaction_id]
+            x.payKey options[:transaction_id]
+          end
+          if options[:tracking_id]
+            x.trackingId options[:tracking_id]
+          end
+          x.cancelUrl options[:cancel_url]
+          x.returnUrl options[:return_url]
+          x.currencyCode options[:currency_code] ||= 'USD'
+          x.receiverList do |x|
+            options[:receiver_list].each do |receiver|
+              x.receiver do |x|
+                x.amount receiver[:amount]
+                x.paymentType receiver[:payment_type] ||= 'GOODS'
+                x.invoiceId receiver[:invoice_id] if receiver[:invoice_id]
+                x.email receiver[:email]
+              end
+            end
+          end
+          x.feesPayer options[:fees_payer] ||= 'EACHRECEIVER'
+        end
       end
-      x.payKey opts[:paykey]
-    end
-  end
 
-  def build_adaptive_refund_details options
-    @xml = ''
-    xml = Builder::XmlMarkup.new :target => @xml, :indent => 2
-    xml.instruct!
-    xml.RefundRequest do |x|
-      x.requestEnvelope do |x|
-        x.detailLevel 'ReturnAll'
-        x.errorLanguage options[:error_language] ||= 'en_US'
-      end
-      x.actionType 'REFUND'
-      if options[:pay_key]
-        x.payKey options[:pay_key]
-      end
-      if options[:transaction_id]
-        x.payKey options[:transaction_id]
-      end
-      if options[:tracking_id]
-        x.trackingId options[:tracking_id]
+      def build_preapproval_payment(options)
+        opts = {
+          :currency_code => "USD",
+          :start_date => DateTime.current
+        }.update(options)
+
+        @xml = ''
+        xml = Builder::XmlMarkup.new :target => @xml, :indent => 2
+        xml.instruct!
+        xml.PreapprovalRequest do |x|
+          # request envelope
+          x.requestEnvelope do |x|
+            x.detailLevel 'ReturnAll'
+            x.errorLanguage opts[:error_language] ||= 'en_US'
+            x.senderEmail opts[:senderEmail]
+          end
+
+          # required preapproval fields
+          x.endingDate opts[:end_date].strftime("%Y-%m-%dT%H:%M:%S")
+          x.startingDate opts[:start_date].strftime("%Y-%m-%dT%H:%M:%S")
+          x.maxTotalAmountOfAllPayments opts[:max_amount]
+          x.maxNumberOfPayments opts[:maxNumberOfPayments] if opts.has_key?(:maxNumberOfPayments)
+          x.currencyCode options[:currency_code]
+          x.cancelUrl opts[:cancel_url]
+          x.returnUrl opts[:return_url]
+
+          # notify url
+          x.ipnNotificationUrl opts[:notify_url] if opts.has_key?(:notify_url)
+        end
       end
-      x.cancelUrl options[:cancel_url]
-      x.returnUrl options[:return_url]
-      x.currencyCode options[:currency_code] ||= 'USD'
-      x.receiverList do |x|
-        options[:receiver_list].each do |receiver|
-          x.receiver do |x|
-            x.amount receiver[:amount]
-            x.paymentType receiver[:payment_type] ||= 'GOODS'
-            x.invoiceId receiver[:invoice_id] if receiver[:invoice_id]
-            x.email receiver[:email]
+
+      def build_preapproval_details(options)
+        @xml = ''
+        xml = Builder::XmlMarkup.new :target => @xml, :indent => 2
+        xml.instruct!
+        xml.PreapprovalDetailsRequest do |x|
+          x.requestEnvelope do |x|
+            x.detailLevel 'ReturnAll'
+            x.errorLanguage options[:error_language] ||= 'en_US'
           end
+          x.preapprovalKey options[:preapproval_key]
+          x.getBillingAddress options[:get_billing_address] if options[:get_billing_address]
         end
       end
-      x.feesPayer options[:fees_payer] ||= 'EACHRECEIVER'
-    end
-  end
 
-  def build_preapproval_payment options
-    opts = {
-      :currency_code => "USD",
-      :start_date => DateTime.current
-    }.update(options)
-
-    @xml = ''
-    xml = Builder::XmlMarkup.new :target => @xml, :indent => 2
-    xml.instruct!
-    xml.PreapprovalRequest do |x|
-      # request envelope
-      x.requestEnvelope do |x|
-        x.detailLevel 'ReturnAll'
-        x.errorLanguage opts[:error_language] ||= 'en_US'
-        x.senderEmail opts[:senderEmail]
+      def build_cancel_preapproval(options)
+        @xml = ''
+        xml = Builder::XmlMarkup.new :target => @xml, :indent => 2
+        xml.instruct!
+        xml.PreapprovalDetailsRequest do |x|
+          x.requestEnvelope do |x|
+            x.detailLevel 'ReturnAll'
+            x.errorLanguage options[:error_language] ||= 'en_US'
+          end
+          x.preapprovalKey options[:preapproval_key]
+        end
       end
 
-      # required preapproval fields
-      x.endingDate opts[:end_date].strftime("%Y-%m-%dT%H%%3a%M%%3a%S")
-      x.startingDate opts[:start_date].strftime("%Y-%m-%dT%H%%3a%M%%3a%S")
-      x.maxTotalAmountOfAllPayments opts[:max_amount]
-      x.maxNumberOfPayments opts[:maxNumberOfPayments]
-      x.currencyCode options[:currency_code]
-      x.cancelUrl opts[:cancel_url]
-      x.returnUrl opts[:return_url]
-
-      # notify url
-      if opts[:notify_url]
-        x.ipnNotificationUrl opts[:notify_url]
+      def build_currency_conversion(options)
+        @xml = ''
+        xml = Builder::XmlMarkup.new :target => @xml, :indent => 2
+        xml.instruct!
+        xml.ConvertCurrencyRequest do |x|
+          x.requestEnvelope do |x|
+            x.detailLevel 'ReturnAll'
+            x.errorLanguage options[:error_language] ||= 'en_US'
+          end
+          x.baseAmountList do |x|
+            options[:currency_list].each do |currency|
+              x.currency do |x|
+                x.amount currency[:amount]
+                x.code currency[:code ]
+              end
+            end
+          end
+          x.convertToCurrencyList do |x|
+            options[:to_currencies].each do |k,v|
+              x.currencyCode "#{v}"
+            end
+          end
+        end
       end
-    end
-  end
 
-  def build_preapproval_details options
-    @xml = ''
-    xml = Builder::XmlMarkup.new :target => @xml, :indent => 2
-    xml.instruct!
-    xml.PreapprovalDetailsRequest do |x|
-      x.requestEnvelope do |x|
-        x.detailLevel 'ReturnAll'
-        x.errorLanguage options[:error_language] ||= 'en_US'
+      def commit(action, data)
+        @response = AdaptivePaymentResponse.new(post_through_ssl(action, data))
       end
-      x.preapprovalKey options[:preapproval_key]
-      x.getBillingAddress options[:get_billing_address] if options[:get_billing_address]
-    end
-  end
 
-  def build_cancel_preapproval options
-    @xml = ''
-    xml = Builder::XmlMarkup.new :target => @xml, :indent => 2
-    xml.instruct!
-    xml.PreapprovalDetailsRequest do |x|
-      x.requestEnvelope do |x|
-        x.detailLevel 'ReturnAll'
-        x.errorLanguage options[:error_language] ||= 'en_US'
+      def post_through_ssl(action, parameters = {})
+        headers = {
+          "X-PAYPAL-REQUEST-DATA-FORMAT" => "XML",
+          "X-PAYPAL-RESPONSE-DATA-FORMAT" => "JSON",
+          "X-PAYPAL-SECURITY-USERID" => @config[:login],
+          "X-PAYPAL-SECURITY-PASSWORD" => @config[:password],
+          "X-PAYPAL-SECURITY-SIGNATURE" => @config[:signature],
+          "X-PAYPAL-APPLICATION-ID" => @config[:appid]
+        }
+        action_url(action)
+        request = Net::HTTP::Post.new(@url.path)
+        request.body = @xml
+        headers.each_pair { |k,v| request[k] = v }
+        request.content_type = 'text/xml'
+        server = Net::HTTP.new(@url.host, 443)
+        server.use_ssl = true
+        server.start { |http| http.request(request) }.body
       end
-      x.preapprovalKey options[:preapproval_key]
-    end
-  end
 
-  def build_currency_conversion options
-    @xml = ''
-    xml = Builder::XmlMarkup.new :target => @xml, :indent => 2
-    xml.instruct!
-    xml.ConvertCurrencyRequest do |x|
-      x.requestEnvelope do |x|
-        x.detailLevel 'ReturnAll'
-        x.errorLanguage options[:error_language] ||= 'en_US'
+      def endpoint_url
+        test? ? TEST_URL : LIVE_URL
       end
 
-      x.baseAmountList do |x|
-        options[:currency_list].each do |currency|
-          x.currency do |x|
-            x.amount currency[:amount]
-            x.code currency[:code ]
-          end
-        end
+      def test?
+        Base.gateway_mode == :test
       end
 
-      x.convertToCurrencyList do |x|
-        options[:to_currencies].each do |k,v|
-          x.currencyCode "#{v}"
-        end
+      def action_url(action)
+        @url = URI.parse(endpoint_url + action)
       end
-    end
-  end
 
-  def parse json
-    @raw = json
-    resp = JSON.parse json
-    if resp['responseEnvelope']['ack'] == 'Failure'
-      error = AdaptivePaypalErrorResponse.new(json)
-    else
-      AdaptivePaypalSuccessResponse.new(resp)
     end
   end
-
-  def commit(action, data)
-    @response = parse(post_through_ssl(action, data))
-  end
-
-  def post_through_ssl(action, parameters = {})
-    headers = {
-      "X-PAYPAL-REQUEST-DATA-FORMAT" => "XML",
-      "X-PAYPAL-RESPONSE-DATA-FORMAT" => "JSON",
-      "X-PAYPAL-SECURITY-USERID" => @config[:login],
-      "X-PAYPAL-SECURITY-PASSWORD" => @config[:password],
-      "X-PAYPAL-SECURITY-SIGNATURE" => @config[:signature],
-      "X-PAYPAL-APPLICATION-ID" => @config[:appid]
-    }
-    url action
-    request = Net::HTTP::Post.new(@url.path)
-    request.body = @xml
-    headers.each_pair { |k,v| request[k] = v }
-    request.content_type = 'text/xml'
-    server = Net::HTTP.new(@url.host, 443)
-    server.use_ssl = true
-    server.start { |http| http.request(request) }.body
-  end
-
-  def endpoint_url
-    test? ? TEST_URL : LIVE_URL
-  end
-
-  def test?
-    Base.gateway_mode == :test
-  end
-
-  def url action
-    @url = URI.parse(endpoint_url + action)
-  end
-
-end; end; end
+end

data/lib/active_merchant/billing/gateways/paypal_adaptive_payments/adaptive_payment_response.rb

@@ -1,134 +1,52 @@
-module ActiveMerchant; module Billing;  module AdaptivePaymentResponses
+require 'multi_json'
+require 'hashie'
+require 'rash'
 
-class AdaptivePaypalSuccessResponse
+module ActiveMerchant
+  module Billing
+    class AdaptivePaymentResponse
 
-  REDIRECT_URL = 'https://www.paypal.com/webscr?cmd=_ap-payment&paykey='
-  TEST_REDIRECT_URL = 'https://www.sandbox.paypal.com/cgi-bin/webscr?cmd=_ap-payment&paykey='
+      REDIRECT_URL = 'https://www.paypal.com/webscr?cmd=_ap-payment&paykey='
+      TEST_REDIRECT_URL = 'https://www.sandbox.paypal.com/cgi-bin/webscr?cmd=_ap-payment&paykey='
 
-  attr_reader :paykey
+      SUCCESS = 'Success'.freeze
 
-  def initialize json
-    @paykey = json['payKey']
-    @params = json
-  end
+      attr_reader :json
+      alias :raw :json
 
-  def redirect_url_for
-    Base.gateway_mode == :test ? (TEST_REDIRECT_URL + @paykey) : (REDIRECT_URL + @paykey)
-  end
+      def initialize(json)
+        @json = json
+        @response_rash = Hashie::Rash.new(MultiJson.decode(json))
+      end
 
-  def ack
-    @params['responseEnvelope']['ack']
-  end
+      def method_missing(method, *args, &block)
+        @response_rash.send(method, *args, &block)
+      end
 
-  def paymentExecStatus
-    @params['paymentExecStatus']
-  end
+      def redirect_url_for
+        Base.gateway_mode == :test ? (TEST_REDIRECT_URL + pay_key) : (REDIRECT_URL + pay_key)
+      end
 
-  def transactionStatus
-    @params['transactionStatus']
-  end
-
-  def senderEmail
-    @params['senderEmail']
-  end
-
-  def actionType
-    @params['actionType']
-  end
-
-  def feesPayer
-    @params['feesPayer']
-  end
-
-  def currencyCode
-    @params['currencyCode']
-  end
-
-  def payKey
-    @params['payKey']
-  end
-
-  def correlationId
-    @params['responseEnvelope']['correlationId']
-  end
-
-  def build
-    @params['responseEnvelope']['build']
-  end
-
-  def refundInfoList
-    @params['refundInfoList']
-  end
-
-  def preapprovalKey
-    @params['preapprovalKey']
-  end
-
-  def curPaymentsAmount
-    @params['curPaymentsAmount']
-  end
+      def ack
+        response_envelope.ack
+      end
 
-  def status
-    @params['status']
-  end
+      def timestamp
+        response_envelope.timestamp
+      end
 
-  def curPeriodAttempts
-    @params['curPeriodAttempts']
-  end
+      def build
+        response_envelope.build
+      end
 
-  def approved
-    @params['approved']
-  end
+      def correlation_id
+        response_envelope.correlation_id
+      end
+      alias :correlationId :correlation_id
 
-  def method_missing name
-    begin
-      @params[name.to_s]
-    rescue
-      raise AttributenotFound
+      def success?
+        ack == SUCCESS
+      end
     end
   end
-
-  def [](key)
-    return @params[key] if @params.include? key
-    raise AttributenotFound
-  end
-
-  def status
-    @params['status']
-  end
-
 end
-
-class AdaptivePaypalErrorResponse
-
-  def initialize error
-    @raw = error
-    @errlist = ActiveSupport::JSON.decode(error)
-  end
-
-  def debug
-    @raw.inspect
-  end
-
-  def ack
-    @raw['responseEnvelope']['ack']
-  end
-
-  def timestamp
-    @raw['responseEnvelope']['timestamp']
-  end
-
-  def build
-    @raw['responseEnvelope']['build']
-  end
-
-  def correlationId
-    @raw['responseEnvelope']['correlationId']
-  end
-
-  def errormessage
-    @errlist['error']
-  end
-end
-
-end; end; end

data/lib/active_merchant/billing/gateways/paypal_adaptive_payments/ext.rb

@@ -1,10 +1,12 @@
 # fix for case sensitive headers in paypal (issue #1)
-module Net; module HTTPHeader
-  def []= key, val
-    unless val
-      @header.delete key
-      return val
+module Net
+  module HTTPHeader
+    def []= key, val
+      unless val
+        @header.delete key
+        return val
+      end
+      @header[key] = [val]
     end
-    @header[key] = [val]
   end
-end; end
+end

data/lib/active_paypal_adaptive_payment.rb

@@ -1,13 +1,4 @@
-$:.unshift File.dirname(__FILE__)
-
-begin
-  require 'active_support'
-  require 'active_merchant/common'
-rescue LoadError
-  require 'rubygems'
-  require 'active_support'
-  require 'active_merchant/common'
-end
+require 'active_merchant'
 
 dir = File.dirname(__FILE__) + '/active_merchant/billing/gateways'
 require dir + '/paypal_adaptive_payment'

data/{README.markdown → readme.md}

@@ -4,8 +4,7 @@ This library is meant to interface with PayPal web services Adaptive Payment Gat
 
 [Active Merchant]:http://www.activemerchant.org
 
-![Active PayPal Adaptive Payment](https://github.com/jpablobr/active_paypal_adaptive_payment/raw/master/doc/split.jpg)
-
+[iAuction: An Adaptive Payments Tutorial Featuring Parallel Payments](https://www.x.com/docs/DOC-2505)
 ## Supported
 
 * payments
@@ -18,23 +17,28 @@ This library is meant to interface with PayPal web services Adaptive Payment Gat
 
 Add the following line to your app Gemfile:
 
-    gem "active_paypal_adaptive_payment", "~> 0.1.0"
+    gem "active_paypal_adaptive_payment"
 
 ## Implementation
 
-In your { payment/order }_controller.rb
+See ![Active PayPal Adaptive Payment](https://github.com/jpablobr/active_paypal_adaptive_payment/raw/master/doc/split.jpg) tutorial for more info.
 
-    def gateway
-      @gateway ||= PaypalAdaptivePaymentGateway.new(
-       :login => 'your_email',
-       :password => 'your_password',
-       :signature => ' your_signature',
-       :appid => 'your_app_id'
-      )
-    end
+### Pre-approved paymen
 
-## Payment process
+    gateway.preapprove_payment (
+      :return_url => "returnURL",
+      :cancel_url => "cancelURL",
+      :senderEmail =>"email address of sender",
+      :start_date => Time.now,
+      :end_date => Time.now + (60*60*24) * 30,
+      :currency_code =>"currency code",
+      :max_amount => "maxTotalAmountOfAllPayments",
+      :maxNumberOfPayments => "maxNumberOfPayments" )
 
+### Cancel pre-approved payment
+
+    gateway.cancel_preapproval(:preapproval_key => "preapprovalkey"
+)
 ### Chained payments
 
     def checkout
@@ -63,16 +67,21 @@ response, the xml sent and the url it was posted to.
 
 From the Rails console it can be accessed like such:
 
-    ActiveMerchant::Billing::PaypalAdaptivePaymentGateway
+    ActiveMerchant::Billing::PaypalAdaptivePayment
+
+`PaypalAdaptivePayment#debug` or `AdaptivePaymentResponse#debug` return the raw
+xml request, raw json response and the URL of the endpoint.
 
 ## TODO
 
-* Better documentation
+* Documentation
+* More tests
 
 ## Contributors
 
 * Jose Pablo Barrantes (<http://jpablobr.com/>)
 * Zarne Dravitzki (<http://github.com/zarno>)
+* LeviRosol (<https://github.com/LeviRosol>)
 
 ## Other previous contributors where some code was taken from.
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: active_paypal_adaptive_payment
 version: !ruby/object:Gem::Version
-  version: 0.1.2
+  version: 0.2.1
   prerelease: 
 platform: ruby
 authors:
@@ -9,12 +9,11 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2011-07-28 00:00:00.000000000 +10:00
-default_executable: 
+date: 2011-08-12 00:00:00.000000000Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activemerchant
-  requirement: &13160920 !ruby/object:Gem::Requirement
+  requirement: &11874900 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -22,29 +21,40 @@ dependencies:
         version: 1.5.1
   type: :runtime
   prerelease: false
-  version_requirements: *13160920
+  version_requirements: *11874900
 - !ruby/object:Gem::Dependency
-  name: activesupport
-  requirement: &13160440 !ruby/object:Gem::Requirement
+  name: multi_json
+  requirement: &11874420 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
-        version: 3.0.7
+        version: 1.0.0
   type: :runtime
   prerelease: false
-  version_requirements: *13160440
+  version_requirements: *11874420
 - !ruby/object:Gem::Dependency
-  name: builder
-  requirement: &13159960 !ruby/object:Gem::Requirement
+  name: rash
+  requirement: &11873820 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
-        version: 2.0.0
+        version: 0.3.0
   type: :runtime
   prerelease: false
-  version_requirements: *13159960
+  version_requirements: *11873820
+- !ruby/object:Gem::Dependency
+  name: money
+  requirement: &11873220 !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: 3.6.0
+  type: :runtime
+  prerelease: false
+  version_requirements: *11873220
 description: This library is meant to interface with PayPal web services Adaptive
   Payment Gateway Library.
 email:
@@ -55,14 +65,12 @@ extra_rdoc_files: []
 files:
 - lib/active_paypal_adaptive_payment.rb
 - lib/active_merchant/billing/gateways/paypal_adaptive_payments/exceptions.rb
-- lib/active_merchant/billing/gateways/paypal_adaptive_payments/utils.rb
 - lib/active_merchant/billing/gateways/paypal_adaptive_payments/adaptive_payment_response.rb
 - lib/active_merchant/billing/gateways/paypal_adaptive_payments/ext.rb
 - lib/active_merchant/billing/gateways/paypal_adaptive_payment.rb
 - MIT-LICENSE
-- README.markdown
-- CHANGELOG
-has_rdoc: true
+- readme.md
+- CHANGELOG.md
 homepage: http://github.com/jpablobr/active_paypal_adaptive_payment
 licenses: []
 post_install_message: 
@@ -83,7 +91,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: 1.3.6
 requirements: []
 rubyforge_project: 
-rubygems_version: 1.6.2
+rubygems_version: 1.8.7
 signing_key: 
 specification_version: 3
 summary: ActiveMercant PayPal Adaptive Payment Library

data/lib/active_merchant/billing/gateways/paypal_adaptive_payments/utils.rb

@@ -1,8 +0,0 @@
-module ActiveMerchant; module Billing; module AdaptiveUtils
-
-def currency_to_two_places amount
-  return 0.01 if amount < 1
-  ("%.2f" % amount).to_f
-end
-
-end; end; end