active_object 4.0.8 → 4.0.9

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 6fc08a3fb5836a6f154a0f1d7854cdafd68dfcea
-  data.tar.gz: 7deb7107836576302250d73656aaf4c0dd9eccb1
+  metadata.gz: f913e9cb5748f85f842d00bd586e9dc60cb41a52
+  data.tar.gz: 71a75e1617ac6176e49040967eebeb32b8caecd2
 SHA512:
-  metadata.gz: d22be40f8fbe844dc638f0d265d03746816850fe2e1e5484ee67fe8131123588c232470f7d14afb96c3498bc3dfe01e632103c195b2384bd92024fdc5ab0f571
-  data.tar.gz: cc1543d95b6ca3a04b422ba207ef4af2e7c1700aab01d962953dd7a140e92eb91fc8635421d939d03a472b160af0d5c5e4b5e69bdc3adda3003672e6807cfff6
+  metadata.gz: 2ca504cc49a338ff400e78db2fb0571bad7cfd5bc705d2c9983d0c09e761fa2f3be54d0f84c30370d3507ebd2aa0547375bc95911edbeef9aab60a40beef8527
+  data.tar.gz: d9cfacf2ac5a0b34cf9f75ab4efb618fc65306fc249e72b64433e47d3ccc08964ef793910e965a22cb7499d760fc654764233d258330ac707d3a4551857d6227

data/.rubocop.yml

@@ -1,11 +1,25 @@
 AllCops:
   DisplayCopNames: true
   DisplayStyleGuide: true
-  TargetRubyVersion: 2.3
+  TargetRubyVersion: 2.4
   Exclude:
     - 'spec/**/**/*'
+Layout/ClosingParenthesisIndentation:
+  Enabled: false
+Layout/EmptyLinesAroundBlockBody:
+  Enabled: false
+Layout/EmptyLinesAroundClassBody:
+  Enabled: false
+Layout/EmptyLinesAroundModuleBody:
+  Enabled: false
+Layout/FirstParameterIndentation:
+  Enabled: false
+Layout/MultilineMethodCallIndentation:
+  EnforcedStyle: aligned
 LineLength:
   Max: 100
+Lint/ScriptPermission:
+  Enabled: false
 Metrics/ClassLength:
   Enabled: false
 Metrics/ModuleLength:
@@ -16,24 +30,12 @@ Style/BracesAroundHashParameters:
   Enabled: false
 Style/ClassAndModuleChildren:
   EnforcedStyle: compact
-Style/ClosingParenthesisIndentation:
-  Enabled: false
 Style/Documentation:
   Enabled: false
-Style/EmptyLinesAroundBlockBody:
-  Enabled: false
-Style/EmptyLinesAroundClassBody:
-  Enabled: false
-Style/EmptyLinesAroundModuleBody:
-  Enabled: false
 Style/HashSyntax:
   Enabled: false
-Style/FirstParameterIndentation:
-  Enabled: false
 Style/FrozenStringLiteralComment:
   Enabled: false
-Style/MultilineMethodCallIndentation:
-  EnforcedStyle: aligned
 Style/NumericLiterals:
   Enabled: false
 Style/RescueModifier:

data/lib/active_object/enumerable.rb

@@ -1,15 +1,15 @@
 module Enumerable
 
-  # rubocop:disable Lint/UnusedMethodArgument
+  # rubocop:disable Lint/UnusedMethodArgument, Style/YodaCondition
   def cluster(&block)
     result = []
     each do |ele|
       last_res = result.last
-      last_res && (yield(last_res.last) == yield(ele)) ? last_res << ele : result << [ele]
+      last_res && (yield(ele) == yield(last_res.last)) ? last_res << ele : result << [ele]
     end
     result
   end
-  # rubocop:enable Lint/UnusedMethodArgument
+  # rubocop:enable Lint/UnusedMethodArgument, Style/YodaCondition
 
   def difference(identity = 0, &block)
     if block_given?

data/lib/active_object/numeric.rb

@@ -86,13 +86,13 @@ module ActiveObject::Numeric
       min_min = minimum.min
       min_max = minimum.max
 
-      return min_min if self < min_min
+      return min_min if min_min > self
 
-      self > min_max ? min_max : self
+      min_max < self ? min_max : self
     else
-      return minimum if self < minimum
+      return minimum if minimum > self
 
-      self > maximum ? maximum : self
+      maximum < self ? maximum : self
     end
   end
   # rubocop:enable Metrics/CyclomaticComplexity, Metrics/PerceivedComplexity
@@ -176,11 +176,11 @@ module ActiveObject::Numeric
   alias_method :gram_in_grams, :grams_in_grams
 
   def greater_than?(num)
-    self > num
+    num < self
   end
 
   def greater_than_or_equal_to?(num)
-    self >= num
+    num <= self
   end
 
   def hectograms_in_grams
@@ -212,7 +212,7 @@ module ActiveObject::Numeric
   end
 
   def inside?(start, finish)
-    (start < self) && (self < finish)
+    (start < self) && (finish > self)
   end
 
   def kilobytes_in_bytes
@@ -234,11 +234,11 @@ module ActiveObject::Numeric
   alias_method :kilogram_in_grams, :kilograms_in_grams
 
   def less_than?(num)
-    self < num
+    num > self
   end
 
   def less_than_or_equal_to?(num)
-    self <= num
+    num >= self
   end
 
   def metric_tons_in_grams
@@ -303,11 +303,11 @@ module ActiveObject::Numeric
 
   alias_method :nautical_mile_in_inches, :nautical_miles_in_inches
 
-  # rubocop:disable Style/NumericPredicate
+  # rubocop:disable Style/NumericPredicate, Style/YodaCondition
   def negative?
-    self < 0
+    0 > self
   end
-  # rubocop:enable Style/NumericPredicate
+  # rubocop:enable Style/NumericPredicate, Style/YodaCondition
 
   def ordinal
     if (11..13).cover?(abs % 100)
@@ -333,7 +333,7 @@ module ActiveObject::Numeric
   alias_method :ounce_in_ounces, :ounces_in_ounces
 
   def outside?(start, finish)
-    (self < start) || (finish < self)
+    (start > self) || (finish < self)
   end
 
   def pad(options = {})
@@ -375,11 +375,11 @@ module ActiveObject::Numeric
 
   alias_method :petabyte_in_bytes, :petabytes_in_bytes
 
-  # rubocop:disable Style/NumericPredicate
+  # rubocop:disable Style/NumericPredicate, Style/YodaCondition
   def positive?
-    self > 0
+    0 < self
   end
-  # rubocop:enable Style/NumericPredicate
+  # rubocop:enable Style/NumericPredicate, Style/YodaCondition
 
   def pounds_in_ounces
     self * POUND
@@ -535,7 +535,7 @@ module ActiveObject::Numeric
   alias_method :week_in_seconds, :weeks_in_seconds
 
   def within?(number, epsilon = 0.01)
-    return self == number if epsilon.zero?
+    return number == self if epsilon.zero?
 
     alpha = to_f
     beta = number.to_f

data/lib/active_object/object.rb

@@ -16,9 +16,11 @@ module ActiveObject::Object
     TRUE_VALUES.include?(self) || FALSE_VALUES.include?(self)
   end
 
+  # rubocop:disable Style/YodaCondition
   def false?
-    self == false
+    false == self
   end
+  # rubocop:enable Style/YodaCondition
 
   def falsey?
     nil? || FALSE_VALUES.include?(self)
@@ -72,9 +74,11 @@ module ActiveObject::Object
     is_a?(Time)
   end
 
+  # rubocop:disable Style/YodaCondition
   def true?
-    self == true
+    true == self
   end
+  # rubocop:enable Style/YodaCondition
 
   def truthy?
     TRUE_VALUES.include?(self)

data/lib/active_object/version.rb

@@ -1,3 +1,3 @@
 module ActiveObject
-  VERSION = '4.0.8'.freeze
+  VERSION = '4.0.9'.freeze
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: active_object
 version: !ruby/object:Gem::Version
-  version: 4.0.8
+  version: 4.0.9
 platform: ruby
 authors:
 - Juan Gomez
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2017-05-13 00:00:00.000000000 Z
+date: 2017-05-27 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: dry-configurable