active_object 3.1.0 → 4.0.0

data/Rakefile

@@ -1,3 +1,3 @@
-require "bundler/gem_tasks"
+require 'bundler/gem_tasks'
 
 task default: :spec

data/active_object.gemspec

@@ -1,27 +1,30 @@
 # coding: utf-8
-lib = File.expand_path("../lib", __FILE__)
+lib = File.expand_path('../lib', __FILE__)
 $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
-require "active_object/version"
+require 'active_object/version'
 
 Gem::Specification.new do |spec|
-  spec.name = "active_object"
+  spec.name = 'active_object'
   spec.version = ActiveObject::VERSION
-  spec.authors = ["Juan Gomez"]
-  spec.email = ["j.gomez@drexed.com"]
+  spec.authors = ['Juan Gomez']
+  spec.email = ['j.gomez@drexed.com']
 
-  spec.summary = %q{Gem for commonly used ruby object helpers.}
-  spec.description = %q{Class extensions of commonly used ruby object helpers.}
-  spec.homepage = "http://drexed.github.io/active_object"
-  spec.license = "MIT"
+  spec.summary = 'Gem for commonly used ruby object helpers.'
+  spec.description = 'Class extensions of commonly used ruby object helpers.'
+  spec.homepage = 'http://drexed.github.io/active_object'
+  spec.license = 'MIT'
 
   spec.files = `git ls-files -z`.split("\x0").reject { |f| f.match(%r{^(test|spec|features)/}) }
-  spec.bindir = "exe"
+  spec.bindir = 'exe'
   spec.executables = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
-  spec.require_paths = ["lib"]
+  spec.require_paths = ['lib']
 
-  spec.add_development_dependency "bundler"
-  spec.add_development_dependency "coveralls"
-  spec.add_development_dependency "rake"
-  spec.add_development_dependency "rspec"
-  spec.add_development_dependency "generator_spec"
+  spec.add_development_dependency 'bundler'
+  spec.add_development_dependency 'coveralls'
+  spec.add_development_dependency 'rake'
+  spec.add_development_dependency 'rspec'
+  spec.add_development_dependency 'generator_spec'
+  spec.add_development_dependency 'fasterer'
+  spec.add_development_dependency 'reek'
+  spec.add_development_dependency 'rubocop'
 end

data/bin/console

@@ -1,14 +1,14 @@
 #!/usr/bin/env ruby
 
-require "bundler/setup"
-require "active_object"
+require 'bundler/setup'
+require 'active_object'
 
 # You can add fixtures and/or initialization code here to make experimenting
 # with your gem easier. You can also use a different console, if you like.
 
 # (If you use this, don't forget to add pry to your Gemfile!)
-# require "pry"
+# require 'pry'
 # Pry.start
 
-require "irb"
+require 'irb'
 IRB.start

data/bin/rake

@@ -2,15 +2,14 @@
 #
 # This file was generated by Bundler.
 #
-# The application "rake" is installed as part of a gem, and
+# The application 'rake' is installed as part of a gem, and
 # this file is here to facilitate running it.
 #
 
-require "pathname"
-ENV["BUNDLE_GEMFILE"] ||= File.expand_path("../../Gemfile",
-  Pathname.new(__FILE__).realpath)
+require 'pathname'
+ENV['BUNDLE_GEMFILE'] ||= File.expand_path('../../Gemfile', Pathname.new(__FILE__).realpath)
 
-require "rubygems"
-require "bundler/setup"
+require 'rubygems'
+require 'bundler/setup'
 
-load Gem.bin_path("rake", "rake")
+load Gem.bin_path('rake', 'rake')

data/lib/active_object.rb

@@ -1,35 +1,6 @@
-require "active_object/version"
-require "active_object/configuration"
-
-module ActiveObject
-
-  class << self
-    attr_accessor :configuration
-  end
-
-  def self.configuration
-    @configuration ||= Configuration.new
-  end
-
-  def self.configuration=(config)
-    @configuration = config
-  end
-
-  def self.configure
-    yield(configuration)
+%w(version settings array date enumerable hash integer numeric object range string time)
+  .each do |file_name|
+    require "active_object/#{file_name}"
   end
 
-end
-
-require "active_object/array"
-require "active_object/date"
-require "active_object/enumerable"
-require "active_object/hash"
-require "active_object/integer"
-require "active_object/numeric"
-require "active_object/object"
-require "active_object/range"
-require "active_object/string"
-require "active_object/time"
-
-require "generators/active_object/install_generator"
+require 'generators/active_object/install_generator'

data/lib/active_object/array.rb

@@ -30,25 +30,26 @@ module ActiveObject::Array
 
   def delete_values(*args)
     result = []
-    args.each { |v| result << delete(v) }
+    args.each { |val| result << delete(val) }
     result
   end
 
   def dig(key, *rest)
-    if value = (self[key] rescue nil)
-      if rest.empty?
-        value
-      elsif value.respond_to?(:dig)
-        value.dig(*rest)
-      end
+    value = (self[key] rescue nil)
+    return if value.nil?
+
+    if rest.empty?
+      value
+    elsif value.respond_to?(:dig)
+      value.dig(*rest)
     end
   end
 
-  def duplicates(minimum=2)
+  def duplicates(minimum = 2)
     hash = Hash.new(0)
 
-    each { |i| hash[i] += 1 }
-    hash.delete_if { |k, v| v < minimum }.keys
+    each { |val| hash[val] += 1 }
+    hash.delete_if { |_, val| val < minimum }.keys
   end
 
   def from(position)
@@ -58,32 +59,36 @@ module ActiveObject::Array
   def groups(number)
     return([]) if number <= 0
 
-    n, r = length.divmod(number)
-    collection = (0..(n - 1)).collect { |i| self[(i * number), number] }
-    r > 0 ? collection << self[-r, r] : collection
+    num, rem = length.divmod(number)
+    collection = (0..(num - 1)).collect { |val| self[(val * number), number] }
+    rem.positive? ? collection << self[-rem, rem] : collection
   end
 
-  def in_groups(number, fill_with=nil)
+  # rubocop:disable Metrics/MethodLength, Metrics/CyclomaticComplexity, Metrics/AbcSize
+  def in_groups(number, fill_with = nil)
     collection_length = length
     division = collection_length.div(number)
     modulo = collection_length % number
 
     collection = []
     start = 0
-    number.times do |i|
-      grouping = division + (modulo > 0 && modulo > i ? 1 : 0)
+    number.times do |int|
+      mod_gt_zero = modulo.positive?
+      grouping = division + (mod_gt_zero && modulo > int ? 1 : 0)
       collection << last_group = slice(start, grouping)
-      last_group << fill_with if fill_with != false && modulo > 0 && grouping == division
+      last_group << fill_with if fill_with != false && mod_gt_zero && grouping == division
       start += grouping
     end
 
-    block_given? ? collection.each { |g| yield(g) } : collection
+    block_given? ? collection.each { |val| yield(val) } : collection
   end
+  # rubocop:enable Metrics/MethodLength, Metrics/CyclomaticComplexity, Metrics/AbcSize
 
-  def in_groups_of(number, fill_with=nil)
+  # rubocop:disable Metrics/MethodLength, Metrics/AbcSize
+  def in_groups_of(number, fill_with = nil)
     if number.to_i <= 0
       raise ArgumentError,
-        "Group length must be a positive integer, was #{number.inspect}"
+            "Group length must be a positive integer, was #{number.inspect}"
     end
 
     if fill_with == false
@@ -93,17 +98,20 @@ module ActiveObject::Array
       collection = dup.concat(Array.new(padding, fill_with))
     end
 
-    block_given? ? collection.each_slice(number) { |slice| yield(slice) } : collection.each_slice(number).to_a
+    sliced_collection = collection.each_slice(number)
+
+    block_given? ? sliced_collection { |val| yield(val) } : sliced_collection.to_a
   end
+  # rubocop:enable Metrics/MethodLength, Metrics/AbcSize
 
   def percentile(percentage)
-    size = self.size
+    total_size = size
 
-    if size > 1
-      index = (size * percentage) / 100.0
-      self.sort[index]
+    if total_size > 1
+      index = (total_size * percentage) / 100.0
+      sort[index]
     else
-      self.first
+      first
     end
   end
 
@@ -111,31 +119,33 @@ module ActiveObject::Array
     hash = Hash.new(0.0)
     differ = 0.0
 
-    each do |e|
-      hash[e] += 1.0
+    each do |val|
+      hash[val] += 1.0
       differ += 1.0
     end
 
-    hash.keys.each { |e| hash[e] /= differ }
+    hash.each_key { |val| hash[val] /= differ }
     hash
   end
 
   def reject_values(*args)
-    reject { |x| args.include?(x) }
+    reject { |val| args.include?(val) }
   end
 
   def sample!
     delete_at(Random.rand(length - 1))
   end
 
-  def split(number=nil)
+  # rubocop:disable Metrics/MethodLength, Metrics/AbcSize
+  def split(number = nil)
     if block_given?
-      inject([[]]) do |results, element|
+      each_with_object([[]]) do |element, results|
         yield(element) ? (results << []) : (results.last << element)
-        results
       end
     else
-      results, arr = [[]], dup
+      results = [[]]
+      arr = dup
+
       until arr.empty?
         if (idx = arr.index(number))
           results.last.concat(arr.shift(idx))
@@ -145,12 +155,14 @@ module ActiveObject::Array
           results.last.concat(arr.shift(arr.length))
         end
       end
+
       results
     end
   end
+  # rubocop:enable Metrics/MethodLength, Metrics/AbcSize
 
   def strip
-    reject { |v| v.blank? }
+    reject(&:blank?)
   end
 
   def strip!
@@ -161,17 +173,18 @@ module ActiveObject::Array
     position >= 0 ? first(position + 1) : self[0..position]
   end
 
-  def to_sentence(options={})
+  # rubocop:disable Metrics/MethodLength
+  def to_sentence(options = {})
     default_connectors = {
-      words_connector: ", ",
-      two_words_connector: " and ",
-      last_word_connector: ", and "
+      words_connector: ', ',
+      two_words_connector: ' and ',
+      last_word_connector: ', and '
     }
     options = default_connectors.merge!(options)
 
     case length
     when 0
-      ""
+      ''
     when 1
       self[0].to_s.dup
     when 2
@@ -180,7 +193,8 @@ module ActiveObject::Array
       "#{self[0...-1].join(options[:words_connector])}#{options[:last_word_connector]}#{self[-1]}"
     end
   end
+  # rubocop:enable Metrics/MethodLength
 
 end
 
-Array.send(:include, ActiveObject::Array) if ActiveObject.configuration.autoload_array
+Array.send(:include, ActiveObject::Array) if ActiveObject::Settings.config.autoload_array

data/lib/active_object/date.rb

@@ -1,5 +1,4 @@
 module ActiveObject::Date
-
   MINUTE = 60.0
   HOUR = MINUTE * 60.0
   DAY = HOUR * 24.0
@@ -10,26 +9,22 @@ module ActiveObject::Date
   MILLENNIUM = CENTURY * 10.0
 
   STRING_UNITS = {
-    d: "d", day: "d", day_padded: "d", dd: "-d", Day: "-d", day_unpadded: "-d",
-    ddd: "_d", DAY: "_d", day_blank: "_d", dddd: "j", day_of_the_year: "j",
-    m: "m", month: "m", month_padded: "m", mm: "-m", Month: "-m",
-    month_unpadded: "-m", mmm: "_m", MONTH: "_m", month_blank: "_m", mmmm: "B",
-    month_name: "B", mmmmm: "b", month_name_abbr: "b", w: "u", weekday: "u",
-    ww: "w", weekday_offset: "w", www: "A", weekday_name: "A", wwww: "a",
-    weekday_name_abbr: "a", wwwww: "W", week: "W", wwwwww: "U", week_offset: "U",
-    yy: "y", yr: "y", yyyy: "Y", year: "Y"
-  }
+    d: 'd', day: 'd', day_padded: 'd', dd: '-d', Day: '-d', day_unpadded: '-d', ddd: '_d',
+    DAY: '_d', day_blank: '_d', dddd: 'j', day_of_the_year: 'j', m: 'm', month: 'm', yyyy: 'Y',
+    month_padded: 'm', mm: '-m', Month: '-m', month_unpadded: '-m', mmm: '_m', MONTH: '_m',
+    month_blank: '_m', mmmm: 'B', month_name: 'B', mmmmm: 'b', month_name_abbr: 'b', w: 'u',
+    weekday: 'u', ww: 'w', weekday_offset: 'w', www: 'A', weekday_name: 'A', wwww: 'a', year: 'Y',
+    weekday_name_abbr: 'a', wwwww: 'W', week: 'W', wwwwww: 'U', week_offset: 'U', yy: 'y', yr: 'y'
+  }.freeze
   KEY_UNITS = {
-    month: "%m", month_padded: "%m", month_unpadded: "%-m", month_blank: "%_m",
-    month_name: "%B", month_name_abbr: "%b", month_year: "%m %Y",
-    month_padded_year: "%m %Y", month_unpadded_year: "%-m %Y",
-    month_blank_year: "%_m %Y", month_name_year: "%B %Y",
-    month_name_abbr_year: "%b %Y", weekday: "%d", weekday_padded: "%d",
-    weekday_unpadded: "%-d", weekday_blank: "%_d", weekday_name: "%A",
-    weekday_name_abbr: "%a", yr: "%y", year_abbr: "%y", year: "%Y",
-    date: "%B %-d, %Y", date_abbr:"%b %-d, %Y", date_iso: "%Y-%m-%d",
-    day: "%B %-d", day_abbr: "%b %-d", day_iso: "%m-%d"
-  }
+    month: '%m', month_padded: '%m', month_unpadded: '%-m', month_blank: '%_m', month_name: '%B',
+    month_name_abbr: '%b', month_year: '%m %Y', month_padded_year: '%m %Y', day_iso: '%m-%d',
+    month_unpadded_year: '%-m %Y', month_blank_year: '%_m %Y', month_name_year: '%B %Y',
+    month_name_abbr_year: '%b %Y', weekday: '%d', weekday_padded: '%d', weekday_unpadded: '%-d',
+    weekday_blank: '%_d', weekday_name: '%A', weekday_name_abbr: '%a', yr: '%y', year_abbr: '%y',
+    year: '%Y', date: '%B %-d, %Y', date_abbr: '%b %-d, %Y', date_iso: '%Y-%m-%d', day: '%B %-d',
+    day_abbr: '%b %-d'
+  }.freeze
 
   def count_centuries_since(time)
     count_seconds_since(time) / CENTURY
@@ -96,7 +91,7 @@ module ActiveObject::Date
     strftime(string.join)
   end
 
-  def to_format(key=:datetime_iso)
+  def to_format(key = :datetime_iso)
     strftime(KEY_UNITS.fetch(key.to_sym))
   end
 
@@ -104,4 +99,4 @@ module ActiveObject::Date
 
 end
 
-Date.send(:include, ActiveObject::Date) if ActiveObject.configuration.autoload_date
+Date.send(:include, ActiveObject::Date) if ActiveObject::Settings.config.autoload_date

data/lib/active_object/enumerable.rb

@@ -1,39 +1,43 @@
 module Enumerable
 
+  # rubocop:disable Lint/UnusedMethodArgument
   def cluster(&block)
     result = []
-    each do |element|
-      if result.last && (yield(result.last.last) == yield(element))
-        result.last << element
+    each do |ele|
+      last_res = result.last
+
+      if last_res && (yield(last_res.last) == yield(ele))
+        last_res << ele
       else
-        result << [element]
+        result << [ele]
       end
     end
     result
   end
+  # rubocop:enable Lint/UnusedMethodArgument
 
-  def difference(identity=0, &block)
+  def difference(identity = 0, &block)
     if block_given?
       map(&block).difference(identity)
     else
-      inject { |d, v| d - v } || identity
+      inject { |key, val| key - val } || identity
     end
   end
 
-  def divisible(identity=0, &block)
+  def divisible(identity = 0, &block)
     if block_given?
       map(&block).divisible(identity)
     else
-      inject { |d, v| d / v } || identity
+      inject { |key, val| key / val } || identity
     end
   end
 
-  def drop_last(n)
+  def drop_last(num)
     collection_length = to_a.length
 
-    return(self) if n > collection_length
+    return(self) if num > collection_length
 
-    self[0...(collection_length - n)]
+    self[0...(collection_length - num)]
   end
 
   def drop_last_if
@@ -41,16 +45,20 @@ module Enumerable
 
     result = []
     dropping = true
-    reverse_each do |value|
-      result.unshift(value) unless dropping &&= yield(value)
+    reverse_each do |val|
+      result.unshift(val) unless dropping &&= yield(val)
     end
     result
   end
 
-  def exactly?(n)
+  def exactly?(num)
     found_count = 0
-    block_given? ? each { |*o| found_count += 1 if yield(*o) } : each { |o| found_count += 1 if o }
-    (found_count > n) ? false : n == found_count
+    if block_given?
+      each { |*opt| found_count += 1 if yield(*opt) }
+    else
+      each { |opt| found_count += 1 if opt }
+    end
+    found_count > num ? false : num == found_count
   end
 
   def exclude?(object)
@@ -58,30 +66,32 @@ module Enumerable
   end
 
   def expand
-    map { |n| n.is_a?(Enumerable) ? n.expand : n }
+    map { |val| val.is_a?(Enumerable) ? val.expand : val }
   end
 
-  def exponential(identity=0, &block)
+  def exponential(identity = 0, &block)
     if block_given?
       map(&block).exponential(identity)
     else
-      inject { |d, v| d ** v } || identity
+      inject { |key, val| key**val } || identity
     end
   end
 
   def frequencies
-    each_with_object(Hash.new(0)) { |e, a| a[e] += 1 }
+    each_with_object(Hash.new(0)) { |key, hsh| hsh[key] += 1 }
   end
 
+  # rubocop:disable Style/CaseEquality
   def incase?(object)
-    any? { |x| object === x }
+    any? { |val| object === val }
   end
+  # rubocop:enable Style/CaseEquality
 
   def many?
     found_count = 0
     if block_given?
-      any? do |v|
-        found_count += 1 if yield v
+      any? do |val|
+        found_count += 1 if yield val
         found_count > 1
       end
     else
@@ -89,16 +99,16 @@ module Enumerable
     end
   end
 
-  def max(identity=0)
-    (length rescue count) > 0 ? sort.last : identity
+  def max(identity = 0)
+    (length rescue count).positive? ? sort.last : identity
   end
 
-  def min(identity=0)
-    (length rescue count) > 0 ? sort.first : identity
+  def min(identity = 0)
+    (length rescue count).positive? ? sort.first : identity
   end
 
-  def mean(identity=0)
-    return(identity) unless length > 0
+  def mean(identity = 0)
+    return(identity) unless length.positive?
 
     collection_length = length
     sum.to_f / collection_length.to_f
@@ -106,44 +116,47 @@ module Enumerable
 
   alias_method :average, :mean
 
-  def median(identity=0)
+  def median(identity = 0)
     collection_length = length.to_f
     collection_sorted = sort
 
     return(identity) unless collection_length > 0.0
+    half_collection = collection_length / 2.0
+    sorted_collection = collection_sorted[half_collection]
 
     if (collection_length % 2).zero?
-      (collection_sorted[(collection_length / 2.0) -1.0] + collection_sorted[collection_length / 2.0]) / 2.0
+      (collection_sorted[half_collection - 1.0] + sorted_collection) / 2.0
     else
-      collection_sorted[collection_length / 2.0]
+      sorted_collection
     end
   end
 
-  def mode(identity=0)
-    return(identity) unless length > 0
+  # rubocop:disable Metrics/AbcSize
+  def mode(identity = 0)
+    return(identity) unless length.positive?
 
-    frequency_distribution = inject(Hash.new(0)) { |h, v| h[v] += 1; h }
-    frequency_top_two = frequency_distribution.sort { |k, v| v[1] <=> k[1] }.take(2)
+    frequency_distribution = each_with_object(Hash.new(0)) { |val, hsh| hsh[val] += 1 }
+    frequency_top_two = frequency_distribution.sort_by { |_, val| -val }.take(2)
+    top_two_first = frequency_top_two.first
 
-    if frequency_top_two.length == 1
-      frequency_top_two.first.first
-    elsif frequency_top_two.first.last == frequency_top_two.last.last
+    if frequency_top_two.length != 1 && top_two_first.last == frequency_top_two.last.last
       nil
     else
-      frequency_top_two.first.first
+      top_two_first.first
     end
   end
+  # rubocop:ensable Metrics/AbcSize
 
-  def multiple(identity=0, &block)
+  def multiple(identity = 0, &block)
     if block_given?
       map(&block).multiple(identity)
     else
-      inject { |d, v| d * v } || identity
+      inject { |key, val| key * val } || identity
     end
   end
 
-  def range(identity=0)
-    return(identity) unless length > 0
+  def range(identity = 0)
+    return(identity) unless length.positive?
 
     collection_sorted = sort
     collection_sorted.last - collection_sorted.first
@@ -151,47 +164,51 @@ module Enumerable
 
   def several?
     found_count = 0
-    block_given? ? each { |*o| found_count += 1 if yield(*o) } : each { |o| found_count += 1 if o }
-    (found_count > 1) ? true : false
+    if block_given?
+      each { |*opt| found_count += 1 if yield(*opt) }
+    else
+      each { |opt| found_count += 1 if opt }
+    end
+    found_count > 1 ? true : false
   end
 
-  def standard_deviation(identity=0)
+  def standard_deviation(identity = 0)
     return(identity) if length < 2
 
     Math.sqrt(variance)
   end
 
-  def sum(identity=0, &block)
+  def sum(identity = 0, &block)
     if block_given?
       map(&block).sum(identity)
     else
-      inject { |s, v| s + v } || identity
+      inject { |sum, val| sum + val } || identity
     end
   end
 
-  def take_last(n)
+  def take_last(num)
     collection_length = to_a.length
 
-    return(self) if n > collection_length
+    return(self) if num > collection_length
 
-    self[(collection_length - n)..-1]
+    self[(collection_length - num)..-1]
   end
 
   def take_last_if
     return(to_enum(:take_last_if)) unless block_given?
 
     result = []
-    reverse_each { |e| yield(e) ? result.unshift(e) : break }
+    reverse_each { |val| yield(val) ? result.unshift(val) : break }
     result
   end
 
-  def variance(identity=0)
+  def variance(identity = 0)
     collection_length = length
 
     return(identity) if collection_length <= 1
 
-    sum = inject(0.0) { |s,v| s + (v - mean) ** 2.0 }
-    sum.to_f / (collection_length.to_f - 1.0)
+    total = inject(0.0) { |sum, val| sum + (val - mean)**2.0 }
+    total.to_f / (collection_length.to_f - 1.0)
   end
 
 end