active_model_validates_intersection_of 3.0.0 → 3.0.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 9ed1bdf75c9a416f57b7bfbde026eaf31a2b9663386df953ff7ed828ce41b5b6
-  data.tar.gz: 835d965a9ffc3e2727271a7a2e35b1e936be77d7ae93b12896d0a1693bb52116
+  metadata.gz: 380a36633d08fb17e45a86ad9d94c329620487717be29f4ee3cfd4573a2ba1de
+  data.tar.gz: 00f2ec575910e8f8c7b8ab563a07b07f8c60e11740ecf10253d45b3f22730ac1
 SHA512:
-  metadata.gz: 31a485ee38ce7e938530eb28bbef35b9be11a003b41c3cd12294c4b71bdabc4fc7ddbed461118445ac1ff9d798a79e54d9bce5c3628ef9feb1e5e4033a5ba29a
-  data.tar.gz: 2f0384c4a8f23d7554df00a1d5300d6c125109f1b334f317ba4105c1af558d1526f0bddd6cd75bd9e0f9590fc745979db497a98612fef70f0f80c155deb1b3c2
+  metadata.gz: bf99fdd4024988e87e6b7fd079f17347750aa80ce75cd7d4c9f71857e373abf99958672adb2af49886beddb9221c3f947060cca21bbacddaec9f0488e3e2a7f8
+  data.tar.gz: be4f4ed87278de54137fa89661ede7a931160fc50996d7d7e36f90efaef2c6b31ff198929880ab36812e19893834eb67ab40eb923f1300465c09c6b661222f7c

data/CHANGELOG.md

@@ -1,3 +1,7 @@
+## v3.0.1 (2021-08-24)
+
+- Fixing model validation when the value is nil (eg: list = `[nil]` model.valid? should be false). (From issue: #9)
+
 ## v3.0.0 (2021-04-13)
 
 - Ruby 3 support.

data/lib/active_model_validates_intersection_of/validator.rb

@@ -12,7 +12,7 @@ module ActiveModelValidatesIntersectionOf
     def validate_each(record, attribute, value)
       raise ArgumentError, "value must be an array" unless value.is_a?(Array)
       
-      if (value - members(record)).any?
+      if (value - members(record)).size > 0
         record.errors.add(attribute, :inclusion, **options.except(:in, :within).merge!(value: value))
       end
     end

data/lib/active_model_validates_intersection_of/version.rb

@@ -1,3 +1,3 @@
 module ActiveModelValidatesIntersectionOf
-  VERSION = "3.0.0".freeze
+  VERSION = "3.0.1".freeze
 end

data/spec/lib/intersection_validator_spec.rb

@@ -37,6 +37,22 @@ RSpec.describe IntersectionValidator do
       describe "with an invalid list" do
         it_behaves_like "invalid object"
       end
+
+      context "when the model value is an array with nil value" do
+        class ListTest
+          VALID_ARRAY = ["z", "x", 5 , 6]
+          include ActiveModel::Validations
+          attr_accessor :list
+          validates_intersection_of :list, within: VALID_ARRAY, message: "not valid"
+        end
+  
+        subject { ListTest.new }
+  
+        it "should return as invalid" do
+          subject.list = [nil]
+          expect(subject.valid?).to eq(false)
+        end
+      end
     end
 
     context "with :within option" do
@@ -61,6 +77,22 @@ RSpec.describe IntersectionValidator do
           it_behaves_like "invalid object"
         end
       end
+
+      context "when the model value is an array with nil value" do
+        class ListTest
+          VALID_ARRAY = ["z", "x", 5 , 6]
+          include ActiveModel::Validations
+          attr_accessor :list
+          validates_intersection_of :list, within: VALID_ARRAY, message: "not valid"
+        end
+  
+        subject { ListTest.new }
+  
+        it "should return as invalid" do
+          subject.list = [nil]
+          expect(subject.valid?).to eq(false)
+        end
+      end
     end
 
     context "validate with lambda" do

data/spec/lib/validates_intersection_of_alias_spec.rb

@@ -65,5 +65,21 @@ RSpec.describe ActiveModel::Validations::HelperMethods do
         end
       end
     end
+
+    context "when the model value is an array with nil value" do
+      class ListTest
+        VALID_ARRAY = ["z", "x", 5 , 6]
+        include ActiveModel::Validations
+        attr_accessor :list
+        validates_intersection_of :list, within: VALID_ARRAY, message: "not valid"
+      end
+
+      subject { ListTest.new }
+
+      it "should return as invalid" do
+        subject.list = [nil]
+        expect(subject.valid?).to eq(false)
+      end
+    end
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: active_model_validates_intersection_of
 version: !ruby/object:Gem::Version
-  version: 3.0.0
+  version: 3.0.1
 platform: ruby
 authors:
 - Rafael Biriba
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2021-04-13 00:00:00.000000000 Z
+date: 2021-08-24 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activemodel