active_model_serializers_validator 1.0.1 → 1.1

data/.travis.yml

@@ -0,0 +1,7 @@
+language: ruby
+
+rvm:
+  - 2.0.0
+  - 1.9.3
+
+script: "echo 'DO IT' && bundle exec rake spec"

data/README.md

@@ -1,5 +1,8 @@
 # ActiveModel::Serializer::Validator
 
+[![Gem Version](https://badge.fury.io/rb/active_model_serializers_validator.png)](https://rubygems.org/gems/active_model_serializers_validator)
+[![Build Status](https://travis-ci.org/mirego/active_model_serializers_validator.png?branch=master)](https://travis-ci.org/mirego/active_model_serializers_validator)
+
 This gem adds JSON schema validations for the JSON output generated by an `ActiveModel::Serializer`.
 
 ## Installation
@@ -57,11 +60,6 @@ serializer.errors
 
 ## About Mirego
 
-Mirego is a team of passionate people who believe that work is a place where you can innovate and have fun.
-We proudly built mobile applications for
-[iPhone](http://mirego.com/en/iphone-app-development/ "iPhone application development"),
-[iPad](http://mirego.com/en/ipad-app-development/ "iPad application development"),
-[Android](http://mirego.com/en/android-app-development/ "Android application development"),
-[Blackberry](http://mirego.com/en/blackberry-app-development/ "Blackberry application development"),
-[Windows Phone](http://mirego.com/en/windows-phone-app-development/ "Windows Phone application development") and
-[Windows 8](http://mirego.com/en/windows-8-app-development/ "Windows 8 application development").
+Mirego is a team of passionate people who believe that work is a place where you can innovate and have fun. We proudly build mobile applications for [iPhone](http://mirego.com/en/iphone-app-development/ "iPhone application development"), [iPad](http://mirego.com/en/ipad-app-development/ "iPad application development"), [Android](http://mirego.com/en/android-app-development/ "Android application development"), [Blackberry](http://mirego.com/en/blackberry-app-development/ "Blackberry application development"), [Windows Phone](http://mirego.com/en/windows-phone-app-development/ "Windows Phone application development") and [Windows 8](http://mirego.com/en/windows-8-app-development/ "Windows 8 application development") in beautiful Quebec City.
+
+We also love [open-source software](http://open.mirego.com/) and we try to extract as much code as possible from our projects to give back to the community.

data/Rakefile

@@ -1,7 +1,7 @@
 require "bundler/gem_tasks"
 require "rspec/core/rake_task"
 
-task :default => :spec
+task default: :spec
 
 desc "Run all specs"
 RSpec::Core::RakeTask.new(:spec) do |task|

data/lib/active_model/serializer/validator/errors.rb

@@ -0,0 +1,8 @@
+module ActiveModel
+  class Serializer
+    module Validator
+      class InvalidSchemaError < StandardError
+      end
+    end
+  end
+end

data/lib/active_model/serializer/validator/mixin.rb

@@ -22,7 +22,14 @@ module ActiveModel
             end
 
             return @_json_schema unless value
-            @_json_schema = value
+
+            if !value.is_a?(String) && !value.is_a?(Hash)
+              raise InvalidSchemaError.new('Schema must be a path to a file or a Hash.')
+            elsif value.is_a?(String) && !File.exists?(value)
+              raise InvalidSchemaError.new('Schema file does not exist.')
+            else
+              @_json_schema = value
+            end
           end
 
           # Validate the rendered data against a JSON schema file and

data/lib/active_model/serializer/validator/version.rb

@@ -1,7 +1,7 @@
 module ActiveModel
   class Serializer
     module Validator
-      VERSION = '1.0.1'
+      VERSION = '1.1'
     end
   end
 end

data/lib/active_model_serializers_validator.rb

@@ -2,6 +2,7 @@ require 'json-schema'
 require 'active_support'
 require 'active_support/core_ext/object/to_json'
 require 'active_model/serializer'
+require 'active_model/serializer/validator/errors'
 require 'active_model/serializer/validator/mixin'
 require 'active_model/serializer/validator/version'
 

data/spec/validator_spec.rb

@@ -2,7 +2,7 @@ require 'spec_helper'
 
 describe ActiveModel::Serializer::Validator do
   describe :valid? do
-    subject { ActiveModel::Serializer.new(OpenStruct.new(:foo => 'bar')) }
+    subject { ActiveModel::Serializer.new(OpenStruct.new(foo: 'bar')) }
     before { ActiveModel::Serializer.stub(:valid_against_schema?).and_return(stubbed_validation) }
 
     context 'with empty errors' do
@@ -28,21 +28,56 @@ describe ActiveModel::Serializer::Validator do
 
     subject { ActiveModel::Serializer.valid_against_schema?(product_schema, serializer) }
     let(:serializer) { ProductSerializer.new(serializable) }
-      let(:schema) { product_schema }
+    let(:schema) { product_schema }
 
     context 'without validaton errors' do
-      let(:serializable) { OpenStruct.new(:id => 4, :name => "Widget", :price => 1200, :tags => %w(foo bar baz)) }
+      let(:serializable) { OpenStruct.new(id: 4, name: "Widget", price: 1200, tags: %w(foo bar baz)) }
       it { should be_empty }
     end
 
     context 'with validaton errors' do
-      let(:serializable) { OpenStruct.new(:id => 4, :price => 1200, :tags => %w(foo bar baz)) }
+      let(:serializable) { OpenStruct.new(id: 4, price: 1200, tags: %w(foo bar baz)) }
       it { should_not be_empty }
       its(:length) { should eql 1 }
     end
   end
 
   describe :json_schema do
-    # TODO
+    subject { ProductSerializer.new(serializable) }
+    let(:set_schema!) { ProductSerializer.json_schema schema_file }
+
+    before do
+      try_remove_const(:ProductSerializer)
+
+      ProductSerializer = Class.new(ActiveModel::Serializer) do
+        self.root = false
+        attributes :id, :name, :price, :tags
+      end
+    end
+
+    context 'with existing file' do
+      let(:schema_file) { File.expand_path("../fixtures/product.jsonschema", __FILE__) }
+      before { set_schema! }
+
+      context 'with valid serializable' do
+        let(:serializable) { OpenStruct.new(id: 4, name: "Widget", price: 1200, tags: %w(foo bar baz)) }
+        it { should be_valid }
+      end
+
+      context 'with invalid serializable' do
+        let(:serializable) { OpenStruct.new }
+        it { should_not be_valid }
+      end
+    end
+
+    context 'with unknown file as schema' do
+      let(:schema_file) { File.expand_path("../fixtures/non-existing-file.jsonschema", __FILE__) }
+      it { expect { set_schema! }.to raise_error ActiveModel::Serializer::Validator::InvalidSchemaError, 'Schema file does not exist.' }
+    end
+
+    context 'with a non-supported type as schema' do
+      let(:schema_file) { true }
+      it { expect { set_schema! }.to raise_error ActiveModel::Serializer::Validator::InvalidSchemaError, 'Schema must be a path to a file or a Hash.' }
+    end
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: active_model_serializers_validator
 version: !ruby/object:Gem::Version
-  version: 1.0.1
+  version: '1.1'
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-07-09 00:00:00.000000000 Z
+date: 2013-08-03 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -133,11 +133,13 @@ extra_rdoc_files: []
 files:
 - .gitignore
 - .rspec
+- .travis.yml
 - Gemfile
 - LICENSE.md
 - README.md
 - Rakefile
 - active_model_serializers_validator.gemspec
+- lib/active_model/serializer/validator/errors.rb
 - lib/active_model/serializer/validator/mixin.rb
 - lib/active_model/serializer/validator/version.rb
 - lib/active_model_serializers_validator.rb
@@ -161,7 +163,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: -3800885852508204265
+      hash: -3032059615404729066
 required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
   requirements:
@@ -170,7 +172,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: -3800885852508204265
+      hash: -3032059615404729066
 requirements: []
 rubyforge_project: 
 rubygems_version: 1.8.23