active_model_serializers 0.8.4 → 0.9.0.alpha1

data/test/integration/active_record/active_record_test.rb

@@ -0,0 +1,77 @@
+require 'test_helper'
+require 'fixtures/active_record'
+
+module ActiveModel
+  class Serializer
+    class ActiveRecordTest < ActiveModel::TestCase
+      def setup
+        @post = ARPost.first
+      end
+
+      def test_serialization_embedding_objects
+        post_serializer = ARPostSerializer.new(@post)
+
+        assert_equal({
+          'ar_post' => {
+            title: 'New post', body: 'A body!!!',
+            ar_comments: [{ body: 'what a dumb post', ar_tags: [{ name: 'happy' }, { name: 'whiny' }] },
+                          { body: 'i liked it', ar_tags: [{:name=>"happy"}, {:name=>"short"}] }],
+            ar_tags: [{ name: 'short' }, { name: 'whiny' }],
+            ar_section: { 'name' => 'ruby' }
+          }
+        }, post_serializer.as_json)
+      end
+
+      def test_serialization_embedding_ids
+        post_serializer = ARPostSerializer.new(@post)
+
+        embed(ARPostSerializer, embed: :ids) do
+          assert_equal({
+            'ar_post' => {
+              title: 'New post', body: 'A body!!!',
+              'ar_comment_ids' => [1, 2],
+              'ar_tag_ids' => [1, 2],
+              'ar_section_id' => 1
+            }
+          }, post_serializer.as_json)
+        end
+      end
+
+      def test_serialization_embedding_ids_including_in_root
+        post_serializer = ARPostSerializer.new(@post)
+
+        embed(ARPostSerializer, embed: :ids, embed_in_root: true) do
+          embed(ARCommentSerializer, embed: :ids, embed_in_root: true) do
+            assert_equal({
+              'ar_post' => {
+                title: 'New post', body: 'A body!!!',
+                'ar_comment_ids' => [1, 2],
+                'ar_tag_ids' => [1, 2],
+                'ar_section_id' => 1
+              },
+              ar_comments: [{ body: 'what a dumb post', 'ar_tag_ids' => [3, 2] },
+                            { body: 'i liked it', 'ar_tag_ids' => [3, 1] }],
+              ar_tags: [{ name: 'happy' }, { name: 'whiny' }, { name: 'short' }],
+              'ar_sections' => [{ 'name' => 'ruby' }]
+            }, post_serializer.as_json)
+          end
+        end
+      end
+
+      private
+
+      def embed(serializer_class, options = {})
+        old_assocs = Hash[serializer_class._associations.to_a.map { |(name, association)| [name, association.dup] }]
+
+        serializer_class._associations.each_value do |association|
+          association.embed = options[:embed]
+          association.embed_in_root = options[:embed_in_root]
+        end
+
+        yield
+      ensure
+        serializer_class._associations = old_assocs
+      end
+    end
+  end
+end

data/test/integration/generators/resource_generator_test.rb

@@ -0,0 +1,26 @@
+require 'test_helper'
+require 'rails'
+require 'active_model/serializer/railtie'
+require 'test_app'
+
+class ResourceGeneratorTest < Rails::Generators::TestCase
+  destination File.expand_path('../../../tmp', __FILE__)
+  setup :prepare_destination, :copy_routes
+
+  tests Rails::Generators::ResourceGenerator
+  arguments %w(account)
+
+  def test_serializer_file_is_generated
+    run_generator
+
+    assert_file 'app/serializers/account_serializer.rb', /class AccountSerializer < ActiveModel::Serializer/
+  end
+
+  private
+
+  def copy_routes
+    config_dir = File.join(destination_root, 'config')
+    FileUtils.mkdir_p(config_dir)
+    File.write(File.join(config_dir, 'routes.rb'), 'Rails.application.routes.draw { }')
+  end
+end

data/test/integration/generators/scaffold_controller_generator_test.rb

@@ -0,0 +1,67 @@
+require 'test_helper'
+require 'rails'
+require 'active_model/serializer/railtie'
+require 'test_app'
+
+class ScaffoldControllerGeneratorTest < Rails::Generators::TestCase
+  destination File.expand_path('../../../tmp', __FILE__)
+  setup :prepare_destination
+
+  tests Rails::Generators::ScaffoldControllerGenerator
+  arguments %w(account name:string description:text business:references)
+
+  def test_generated_controller
+    return true if Rails::VERSION::MAJOR < 4
+
+    run_generator
+
+    assert_file 'app/controllers/accounts_controller.rb' do |content|
+      
+      assert_instance_method :index, content do |m|
+        assert_match /@accounts = Account\.all/, m
+        assert_match /format.html/, m
+        assert_match /format.json \{ render json: @accounts \}/, m
+      end
+
+      assert_instance_method :show, content do |m|
+        assert_match /format.html/, m
+        assert_match /format.json \{ render json: @account \}/, m
+      end
+
+      assert_instance_method :new, content do |m|
+        assert_match /@account = Account\.new/, m
+      end
+
+      assert_instance_method :edit, content do |m|
+        assert m.blank?
+      end
+
+      assert_instance_method :create, content do |m|
+        assert_match /@account = Account\.new\(account_params\)/, m
+        assert_match /@account\.save/, m
+        assert_match /format\.html \{ redirect_to @account, notice: 'Account was successfully created\.' \}/, m
+        assert_match /format\.json \{ render json: @account, status: :created \}/, m
+        assert_match /format\.html \{ render action: 'new' \}/, m
+        assert_match /format\.json \{ render json: @account\.errors, status: :unprocessable_entity \}/, m
+      end
+
+      assert_instance_method :update, content do |m|
+        assert_match /format\.html \{ redirect_to @account, notice: 'Account was successfully updated\.' \}/, m
+        assert_match /format\.json \{ head :no_content \}/, m
+        assert_match /format\.html \{ render action: 'edit' \}/, m
+        assert_match /format\.json \{ render json: @account.errors, status: :unprocessable_entity \}/, m
+      end
+
+      assert_instance_method :destroy, content do |m|
+        assert_match /@account\.destroy/, m
+        assert_match /format\.html { redirect_to accounts_url \}/, m
+        assert_match /format\.json \{ head :no_content \}/, m
+      end
+
+      assert_match(/def account_params/, content)
+      assert_match(/params\.require\(:account\)\.permit\(:name, :description, :business_id\)/, content)
+
+    end
+
+  end
+end

data/test/integration/generators/serializer_generator_test.rb

@@ -0,0 +1,41 @@
+require 'test_helper'
+require 'rails'
+require 'active_model/serializer/railtie'
+require 'test_app'
+
+class SerializerGeneratorTest < Rails::Generators::TestCase
+  destination File.expand_path('../../../tmp', __FILE__)
+  setup :prepare_destination
+
+  tests Rails::Generators::SerializerGenerator
+  arguments %w(account name:string description:text business:references)
+
+  def test_generates_a_serializer_with_attributes_and_associations
+    run_generator
+    assert_file 'app/serializers/account_serializer.rb', /class AccountSerializer < ActiveModel::Serializer/ do |serializer|
+      assert_match(/attributes :id, :name, :description/, serializer)
+      assert_match(/has_one :business/, serializer)
+    end
+  end
+
+  def test_generates_a_namespaced_serializer
+    run_generator ['admin/account']
+    assert_file 'app/serializers/admin/account_serializer.rb', /class Admin::AccountSerializer < ActiveModel::Serializer/
+  end
+
+  def test_uses_application_serializer_if_one_exists
+    Object.const_set(:ApplicationSerializer, Class.new)
+    run_generator
+    assert_file 'app/serializers/account_serializer.rb', /class AccountSerializer < ApplicationSerializer/
+  ensure
+    Object.send :remove_const, :ApplicationSerializer
+  end
+
+  def test_uses_given_parent
+    Object.const_set(:ApplicationSerializer, Class.new)
+    run_generator ['Account', '--parent=MySerializer']
+    assert_file 'app/serializers/account_serializer.rb', /class AccountSerializer < MySerializer/
+  ensure
+    Object.send :remove_const, :ApplicationSerializer
+  end
+end

data/test/test_app.rb

@@ -0,0 +1,11 @@
+class TestApp < Rails::Application
+  if Rails.version.to_s.first >= '4'
+    config.eager_load = false
+    config.secret_key_base = 'abc123'
+  end
+
+  # Set up a logger to avoid creating a log directory on every run.
+  config.logger = Logger.new(nil)
+end
+
+TestApp.initialize!

data/test/test_helper.rb

@@ -1,55 +1,21 @@
-require "rubygems"
-require "bundler/setup"
-
-require 'rails'
-require 'action_controller'
-require 'action_controller/test_case'
-require 'action_controller/railtie'
-require 'active_support/json'
-
-gem 'minitest'
+require 'bundler/setup'
+require 'coverage_setup'
 require 'minitest/autorun'
-if defined?(Minitest::Test)
-  $minitest_version = 5 # rubocop:disable Style/GlobalVars
-  # Minitest 5
-  # https://github.com/seattlerb/minitest/blob/e21fdda9d/lib/minitest/autorun.rb
-  # https://github.com/seattlerb/minitest/blob/e21fdda9d/lib/minitest.rb#L45-L59
-else
-  $minitest_version = 4 # rubocop:disable Style/GlobalVars
-  # Minitest 4
-  # https://github.com/seattlerb/minitest/blob/644a52fd0/lib/minitest/autorun.rb
-  # https://github.com/seattlerb/minitest/blob/644a52fd0/lib/minitest/unit.rb#L768-L787
-  # Ensure backward compatibility with Minitest 4
-  Minitest = MiniTest unless defined?(Minitest)
-  Minitest::Test = MiniTest::Unit::TestCase
-  def Minitest.after_run(&block)
-    MiniTest::Unit.after_tests(&block)
-  end
-end
-
-
-require "pry"
-
-require "active_model_serializers"
+require 'active_model_serializers'
+require 'fixtures/poro'
 
 module TestHelper
   Routes = ActionDispatch::Routing::RouteSet.new
   Routes.draw do
-    resource :hypermedia
     get ':controller(/:action(/:id))'
     get ':controller(/:action)'
   end
 
   ActionController::Base.send :include, Routes.url_helpers
-  ActiveModel::Serializer.send :include, Routes.url_helpers
 end
 
-ActiveSupport::TestCase.class_eval do
-  setup do
-    @routes = ::TestHelper::Routes
+ActionController::TestCase.class_eval do
+  def setup
+    @routes = TestHelper::Routes
   end
 end
-
-class Object
-  undef_method :id if respond_to?(:id)
-end

data/test/tmp/app/serializers/account_serializer.rb

@@ -0,0 +1,3 @@
+class AccountSerializer < MySerializer
+  attributes :id
+end

data/test/unit/active_model/array_serializer/meta_test.rb

@@ -0,0 +1,53 @@
+require 'test_helper'
+require 'active_model/serializer'
+
+module ActiveModel
+  class ArraySerializer
+    class MetaTest < ActiveModel::TestCase
+      def setup
+        @profile1 = Profile.new({ name: 'Name 1', description: 'Description 1', comments: 'Comments 1' })
+        @profile2 = Profile.new({ name: 'Name 2', description: 'Description 2', comments: 'Comments 2' })
+        @serializer = ArraySerializer.new([@profile1, @profile2], root: 'profiles')
+      end
+
+      def test_meta
+        @serializer.meta = { total: 10 }
+
+        assert_equal({
+          'profiles' => [
+            {
+              name: 'Name 1',
+              description: 'Description 1'
+            }, {
+              name: 'Name 2',
+              description: 'Description 2'
+            }
+          ],
+          meta: {
+            total: 10
+          }
+        }, @serializer.as_json)
+      end
+
+      def test_meta_using_meta_key
+        @serializer.meta_key = :my_meta
+        @serializer.meta     = { total: 10 }
+
+        assert_equal({
+          'profiles' => [
+            {
+              name: 'Name 1',
+              description: 'Description 1'
+            }, {
+              name: 'Name 2',
+              description: 'Description 2'
+            }
+          ],
+          my_meta: {
+            total: 10
+          }
+        }, @serializer.as_json)
+      end
+    end
+  end
+end

data/test/unit/active_model/array_serializer/root_test.rb

@@ -0,0 +1,102 @@
+require 'test_helper'
+
+module ActiveModel
+  class ArraySerializer
+    class RootAsOptionTest < ActiveModel::TestCase
+      def setup
+        @old_root = ArraySerializer._root
+        @profile1 = Profile.new({ name: 'Name 1', description: 'Description 1', comments: 'Comments 1' })
+        @profile2 = Profile.new({ name: 'Name 2', description: 'Description 2', comments: 'Comments 2' })
+        @serializer = ArraySerializer.new([@profile1, @profile2], root: :initialize)
+      end
+
+      def teardown
+        ArraySerializer._root = @old_root
+      end
+
+      def test_root_is_not_displayed_using_serializable_array
+        assert_equal([
+          { name: 'Name 1', description: 'Description 1' },
+          { name: 'Name 2', description: 'Description 2' }
+        ], @serializer.serializable_array)
+      end
+
+      def test_root_using_as_json
+        assert_equal({
+          initialize: [
+            { name: 'Name 1', description: 'Description 1' },
+            { name: 'Name 2', description: 'Description 2' }
+          ]
+        }, @serializer.as_json)
+      end
+
+      def test_root_as_argument_takes_precedence
+        assert_equal({
+          argument: [
+            { name: 'Name 1', description: 'Description 1' },
+            { name: 'Name 2', description: 'Description 2' }
+          ]
+        }, @serializer.as_json(root: :argument))
+      end
+
+      def test_using_false_root_in_initialize_takes_precedence
+        ArraySerializer._root = 'root'
+        @serializer = ArraySerializer.new([@profile1, @profile2], root: false)
+
+        assert_equal([
+          { name: 'Name 1', description: 'Description 1' },
+          { name: 'Name 2', description: 'Description 2' }
+        ], @serializer.as_json)
+      end
+    end
+
+    class RootInSerializerTest < ActiveModel::TestCase
+      def setup
+        @old_root = ArraySerializer._root
+        ArraySerializer._root = :in_serializer
+        @profile1 = Profile.new({ name: 'Name 1', description: 'Description 1', comments: 'Comments 1' })
+        @profile2 = Profile.new({ name: 'Name 2', description: 'Description 2', comments: 'Comments 2' })
+        @serializer = ArraySerializer.new([@profile1, @profile2])
+        @rooted_serializer = ArraySerializer.new([@profile1, @profile2], root: :initialize)
+      end
+
+      def teardown
+        ArraySerializer._root = @old_root
+      end
+
+      def test_root_is_not_displayed_using_serializable_hash
+        assert_equal([
+          { name: 'Name 1', description: 'Description 1' },
+          { name: 'Name 2', description: 'Description 2' }
+        ], @serializer.serializable_array)
+      end
+
+      def test_root_using_as_json
+        assert_equal({
+          in_serializer: [
+            { name: 'Name 1', description: 'Description 1' },
+            { name: 'Name 2', description: 'Description 2' }
+          ]
+        }, @serializer.as_json)
+      end
+
+      def test_root_in_initializer_takes_precedence
+        assert_equal({
+          initialize: [
+            { name: 'Name 1', description: 'Description 1' },
+            { name: 'Name 2', description: 'Description 2' }
+          ]
+        }, @rooted_serializer.as_json)
+      end
+
+      def test_root_as_argument_takes_precedence
+        assert_equal({
+          argument: [
+            { name: 'Name 1', description: 'Description 1' },
+            { name: 'Name 2', description: 'Description 2' }
+          ]
+        }, @rooted_serializer.as_json(root: :argument))
+      end
+    end
+  end
+end