active_model_serializers 0.8.3 → 0.9.0.alpha1

data/test/integration/generators/serializer_generator_test.rb

@@ -0,0 +1,41 @@
+require 'test_helper'
+require 'rails'
+require 'active_model/serializer/railtie'
+require 'test_app'
+
+class SerializerGeneratorTest < Rails::Generators::TestCase
+  destination File.expand_path('../../../tmp', __FILE__)
+  setup :prepare_destination
+
+  tests Rails::Generators::SerializerGenerator
+  arguments %w(account name:string description:text business:references)
+
+  def test_generates_a_serializer_with_attributes_and_associations
+    run_generator
+    assert_file 'app/serializers/account_serializer.rb', /class AccountSerializer < ActiveModel::Serializer/ do |serializer|
+      assert_match(/attributes :id, :name, :description/, serializer)
+      assert_match(/has_one :business/, serializer)
+    end
+  end
+
+  def test_generates_a_namespaced_serializer
+    run_generator ['admin/account']
+    assert_file 'app/serializers/admin/account_serializer.rb', /class Admin::AccountSerializer < ActiveModel::Serializer/
+  end
+
+  def test_uses_application_serializer_if_one_exists
+    Object.const_set(:ApplicationSerializer, Class.new)
+    run_generator
+    assert_file 'app/serializers/account_serializer.rb', /class AccountSerializer < ApplicationSerializer/
+  ensure
+    Object.send :remove_const, :ApplicationSerializer
+  end
+
+  def test_uses_given_parent
+    Object.const_set(:ApplicationSerializer, Class.new)
+    run_generator ['Account', '--parent=MySerializer']
+    assert_file 'app/serializers/account_serializer.rb', /class AccountSerializer < MySerializer/
+  ensure
+    Object.send :remove_const, :ApplicationSerializer
+  end
+end

data/test/test_app.rb

@@ -0,0 +1,11 @@
+class TestApp < Rails::Application
+  if Rails.version.to_s.first >= '4'
+    config.eager_load = false
+    config.secret_key_base = 'abc123'
+  end
+
+  # Set up a logger to avoid creating a log directory on every run.
+  config.logger = Logger.new(nil)
+end
+
+TestApp.initialize!

data/test/test_helper.rb

@@ -1,32 +1,21 @@
-require "rubygems"
-require "bundler/setup"
-
-require "pry"
-
-require "active_model_serializers"
-require "active_support/json"
-require "minitest/autorun"
-
-require 'rails'
+require 'bundler/setup'
+require 'coverage_setup'
+require 'minitest/autorun'
+require 'active_model_serializers'
+require 'fixtures/poro'
 
 module TestHelper
   Routes = ActionDispatch::Routing::RouteSet.new
   Routes.draw do
-    resource :hypermedia
     get ':controller(/:action(/:id))'
     get ':controller(/:action)'
   end
 
   ActionController::Base.send :include, Routes.url_helpers
-  ActiveModel::Serializer.send :include, Routes.url_helpers
 end
 
-ActiveSupport::TestCase.class_eval do
-  setup do
-    @routes = ::TestHelper::Routes
+ActionController::TestCase.class_eval do
+  def setup
+    @routes = TestHelper::Routes
   end
 end
-
-class Object
-  undef_method :id if respond_to?(:id)
-end

data/test/tmp/app/serializers/account_serializer.rb

@@ -0,0 +1,3 @@
+class AccountSerializer < MySerializer
+  attributes :id
+end

data/test/unit/active_model/array_serializer/meta_test.rb

@@ -0,0 +1,53 @@
+require 'test_helper'
+require 'active_model/serializer'
+
+module ActiveModel
+  class ArraySerializer
+    class MetaTest < ActiveModel::TestCase
+      def setup
+        @profile1 = Profile.new({ name: 'Name 1', description: 'Description 1', comments: 'Comments 1' })
+        @profile2 = Profile.new({ name: 'Name 2', description: 'Description 2', comments: 'Comments 2' })
+        @serializer = ArraySerializer.new([@profile1, @profile2], root: 'profiles')
+      end
+
+      def test_meta
+        @serializer.meta = { total: 10 }
+
+        assert_equal({
+          'profiles' => [
+            {
+              name: 'Name 1',
+              description: 'Description 1'
+            }, {
+              name: 'Name 2',
+              description: 'Description 2'
+            }
+          ],
+          meta: {
+            total: 10
+          }
+        }, @serializer.as_json)
+      end
+
+      def test_meta_using_meta_key
+        @serializer.meta_key = :my_meta
+        @serializer.meta     = { total: 10 }
+
+        assert_equal({
+          'profiles' => [
+            {
+              name: 'Name 1',
+              description: 'Description 1'
+            }, {
+              name: 'Name 2',
+              description: 'Description 2'
+            }
+          ],
+          my_meta: {
+            total: 10
+          }
+        }, @serializer.as_json)
+      end
+    end
+  end
+end

data/test/unit/active_model/array_serializer/root_test.rb

@@ -0,0 +1,102 @@
+require 'test_helper'
+
+module ActiveModel
+  class ArraySerializer
+    class RootAsOptionTest < ActiveModel::TestCase
+      def setup
+        @old_root = ArraySerializer._root
+        @profile1 = Profile.new({ name: 'Name 1', description: 'Description 1', comments: 'Comments 1' })
+        @profile2 = Profile.new({ name: 'Name 2', description: 'Description 2', comments: 'Comments 2' })
+        @serializer = ArraySerializer.new([@profile1, @profile2], root: :initialize)
+      end
+
+      def teardown
+        ArraySerializer._root = @old_root
+      end
+
+      def test_root_is_not_displayed_using_serializable_array
+        assert_equal([
+          { name: 'Name 1', description: 'Description 1' },
+          { name: 'Name 2', description: 'Description 2' }
+        ], @serializer.serializable_array)
+      end
+
+      def test_root_using_as_json
+        assert_equal({
+          initialize: [
+            { name: 'Name 1', description: 'Description 1' },
+            { name: 'Name 2', description: 'Description 2' }
+          ]
+        }, @serializer.as_json)
+      end
+
+      def test_root_as_argument_takes_precedence
+        assert_equal({
+          argument: [
+            { name: 'Name 1', description: 'Description 1' },
+            { name: 'Name 2', description: 'Description 2' }
+          ]
+        }, @serializer.as_json(root: :argument))
+      end
+
+      def test_using_false_root_in_initialize_takes_precedence
+        ArraySerializer._root = 'root'
+        @serializer = ArraySerializer.new([@profile1, @profile2], root: false)
+
+        assert_equal([
+          { name: 'Name 1', description: 'Description 1' },
+          { name: 'Name 2', description: 'Description 2' }
+        ], @serializer.as_json)
+      end
+    end
+
+    class RootInSerializerTest < ActiveModel::TestCase
+      def setup
+        @old_root = ArraySerializer._root
+        ArraySerializer._root = :in_serializer
+        @profile1 = Profile.new({ name: 'Name 1', description: 'Description 1', comments: 'Comments 1' })
+        @profile2 = Profile.new({ name: 'Name 2', description: 'Description 2', comments: 'Comments 2' })
+        @serializer = ArraySerializer.new([@profile1, @profile2])
+        @rooted_serializer = ArraySerializer.new([@profile1, @profile2], root: :initialize)
+      end
+
+      def teardown
+        ArraySerializer._root = @old_root
+      end
+
+      def test_root_is_not_displayed_using_serializable_hash
+        assert_equal([
+          { name: 'Name 1', description: 'Description 1' },
+          { name: 'Name 2', description: 'Description 2' }
+        ], @serializer.serializable_array)
+      end
+
+      def test_root_using_as_json
+        assert_equal({
+          in_serializer: [
+            { name: 'Name 1', description: 'Description 1' },
+            { name: 'Name 2', description: 'Description 2' }
+          ]
+        }, @serializer.as_json)
+      end
+
+      def test_root_in_initializer_takes_precedence
+        assert_equal({
+          initialize: [
+            { name: 'Name 1', description: 'Description 1' },
+            { name: 'Name 2', description: 'Description 2' }
+          ]
+        }, @rooted_serializer.as_json)
+      end
+
+      def test_root_as_argument_takes_precedence
+        assert_equal({
+          argument: [
+            { name: 'Name 1', description: 'Description 1' },
+            { name: 'Name 2', description: 'Description 2' }
+          ]
+        }, @rooted_serializer.as_json(root: :argument))
+      end
+    end
+  end
+end

data/test/unit/active_model/array_serializer/scope_test.rb

@@ -0,0 +1,24 @@
+require 'test_helper'
+
+module ActiveModel
+  class ArraySerializer
+    class ScopeTest < ActiveModel::TestCase
+      def test_array_serializer_pass_options_to_items_serializers
+        array = [Profile.new({ name: 'Name 1', description: 'Description 1', comments: 'Comments 1' }),
+                 Profile.new({ name: 'Name 2', description: 'Description 2', comments: 'Comments 2' })]
+        serializer = ArraySerializer.new(array, scope: current_user)
+
+        expected = [{ name: 'Name 1', description: 'Description 1 - user' },
+                    { name: 'Name 2', description: 'Description 2 - user' }]
+
+        assert_equal expected, serializer.serializable_array
+      end
+
+      private
+
+      def current_user
+        'user'
+      end
+    end
+  end
+end

data/test/unit/active_model/array_serializer/serialization_test.rb

@@ -0,0 +1,83 @@
+require 'test_helper'
+
+module ActiveModel
+  class ArraySerializer
+    class BasicObjectsSerializationTest < ActiveModel::TestCase
+      def setup
+        array = [1, 2, 3]
+        @serializer = ActiveModel::Serializer.serializer_for(array).new(array)
+      end
+
+      def test_serializer_for_array_returns_appropriate_type
+        assert_kind_of ArraySerializer, @serializer
+      end
+
+      def test_array_serializer_serializes_simple_objects
+        assert_equal [1, 2, 3], @serializer.serializable_array
+        assert_equal [1, 2, 3], @serializer.as_json
+      end
+    end
+
+    class ModelSerializationTest < ActiveModel::TestCase
+      def test_array_serializer_serializes_models
+        array = [Profile.new({ name: 'Name 1', description: 'Description 1', comments: 'Comments 1' }),
+                 Profile.new({ name: 'Name 2', description: 'Description 2', comments: 'Comments 2' })]
+        serializer = ArraySerializer.new(array)
+
+        expected = [{ name: 'Name 1', description: 'Description 1' },
+                    { name: 'Name 2', description: 'Description 2' }]
+
+        assert_equal expected, serializer.serializable_array
+        assert_equal expected, serializer.as_json
+      end
+
+      def test_array_serializers_each_serializer
+        array = [::Model.new({ name: 'Name 1', description: 'Description 1', comments: 'Comments 1' }),
+                 ::Model.new({ name: 'Name 2', description: 'Description 2', comments: 'Comments 2' })]
+        serializer = ArraySerializer.new(array, each_serializer: ProfileSerializer)
+
+        expected = [{ name: 'Name 1', description: 'Description 1' },
+                    { name: 'Name 2', description: 'Description 2' }]
+
+        assert_equal expected, serializer.serializable_array
+        assert_equal expected, serializer.as_json
+      end
+
+      def test_associated_objects_of_multiple_instances_embedded_in_root
+        @association = PostSerializer._associations[:comments]
+        @old_association = @association.dup
+
+        @association.embed = :ids
+        @association.embed_in_root = true
+
+        @post1 = Post.new({ title: 'Title 1', body: 'Body 1', date: '1/1/2000' })
+        @post2 = Post.new({ title: 'Title 2', body: 'Body 2', date: '1/1/2000' })
+
+        class << @post2
+          attr_writer :comments
+        end
+
+        @post2.comments = [
+          Comment.new(content: 'C3'),
+          Comment.new(content: 'C4')
+        ]
+
+        @serializer = ArraySerializer.new([@post1, @post2], root: :posts)
+        assert_equal({
+            posts: [
+              {title: "Title 1", body: "Body 1", "comment_ids" => @post1.comments.map(&:object_id) },
+              {title: "Title 2", body: "Body 2", "comment_ids" => @post2.comments.map(&:object_id) }
+            ],
+            comments: [
+              {content: "C1"},
+              {content: "C2"},
+              {content: "C3"},
+              {content: "C4"}
+            ]
+          }, @serializer.as_json)
+      ensure
+        PostSerializer._associations[:comments] = @old_association
+      end
+    end
+  end
+end

data/test/unit/active_model/default_serializer_test.rb

@@ -0,0 +1,13 @@
+require 'test_helper'
+
+module ActiveModel
+  class DefaultSerializer
+    class Test < ActiveModel::TestCase
+      def test_serialize_objects
+        assert_equal(nil, DefaultSerializer.new(nil).serializable_object)
+        assert_equal(1, DefaultSerializer.new(1).serializable_object)
+        assert_equal('hi', DefaultSerializer.new('hi').serializable_object)
+      end
+    end
+  end
+end

data/test/unit/active_model/serializer/associations/build_serializer_test.rb

@@ -0,0 +1,21 @@
+require 'test_helper'
+
+module ActiveModel
+  class Serializer
+    class Association
+      class BuildSerializerTest < ActiveModel::TestCase
+        def setup
+          @association = Association::HasOne.new('post', serializer: PostSerializer)
+          @post = Post.new({ title: 'Title 1', body: 'Body 1', date: '1/1/2000' })
+        end
+
+        def test_build_serializer_for_array_called_twice
+          2.times do
+            serializer = @association.build_serializer(@post)
+            assert_instance_of(PostSerializer, serializer)
+          end
+        end
+      end
+    end
+  end
+end

data/test/unit/active_model/serializer/associations_test.rb

@@ -0,0 +1,19 @@
+require 'test_helper'
+
+module ActiveModel
+  class Serializer
+    class AssociationsTest < ActiveModel::TestCase
+      def test_associations_inheritance
+        inherited_serializer_klass = Class.new(PostSerializer) do
+          has_many :users
+        end
+        another_inherited_serializer_klass = Class.new(PostSerializer)
+
+        assert_equal([:comments, :users],
+                     inherited_serializer_klass._associations.keys)
+        assert_equal([:comments],
+                     another_inherited_serializer_klass._associations.keys)
+      end
+    end
+  end
+end

data/test/unit/active_model/serializer/attributes_test.rb

@@ -0,0 +1,41 @@
+require 'test_helper'
+
+module ActiveModel
+  class Serializer
+    class AttributesTest < ActiveModel::TestCase
+      def setup
+        @profile = Profile.new({ name: 'Name 1', description: 'Description 1', comments: 'Comments 1' })
+        @profile_serializer = ProfileSerializer.new(@profile)
+      end
+
+      def test_attributes_definition
+        assert_equal([:name, :description],
+                     @profile_serializer.class._attributes)
+      end
+
+      def test_attributes_serialization_using_serializable_hash
+        assert_equal({
+          name: 'Name 1', description: 'Description 1'
+        }, @profile_serializer.serializable_hash)
+      end
+
+      def test_attributes_serialization_using_as_json
+        assert_equal({
+          'profile' => { name: 'Name 1', description: 'Description 1' }
+        }, @profile_serializer.as_json)
+      end
+
+      def test_attributes_inheritance
+        inherited_serializer_klass = Class.new(ProfileSerializer) do
+          attributes :comments
+        end
+        another_inherited_serializer_klass = Class.new(ProfileSerializer)
+
+        assert_equal([:name, :description, :comments],
+                     inherited_serializer_klass._attributes)
+        assert_equal([:name, :description],
+                     another_inherited_serializer_klass._attributes)
+      end
+    end
+  end
+end

data/test/unit/active_model/serializer/config_test.rb

@@ -0,0 +1,86 @@
+require 'test_helper'
+
+module ActiveModel
+  class Serializer
+    class Config
+      class Test < ActiveModel::TestCase
+        def test_config_const_is_an_instance_of_config
+          assert_kind_of Config, CONFIG
+        end
+
+        def test_config_instance
+          config = Config.new
+          config.setting1 = 'value1'
+
+          assert_equal 'value1', config.setting1
+        end
+
+        def test_each_config
+          config = Config.new
+          config.setting1 = 'value1'
+          config.setting2 = 'value2'
+
+          actual = {}
+
+          config.each do |k, v|
+            actual[k] = v
+          end
+
+          assert_equal({ 'setting1' => 'value1', 'setting2' => 'value2' }, actual)
+        end
+      end
+
+      class ConfigTest < ActiveModel::TestCase
+        def test_setup
+          ActiveModel::Serializer.setup do |config|
+            config.a = 'v1'
+            config.b = 'v2'
+          end
+
+          assert_equal 'v1', CONFIG.a
+          assert_equal 'v2', CONFIG.b
+        ensure
+          CONFIG.clear
+        end
+
+        def test_config_accessors
+          ActiveModel::Serializer.setup do |config|
+            config.foo = 'v1'
+            config.bar = 'v2'
+          end
+
+          assert_equal 'v1', CONFIG.foo
+          assert_equal 'v2', CONFIG.bar
+        ensure
+          CONFIG.clear
+        end
+
+        def test_acessor_when_nil
+          assert_nil CONFIG.foo
+          CONFIG.foo = 1
+          assert_equal 1, CONFIG.foo
+          assert_nil CONFIG.bar
+        end
+      end
+
+      class ApplyConfigTest < ActiveModel::TestCase
+        def test_apply_config_to_associations
+          CONFIG.embed     = :ids
+          CONFIG.embed_in_root = true
+
+          association = PostSerializer._associations[:comments]
+          old_association = association.dup
+
+          association.send :initialize, association.name, association.options
+
+          assert association.embed_ids?
+          assert !association.embed_objects?
+          assert association.embed_in_root
+        ensure
+          PostSerializer._associations[:comments] = old_association
+          CONFIG.clear
+        end
+      end
+    end
+  end
+end

data/test/unit/active_model/serializer/filter_test.rb

@@ -0,0 +1,49 @@
+require 'test_helper'
+
+module ActiveModel
+  class Serializer
+    class FilterAttributesTest < ActiveModel::TestCase
+      def setup
+        @profile = Profile.new({ name: 'Name 1', description: 'Description 1', comments: 'Comments 1' })
+        @profile_serializer = ProfileSerializer.new(@profile)
+        @profile_serializer.instance_eval do
+          def filter(keys)
+            keys - [:description]
+          end
+        end
+      end
+
+      def test_filtered_attributes_serialization
+        assert_equal({
+          'profile' => { name: 'Name 1' }
+        }, @profile_serializer.as_json)
+      end
+    end
+
+    class FilterAssociationsTest < ActiveModel::TestCase
+      def setup
+        @association = PostSerializer._associations[:comments]
+        @old_association = @association.dup
+        @association.embed = :ids
+        @association.embed_in_root = true
+        @post = Post.new({ title: 'Title 1', body: 'Body 1', date: '1/1/2000' })
+        @post_serializer = PostSerializer.new(@post)
+        @post_serializer.instance_eval do
+          def filter(keys)
+            keys - [:body, :comments]
+          end
+        end
+      end
+
+      def teardown
+        PostSerializer._associations[:comments] = @old_association
+      end
+
+      def test_filtered_associations_serialization
+        assert_equal({
+          'post' => { title: 'Title 1' }
+        }, @post_serializer.as_json)
+      end
+    end
+  end
+end