active_model_serializers 0.10.0 → 0.10.3

data/test/benchmark/fixtures.rb

@@ -1,33 +1,33 @@
 Rails.configuration.serializers = []
-class AuthorSerializer < ActiveModel::Serializer
+class HasOneRelationshipSerializer < ActiveModel::Serializer
   attributes :id, :first_name, :last_name
 
-  has_many :posts, embed: :ids
+  has_many :primary_resources, embed: :ids
   has_one :bio
 end
-Rails.configuration.serializers << AuthorSerializer
+Rails.configuration.serializers << HasOneRelationshipSerializer
 
-class BlogSerializer < ActiveModel::Serializer
+class VirtualAttributeSerializer < ActiveModel::Serializer
   attributes :id, :name
 end
-Rails.configuration.serializers << BlogSerializer
+Rails.configuration.serializers << VirtualAttributeSerializer
 
-class CommentSerializer < ActiveModel::Serializer
-  attributes :id, :body, :updated_at
+class HasManyRelationshipSerializer < ActiveModel::Serializer
+  attributes :id, :body
 
-  belongs_to :post
-  belongs_to :author
+  belongs_to :primary_resource
+  belongs_to :has_one_relationship
 end
-Rails.configuration.serializers << CommentSerializer
+Rails.configuration.serializers << HasManyRelationshipSerializer
 
-class PostSerializer < ActiveModel::Serializer
+class PrimaryResourceSerializer < ActiveModel::Serializer
   attributes :id, :title, :body
 
-  has_many :comments, serializer: CommentSerializer
-  belongs_to :blog, serializer: BlogSerializer
-  belongs_to :author, serializer: AuthorSerializer
+  has_many :has_many_relationships, serializer: HasManyRelationshipSerializer
+  belongs_to :virtual_attribute, serializer: VirtualAttributeSerializer
+  belongs_to :has_one_relationship, serializer: HasOneRelationshipSerializer
 
-  link(:post_authors) { 'https://example.com/post_authors' }
+  link(:primary_resource_has_one_relationships) { 'https://example.com/primary_resource_has_one_relationships' }
 
   meta do
     {
@@ -36,33 +36,33 @@ class PostSerializer < ActiveModel::Serializer
     }
   end
 
-  def blog
-    Blog.new(id: 999, name: 'Custom blog')
+  def virtual_attribute
+    VirtualAttribute.new(id: 999, name: 'Free-Range Virtual Attribute')
   end
 end
-Rails.configuration.serializers << PostSerializer
+Rails.configuration.serializers << PrimaryResourceSerializer
 
-class CachingAuthorSerializer < AuthorSerializer
+class CachingHasOneRelationshipSerializer < HasOneRelationshipSerializer
   cache key: 'writer', skip_digest: true
 end
-Rails.configuration.serializers << CachingAuthorSerializer
+Rails.configuration.serializers << CachingHasOneRelationshipSerializer
 
-class CachingCommentSerializer < CommentSerializer
+class CachingHasManyRelationshipSerializer < HasManyRelationshipSerializer
   cache expires_in: 1.day, skip_digest: true
 end
-Rails.configuration.serializers << CachingCommentSerializer
+Rails.configuration.serializers << CachingHasManyRelationshipSerializer
 
 # see https://github.com/rails-api/active_model_serializers/pull/1690/commits/68715b8f99bc29677e8a47bb3f305f23c077024b#r60344532
-class CachingPostSerializer < ActiveModel::Serializer
-  cache key: 'post', expires_in: 0.1, skip_digest: true
+class CachingPrimaryResourceSerializer < ActiveModel::Serializer
+  cache key: 'primary_resource', expires_in: 0.1, skip_digest: true
 
   attributes :id, :title, :body
 
-  belongs_to :blog, serializer: BlogSerializer
-  belongs_to :author, serializer: CachingAuthorSerializer
-  has_many :comments, serializer: CachingCommentSerializer
+  belongs_to :virtual_attribute, serializer: VirtualAttributeSerializer
+  belongs_to :has_one_relationship, serializer: CachingHasOneRelationshipSerializer
+  has_many :has_many_relationships, serializer: CachingHasManyRelationshipSerializer
 
-  link(:post_authors) { 'https://example.com/post_authors' }
+  link(:primary_resource_has_one_relationships) { 'https://example.com/primary_resource_has_one_relationships' }
 
   meta do
     {
@@ -71,33 +71,33 @@ class CachingPostSerializer < ActiveModel::Serializer
     }
   end
 
-  def blog
-    Blog.new(id: 999, name: 'Custom blog')
+  def virtual_attribute
+    VirtualAttribute.new(id: 999, name: 'Free-Range Virtual Attribute')
   end
 end
-Rails.configuration.serializers << CachingPostSerializer
+Rails.configuration.serializers << CachingPrimaryResourceSerializer
 
-class FragmentCachingAuthorSerializer < AuthorSerializer
+class FragmentCachingHasOneRelationshipSerializer < HasOneRelationshipSerializer
   cache key: 'writer', only: [:first_name, :last_name], skip_digest: true
 end
-Rails.configuration.serializers << FragmentCachingAuthorSerializer
+Rails.configuration.serializers << FragmentCachingHasOneRelationshipSerializer
 
-class FragmentCachingCommentSerializer < CommentSerializer
-  cache expires_in: 1.day, except: [:updated_at], skip_digest: true
+class FragmentCachingHasManyRelationshipSerializer < HasManyRelationshipSerializer
+  cache expires_in: 1.day, except: [:body], skip_digest: true
 end
-Rails.configuration.serializers << CachingCommentSerializer
+Rails.configuration.serializers << CachingHasManyRelationshipSerializer
 
 # see https://github.com/rails-api/active_model_serializers/pull/1690/commits/68715b8f99bc29677e8a47bb3f305f23c077024b#r60344532
-class FragmentCachingPostSerializer < ActiveModel::Serializer
-  cache key: 'post', expires_in: 0.1, skip_digest: true
+class FragmentCachingPrimaryResourceSerializer < ActiveModel::Serializer
+  cache key: 'primary_resource', expires_in: 0.1, skip_digest: true
 
   attributes :id, :title, :body
 
-  belongs_to :blog, serializer: BlogSerializer
-  belongs_to :author, serializer: FragmentCachingAuthorSerializer
-  has_many :comments, serializer: FragmentCachingCommentSerializer
+  belongs_to :virtual_attribute, serializer: VirtualAttributeSerializer
+  belongs_to :has_one_relationship, serializer: FragmentCachingHasOneRelationshipSerializer
+  has_many :has_many_relationships, serializer: FragmentCachingHasManyRelationshipSerializer
 
-  link(:post_authors) { 'https://example.com/post_authors' }
+  link(:primary_resource_has_one_relationships) { 'https://example.com/primary_resource_has_one_relationships' }
 
   meta do
     {
@@ -106,11 +106,11 @@ class FragmentCachingPostSerializer < ActiveModel::Serializer
     }
   end
 
-  def blog
-    Blog.new(id: 999, name: 'Custom blog')
+  def virtual_attribute
+    VirtualAttribute.new(id: 999, name: 'Free-Range Virtual Attribute')
   end
 end
-Rails.configuration.serializers << FragmentCachingPostSerializer
+Rails.configuration.serializers << FragmentCachingPrimaryResourceSerializer
 
 if ENV['ENABLE_ACTIVE_RECORD'] == 'true'
   require 'active_record'
@@ -119,48 +119,48 @@ if ENV['ENABLE_ACTIVE_RECORD'] == 'true'
   ActiveRecord::Schema.define do
     self.verbose = false
 
-    create_table :blogs, force: true do |t|
+    create_table :virtual_attributes, force: true do |t|
       t.string :name
       t.timestamps null: false
     end
-    create_table :authors, force: true do |t|
+    create_table :has_one_relationships, force: true do |t|
       t.string :first_name
       t.string :last_name
       t.timestamps null: false
     end
-    create_table :posts, force: true do |t|
+    create_table :primary_resources, force: true do |t|
       t.string :title
       t.text :body
-      t.references :author
-      t.references :blog
+      t.references :has_one_relationship
+      t.references :virtual_attribute
       t.timestamps null: false
     end
-    create_table :comments, force: true do |t|
+    create_table :has_many_relationships, force: true do |t|
       t.text :body
-      t.references :author
-      t.references :post
+      t.references :has_one_relationship
+      t.references :primary_resource
       t.timestamps null: false
     end
   end
 
-  class Comment < ActiveRecord::Base
-    belongs_to :author
-    belongs_to :post
+  class HasManyRelationship < ActiveRecord::Base
+    belongs_to :has_one_relationship
+    belongs_to :primary_resource
   end
 
-  class Author < ActiveRecord::Base
-    has_many :posts
-    has_many :comments
+  class HasOneRelationship < ActiveRecord::Base
+    has_many :primary_resources
+    has_many :has_many_relationships
   end
 
-  class Post < ActiveRecord::Base
-    has_many :comments
-    belongs_to :author
-    belongs_to :blog
+  class PrimaryResource < ActiveRecord::Base
+    has_many :has_many_relationships
+    belongs_to :has_one_relationship
+    belongs_to :virtual_attribute
   end
 
-  class Blog < ActiveRecord::Base
-    has_many :posts
+  class VirtualAttribute < ActiveRecord::Base
+    has_many :primary_resources
   end
 else
   # ActiveModelSerializers::Model is a convenient
@@ -201,19 +201,19 @@ else
     end
   end
 
-  class Comment < BenchmarkModel
-    attr_accessor :id, :body, :updated_at
+  class HasManyRelationship < BenchmarkModel
+    attr_accessor :id, :body
   end
 
-  class Author < BenchmarkModel
-    attr_accessor :id, :first_name, :last_name, :posts
+  class HasOneRelationship < BenchmarkModel
+    attr_accessor :id, :first_name, :last_name, :primary_resources
   end
 
-  class Post < BenchmarkModel
-    attr_accessor :id, :title, :body, :comments, :blog, :author
+  class PrimaryResource < BenchmarkModel
+    attr_accessor :id, :title, :body, :has_many_relationships, :virtual_attribute, :has_one_relationship
   end
 
-  class Blog < BenchmarkModel
+  class VirtualAttribute < BenchmarkModel
     attr_accessor :id, :name
   end
 end

data/test/cache_test.rb

@@ -4,22 +4,46 @@ require 'tempfile'
 
 module ActiveModelSerializers
   class CacheTest < ActiveSupport::TestCase
-    UncachedAuthor = Class.new(Author) do
+    # Instead of a primitive cache key (i.e. a string), this class
+    # returns a list of objects that require to be expanded themselves.
+    class AuthorWithExpandableCacheElements < Author
+      # For the test purposes it's important that #to_s for HasCacheKey differs
+      # between instances, hence not a Struct.
+      class HasCacheKey
+        attr_reader :cache_key
+        def initialize(cache_key)
+          @cache_key = cache_key
+        end
+
+        def to_s
+          "HasCacheKey##{object_id}"
+        end
+      end
+
+      def cache_key
+        [
+          HasCacheKey.new(name),
+          HasCacheKey.new(id)
+        ]
+      end
+    end
+
+    class UncachedAuthor < Author
       # To confirm cache_key is set using updated_at and cache_key option passed to cache
       undef_method :cache_key
     end
 
-    Article = Class.new(::Model) do
+    class Article < ::Model
       # To confirm error is raised when cache_key is not set and cache_key option not passed to cache
       undef_method :cache_key
     end
 
-    ArticleSerializer = Class.new(ActiveModel::Serializer) do
+    class ArticleSerializer < ActiveModel::Serializer
       cache only: [:place], skip_digest: true
       attributes :title
     end
 
-    InheritedRoleSerializer = Class.new(RoleSerializer) do
+    class InheritedRoleSerializer < RoleSerializer
       cache key: 'inherited_role', only: [:name, :special_attribute]
       attribute :special_attribute
     end
@@ -101,14 +125,28 @@ module ActiveModelSerializers
       uncached_author_serializer = AuthorSerializer.new(uncached_author)
 
       render_object_with_cache(uncached_author)
-      key = "#{uncached_author_serializer.class._cache_key}/#{uncached_author_serializer.object.id}-#{uncached_author_serializer.object.updated_at.strftime("%Y%m%d%H%M%S%9N")}"
-      key = "#{key}/#{adapter.cached_name}"
+      key = "#{uncached_author_serializer.class._cache_key}/#{uncached_author_serializer.object.id}-#{uncached_author_serializer.object.updated_at.strftime('%Y%m%d%H%M%S%9N')}"
+      key = "#{key}/#{adapter.cache_key}"
       assert_equal(uncached_author_serializer.attributes.to_json, cache_store.fetch(key).to_json)
     end
 
+    def test_cache_key_expansion
+      author = AuthorWithExpandableCacheElements.new(id: 10, name: 'hello')
+      same_author = AuthorWithExpandableCacheElements.new(id: 10, name: 'hello')
+      diff_author = AuthorWithExpandableCacheElements.new(id: 11, name: 'hello')
+
+      author_serializer = AuthorSerializer.new(author)
+      same_author_serializer = AuthorSerializer.new(same_author)
+      diff_author_serializer = AuthorSerializer.new(diff_author)
+      adapter = AuthorSerializer.serialization_adapter_instance
+
+      assert_equal(author_serializer.cache_key(adapter), same_author_serializer.cache_key(adapter))
+      refute_equal(author_serializer.cache_key(adapter), diff_author_serializer.cache_key(adapter))
+    end
+
     def test_default_cache_key_fallback
       render_object_with_cache(@comment)
-      key = "#{@comment.cache_key}/#{adapter.cached_name}"
+      key = "#{@comment.cache_key}/#{adapter.cache_key}"
       assert_equal(@comment_serializer.attributes.to_json, cache_store.fetch(key).to_json)
     end
 
@@ -117,7 +155,7 @@ module ActiveModelSerializers
       e = assert_raises ActiveModel::Serializer::UndefinedCacheKey do
         render_object_with_cache(article)
       end
-      assert_match(/ActiveModelSerializers::CacheTest::Article must define #cache_key, or the 'key:' option must be passed into 'CachedActiveModelSerializers_CacheTest_ArticleSerializer.cache'/, e.message)
+      assert_match(/ActiveModelSerializers::CacheTest::Article must define #cache_key, or the 'key:' option must be passed into 'ActiveModelSerializers::CacheTest::ArticleSerializer.cache'/, e.message)
     end
 
     def test_cache_options_definition
@@ -127,7 +165,7 @@ module ActiveModelSerializers
     end
 
     def test_fragment_cache_definition
-      assert_equal([:name], @role_serializer.class._cache_only)
+      assert_equal([:name, :slug], @role_serializer.class._cache_only)
       assert_equal([:content], @bio_serializer.class._cache_except)
     end
 
@@ -139,9 +177,9 @@ module ActiveModelSerializers
       Timecop.freeze(Time.current) do
         render_object_with_cache(@post)
 
-        key = "#{@post.cache_key}/#{adapter.cached_name}"
+        key = "#{@post.cache_key}/#{adapter.cache_key}"
         assert_equal(@post_serializer.attributes, cache_store.fetch(key))
-        key = "#{@comment.cache_key}/#{adapter.cached_name}"
+        key = "#{@comment.cache_key}/#{adapter.cache_key}"
         assert_equal(@comment_serializer.attributes, cache_store.fetch(key))
       end
     end
@@ -152,9 +190,9 @@ module ActiveModelSerializers
         render_object_with_cache(@post)
 
         # Check if it cached the objects separately
-        key = "#{@post.cache_key}/#{adapter.cached_name}"
+        key = "#{@post.cache_key}/#{adapter.cache_key}"
         assert_equal(@post_serializer.attributes, cache_store.fetch(key))
-        key = "#{@comment.cache_key}/#{adapter.cached_name}"
+        key = "#{@comment.cache_key}/#{adapter.cache_key}"
         assert_equal(@comment_serializer.attributes, cache_store.fetch(key))
 
         # Simulating update on comments relationship with Post
@@ -166,9 +204,9 @@ module ActiveModelSerializers
         render_object_with_cache(@post)
 
         # Check if the the new comment was cached
-        key = "#{new_comment.cache_key}/#{adapter.cached_name}"
+        key = "#{new_comment.cache_key}/#{adapter.cache_key}"
         assert_equal(new_comment_serializer.attributes, cache_store.fetch(key))
-        key = "#{@post.cache_key}/#{adapter.cached_name}"
+        key = "#{@post.cache_key}/#{adapter.cache_key}"
         assert_equal(@post_serializer.attributes, cache_store.fetch(key))
       end
     end
@@ -178,14 +216,14 @@ module ActiveModelSerializers
         id: @location.id,
         lat: @location.lat,
         lng: @location.lng,
-        place: 'Nowhere'
+        address: 'Nowhere'
       }
 
       hash = render_object_with_cache(@location)
 
       assert_equal(hash, expected_result)
-      key = "#{@location.cache_key}/#{adapter.cached_name}"
-      assert_equal({ place: 'Nowhere' }, cache_store.fetch(key))
+      key = "#{@location.cache_key}/#{adapter.cache_key}"
+      assert_equal({ address: 'Nowhere' }, cache_store.fetch(key))
     end
 
     def test_fragment_cache_with_inheritance
@@ -204,7 +242,7 @@ module ActiveModelSerializers
 
     # Based on original failing test by @kevintyll
     # rubocop:disable Metrics/AbcSize
-    def test_a_serializer_rendered_by_two_adapter_returns_differently_cached_attributes
+    def test_a_serializer_rendered_by_two_adapter_returns_differently_fetch_attributes
       Object.const_set(:Alert, Class.new(ActiveModelSerializers::Model) do
         attr_accessor :id, :status, :resource, :started_at, :ended_at, :updated_at, :created_at
       end)
@@ -225,7 +263,7 @@ module ActiveModelSerializers
         created_at: Time.new(2016, 3, 31, 21, 37, 35, 0)
       )
 
-      expected_cached_attributes = {
+      expected_fetch_attributes = {
         id: 1,
         status: 'fail',
         resource: 'resource-1',
@@ -250,7 +288,7 @@ module ActiveModelSerializers
       # Assert attributes are serialized correctly
       serializable_alert = serializable(alert, serializer: AlertSerializer, adapter: :attributes)
       attributes_serialization = serializable_alert.as_json
-      assert_equal expected_cached_attributes, alert.attributes
+      assert_equal expected_fetch_attributes, alert.attributes
       assert_equal alert.attributes, attributes_serialization
       attributes_cache_key = serializable_alert.adapter.serializer.cache_key(serializable_alert.adapter)
       assert_equal attributes_serialization, cache_store.fetch(attributes_cache_key)
@@ -276,7 +314,7 @@ module ActiveModelSerializers
 
     def test_uses_file_digest_in_cache_key
       render_object_with_cache(@blog)
-      key = "#{@blog.cache_key}/#{adapter.cached_name}/#{::Model::FILE_DIGEST}"
+      key = "#{@blog.cache_key}/#{adapter.cache_key}/#{::Model::FILE_DIGEST}"
       assert_equal(@blog_serializer.attributes, cache_store.fetch(key))
     end
 
@@ -286,33 +324,66 @@ module ActiveModelSerializers
 
     def test_object_cache_keys
       serializable = ActiveModelSerializers::SerializableResource.new([@comment, @comment])
-      include_tree = ActiveModel::Serializer::IncludeTree.from_include_args('*')
+      include_directive = JSONAPI::IncludeDirective.new('*', allow_wildcard: true)
 
-      actual = ActiveModel::Serializer.object_cache_keys(serializable.adapter.serializer, serializable.adapter, include_tree)
+      actual = ActiveModel::Serializer.object_cache_keys(serializable.adapter.serializer, serializable.adapter, include_directive)
 
       assert_equal 3, actual.size
-      assert actual.any? { |key| key == "comment/1/#{serializable.adapter.cached_name}" }
+      assert actual.any? { |key| key == "comment/1/#{serializable.adapter.cache_key}" }
       assert actual.any? { |key| key =~ %r{post/post-\d+} }
       assert actual.any? { |key| key =~ %r{author/author-\d+} }
     end
 
-    def test_cached_attributes
-      serializer = ActiveModel::Serializer::CollectionSerializer.new([@comment, @comment])
+    def test_fetch_attributes_from_cache
+      serializers = ActiveModel::Serializer::CollectionSerializer.new([@comment, @comment])
 
       Timecop.freeze(Time.current) do
         render_object_with_cache(@comment)
 
-        attributes = Adapter::Attributes.new(serializer)
-        attributes.send(:cache_attributes)
-        cached_attributes = attributes.instance_variable_get(:@cached_attributes)
+        options = {}
+        adapter_options = {}
+        adapter_instance = ActiveModelSerializers::Adapter::Attributes.new(serializers, adapter_options)
+        serializers.serializable_hash(adapter_options, options, adapter_instance)
+        cached_attributes = adapter_options.fetch(:cached_attributes)
+
+        include_directive = ActiveModelSerializers.default_include_directive
+        manual_cached_attributes = ActiveModel::Serializer.cache_read_multi(serializers, adapter_instance, include_directive)
+        assert_equal manual_cached_attributes, cached_attributes
 
-        assert_equal cached_attributes["#{@comment.cache_key}/#{attributes.cached_name}"], Comment.new(id: 1, body: 'ZOMG A COMMENT').attributes
-        assert_equal cached_attributes["#{@comment.post.cache_key}/#{attributes.cached_name}"], Post.new(id: 'post', title: 'New Post', body: 'Body').attributes
+        assert_equal cached_attributes["#{@comment.cache_key}/#{adapter_instance.cache_key}"], Comment.new(id: 1, body: 'ZOMG A COMMENT').attributes
+        assert_equal cached_attributes["#{@comment.post.cache_key}/#{adapter_instance.cache_key}"], Post.new(id: 'post', title: 'New Post', body: 'Body').attributes
 
         writer = @comment.post.blog.writer
         writer_cache_key = writer.cache_key
+        assert_equal cached_attributes["#{writer_cache_key}/#{adapter_instance.cache_key}"], Author.new(id: 'author', name: 'Joao M. D. Moura').attributes
+      end
+    end
 
-        assert_equal cached_attributes["#{writer_cache_key}/#{attributes.cached_name}"], Author.new(id: 'author', name: 'Joao M. D. Moura').attributes
+    def test_cache_read_multi_with_fragment_cache_enabled
+      post_serializer = Class.new(ActiveModel::Serializer) do
+        cache except: [:body]
+      end
+
+      serializers = ActiveModel::Serializer::CollectionSerializer.new([@post, @post], serializer: post_serializer)
+
+      Timecop.freeze(Time.current) do
+        # Warming up.
+        options = {}
+        adapter_options = {}
+        adapter_instance = ActiveModelSerializers::Adapter::Attributes.new(serializers, adapter_options)
+        serializers.serializable_hash(adapter_options, options, adapter_instance)
+
+        # Should find something with read_multi now
+        adapter_options = {}
+        serializers.serializable_hash(adapter_options, options, adapter_instance)
+        cached_attributes = adapter_options.fetch(:cached_attributes)
+
+        include_directive = ActiveModelSerializers.default_include_directive
+        manual_cached_attributes = ActiveModel::Serializer.cache_read_multi(serializers, adapter_instance, include_directive)
+
+        refute_equal 0, cached_attributes.size
+        refute_equal 0, manual_cached_attributes.size
+        assert_equal manual_cached_attributes, cached_attributes
       end
     end
 
@@ -429,25 +500,53 @@ module ActiveModelSerializers
     end
 
     def test_fragment_fetch_with_virtual_attributes
-      @author          = Author.new(name: 'Joao M. D. Moura')
-      @role            = Role.new(name: 'Great Author', description: nil)
-      @role.author     = [@author]
-      @role_serializer = RoleSerializer.new(@role)
-      @role_hash       = @role_serializer.fetch_fragment_cache(ActiveModelSerializers::Adapter.configured_adapter.new(@role_serializer))
+      author          = Author.new(name: 'Joao M. D. Moura')
+      role            = Role.new(name: 'Great Author', description: nil)
+      role.author     = [author]
+      role_serializer = RoleSerializer.new(role)
+      adapter_instance = ActiveModelSerializers::Adapter.configured_adapter.new(role_serializer)
+      expected_result = {
+        id: role.id,
+        description: role.description,
+        slug: "#{role.name}-#{role.id}",
+        name: role.name
+      }
+      cache_store.clear
+
+      role_hash = role_serializer.fetch_attributes_fragment(adapter_instance)
+      assert_equal(role_hash, expected_result)
+
+      role.attributes[:id] = 'this has been updated'
+      role.name = 'this was cached'
+
+      role_hash = role_serializer.fetch_attributes_fragment(adapter_instance)
+      assert_equal(expected_result.merge(id: role.id), role_hash)
+    end
 
+    def test_fragment_fetch_with_except
+      adapter_instance = ActiveModelSerializers::Adapter.configured_adapter.new(@bio_serializer)
       expected_result = {
-        id: @role.id,
-        description: @role.description,
-        slug: "#{@role.name}-#{@role.id}",
-        name: @role.name
+        id: @bio.id,
+        rating: nil,
+        content: @bio.content
       }
-      assert_equal(@role_hash, expected_result)
+      cache_store.clear
+
+      bio_hash = @bio_serializer.fetch_attributes_fragment(adapter_instance)
+      assert_equal(expected_result, bio_hash)
+
+      @bio.content = 'this has been updated'
+      @bio.rating = 'this was cached'
+
+      bio_hash = @bio_serializer.fetch_attributes_fragment(adapter_instance)
+      assert_equal(expected_result.merge(content: @bio.content), bio_hash)
     end
 
     def test_fragment_fetch_with_namespaced_object
       @spam            = Spam::UnrelatedLink.new(id: 'spam-id-1')
       @spam_serializer = Spam::UnrelatedLinkSerializer.new(@spam)
-      @spam_hash       = @spam_serializer.fetch_fragment_cache(ActiveModelSerializers::Adapter.configured_adapter.new(@spam_serializer))
+      adapter_instance = ActiveModelSerializers::Adapter.configured_adapter.new(@spam_serializer)
+      @spam_hash       = @spam_serializer.fetch_attributes_fragment(adapter_instance)
       expected_result = {
         id: @spam.id
       }
@@ -476,10 +575,5 @@ module ActiveModelSerializers
     def adapter
       @serializable_resource.adapter
     end
-
-    def cached_serialization(serializer)
-      cache_key = serializer.cache_key(adapter)
-      cache_store.fetch(cache_key)
-    end
   end
 end

data/test/collection_serializer_test.rb

@@ -3,7 +3,7 @@ require 'test_helper'
 module ActiveModel
   class Serializer
     class CollectionSerializerTest < ActiveSupport::TestCase
-      MessagesSerializer = Class.new(ActiveModel::Serializer) do
+      class MessagesSerializer < ActiveModel::Serializer
         type 'messages'
       end
 
@@ -11,7 +11,7 @@ module ActiveModel
         @comment = Comment.new
         @post = Post.new
         @resource = build_named_collection @comment, @post
-        @serializer = collection_serializer.new(@resource, { some: :options })
+        @serializer = collection_serializer.new(@resource, some: :options)
       end
 
       def collection_serializer
@@ -44,7 +44,7 @@ module ActiveModel
       end
 
       def test_serializer_option_not_passed_to_each_serializer
-        serializers = collection_serializer.new([@post], { serializer: PostSerializer }).to_a
+        serializers = collection_serializer.new([@post], serializer: PostSerializer).to_a
 
         refute serializers.first.custom_options.key?(:serializer)
       end